WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,268 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

42268 Commits

Author SHA1 Message Date
desrosj ecd6a4c549 Build/Test Tools: Specify a type when using `wp config set`. 
This prevents an error if constants are not predefined when running the Docker install script while using older combinations of WordPress/PHP/WP-CLI.

Backports [49335] to the 5.5 branch.
See #48301.
Built from https://develop.svn.wordpress.org/branches/5.5@49340


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 19:03:06 +00:00
desrosj 3bdec70780 Build/Test Tools: Set the local development environment to a local environment type by default. 
Props igorradovanov, TimothyBlynJacobs, johnbillion.
Merges [49121] to the 5.5 branch.
See #50903.
Built from https://develop.svn.wordpress.org/branches/5.5@49339


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 19:01:03 +00:00
Sergey Biryukov 8f1ac79d9f Posts, Post Types: Check if taxonomy is set for the `tax_input` parameter of `wp_insert_post()`. 
This avoids a PHP notice when creating a post with multiple taxonomies both having a default term.

Props yakimun, szaqal21, hareesh-pillai, audrasjb.
Merges [49328] to the 5.5 branch.
Fixes #51320.
Built from https://develop.svn.wordpress.org/branches/5.5@49332


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 17:56:05 +00:00
Sergey Biryukov f062c1a2cc Build Tools: Update mergeinfo for [49313]. 
See #51624.
Built from https://develop.svn.wordpress.org/branches/5.5@49315


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 22:58:06 +00:00
Sergey Biryukov bb32328f5e Build Tools: Fix running installing Composer dependencies using Composer 2.0. 
This updates the `dealerdirect/phpcodesniffer-composer-installer` package to allow installing version `0.7.0` which supports Composer 2.0.

Props itowhid06, jrf.
Merges [49306] to the 5.5 branch.
See #51624.
Built from https://develop.svn.wordpress.org/branches/5.5@49313


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 22:47:06 +00:00
Sergey Biryukov 1d0dc9f672 Tests: Declare UTF-8 encoding for QUnit test suite. 
This was done for trunk in [49101] as part of other changes, and is now backported to the 5.5 branch.

Follow-up to [49275].

Props iandunn, SergeyBiryukov.
Fixes #51130.
Built from https://develop.svn.wordpress.org/branches/5.5@49307


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 01:31:05 +00:00
Dion Hulse 82ed257403 Bump Akismet external to 4.1.7. 
git-svn-id: http://core.svn.wordpress.org/branches/5.5@49044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 04:42:44 +00:00
tellyworth 542c3d4bb1 Community Events: Display dates and times in the user's time zone. 
Fixes #51130
Merges [49145], [49146], [49147], [49152], and [49201] to the 5.5 branch.
Props sippis, hlashbrooke, audrasjb, Rarst, iandunn

Built from https://develop.svn.wordpress.org/branches/5.5@49275


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 04:05:05 +00:00
Peter Wilson 59ca490c66 XML-RPC: Fix length validation of anonymous commenter's email address. 
Fix the first step of validating an anonymous commenters in which the length is checked prior to running regular expressions.

Follow up to [47808].
Merges [49271] to the 5.5 branch.
Fixes #51595.


Built from https://develop.svn.wordpress.org/branches/5.5@49273


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 02:47:07 +00:00
Sergey Biryukov f7533ee854 Comments: Hide the link to the initial parent comment in the reply heading when replying to another comment. 
This ensures that the reply heading is updated correctly on single post URLs with the `?replytocom` query argument.

Follow-up to [47506], [48876], [48904].

Props mailnew2ster, wpamitkumar, audrasjb, desrosj, SergeyBiryukov.
Merges [49187] to the 5.5 branch.
Fixes #51175.
Built from https://develop.svn.wordpress.org/branches/5.5@49191


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-18 17:11:06 +00:00
Sergey Biryukov 5188ab0ce7 Upgrade/Install: Check if plugin or theme update results are available before applying the notification filters. 
This avoids a PHP notice for an undefined index of either `plugin` or `theme` in the `auto_{plugin|theme}_update_send_email` filter hook.

Props afragen, audrasjb.
Merges [49166] to the 5.5 branch.
Fixes #51400.
Built from https://develop.svn.wordpress.org/branches/5.5@49167


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-15 23:31:07 +00:00
Sergey Biryukov f2b876135c Bootstrap/Load: Revert [49161] from the 5.5 branch. 
See #50913.
Built from https://develop.svn.wordpress.org/branches/5.5@49164


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-15 21:19:05 +00:00
Aaron Jorbin 4c768414d6 Bootstrap/Load: Don't assume WP_CONTENT_DIR is defined 
When the mysql extention isn't loaded and a custom db dropin is not in place, we give folks a nice error. However, we can't assume that the WP_CONTENT_DIR constant is set yet since this runs before we define default constants.

This fixes a PHP8 error.

See: #50913.


Built from https://develop.svn.wordpress.org/branches/5.5@49161


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-15 17:07:06 +00:00
Sergey Biryukov 2434d8188d Comments: Check if a valid comment ID was passed when editing a comment. 
This avoids a PHP notice after submitting the Edit Comment form.

Follow-up to [48050].

Props regan.khadgi.
Merges [48958] to the 5.5 branch.
Fixes #51263.
Built from https://develop.svn.wordpress.org/branches/5.5@48959


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-09-08 22:46:07 +00:00
Sergey Biryukov a4b9563038 Media: In `wp_ajax_image_editor()`, check if the `error` property exists before accessing it. 
This avoids a PHP notice when editing an image.

Follow-up to [48375].

Props Mista-Flo.
Merges [48946] to the 5.5 branch.
Fixes #51251.
Built from https://develop.svn.wordpress.org/branches/5.5@48956


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-09-07 13:07:03 +00:00
Sergey Biryukov ff206bc029 Administration: Give the `$error` variable in `wp-admin/admin-header.php` a more descriptive name. 
This avoids a conflict with the same global variable used elsewhere, e.g. in Theme Editor.

Follow-up to [48850].

Props vinayak.anivase.
Merges [48938] to the 5.5 branch.
Fixes #51219.
Built from https://develop.svn.wordpress.org/branches/5.5@48955


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-09-07 13:05:10 +00:00
desrosj 0fb385f897 Post WordPress 5.5.1 version bump. The 5.5 branch is now 5.5.2 alpha. 
Built from https://develop.svn.wordpress.org/branches/5.5@48936


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-09-01 19:22:05 +00:00
desrosj e56d08be94 WordPress 5.5.1. 
Built from https://develop.svn.wordpress.org/branches/5.5@48934


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-09-01 18:52:03 +00:00
Sergey Biryukov bb254465ec Help/About: Update the About page for 5.5.1. 
Props audrasjb, desrosj, SergeyBiryukov.
Fixes #51202.
Built from https://develop.svn.wordpress.org/branches/5.5@48933


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-09-01 17:44:03 +00:00
Sergey Biryukov 0cf22af9bc Help/About: Fix typo and remove trailing spaces from some strings. 
Props mukesh27, casiepa, davidbaumwald.
Merges [48809] to the 5.5 branch.
Fixes #51028.
Built from https://develop.svn.wordpress.org/branches/5.5@48932


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-09-01 17:24:08 +00:00
desrosj e803596246 Post WordPress 5.5.1 RC2 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.5@48928


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 23:47:04 +00:00
desrosj f06114fff2 WordPress 5.5.1 RC2. 
Built from https://develop.svn.wordpress.org/branches/5.5@48927


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 23:29:04 +00:00
desrosj 26e1ea0fe0 Tests: Move the tests for `get_the_modified_time()` to a more appropriate place. 
Add some new tests to better cover the functionality, for consistency with `get_the_date()` and `get_the_time()`.

Follow-up to [48911], [48912], [48918].

Props wittich.
Merges [48924] to the 5.5 branch.
Fixes #51184.
Built from https://develop.svn.wordpress.org/branches/5.5@48926


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 22:51:06 +00:00
desrosj fdad915022 Script Loader: Add backward compatibility for JavaScript i18n globals and properties deprecated in WordPress 5.5. 
The recommended approach for any plugins using these globals or properties is to switch to the newer `wp.i18n` functions.

In the meantime, this ensures that accessing any of these globals does not break the rest of the code on the page, and an appropriate warning message is logged to the JavaScript console.

Follow-up to: https://core.trac.wordpress.org/query?summary=~wp.i18n&milestone=5.5

Props omarreiss, peterwilsoncc, kbjohnson90, johnbillion, TimothyBlynJacobs, joostdevalk, ocean90, desrosj, SergeyBiryukov.
Merges [48923] to the 5.5 branch.
Fixes #51123.
Built from https://develop.svn.wordpress.org/branches/5.5@48925


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 22:44:13 +00:00
desrosj 649a2dbd38 Date/Time: In `get_the_date()` and related functions, pass the original, unmodified `$format` value to the filters. 
Additionally, simplify the `$format` argument checks for consistency with similar checks in `get_the_modified_date()` and `get_the_modified_time()`.

Follow-up to [48912].

Props Rarst.
Merges [48918] to the 5.5 branch.
See #51184.
Built from https://develop.svn.wordpress.org/branches/5.5@48922


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 19:00:08 +00:00
desrosj bb9c99c489 Date/Time: Make sure `get_the_date()` and related functions return correct time if the format was specified as `false`. 
Technically, the `$format` argument should always be a string, but passing `false` used to work before [47808], so this restores backward compatibility.

The list of affected functions:

- `get_the_date()`
- `get_the_time()`
- `get_comment_date()`
- `get_comment_time()`

Props wittich, Rarst, akabarikalpesh, SergeyBiryukov.
Merges [48912] to the 5.5 branch.
Fixes #51184.
Built from https://develop.svn.wordpress.org/branches/5.5@48921


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 18:58:03 +00:00
desrosj 8fd734ae42 Tests: Bring some consistency to Date/Time tests: 
- Move some tests from `post.php` to a more appropriate location in the `date` directory.
- Rename `date/postTime.php` to `date/getPostTime.php` to match the function name. 

Props Rarst.
Merges [48911] to the 5.5 branch.
See #51184.
Built from https://develop.svn.wordpress.org/branches/5.5@48920


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 18:55:04 +00:00
desrosj 22ceef8ed5 Themes: Normalize the installed theme path in `Theme_Installer_Skin::do_overwrite()` before comparing with the uploaded theme. 
This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows.

Follow-up to [48390].

Props bobbingwide, wpamitkumar, mukesh27.
Merges [48913] to the 5.5 branch.
Fixes #51182.
Built from https://develop.svn.wordpress.org/branches/5.5@48919


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 18:31:09 +00:00
desrosj f5a90352b3 Comments: Check if reply heading text node exists before accessing its property in `comment-reply.js`. 
Follow-up to [47506], [48876].

Props johannadevos, mailnew2ster.
Merges [48904] to the 5.5 branch.
Fixes #38009.
Built from https://develop.svn.wordpress.org/branches/5.5@48917


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 18:14:04 +00:00
desrosj 26edd1d039 Docs: Clarify the usage of `null` for `auto_update_{$type}` filter. 
The value is internally used to detect whether nothing has hooked into this filter.

Props audrasjb, pbiron, johnbillion, SergeyBiryukov.
Merges [48909] to the 5.5 branch.
Fixes #50848.
Built from https://develop.svn.wordpress.org/branches/5.5@48916


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 18:02:04 +00:00
desrosj 15ed5a9e75 Docs: Add a `@since` note to the `display_post_states` filter to clarify that it is now also applied in the Customizer context. 
If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used.

Follow-up to [47763], [48620].

Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov.
Merges [48910] to the 5.5 branch.
Fixes #51081.
Built from https://develop.svn.wordpress.org/branches/5.5@48915


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 17:57:02 +00:00
desrosj 94b419b058 Tests: Reset the `$wp_sitemap` global after each test, so that sitemaps are re-initialized when the next test runs. 
This ensures consistent results in query var tests, regardless of whether they are run in isolation or as part of a larger group of tests.

Props pbiron, peterwilsoncc.
Merges [48908] to the 5.5 branch.
Fixes #51154.
Built from https://develop.svn.wordpress.org/branches/5.5@48914


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-31 17:53:07 +00:00
desrosj 5d3eb85af8 Post WordPress 5.5.1 RC1 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.5@48902


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 23:24:04 +00:00
desrosj 280739e72c WordPress 5.5.1 RC1. 
Built from https://develop.svn.wordpress.org/branches/5.5@48901


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 23:06:05 +00:00
Sergey Biryukov a6f6950507 Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature. 
Follow-up to [48669], [48688].

Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov.
Merges [48899] to the 5.5 branch.
Fixes #51129.
Built from https://develop.svn.wordpress.org/branches/5.5@48900


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 22:26:04 +00:00
Sergey Biryukov 825f0e01b4 Script Loader: Disable concatenation for scripts with translations to ensure they are printed in the right order. 
Props herregroen, ocean90, desrosj, mikeyarce, bobbingwide, audrasjb, johnbillion.
Merges [48897] to the 5.5 branch.
Fixes #50999.
Built from https://develop.svn.wordpress.org/branches/5.5@48898


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 22:01:05 +00:00
Sergey Biryukov a0096893c3 Bootstrap/Load: Remove the ability to alter the list of environment types in `wp_get_environment_type()`. 
The intention of `wp_get_environment_type()` is to provide a consistent means of identifying the environment type, not of identifying a specific environment.

Actual environments should fit within one of the existing types: `local`, `development`, `staging`, or `production`. That should cover the types that plugins and themes might be concerned about when toggling functionality. 

Props johnbillion, joostdevalk, TimothyBlynJacobs, jeremyfelt, batmoo, claytoncollie, Clorith, markjaquith, garrett-eclipse, GaryJ, elrae.
Merges [48894] and [48895] to the 5.5 branch.
Fixes #50992.
Built from https://develop.svn.wordpress.org/branches/5.5@48896


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 21:46:05 +00:00
Sergey Biryukov de7200c257 Tests: Update `wp_add_inline_script()` unit tests to account for the `jquery` handle being an alias for `jquery-core` again. 
Follow-up to [48323], [48324], [48890].

Props davidbaumwald, audrasjb.
Merges [48892] to the 5.5 branch.
See #50919.
Built from https://develop.svn.wordpress.org/branches/5.5@48893


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 21:08:04 +00:00
Sergey Biryukov 128ba6a38a Script Loader: Change the `jquery` handle back to an alias for `jquery-core`. 
This ensures that `wp_localize_script( 'jquery', ... )` continues to work as expected, since `WP_Scripts::localize()` rewrites the `jquery` handle to `jquery-core` internally.

Follow-up to [48323].

Props mukesh27, rajeshsingh520, johnbillion, TimothyBlynJacobs, TobiasBg.
Merges [48890] to the 5.5 branch.
Fixes #50919.
Built from https://develop.svn.wordpress.org/branches/5.5@48891


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 20:36:07 +00:00
desrosj 9fceb56948 Upgrade/Install: Pass details about the specific plugin and theme updates attempted to filters. 
This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner's liking.

Props audrasjb, Paddy Landau, desrosj.
Merges [48888] to the 5.5 branch.
Fixes #50988.
Built from https://develop.svn.wordpress.org/branches/5.5@48889


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 19:34:05 +00:00
desrosj 8096a67b7c Build/Test Tools: Update the package lock file. 
Follow up to [48884].

Merges [48886] to the 5.5 branch.
See #51151.
Built from https://develop.svn.wordpress.org/branches/5.5@48887


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 19:07:05 +00:00
jorgefilipecosta 5228943449 Editor: update packages. 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Merges [48884] to the 5.5 branch.
Fixes: #51151.
Built from https://develop.svn.wordpress.org/branches/5.5@48885


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 18:00:38 +00:00
Sergey Biryukov 5b5de79ffd REST API: Fix multi-type schemas with integer fields. 
In [48306] support for multi-typed schemas was improved to first detect the data type of the value before applying further validation. The `integer` data type was detected using the new `rest_is_integer` function. This function used logic, however, that assumed that the value had already passed an `is_numeric` check. This meant that if `integer` and `string` were both acceptable types, the value would always be considered an `integer` causing the later accurate type validation to fail.

This commit fixes the `rest_is_integer` logic to include an `is_numeric` check.

Props rtagliento, TimothyBlynJacobs.
Merges [48881] to the 5.5 branch.
Fixes #51146.
Built from https://develop.svn.wordpress.org/branches/5.5@48883


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 14:45:05 +00:00
Sergey Biryukov 522904bde6 Taxonomy: Make sure `wp_terms_checklist()` and `Walker_Category_Checklist::start_el()` properly handle an array of strings as `selected_cats` or `popular_cats` values. 
Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results.

Add a unit test.

Props brianhogg, TimothyBlynJacobs, SergeyBiryukov.
Merges [48880] to the 5.5 branch.
Fixes #51137.
Built from https://develop.svn.wordpress.org/branches/5.5@48882


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 03:08:03 +00:00
Sergey Biryukov 8e1d2765d0 Tests: Update one more test to account for lazy-loading being disabled for custom logos by default. 
Follow-up to [48870], [48874].

Props desrosj.
Merges [48878] to the 5.5 branch.
See #50933.
Built from https://develop.svn.wordpress.org/branches/5.5@48879


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 02:05:04 +00:00
Sergey Biryukov 466316ef95 Comments: Correct the check for reply element existence in `comment-reply.js`. 
`document.getElementById()` returns `null` if no matching element was found, so the previous comparison didn't work as expected.

Follow-up to [47506].

Props mailnew2ster, sarahricker.
Merges [48876] to the 5.5 branch.
Fixes #38009.
Built from https://develop.svn.wordpress.org/branches/5.5@48877


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 02:01:04 +00:00
Sergey Biryukov 9135fd39a6 Tests: Update unit tests to account for lazy-loading being disabled for custom logos by default. 
Follow-up to [48870].

Merges [48874] to the 5.5 branch.
See #50933.
Built from https://develop.svn.wordpress.org/branches/5.5@48875


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 01:58:04 +00:00
Peter Wilson b0038c85f1 Sitemaps: Prevent incorrect redirection of paged sitemap requests. 
Update `redirect_canonical()` to account for custom pagination and URL format used by sitemaps in order to follow standard practices.

Introduce the function `get_sitemap_url()` to simplify getting the index and provider URLs as needed.

Props jonathanstegall, pbiron, GamerZ, salvoaranzulla, peterwilsoncc.
Merges [48872] to the 5.5 branch.
Fixes #50910.


Built from https://develop.svn.wordpress.org/branches/5.5@48873


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 01:37:03 +00:00
desrosj 7c2369f292 Media: Disable lazy-loading for custom logos by default. 
Custom site logos are most commonly displayed above the fold, so lazy-loading is unnecessary.

Props demetris, khag7, johnbillion, rebasaurus, audrasjb.
Merges [48870] to the 5.5 branch.
Fixes #50933.
Built from https://develop.svn.wordpress.org/branches/5.5@48871


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-27 01:10:07 +00:00
Sergey Biryukov 97bbea6001 Upgrade/Install: Make the check for empty `home` option in `__get_option()` more resilient. 
This addresses a regression in [47808], where the `home` check expected an empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns `null` if the option is empty.

Props fjarrett.
Merges [48868] to the 5.5 branch.
Fixes #51011.
Built from https://develop.svn.wordpress.org/branches/5.5@48869


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-26 17:07:09 +00:00