Commit Graph

19822 Commits

Author SHA1 Message Date
Dion Hulse a579aad05b XMLRPC: Prevent authentication from occuring after a failed authentication attmept in any single XML-RPC call.
This hardens WordPress against a common vector which uses multiple user identifiers in a single `system.multicall` call. In the event that authentication fails, all following authentication attempts ''in that call'' will also fail.

Props dd32, johnbillion.
Fixes #34336

Built from https://develop.svn.wordpress.org/trunk@35366


git-svn-id: http://core.svn.wordpress.org/trunk@35331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 04:46:24 +00:00
Dion Hulse 53afc72ab7 Update to Random_Compat 1.0.9.
This update includes fixes for Windows support & libSodium support, and removes the `Throwable` Polyfill due to PHP7 incompatibilities. 

Fixes #28633

Built from https://develop.svn.wordpress.org/trunk@35365


git-svn-id: http://core.svn.wordpress.org/trunk@35330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 04:22:26 +00:00
Dion Hulse a49062c2db Update variable naming after [35279].
See #29957.

Built from https://develop.svn.wordpress.org/trunk@35364


git-svn-id: http://core.svn.wordpress.org/trunk@35329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 02:01:25 +00:00
Scott Taylor 90ff454ec2 4.4-beta1
Built from https://develop.svn.wordpress.org/trunk@35362


git-svn-id: http://core.svn.wordpress.org/trunk@35328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 21:45:25 +00:00
Scott Taylor 2afbf378d9 Plugins: after [35151], set default `$restrict_network_*` values to prevent notices.
Props johnjamesjacoby.
Fixes #20104.

Built from https://develop.svn.wordpress.org/trunk@35361


git-svn-id: http://core.svn.wordpress.org/trunk@35327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:56:23 +00:00
Scott Taylor e31c837d70 Options: remove old 'gzipcompression' and 'advanced_edit' options.
Props chriscct7, solarissmoke.
Fixes #12996.

Built from https://develop.svn.wordpress.org/trunk@35360


git-svn-id: http://core.svn.wordpress.org/trunk@35326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:49:24 +00:00
Drew Jaynes 56c81005fe Docs: Add a proper file header to wp-admin/includes/continents-cities.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35359


git-svn-id: http://core.svn.wordpress.org/trunk@35325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:43:25 +00:00
Andrew Ozz dfc2412be1 Responsive Images: limit the size of images included in `srcset` attributes. Introduce `max_srcset_image_width` filter to adjust the limit.
Props joemcgill.
Fixes #34341.
Built from https://develop.svn.wordpress.org/trunk@35358


git-svn-id: http://core.svn.wordpress.org/trunk@35324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:31:25 +00:00
Helen Hou-Sandí 6ca92efe23 List tables: Move the view mode switcher into screen options for posts.
Having a view mode switcher nestled within table navigation makes no sense, especially now that it's a sticky user option. While less convenient for frequent switching, there is no evidence as of yet that there is a large userbase of frequent view mode switchers.

Introduces a filter for `view_mode_post_types`, which by default is all hierarchical post types with edit UI on.

props Oxymoron.
fixes #22222.

Built from https://develop.svn.wordpress.org/trunk@35357


git-svn-id: http://core.svn.wordpress.org/trunk@35323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:25:25 +00:00
Scott Taylor 677762f6cf oEmbed: add Reddit Comments as a provider
Docs: https://github.com/reddit/reddit/wiki/oEmbed

Props swissspidy.
Fixes #31752.


Built from https://develop.svn.wordpress.org/trunk@35356


git-svn-id: http://core.svn.wordpress.org/trunk@35322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 18:17:24 +00:00
Scott Taylor 318ad90a22 Media: in `wp_get_attachment_image_sizes()`, to streamline and for performance:
* Change the 3rd arg from `args` to `width`
* Change `wp_image_sizes_args` filter to `wp_get_attachment_image_sizes`

Updates unit tests.

Props joemcgill.
Fixes #34379.

Built from https://develop.svn.wordpress.org/trunk@35355


git-svn-id: http://core.svn.wordpress.org/trunk@35321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 16:46:24 +00:00
Scott Taylor 1cd49e2d4d oEmbed: if `SimpleXMLElement` does not exist, return an `HTTP Error 501 Not implemented` response.
Props swissspidy.
Fixes #34274.

Built from https://develop.svn.wordpress.org/trunk@35354


git-svn-id: http://core.svn.wordpress.org/trunk@35320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 16:38:26 +00:00
Scott Taylor 31e0b06125 REST API: don't load `wp-admin/includes/admin.php` on every request.
Props swissspidy.
Fixes #34395.

Built from https://develop.svn.wordpress.org/trunk@35353


git-svn-id: http://core.svn.wordpress.org/trunk@35319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 16:29:28 +00:00
Sergey Biryukov 560b276b0b Docs: Correct description for `_wp_post_revision_fields()` arguments.
See #13382.
Built from https://develop.svn.wordpress.org/trunk@35352


git-svn-id: http://core.svn.wordpress.org/trunk@35318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 12:17:28 +00:00
John Blackbourn 7757d04ce3 Force the REST API URL to use `https` for its scheme when the current request is served over HTTPS and the host name matches that of the REST API URL.
This allows sites to use an admin area over HTTPS with the front end over HTTP, and not end up with a cross-protocol problem when using the REST API URL in the admin area.

Fixes #34299

Built from https://develop.svn.wordpress.org/trunk@35351


git-svn-id: http://core.svn.wordpress.org/trunk@35317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 00:08:26 +00:00
John Blackbourn 9bcf8a9ec7 Initialise `$_SERVER['SERVER_NAME']` during the test bootstrap to avoid individual tests having to do it.
Fixes #34394

Built from https://develop.svn.wordpress.org/trunk@35350


git-svn-id: http://core.svn.wordpress.org/trunk@35316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 23:52:31 +00:00
John Blackbourn e552b77739 Revert [34352], pending investigation.
See #34299

Built from https://develop.svn.wordpress.org/trunk@35349


git-svn-id: http://core.svn.wordpress.org/trunk@35315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 23:06:30 +00:00
John Blackbourn 93642e94ba Remove the explicit Imagick extension test.
See #34087

Built from https://develop.svn.wordpress.org/trunk@35348


git-svn-id: http://core.svn.wordpress.org/trunk@35314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 22:41:27 +00:00
John Blackbourn f721788901 Correctly use `WP_TESTS_EMAIL` in email tests.
See #761, #34000

Built from https://develop.svn.wordpress.org/trunk@35347


git-svn-id: http://core.svn.wordpress.org/trunk@35313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 22:34:26 +00:00
John Blackbourn 98ea864e32 Correct some more tests which were using `example.org` instead of `WP_TESTS_DOMAIN`.
See #33641, #34000

Built from https://develop.svn.wordpress.org/trunk@35346


git-svn-id: http://core.svn.wordpress.org/trunk@35312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 22:22:31 +00:00
John Blackbourn cf657cca29 Provide a more helpful failure message when Imagick isn't installed. Skipping the tests isn't really an option because Imagick's presence affects several other tests too.
See #34087

Built from https://develop.svn.wordpress.org/trunk@35345


git-svn-id: http://core.svn.wordpress.org/trunk@35311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 22:11:25 +00:00
John Blackbourn 2987fe95af Remove the failing `test_rest_url_scheme()` test while it's investigated.
See #34299

Built from https://develop.svn.wordpress.org/trunk@35344


git-svn-id: http://core.svn.wordpress.org/trunk@35310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 22:07:25 +00:00
Andrea Fercia cfa07d28af Plugins: Improve the "Install Now" button vertical alignment in the Plugin Details modal dialog.
Props paulwilde.

Fixes #34199.
Built from https://develop.svn.wordpress.org/trunk@35343


git-svn-id: http://core.svn.wordpress.org/trunk@35309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 21:55:29 +00:00
John Blackbourn f7f5b64a7e Force the REST API URL to use `https` for its scheme when the current request is served over HTTPS and the host name matches that of the REST API URL.
This allows sites to use an admin area over HTTPS with the front end over HTTP, and not end up with a cross-protocol problem when using the REST API URL in the admin area.

Fixes #34299

Built from https://develop.svn.wordpress.org/trunk@35342


git-svn-id: http://core.svn.wordpress.org/trunk@35308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 20:38:50 +00:00
Andrew Ozz 4cdddd401a TinyMCE:
- Sanitize and render HTML in captions when showing a gallery preview (wpView).
- Encode/escape HTML entered in the text field in the wpLink dialog.

Props iseulde, kraftbj, jnylen0, shawarkhan.
Fixes #32616.
Built from https://develop.svn.wordpress.org/trunk@35341


git-svn-id: http://core.svn.wordpress.org/trunk@35307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 20:38:26 +00:00
Helen Hou-Sandí 28c77bec72 RIP `#21759b`, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.

Built from https://develop.svn.wordpress.org/trunk@35340


git-svn-id: http://core.svn.wordpress.org/trunk@35306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:36:28 +00:00
Drew Jaynes f954194a1c Comments: Introduce two new filters, `notify_moderator` and `notify_post_author`, both of which make it possible to selectively override site notification email settings for new comments.
The `notify_moderator` filter makes it possible to override the value for the `moderation_notify` option, which controls whether to send new comment emails to "site moderators", that is to say, the owner of the admin email for the site and the post author if they have the ability to modify the comment.

The `notify_post_author` filter likewise makes it possible to override the value for the `comments_notify` option, which controls whether to send new comment emails to the post author. If the post author is the comment author, default behavior is not to send the notification. Note: enabling or disabling notifications via this hook could also affect other recipients added via the 'comment_notification_recipients' filter in `wp_notify_postauthor()`, if hooked.

Passing a falsey value to either of the new filters will prevent notifications from being sent, regardless of their corresponding option values.

Adds tests.

Props coffee2code, adamsilverstein, DrewAPicture.
Fixes #761.

Built from https://develop.svn.wordpress.org/trunk@35339


git-svn-id: http://core.svn.wordpress.org/trunk@35305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:35:31 +00:00
Andrea Fercia 223afd7e04 Press This: Improve the "choose tags" button focus style.
Props adamholisky for the initial patch.

Fixes 34241.
Built from https://develop.svn.wordpress.org/trunk@35338


git-svn-id: http://core.svn.wordpress.org/trunk@35304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:34:26 +00:00
Dominik Schilling 253646fcd1 Options: Hide the week starts on setting for installs that have the default setting already.
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.
Built from https://develop.svn.wordpress.org/trunk@35337


git-svn-id: http://core.svn.wordpress.org/trunk@35303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 17:39:25 +00:00
Dominik Schilling 46a115de61 WP Locale: Add a `start_of_week` property to store the start of the week per locale.
Props swissspidy.
See #28344.
Built from https://develop.svn.wordpress.org/trunk@35336


git-svn-id: http://core.svn.wordpress.org/trunk@35302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 17:28:29 +00:00
Aaron Jorbin 5a7bb070da Update grunt-browserify
upstream changes https://github.com/jmreidy/grunt-browserify/compare/v4.0.0...v4.0.1

See #34177

Built from https://develop.svn.wordpress.org/trunk@35335


git-svn-id: http://core.svn.wordpress.org/trunk@35301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:59:25 +00:00
Konstantin Obenland d7bb9d8254 Tests: Use most specific function for document titles.
Adds tests specific to `_wp_render_title_tag()`.

See #31078.


Built from https://develop.svn.wordpress.org/trunk@35334


git-svn-id: http://core.svn.wordpress.org/trunk@35300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:55:25 +00:00
Boone Gorges 9088df3fee Prevent non-public taxonomies from registering aquery var.
[34247] made the 'public' paramater of `register_taxonomy()` work by blocking
requests for non-public taxonomy archives during `parse_request()`. Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to `register_taxonomy()` - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in `parse_request()` and better parallel the way non-public post types
work. See `register_post_type()`.

Non-public taxonomy archives that are requested using `?taxonomy=tax_name` are
still blocked during `parse_request`. It's only custom query vars -
`?tax_name=term` - that are affected by this change.

Props mboynes.
Fixes #21949.
Built from https://develop.svn.wordpress.org/trunk@35333


git-svn-id: http://core.svn.wordpress.org/trunk@35299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:54:24 +00:00
Aaron Jorbin 3fcb37a831 Replace Autoprefixer Core with Autoprefixer
Autoprefixer Core 5.2.1 -> Autoprefixer 6.0.3 https://github.com/postcss/autoprefixer/releases/tag/6.0.0
Package autoprefixer-core is deprecated in favour of autoprefixer as part of the 6.0.0 release:
Packages autoprefixer and autoprefixer-core were merged in 6.0 release.
Autoprefixer 6.0.0 requires PostCSS 5.0.10 or greater
PostCSS 0.5.4 -> 0.6.0 https://github.com/nDmitry/grunt-postcss/compare/v0.5.4...v0.6.0

You will need to update your dev dependencies after this change.

Props netweb
See #34177


Built from https://develop.svn.wordpress.org/trunk@35332


git-svn-id: http://core.svn.wordpress.org/trunk@35298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:48:38 +00:00
Boone Gorges 3eab09a694 Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.
Built from https://develop.svn.wordpress.org/trunk@35331


git-svn-id: http://core.svn.wordpress.org/trunk@35297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:26:42 +00:00
Helen Hou-Sandí 3df1d2abde Media: Update colors to match the times.
This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.

Built from https://develop.svn.wordpress.org/trunk@35330


git-svn-id: http://core.svn.wordpress.org/trunk@35296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:18:26 +00:00
Boone Gorges cc0bf494a4 Document title tests should expect dynamic blogname.
Fixes #31078.
Built from https://develop.svn.wordpress.org/trunk@35329


git-svn-id: http://core.svn.wordpress.org/trunk@35295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:15:26 +00:00
Drew Jaynes aef5b20ee3 Docs: Add documentation in the form of a hash notation for default arguments accepted by `wp_login_form()`.
Props ramiy for the initial patch.
Fixes #34364.

Built from https://develop.svn.wordpress.org/trunk@35328


git-svn-id: http://core.svn.wordpress.org/trunk@35294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 15:38:26 +00:00
Helen Hou-Sandí 8803c05db5 `wp_die()`: Update colors and button styling.
see #34388, #31459.

Built from https://develop.svn.wordpress.org/trunk@35327


git-svn-id: http://core.svn.wordpress.org/trunk@35293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 15:23:26 +00:00
Dominik Schilling 4d0759afae List Tables: Replace the hyphen separator for titles and post/media states with a `—`.
Props McGuive7.
Fixes #23230.
Built from https://develop.svn.wordpress.org/trunk@35326


git-svn-id: http://core.svn.wordpress.org/trunk@35292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 14:33:27 +00:00
Drew Jaynes 81524f3bfc Filesystem: Following the introduction of the `KB|MB|GB|TB_IN_BYTES` constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.

Built from https://develop.svn.wordpress.org/trunk@35325


git-svn-id: http://core.svn.wordpress.org/trunk@35291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 14:03:25 +00:00
Drew Jaynes 6a51505a23 Docs: Improve the return description in the DocBlock for `rest_send_allow_header()`.
Props danielbachhuber.
Fixes #34374.

Built from https://develop.svn.wordpress.org/trunk@35324


git-svn-id: http://core.svn.wordpress.org/trunk@35290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 13:48:27 +00:00
Sergey Biryukov 116f59af60 REST API: Change nonce name to `_wpnonce`.
It's shorter and is compatible with the default name in `wp_nonce_field()`.

Props danielbachhuber.
Fixes #34375.
Built from https://develop.svn.wordpress.org/trunk@35323


git-svn-id: http://core.svn.wordpress.org/trunk@35289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 08:14:24 +00:00
Sergey Biryukov da157f16b1 Add `get_terms_defaults` filter for the default arguments of `get_terms()`.
Fixes #33369.
Built from https://develop.svn.wordpress.org/trunk@35322


git-svn-id: http://core.svn.wordpress.org/trunk@35288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 08:08:25 +00:00
Sergey Biryukov d1dea6e6cf Reorder default arguments in `get_terms()` for consistency with the hash notation added in [29128].
See #33369.
Built from https://develop.svn.wordpress.org/trunk@35321


git-svn-id: http://core.svn.wordpress.org/trunk@35287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 08:01:25 +00:00
Sergey Biryukov 6b5e523996 Docs: Correct function name in `get_terms_args` parameter description.
See #33369.
Built from https://develop.svn.wordpress.org/trunk@35320


git-svn-id: http://core.svn.wordpress.org/trunk@35286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 07:42:24 +00:00
Sergey Biryukov 1025e22303 Docs: Correct duplicate hook reference for `get_terms`.
See #33369.
Built from https://develop.svn.wordpress.org/trunk@35319


git-svn-id: http://core.svn.wordpress.org/trunk@35285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 07:40:27 +00:00
Andrew Ozz de881c4a97 Precommit cleanup, see r35313.
Built from https://develop.svn.wordpress.org/trunk@35318


git-svn-id: http://core.svn.wordpress.org/trunk@35284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:33:24 +00:00
Andrew Ozz 71ac079074 Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.
Built from https://develop.svn.wordpress.org/trunk@35317


git-svn-id: http://core.svn.wordpress.org/trunk@35283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:23:26 +00:00
Scott Taylor 47879dc83a Export: add missing labels and improvement accessibility of the Export screen.
Props afercia.
Fixes #33046.

Built from https://develop.svn.wordpress.org/trunk@35316


git-svn-id: http://core.svn.wordpress.org/trunk@35282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:57:24 +00:00
Scott Taylor 85d21feca6 Plugins/Updates: in `request_filesystem_credentials()`, alter the heading HTML tag based on the current screen for improved semantics.
Props afercia.
Fixes #34267.

Built from https://develop.svn.wordpress.org/trunk@35315


git-svn-id: http://core.svn.wordpress.org/trunk@35281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:51:24 +00:00
Scott Taylor 8eb3de46c9 Formatting: move `url_shorten()` from `wp-admin/includes/misc.php` to `wp-includes/formatting.php` for more global access.
Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.

Built from https://develop.svn.wordpress.org/trunk@35314


git-svn-id: http://core.svn.wordpress.org/trunk@35280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:48:24 +00:00
Scott Taylor e525ab849d Administration: the current admin menu item should have an `aria-haspopup` attribute when the menu is folded.
Unify the jQuery selector caching for `window`, `document`, and `body`.

Props afercia.
Fixes #32578.

Built from https://develop.svn.wordpress.org/trunk@35313


git-svn-id: http://core.svn.wordpress.org/trunk@35279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:41:24 +00:00
Scott Taylor e6015a31ab Site Icon: make the default value for the `site_icon` option `0` in `schema.php`.
Props swissspidy, sebastian.pisula.
Fixes #34339.

Built from https://develop.svn.wordpress.org/trunk@35312


git-svn-id: http://core.svn.wordpress.org/trunk@35278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:28:25 +00:00
Scott Taylor 97c75b5f07 AJAX UNIT TESTS: Have you ever wondered why these take 600 forevers to run? They all eventually call `do_action( 'admin_init' )`, which has `_maybe_update_core`, `_maybe_update_plugins`, and `_maybe_update_themes` hooked to it. REMOVE THEM, and AJAX unit tests run like the wind. `Tests_Ajax_Response` is still slow.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35311


git-svn-id: http://core.svn.wordpress.org/trunk@35277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:18:25 +00:00
Sergey Biryukov 9fa88a7f27 Autoprefixer for [35281].
See #33322.
Built from https://develop.svn.wordpress.org/trunk@35310


git-svn-id: http://core.svn.wordpress.org/trunk@35276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:02:24 +00:00
Scott Taylor fc850bf274 Unit Tests: consolidate the many separate implementations of `_make_attachment()` into a helper method on `WP_UnitTestCase`.
Fixes #34075.

Built from https://develop.svn.wordpress.org/trunk@35309


git-svn-id: http://core.svn.wordpress.org/trunk@35275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 01:59:26 +00:00
Weston Ruter d7e13544ea Customizer: Prevent `nav_menu_item` settings from becoming dirty when their controls are set up.
Since `wp_setup_nav_menu_item()` returns the `classes` property as an array but the Customizer manages the value as a string, the setting needs to initially export the value as a string. This prevents the `classes` property type change from causing the setting to get marked as dirty even though nothing changed. This is a regression from [34788].

See #34111.

Built from https://develop.svn.wordpress.org/trunk@35308


git-svn-id: http://core.svn.wordpress.org/trunk@35274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:45:29 +00:00
Weston Ruter bee05e0cdc Customizer: Introduce `customize_loaded_components` filter to allow core components to be disabled.
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327.

Props westonruter, DrewAPicture.
Fixes #33552.

Built from https://develop.svn.wordpress.org/trunk@35307


git-svn-id: http://core.svn.wordpress.org/trunk@35273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:16:25 +00:00
Andrew Ozz 3451251548 TinyMCE: update to 4.2.6. Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=887.
Fixes #34331.
Built from https://develop.svn.wordpress.org/trunk@35306


git-svn-id: http://core.svn.wordpress.org/trunk@35272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:06:24 +00:00
Weston Ruter c77bb38b3d Customizer: Allow new `option` settings to not be saved as autoloaded by passing an `autoload` arg value of `false`.
The `autoload` argument value is passed along to `update_option()` which has accepted an `$autoload` parameter since [31628].

Props westonruter, dlh.
See #26394.
Fixes #33499.

Built from https://develop.svn.wordpress.org/trunk@35305


git-svn-id: http://core.svn.wordpress.org/trunk@35271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 21:19:25 +00:00
Andrea Fercia 1e1e7a9fc9 Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.

Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.

Fixes #33327.
Built from https://develop.svn.wordpress.org/trunk@35304


git-svn-id: http://core.svn.wordpress.org/trunk@35270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 20:15:26 +00:00
Drew Jaynes 8549e76d56 Docs: Add translator comments for two `_deprecated_argument()` calls added to `get_wp_title_rss()` and `wp_title_rss()` in [35294].
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35303


git-svn-id: http://core.svn.wordpress.org/trunk@35269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:20:25 +00:00
Weston Ruter 6d9d18315d Customizer: Implement indicators for invalid nav menu items.
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.

Built from https://develop.svn.wordpress.org/trunk@35302


git-svn-id: http://core.svn.wordpress.org/trunk@35268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:08:25 +00:00
Drew Jaynes 0715dc8a4f Docs: Adjust syntax in the hook doc summaries for the `document_title_separator` and `document_title_parts` filters, introduced in [35294].
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35301


git-svn-id: http://core.svn.wordpress.org/trunk@35267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:37:54 +00:00
Drew Jaynes 7c538033dd Docs: Fix indentation and improve usefulness of inline comments surrounding the if/elseif conditions for assigning document titles in `wp_get_document_title()`.
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35300


git-svn-id: http://core.svn.wordpress.org/trunk@35266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:32:00 +00:00
Konstantin Obenland f6941fddf4 Site Icon: Get site icon ID only when needed.
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.


Built from https://develop.svn.wordpress.org/trunk@35299


git-svn-id: http://core.svn.wordpress.org/trunk@35265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:23:44 +00:00
Drew Jaynes 0ea90a9174 Docs: Update the hook doc for the `pre_get_document_title` filter to explain ''what'' value is filterable rather than ''why'' the value is filterable :-)
The hook was introduced in [35294].

See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35298


git-svn-id: http://core.svn.wordpress.org/trunk@35264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:14:24 +00:00
Drew Jaynes 0a1026ac10 Docs: Improve vague changelog entries for functions and hooks where arguments were deprecated in [35294].
See #31078. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35297


git-svn-id: http://core.svn.wordpress.org/trunk@35263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:10:43 +00:00
Drew Jaynes 08f3a3b226 Docs: Fix up DocBlock syntax for the now-deprecated `wp_title()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35296


git-svn-id: http://core.svn.wordpress.org/trunk@35262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 17:53:24 +00:00
Konstantin Obenland 788cb75879 Tests: Use updated filter names and oembed title for UT sanity.
See [35294], #31078.

Built from https://develop.svn.wordpress.org/trunk@35295


git-svn-id: http://core.svn.wordpress.org/trunk@35261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 17:05:25 +00:00
Konstantin Obenland c69e96422b Themes: Improve document title output.
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.


Built from https://develop.svn.wordpress.org/trunk@35294


git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:21:25 +00:00
Sergey Biryukov b8e250927f In `wp_list_categories()`, rewrite a long condition for clarity.
See #34363.
Built from https://develop.svn.wordpress.org/trunk@35293


git-svn-id: http://core.svn.wordpress.org/trunk@35259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:13:26 +00:00
Sergey Biryukov e0af554638 Tags: Avoid a double trailing space after tags separator in auto-suggest.
Props afercia.
Fixes #33881.
Built from https://develop.svn.wordpress.org/trunk@35292


git-svn-id: http://core.svn.wordpress.org/trunk@35258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:00:30 +00:00
Boone Gorges b285b3002a Correct inline comment in `wp_list_categories()`.
The fallback link for the 'All' option is 'page_for_posts', not
'page_on_front'. Introduced in [32292].

Props sudar, SergeyBiryukov.
Fixes #34363.
Built from https://develop.svn.wordpress.org/trunk@35291


git-svn-id: http://core.svn.wordpress.org/trunk@35257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 12:55:27 +00:00
Drew Jaynes 7c3a476909 Docs: Correction: `MONTH_IN_SECONDS` was added in 4.4.0.
Props swissspidy.
See [33698]. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35290


git-svn-id: http://core.svn.wordpress.org/trunk@35256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 07:35:26 +00:00
Drew Jaynes 3686b78448 Media: Introduce the `image_get_intermediate_size` filter to its like-named function, making it possible to manipulate returned intermedia image size data.
Covers both the default and meaningful short-circuit return cases. Also adds a hash notation to the return documentation in the DocBlock.

Props A5hleyRich, DH-Shredder, wonderboymusic.
Fixes #34124.

Built from https://develop.svn.wordpress.org/trunk@35289


git-svn-id: http://core.svn.wordpress.org/trunk@35255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 07:24:27 +00:00
Drew Jaynes 875c82f17f Media: Introduce the `enclosure_links` filter, which makes it possible to adjust the list of audio and video enclosure links derived from post content before querying the database.
Props niallkennedy, stevenkword.
Fixes #19890.

Built from https://develop.svn.wordpress.org/trunk@35288


git-svn-id: http://core.svn.wordpress.org/trunk@35254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 07:09:25 +00:00
Drew Jaynes 2eb8672961 Docs: The `MINUTE_IN_SECONDS`, `HOUR_IN_SECONDS`, `DAY_IN_SECONDS`, `WEEK_IN_SECONDS`, `MONTH_IN_SECONDS`, and `YEAR_IN_SECONDS` constants were introduced in 3.5.
See [21996]. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35287


git-svn-id: http://core.svn.wordpress.org/trunk@35253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:59:29 +00:00
Drew Jaynes 02c9aeaef3 Filesystem: Introduce constants to allow for easier expression of file sizes and other data amounts.
Adds:
* `KB_IN_BYTES` (kilobytes)
* `MB_IN_BYTES` (megabytes)
* `GB_IN_BYTES` (gigabytes)
* `TB_IN_BYTES` (terabytes)

Props nbachiyski, sudar.
See #22405.

Built from https://develop.svn.wordpress.org/trunk@35286


git-svn-id: http://core.svn.wordpress.org/trunk@35252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:55:25 +00:00
Drew Jaynes 7771205935 Query: Introduce the `content_pagination` filter, which makes it possible to manipulate how post content is split into "pages" in `WP_Query::setup_postdata()`.
The "pages" — or chunks of post content – are determined by splitting based on the presence of `<!-- nextpage -->` tags in the post content.

Props sirzooro, chriscct7.
Fixes #9911.

Built from https://develop.svn.wordpress.org/trunk@35285


git-svn-id: http://core.svn.wordpress.org/trunk@35251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:33:27 +00:00
Scott Taylor afe975d754 Formatting: allow date strings to be passed to `get_gmt_from_date()`, instead of requiring `'Y-m-d H:i:s'`.
Adds unit tests.

Props pbearne.
Fixes #34279.

Built from https://develop.svn.wordpress.org/trunk@35284


git-svn-id: http://core.svn.wordpress.org/trunk@35250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:08:25 +00:00
Scott Taylor f4cc7b3de8 Feeds: add `CEST` to `$timezone` in `SimplePie_Parse_Date`.
Props swissspidy.
Fixes #32749.

Built from https://develop.svn.wordpress.org/trunk@35283


git-svn-id: http://core.svn.wordpress.org/trunk@35249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:57:24 +00:00
Scott Taylor b0561ed6e4 Dashboard: use the `create_posts` cap on the post type object when determining if the Quick Press widget can be displayed.
Props jim912, ocean90, chriscct7.
Fixes #25681.

Built from https://develop.svn.wordpress.org/trunk@35282


git-svn-id: http://core.svn.wordpress.org/trunk@35248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:49:24 +00:00
Scott Taylor f89b90a1c9 Theme Installer: toggle `iframe-ready` on the overlay to control the spinner animated GIF and high CPU usage.
Props afercia, adamsilverstein.
Fixes #33322.

Built from https://develop.svn.wordpress.org/trunk@35281


git-svn-id: http://core.svn.wordpress.org/trunk@35247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:36:25 +00:00
Scott Taylor 85a6189ad8 Users: when calling `wp_insert_user()` with an valid user ID, return `WP_Error` instead of arbitrarily updating user meta.
Adds unit test.

Props swissspidy, bilalcoder.
Fixes #28004.

Built from https://develop.svn.wordpress.org/trunk@35280


git-svn-id: http://core.svn.wordpress.org/trunk@35246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:28:24 +00:00
Scott Taylor 5d63788d9a XML-RPC: after [35095], change the name of the `xmlrpc_memory_limit` filter to `xmlrpc_chunk_parsing_size`.
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35279


git-svn-id: http://core.svn.wordpress.org/trunk@35245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:19:25 +00:00
Scott Taylor c5b6202dfa Widgets: revert [34376] and [34386] as pertains to the Categories widget supporting custom taxonomies.
Punting on 4th down.

See #21165.

Built from https://develop.svn.wordpress.org/trunk@35278


git-svn-id: http://core.svn.wordpress.org/trunk@35244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:57:25 +00:00
Scott Taylor 62d8b8c5bc List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns).
See #31634.

Built from https://develop.svn.wordpress.org/trunk@35277


git-svn-id: http://core.svn.wordpress.org/trunk@35243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:29:24 +00:00
Scott Taylor 89d1eb1e00 Formatting: when making unique filenames in `wp_unique_filename()` by adding an incrementing number, prefix it with a dash to disambiguate from files that end in numbers.
Updates unit tests.

Props mikejolley, tyxla.
Fixes #21453.

Built from https://develop.svn.wordpress.org/trunk@35276


git-svn-id: http://core.svn.wordpress.org/trunk@35242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:05:25 +00:00
Scott Taylor 4f16590e8e Customizer: when available, show the `description` when rendering the `dropdown-pages` Control.
Props downstairsdev, MikeHansenMe, _smartik_.
Fixes #31540.

Built from https://develop.svn.wordpress.org/trunk@35275


git-svn-id: http://core.svn.wordpress.org/trunk@35241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 03:48:26 +00:00
Drew Jaynes a92d4f6fcb Docs: Update the default scheme for `get_rest_url()` from 'json' to 'rest'.
Also adds 'rest' to the documented list of schemes for `home_url()`, `get_home_url()`, `set_url_scheme()`, and the `home_url` and `set_url_scheme` hooks.

Props rachelbaker.
Fixes #34300.

Built from https://develop.svn.wordpress.org/trunk@35274


git-svn-id: http://core.svn.wordpress.org/trunk@35240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:39:25 +00:00
Andrea Fercia e074209a3d Accessibility: Improve the headings hierarchy in the Add Themes screen.
Fixes #33819.
Built from https://develop.svn.wordpress.org/trunk@35273


git-svn-id: http://core.svn.wordpress.org/trunk@35239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:04:25 +00:00
Weston Ruter a89294dc49 Widgets: Modify unit test assertion to be compatible with `widget_nav_menu` option being filtered by plugin to return `ArrayIterator`.
Modifies assertion added in [35100].

See #26876.
See #32474.

Built from https://develop.svn.wordpress.org/trunk@35272


git-svn-id: http://core.svn.wordpress.org/trunk@35238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 21:27:26 +00:00
Drew Jaynes 9f0f213d5e Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35271


git-svn-id: http://core.svn.wordpress.org/trunk@35237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 20:09:26 +00:00
Drew Jaynes d5a15475d2 Tests: Add some more test coverage for `get_term_field()`.
See #33968.

Built from https://develop.svn.wordpress.org/trunk@35270


git-svn-id: http://core.svn.wordpress.org/trunk@35236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 03:29:24 +00:00
Boone Gorges 9cc7660c53 Don't store `data` as a property on `WP_Term` objects.
`wp_ajax_add_term()` fetches a term using `get_term()`, and passes the term to
`WP_Ajax_Response`, which expects each of the term's properties to be scalar.
Having `$data` as a `stdClass` (meant to mimic `WP_User::data`, populated by
a `get_row()` database query) violated this expectation, causing fatal string
conversion errors. As a workaround, `$term->data` is converted so that it is
no longer an actual property of the term object, but is assembled only when
requested in the magic `__get()` method.

Fixes #34348.
Built from https://develop.svn.wordpress.org/trunk@35269


git-svn-id: http://core.svn.wordpress.org/trunk@35235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 03:12:24 +00:00
Boone Gorges 2543ffbbae Bust object term cache in `wp_remove_object_terms()`.
Props tszming.
Fixes #34338.
Built from https://develop.svn.wordpress.org/trunk@35268


git-svn-id: http://core.svn.wordpress.org/trunk@35234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 01:53:24 +00:00
Dion Hulse 85258bb914 In `insert_with_markers()` restore the 4.3 behaviour of creating the file if it doesn't exist.
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.

Props willmot tigertech kevinatelement
See #31767

Built from https://develop.svn.wordpress.org/trunk@35267


git-svn-id: http://core.svn.wordpress.org/trunk@35233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 00:53:24 +00:00
Drew Jaynes fd9bcf111d Docs: Fix a typo in the `$blog_id` parameter name in the `rest_url` filter doc.
Props rachelbaker.
Fixes #34351.

Built from https://develop.svn.wordpress.org/trunk@35266


git-svn-id: http://core.svn.wordpress.org/trunk@35232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 23:12:25 +00:00
Andrea Fercia 579246ab4a Multisite: Improve the Admin Bar parent menu items color on hover and focus.
Props Nikschavan for the initial patch.
Fixes #34040.
Built from https://develop.svn.wordpress.org/trunk@35265


git-svn-id: http://core.svn.wordpress.org/trunk@35231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 16:22:24 +00:00
Drew Jaynes 2e11f8cc16 Taxonomy: Improve deprecated argument strings for the 'link' type in `get_categories()` and `wp_dropdown_categories()`.
Props swissspidy, gagan0123.
Fixes #34318.

Built from https://develop.svn.wordpress.org/trunk@35264


git-svn-id: http://core.svn.wordpress.org/trunk@35230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 15:35:24 +00:00
Drew Jaynes b37bb95aad Administration: Introduce the `manage_posts_extra_tablenav` action, which fires inside the tablenav for the posts list table, and just outside the "actions" container.
Props hlashbrooke, wonderboymusic.
Fixes #30341.

Built from https://develop.svn.wordpress.org/trunk@35263


git-svn-id: http://core.svn.wordpress.org/trunk@35229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:56:23 +00:00
Drew Jaynes 0aaa2900eb Docs: Add a version to the file header for wp-admin/includes/comment.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35262


git-svn-id: http://core.svn.wordpress.org/trunk@35228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:34:25 +00:00
Ella Iseulde Van Dorpe 9845e08340 TinyMCE: Drag and drop link with image
Make sure images don't loose their link after drag and drop.

Fixes #28272.

Built from https://develop.svn.wordpress.org/trunk@35261


git-svn-id: http://core.svn.wordpress.org/trunk@35227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 11:05:23 +00:00
John Blackbourn 532e1fb856 Some cleanup that was missed in [35259].
See #33728, #24853

Built from https://develop.svn.wordpress.org/trunk@35260


git-svn-id: http://core.svn.wordpress.org/trunk@35226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 06:26:24 +00:00
John Blackbourn 46a191dfcc Some rewrite endpoint tests in preparation for new endpoint masks. More to come.
See #33728, #24853

Built from https://develop.svn.wordpress.org/trunk@35259


git-svn-id: http://core.svn.wordpress.org/trunk@35225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 06:24:24 +00:00
John Blackbourn 9564ccf373 Preserve the public and private query var properties on the global `WP` instance when using `WP_UnitTestCase::go_to()`. These properties apply to the application state, not the current request.
See #34346

Built from https://develop.svn.wordpress.org/trunk@35258


git-svn-id: http://core.svn.wordpress.org/trunk@35224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 05:01:24 +00:00
John Blackbourn 53f5767ee1 Add `is_embed()` to `WP_UnitTestCase::assertQueryTrue()` and update the relevant embed tests.
See #32522

Built from https://develop.svn.wordpress.org/trunk@35257


git-svn-id: http://core.svn.wordpress.org/trunk@35223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 04:51:25 +00:00
John Blackbourn c01a64ad31 Move the `test_is_home_should_be_false_when_visiting_custom_endpoint_without_a_registered_query_var_and_page_on_front_is_set()` test into a more appropriate place.
See #25143

Built from https://develop.svn.wordpress.org/trunk@35256


git-svn-id: http://core.svn.wordpress.org/trunk@35222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 01:35:24 +00:00
John Blackbourn 0b845bed03 Correct a test after r35253.
See #34272

Built from https://develop.svn.wordpress.org/trunk@35255


git-svn-id: http://core.svn.wordpress.org/trunk@35221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 00:56:24 +00:00
John Blackbourn 9da3b964fc Remove an IDE-specific rule in `.gitignore`. These should be managed in the user's `~/.gitignore_global` file.
Fixes #34345

Built from https://develop.svn.wordpress.org/trunk@35254


git-svn-id: http://core.svn.wordpress.org/trunk@35220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 00:16:24 +00:00
Sergey Biryukov d76d340036 Embeds: After [35235], replace some missed `oembed` references with `embed`.
Props peterwilsoncc.
Fixes #34272.
Built from https://develop.svn.wordpress.org/trunk@35253


git-svn-id: http://core.svn.wordpress.org/trunk@35219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 23:26:47 +00:00
John Blackbourn 5576cd3978 Introduce `map_deep()`, a utility function that recursively maps a callable function to every item in an array or object. Works like `array_walk_recursive()` but works with objects too.
Updates `rawurlencode_deep()`, `urlencode_deep()`, and `stripslashes_deep()` to use `map_deep()`. Introduces `urldecode_deep()` for completeness.

Props wpmuguru, nbachiyski, boonebgorges, MikeHansenMe, chriscct7, realloc, johnbillion
Fixes #22300

Built from https://develop.svn.wordpress.org/trunk@35252


git-svn-id: http://core.svn.wordpress.org/trunk@35218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 23:26:24 +00:00
Weston Ruter f676fdcee3 Customizer: Fix `margin-top` calculation for Themes section.
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].

See #33567.


Built from https://develop.svn.wordpress.org/trunk@35251


git-svn-id: http://core.svn.wordpress.org/trunk@35217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:41:25 +00:00
Scott Taylor 443ce28304 Media: in `wp_get_attachment_image_sizes()`, ensure that `$img_width` exists when the image does not.
Props kraftbj.
See #33641.


Built from https://develop.svn.wordpress.org/trunk@35250


git-svn-id: http://core.svn.wordpress.org/trunk@35216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:12:24 +00:00
Scott Taylor c7b0db99a6 Unit Tests: better fixtures for `Tests_Meta_Slashes` and `Tests_WP_Customize_Section`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35249


git-svn-id: http://core.svn.wordpress.org/trunk@35215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:29:24 +00:00
Scott Taylor 11d1e8af8b Unit Tests: better fixtures for `Tests_User_WpSetCurrentUser`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35248


git-svn-id: http://core.svn.wordpress.org/trunk@35214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:19:24 +00:00
Scott Taylor 32bb609d88 Unit Tests: better fixtures for `Tests_User`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35247


git-svn-id: http://core.svn.wordpress.org/trunk@35213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:15:25 +00:00
Scott Taylor a9134691d4 Unit Tests: better fixtures for `Tests_AdminBar`. Don't force-delete some posts: some filter callbacks are no-ops on Multisite if the post is vanquished.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35246


git-svn-id: http://core.svn.wordpress.org/trunk@35212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 20:49:24 +00:00
Scott Taylor 4204afdd40 Unit Tests: better fixtures for `Tests_Admin_Includes_Post`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35245


git-svn-id: http://core.svn.wordpress.org/trunk@35211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 19:48:23 +00:00
Scott Taylor d54f567862 Unit Tests: `WP_UnitTest_Generator_Sequence` needs a static incrementer - otherwise, it assumes every test class is a reset, which it no longer is (it is now static).
While we're at it, remove unnecessary `tearDown()` code.

See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35244


git-svn-id: http://core.svn.wordpress.org/trunk@35210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 19:25:24 +00:00
Scott Taylor 7d7c85b83d Unit Tests: after [35242], declare some missing instance props on individual test classes.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35243


git-svn-id: http://core.svn.wordpress.org/trunk@35209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 18:30:24 +00:00
Scott Taylor 7f8dca02b7 Unit Tests: after [35225], make `factory` a method/getter on `WP_UnitTestCase` and add magic methods for BC for every plugin that is extending `WP_UnitTestCase` and accessing the `$factory` instance prop.
Props nerrad, wonderboymusic.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35242


git-svn-id: http://core.svn.wordpress.org/trunk@35208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 18:03:25 +00:00
Drew Jaynes 8a386cb24f Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35241


git-svn-id: http://core.svn.wordpress.org/trunk@35207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 15:13:25 +00:00
Drew Jaynes 767d091c74 Docs: Improve the hook doc for the `get_post_status` filter, introduced in [35233].
Also adds a missing parameter description for `$post`.

See #23458. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35240


git-svn-id: http://core.svn.wordpress.org/trunk@35206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 14:24:25 +00:00
Ella Iseulde Van Dorpe 08f71faac3 JSHint after [35238]
Built from https://develop.svn.wordpress.org/trunk@35239


git-svn-id: http://core.svn.wordpress.org/trunk@35205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:11:24 +00:00
Ella Iseulde Van Dorpe 47e364de42 Admin: fix repositioning notices
Fixes #34294.
Props afercia.

Built from https://develop.svn.wordpress.org/trunk@35238


git-svn-id: http://core.svn.wordpress.org/trunk@35204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:04:26 +00:00
Drew Jaynes 10d94ea673 Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35237


git-svn-id: http://core.svn.wordpress.org/trunk@35203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 06:07:24 +00:00
Weston Ruter c7a951194d Customizer: Add unit test for `WP_Customize_Widgets::is_panel_active()`.
See #33052.

Built from https://develop.svn.wordpress.org/trunk@35236


git-svn-id: http://core.svn.wordpress.org/trunk@35202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 04:44:25 +00:00
Sergey Biryukov a908d2d4b1 Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't.
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.

Props swissspidy.
Fixes #34272.
Built from https://develop.svn.wordpress.org/trunk@35235


git-svn-id: http://core.svn.wordpress.org/trunk@35201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 01:21:25 +00:00
Sergey Biryukov 1157540283 Replace Quick Edit and Bulk Edit headings with `<legend>` elements.
Props afercia.
Fixes #34289.
Built from https://develop.svn.wordpress.org/trunk@35234


git-svn-id: http://core.svn.wordpress.org/trunk@35200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:45:25 +00:00
Aaron Jorbin b778726e74 Improve `get_post_permalink` compatibility with non standard post status
This adds a new filter named `get_post_status` to the function named `get_post_status` which can be used to make additional post types behave like unpublished post status in `get_post_permalink`.

Props misterbisson, antpb, iamfriendly
Fixes #23458


Built from https://develop.svn.wordpress.org/trunk@35233


git-svn-id: http://core.svn.wordpress.org/trunk@35199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:44:26 +00:00
Sergey Biryukov 7c2919c02b Merge two strings for expanding accordion and Customizer sections.
Props pavelevap.
Fixes #33939.
Built from https://develop.svn.wordpress.org/trunk@35232


git-svn-id: http://core.svn.wordpress.org/trunk@35198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:28:25 +00:00
Weston Ruter 6bcd8ad757 Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
Widgets panel will not wait to display until the preview loads.

Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.

Fixes #33052.
Fixes #33567.

Built from https://develop.svn.wordpress.org/trunk@35231


git-svn-id: http://core.svn.wordpress.org/trunk@35197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:48:25 +00:00
Sergey Biryukov 5c8522c022 Merge two warning strings.
Props pavelevap.
Fixes #29740.
Built from https://develop.svn.wordpress.org/trunk@35230


git-svn-id: http://core.svn.wordpress.org/trunk@35196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:31:25 +00:00
Sergey Biryukov f98136c1b5 Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
Props afercia.
Fixes #34255.
Built from https://develop.svn.wordpress.org/trunk@35229


git-svn-id: http://core.svn.wordpress.org/trunk@35195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:02:25 +00:00
Sergey Biryukov ac630ba233 Embeds: In `print_oembed_embed_styles()`, load non-minified file if `SCRIPT_DEBUG` is true.
This is consistent with `print_oembed_embed_scripts()`.

Props MikeHansenMe.
Fixes #34321.
Built from https://develop.svn.wordpress.org/trunk@35228


git-svn-id: http://core.svn.wordpress.org/trunk@35194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 22:43:24 +00:00
Boone Gorges 4430e5dbbb Return `null` from `get_term()` on taxonomy mismatch.
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.

Props dlh.
See #14162. Fixes #34332.
Built from https://develop.svn.wordpress.org/trunk@35227


git-svn-id: http://core.svn.wordpress.org/trunk@35193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:42:25 +00:00
Scott Taylor efb224e831 Unit Tests: PHP 5.2, I Hate You and You Are Bringing Me Down.
#YOLOFriday

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35226


git-svn-id: http://core.svn.wordpress.org/trunk@35192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:15:25 +00:00
Scott Taylor a2a65a06bd Unit Tests: one `$factory` to rule them all, and it shall be `static`.
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday


Built from https://develop.svn.wordpress.org/trunk@35225


git-svn-id: http://core.svn.wordpress.org/trunk@35191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:05:25 +00:00
Scott Taylor 3693228a9b Unit Tests: since [32953], we can just use `self::delete_user()` instead of using `if` logic for Multisite.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35224


git-svn-id: http://core.svn.wordpress.org/trunk@35190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 19:52:27 +00:00
Sergey Biryukov 7fdbebdd7d In `WP_Posts_List_Table`, correct the type for `$comment_pending_count`.
See #11381.
Built from https://develop.svn.wordpress.org/trunk@35223


git-svn-id: http://core.svn.wordpress.org/trunk@35189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:25:25 +00:00
Sergey Biryukov dcf23c5e2a In `WP_Media_List_Table`, rename `$pending_count` to `$comment_pending_count` and mark it as protected, for consistency with `WP_Posts_List_Table`.
See #11381.
Built from https://develop.svn.wordpress.org/trunk@35222


git-svn-id: http://core.svn.wordpress.org/trunk@35188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:23:27 +00:00
Drew Jaynes 1cb39b180f Docs: Standardize the file header summary for wp-admin/includes/file.php.
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.

Built from https://develop.svn.wordpress.org/trunk@35221


git-svn-id: http://core.svn.wordpress.org/trunk@35187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 16:56:26 +00:00
Andrea Fercia dc0e7e1a79 Accessibility: Improve headings hierarchy in the Theme browser modal dialog.
Fixes #34288.
Built from https://develop.svn.wordpress.org/trunk@35220


git-svn-id: http://core.svn.wordpress.org/trunk@35186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:56:25 +00:00
Andrea Fercia 7f4a0ebbf3 Bump H4 headings to H2 in the Updates screen for better accessibility.
Fixes #34265.
Built from https://develop.svn.wordpress.org/trunk@35219


git-svn-id: http://core.svn.wordpress.org/trunk@35185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:45:28 +00:00
Dominik Schilling 0df9abe092 Travis CI: Use a pinned version of the object cache drop-in.
Props tollmanz.
See #31491.
Built from https://develop.svn.wordpress.org/trunk@35218


git-svn-id: http://core.svn.wordpress.org/trunk@35184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 14:16:28 +00:00
Ella Iseulde Van Dorpe bafdd96ebf TinyMCE: add lang attribute
This is needed to make `hyphens: auto;` work correctly.

Fixes #32555.

Built from https://develop.svn.wordpress.org/trunk@35217


git-svn-id: http://core.svn.wordpress.org/trunk@35183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 10:11:27 +00:00
Ella Iseulde Van Dorpe ef01315cac TinyMCE: make sure markers are removed after first init
This is only relevant to non embeddable URLs.
After first init, markers were set but not removed,
causing an edited URL to revert when switching to text mode
or any paragraph after the URL to just contain that URL.

Fixes #33954.

Built from https://develop.svn.wordpress.org/trunk@35216


git-svn-id: http://core.svn.wordpress.org/trunk@35182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 05:43:26 +00:00
Helen Hou-Sandí fc02ca2d01 Account for icon alignment using text-indent in RTL.
fixes #33808.

Built from https://develop.svn.wordpress.org/trunk@35215


git-svn-id: http://core.svn.wordpress.org/trunk@35181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 00:58:25 +00:00
Scott Taylor 438c2462e1 Unit Tests: add `SpeedTrapListener` to `phpunit/includes` and add the config node to `phpunit.xml.dist`.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35214


git-svn-id: http://core.svn.wordpress.org/trunk@35180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 00:28:23 +00:00
Dominik Schilling dd753ef3ad Travis: Extend our test suite with a memcached instance.
To test persistent object caching Travis CI runs now a build on PHP 5.6 with memached enabled. The build uses the drop-in from https://github.com/tollmanz/wordpress-pecl-memcached-object-cache which is based on the PECL memcached extension.

Props pento, ocean90.
Fixes #31491.
Built from https://develop.svn.wordpress.org/trunk@35213


git-svn-id: http://core.svn.wordpress.org/trunk@35179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 22:52:25 +00:00
Dominik Schilling 22874716dd Multisite: Remove the strictness for `$using_paths` in `WP_Network::get_by_path()`.
The network lookup was broken when using an external object cache because `$using_paths` isn't always a boolean. Added in [34099].

See #31985, #31491.
Built from https://develop.svn.wordpress.org/trunk@35212


git-svn-id: http://core.svn.wordpress.org/trunk@35178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 22:07:24 +00:00
Dominik Schilling 272ff97709 Tests: Remove the `@runTestsInSeparateProcesses` annotation for Ajax tests.
They were added 3 years ago in [846/tests] because tests weren't excluded from the normal runs.

Reverts [35209] because it doesn't work with Xdebug.
`Tests_Ajax_Response::test_response_charset_in_header` is the only test which needs to run in a separate process, see [975/tests].

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35211


git-svn-id: http://core.svn.wordpress.org/trunk@35177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 21:31:24 +00:00
Drew Jaynes d4711aff8a Docs: Fix a typo in an inline comment in `wp_get_attachment_image_srcset_array()`.
Props neoxx.
Fixes #34319.

Built from https://develop.svn.wordpress.org/trunk@35210


git-svn-id: http://core.svn.wordpress.org/trunk@35176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 20:52:24 +00:00
Dominik Schilling bcdad0aa12 Tests: Don't preserve the global state for Ajax tests when using an external object cache.
Most of the Ajax tests are running in a separate PHP process, and thus PHPUnit attempts to preserve the global state from the parent process by serializing all globals. But this doesn't work for external object caches so we have to disable this "feature".

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35209


git-svn-id: http://core.svn.wordpress.org/trunk@35175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 20:35:23 +00:00
Aaron Jorbin 41b21cf23b Add Twenty Sixteen to travis builds
This allows the automated tests to include Twenty Sixteen.

Fixes #34315. See #34306.


Built from https://develop.svn.wordpress.org/trunk@35208


git-svn-id: http://core.svn.wordpress.org/trunk@35174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 19:06:25 +00:00
Helen Hou-Sandí 7aabfdaca4 Circular focus styling for widgets and menus in the customizer.
see #33808.

Built from https://develop.svn.wordpress.org/trunk@35207


git-svn-id: http://core.svn.wordpress.org/trunk@35173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 18:53:25 +00:00
Boone Gorges 76a89d95c3 Fix incorrect variable name introduced in [35197].
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35206


git-svn-id: http://core.svn.wordpress.org/trunk@35172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 18:48:24 +00:00
Sergey Biryukov 2d540d0280 In `WP::parse_request()` and `url_to_postid()`, don't skip objects that have a post status with `'exclude_from_search' => false`, e.g. `inherit`.
This fixes pretty permalinks for attachments, broken in [35195].

Fixes #21970.
Built from https://develop.svn.wordpress.org/trunk@35205


git-svn-id: http://core.svn.wordpress.org/trunk@35171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:53:24 +00:00
Helen Hou-Sandí 395258bcaa Make the database update button primary.
see #23738.

Built from https://develop.svn.wordpress.org/trunk@35204


git-svn-id: http://core.svn.wordpress.org/trunk@35170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:35:24 +00:00
Sergey Biryukov de730d605f Twenty Sixteen: Update `Gruntfile.js` to ignore the html5 shiv for JSHint.
See #34306, #34315.
Built from https://develop.svn.wordpress.org/trunk@35203


git-svn-id: http://core.svn.wordpress.org/trunk@35169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:27:24 +00:00
Drew Jaynes 0905e847ae Docs: `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit` are part of the Navigation Menu API, but intended for use in the scope of administration.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35202


git-svn-id: http://core.svn.wordpress.org/trunk@35168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:26:24 +00:00
Helen Hou-Sandí 12290303a8 Box shadows still need `-webkit-`, turns out.
see #33808, [35200].

Built from https://develop.svn.wordpress.org/trunk@35201


git-svn-id: http://core.svn.wordpress.org/trunk@35167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:09:26 +00:00
Helen Hou-Sandí 50288dea5a Circular focus styling for expand/collapse arrows.
Affects postboxes, widgets, and nav menus, all in the admin.

props grvrulz for the initial patch.
see #33808.

Built from https://develop.svn.wordpress.org/trunk@35200


git-svn-id: http://core.svn.wordpress.org/trunk@35166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 16:47:25 +00:00
Ella Iseulde Van Dorpe 3eb4a57c27 TinyMCE: make captioned images draggable
See #28003.

Built from https://develop.svn.wordpress.org/trunk@35199


git-svn-id: http://core.svn.wordpress.org/trunk@35165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 15:20:25 +00:00
Ella Iseulde Van Dorpe 3babb1682a Fix close button plugin modal after [18590]
See #18590.


Built from https://develop.svn.wordpress.org/trunk@35198


git-svn-id: http://core.svn.wordpress.org/trunk@35164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 14:52:26 +00:00
Scott Taylor 9d4069e5d9 Unit Tests: add/upgrade the fixtures in `Tests_User_Query`.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35197


git-svn-id: http://core.svn.wordpress.org/trunk@35163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 07:29:24 +00:00
Scott Taylor 1603ccad71 Unit Tests: create fewer terms in `Tests_Term_getTerms::test_get_terms_parent_zero()`
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35196


git-svn-id: http://core.svn.wordpress.org/trunk@35162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:53:24 +00:00
Sergey Biryukov 8a6d07f596 In `WP::parse_request()` and `url_to_postid()`, if a post slug clashes with a trashed page, return the post instead of the page.
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970.
Built from https://develop.svn.wordpress.org/trunk@35195


git-svn-id: http://core.svn.wordpress.org/trunk@35161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:49:25 +00:00
Scott Taylor 3bf9aa75a4 Unit Tests: upgrade the fixtures in `Tests_Post_Thumbnail_Template`.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35194


git-svn-id: http://core.svn.wordpress.org/trunk@35160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:40:24 +00:00
Scott Taylor 274d7f5bb0 Unit Tests: upgrade the fixtures in `Tests_Post_Revisions`.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35193


git-svn-id: http://core.svn.wordpress.org/trunk@35159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:32:25 +00:00
Scott Taylor 5b49ff3a48 Unit Tests: in `Tests_Comment_Query::test_get_comments_for_post()`, create fewer comments (5, instead of 10).
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35192


git-svn-id: http://core.svn.wordpress.org/trunk@35158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:57:25 +00:00
Scott Taylor 53ef754260 Unit Tests: after [35186], "upgrade" the Canonical fixtures.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35191


git-svn-id: http://core.svn.wordpress.org/trunk@35157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:51:24 +00:00
Sergey Biryukov 8aa7fb88f0 Remove a one-time variable from `edit_user()` added in [35189].
See #27317.
Built from https://develop.svn.wordpress.org/trunk@35190


git-svn-id: http://core.svn.wordpress.org/trunk@35156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:46:24 +00:00
Sergey Biryukov 7f08716c16 Users: Add `'illegal_user_logins'` filter to allow certain usernames to be blacklisted.
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317.
Built from https://develop.svn.wordpress.org/trunk@35189


git-svn-id: http://core.svn.wordpress.org/trunk@35155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:43:26 +00:00
Scott Taylor b6b2baccbd Unit Tests: create more fixtures for `Tests_User`. When using a factory to create ad hoc users, use the inherited static prop `$static_factory` instead of the instance prop, `$factory`. If 2 factories are used out of sync, the generator sequences diverge and dupes can be created, causing an untold number of unforeseen errors. Yay.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35188


git-svn-id: http://core.svn.wordpress.org/trunk@35154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:30:25 +00:00
Sergey Biryukov 09ee95ea49 Themes: Add Install Parent Theme button for child themes that are missing a parent theme.
Props rabmalin for initial patch.
Fixes #32668.
Built from https://develop.svn.wordpress.org/trunk@35187


git-svn-id: http://core.svn.wordpress.org/trunk@35153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:11:24 +00:00
Scott Taylor 5cebd10ced Unit Tests: implement `setUpBeforeClass()` and `tearDownAfterClass()` on `WP_UnitTestCase`. Use late static binding (plus a gross fallback for PHP 5.2) to check if `wpSetUpBeforeClass()` or `wpTearDownAfterClass()` exist on the called class, and then call it and pass a static `WP_UnitTest_Factory` instance via Dependency Injection, if it exists.
This makes it way easier to add fixtures, and tear them down, without needing to instantiate `WP_UnitTest_Factory` in every class - removes the need to call `commit_transaction()` in each individual class.

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35186


git-svn-id: http://core.svn.wordpress.org/trunk@35152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 04:44:25 +00:00
Scott Taylor e62864ce46 Unit Tests: in `Tests_Term`, create fixtures for posts.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35185


git-svn-id: http://core.svn.wordpress.org/trunk@35151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:48:25 +00:00
Sergey Biryukov e63ba31f93 Acessibility: Add back-compat styles for plugins that use `h3` inside the `.metabox-holder` container.
Props afercia.
Fixes #33557.
Built from https://develop.svn.wordpress.org/trunk@35184


git-svn-id: http://core.svn.wordpress.org/trunk@35150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:38:25 +00:00
Scott Taylor ad90d33285 Unit Tests: in `Tests_Post`, create fixtures for users.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35183


git-svn-id: http://core.svn.wordpress.org/trunk@35149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:31:24 +00:00
Helen Hou-Sandí f3107e5842 Make some primary action buttons look primary.
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.

Built from https://develop.svn.wordpress.org/trunk@35182


git-svn-id: http://core.svn.wordpress.org/trunk@35148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:08:24 +00:00
Scott Taylor 2c46a4dcba Unit Tests: in `Tests_Media::test_wp_get_attachment_image_srcset_array_no_width()`, just toggle metadata, instead of creating a new attachment. Shaves 75ms off the test.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35181


git-svn-id: http://core.svn.wordpress.org/trunk@35147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 02:55:24 +00:00
Sergey Biryukov 6d91caa931 Theme Editor: Repurpose the `'wp_theme_editor_filetypes'` filter added in [35134] to actually filter file types instead of files.
Default types include 'php' and 'css' and cannot be removed, only new types can be added.

Props DrewAPicture, SergeyBiryukov.
Fixes #22924.
Built from https://develop.svn.wordpress.org/trunk@35180


git-svn-id: http://core.svn.wordpress.org/trunk@35146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 02:20:24 +00:00
Scott Taylor 317d62bfad Unit Tests: make a fixture in `Tests_Media` to represent the large image, instead of creating it 10 times.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35179


git-svn-id: http://core.svn.wordpress.org/trunk@35145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:43:24 +00:00
Scott Taylor 60ad26b4fd Unit Tests: move some oEmbed tests that can trigger HTTP calls to `Tests_External_HTTP_OEmbed`.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35178


git-svn-id: http://core.svn.wordpress.org/trunk@35144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:29:24 +00:00
Scott Taylor f19e4c9b46 Unit Tests: `Tests_Canonical` doesn't need to call `wp_set_current_user()` or implement `tearDown` because its grandparent calls `wp_set_current_user( 0 )` in `tearDown()`.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35177


git-svn-id: http://core.svn.wordpress.org/trunk@35143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:18:24 +00:00
Scott Taylor 972e76991f Unit Tests: `Tests_Comment` needs a `tearDownAfterClass` impl to avoid spillage.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35176


git-svn-id: http://core.svn.wordpress.org/trunk@35142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:06:24 +00:00
Scott Taylor 083537d213 Unit Tests: `Tests_Auth` needs a `tearDownAfterClass` impl to avoid spillage.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35175


git-svn-id: http://core.svn.wordpress.org/trunk@35141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:04:24 +00:00
Scott Taylor b7e9b93be3 Unit Tests: call `commit_transaction()` in `Tests_Auth` set up.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35174


git-svn-id: http://core.svn.wordpress.org/trunk@35140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:49:24 +00:00
Scott Taylor b1a39f1a6a Unit Tests: reuse fixtures in `Tests_Comment`.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35173


git-svn-id: http://core.svn.wordpress.org/trunk@35139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:39:23 +00:00
Scott Taylor e9db7c15fd Unit Tests: move `->test_readme()` out of `Tests_Basic` and into `Tests_External_HTTP_Basic` in `tests/external-http/`.
I intend to move other `wp_remote_get()` tests into similar classes.

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35172


git-svn-id: http://core.svn.wordpress.org/trunk@35138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:23:24 +00:00
Scott Taylor 351d78fbac Unit Tests: wrestle performance out of `Tests_Auth` by cloning the same user for a majority of the tests.
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35171


git-svn-id: http://core.svn.wordpress.org/trunk@35137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:11:24 +00:00
Drew Jaynes 217b661703 Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35170


git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:44:25 +00:00
Drew Jaynes 43c10f7d35 Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php.
Also adds some missing parameter, return, and global descriptions, and one missing summary.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35169


git-svn-id: http://core.svn.wordpress.org/trunk@35135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:25:25 +00:00
Drew Jaynes c78ee60edd Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php.
See #33701.

[ci skip]

Built from https://develop.svn.wordpress.org/trunk@35168


git-svn-id: http://core.svn.wordpress.org/trunk@35134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:49:24 +00:00
Drew Jaynes c3ee28ea06 Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35167


git-svn-id: http://core.svn.wordpress.org/trunk@35133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:35:24 +00:00
Drew Jaynes 2e2e898802 Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35166


git-svn-id: http://core.svn.wordpress.org/trunk@35132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:32:24 +00:00
Boone Gorges a53fe085aa Fix incorrect variable names from [35164].
Cool story - the tests appeared to pass with the typos.

See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35165


git-svn-id: http://core.svn.wordpress.org/trunk@35131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:00:26 +00:00
Boone Gorges ba37dc9123 Share fixtures in `Tests_Admin_includesListTable` tests.
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35164


git-svn-id: http://core.svn.wordpress.org/trunk@35130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 21:41:24 +00:00
Boone Gorges cb8a2f2e47 Share fixtures in `Tests_Get_Archives`.
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35163


git-svn-id: http://core.svn.wordpress.org/trunk@35129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 21:30:25 +00:00
Boone Gorges 530111994d Create fewer fixtures in some tests.
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35162


git-svn-id: http://core.svn.wordpress.org/trunk@35128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 21:24:24 +00:00
Helen Hou-Sandí 6820130e33 Screen options: Improve the "Apply" button
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.

Built from https://develop.svn.wordpress.org/trunk@35161


git-svn-id: http://core.svn.wordpress.org/trunk@35127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 18:58:25 +00:00
Andrea Fercia f1787056de Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility.
Fixes #34286.
Built from https://develop.svn.wordpress.org/trunk@35160


git-svn-id: http://core.svn.wordpress.org/trunk@35126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:44:24 +00:00
Jeremy Felt 9dd1462fe3 MS: Introduce action `before_signup_header`.
This aligns `wp-signup.php` a bit more `with `wp-activate.php` and, among other things, allows a plugin to redirect signup requests.

Props pbearne.
Fixes #17630.

Built from https://develop.svn.wordpress.org/trunk@35159


git-svn-id: http://core.svn.wordpress.org/trunk@35125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:32:49 +00:00
Andrea Fercia c4ff6317a7 Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility.
Fixes #34285.
Built from https://develop.svn.wordpress.org/trunk@35158


git-svn-id: http://core.svn.wordpress.org/trunk@35124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:32:24 +00:00
Drew Jaynes d01f1c2e15 Docs: Add missing file headers to two Toolbar API files: wp-includes/admin-bar.php and wp-includes/class-wp-admin-bar.php.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35157


git-svn-id: http://core.svn.wordpress.org/trunk@35123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:27:25 +00:00
Jeremy Felt b9b7592ee8 MS: Add "Settings" link under "Network Admin" toolbar menu.
Props johnjamesjacoby.
Fixes #34287.

Built from https://develop.svn.wordpress.org/trunk@35156


git-svn-id: http://core.svn.wordpress.org/trunk@35122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:00:26 +00:00
Andrea Fercia 19eb905f58 Accessibility: update a jQuery selector used for the Plugin Cards after [35009].
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.

Fixes #33818.
Built from https://develop.svn.wordpress.org/trunk@35155


git-svn-id: http://core.svn.wordpress.org/trunk@35121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 15:27:27 +00:00
Boone Gorges fde30ae8b7 Create fewer fixtures in XML-RPC `getComments` tests.
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35154


git-svn-id: http://core.svn.wordpress.org/trunk@35120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 14:39:27 +00:00
John Blackbourn a5cca9c5ff Reinstate the Link Category admin screen after [34359].
See [13216]

Fixes #34284

Built from https://develop.svn.wordpress.org/trunk@35153


git-svn-id: http://core.svn.wordpress.org/trunk@35119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 01:51:26 +00:00
John Blackbourn 8dd677a09f Introduce a language chooser to the site signup process on Multisite.
If your Multisite installation is one of the relatively few that allows new sites to be registered, either by existing users or by new visitors to your site, a 'Site Language' dropdown menu will now be presented if your network has additional languages installed. This option defaults to the value of the 'Default Language' setting on the Network Admin Settings screen, and is restricted to currently installed languages.

The languages available in this setting can be controlled via the `signup_get_available_languages` filter. To disable it completely, return an empty array.

Fixes #33844
Props DrewAPicture, johnbillion

Built from https://develop.svn.wordpress.org/trunk@35152


git-svn-id: http://core.svn.wordpress.org/trunk@35118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 23:46:25 +00:00
John Blackbourn 87aa982824 Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite.
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.

This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.

Fixes #20104

Built from https://develop.svn.wordpress.org/trunk@35151


git-svn-id: http://core.svn.wordpress.org/trunk@35117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 22:12:25 +00:00
Sergey Biryukov 31b40bdbb7 Remove `fast_finish: true` from Travis CI configuration for now.
Upstream: https://github.com/travis-ci/travis-ci/issues/4928
Built from https://develop.svn.wordpress.org/trunk@35150


git-svn-id: http://core.svn.wordpress.org/trunk@35116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 21:36:24 +00:00
John Blackbourn 537ac4c2ec Improve the docs for the `$expiration` parameter in `set_transient()`, `set_site_transient()`, and associated filters.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35149


git-svn-id: http://core.svn.wordpress.org/trunk@35115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 21:31:25 +00:00
Dominik Schilling a2a4bdcb9d Improve [35146] to only skip pluggable function signature tests for `wp-includes/cache.php` when an external object cache is in use.
See #31491, #33867.
Built from https://develop.svn.wordpress.org/trunk@35148


git-svn-id: http://core.svn.wordpress.org/trunk@35114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 20:45:24 +00:00
John Blackbourn a9f9cca311 Reinstate `wp_cache_get()` into the pluggable function tests. The signature tests are now skipped if an external object cache is in use.
See #31491

Built from https://develop.svn.wordpress.org/trunk@35147


git-svn-id: http://core.svn.wordpress.org/trunk@35113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 19:33:24 +00:00
John Blackbourn 74167bc09a Skip the pluggable function signature tests when an external object cache is in use.
See #31491

Built from https://develop.svn.wordpress.org/trunk@35146


git-svn-id: http://core.svn.wordpress.org/trunk@35112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 19:31:25 +00:00
John Blackbourn a13e405b4c Remove `wp_cache_reset()` from the pluggable functions signature tests, as the function is deprecated and no longer used.
See #31491, #33867

Built from https://develop.svn.wordpress.org/trunk@35145


git-svn-id: http://core.svn.wordpress.org/trunk@35111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 19:20:25 +00:00
Drew Jaynes 57e69d4a3f Upgrader: Introduce a new action hook `pre_auto_update`, which fires immediately prior to an auto-update for core, themes, plugins, or translations.
Props DavidAnderson, welcher.
Fixes #30441.

Built from https://develop.svn.wordpress.org/trunk@35144


git-svn-id: http://core.svn.wordpress.org/trunk@35110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 18:58:25 +00:00
Sergey Biryukov 4ef12c7814 Correct the error message displayed on setup when `wp-config-sample.php` does not exist.
Props bradparbs.
Fixes #23247.
Built from https://develop.svn.wordpress.org/trunk@35143


git-svn-id: http://core.svn.wordpress.org/trunk@35109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 17:36:25 +00:00
Drew Jaynes a0bbd154d9 Multisite: Improve two error strings specifying allowed characters in usernames and site names.
Also removes two error strings that were likely never being triggered anyway due to the stricter character matching higher up.

Props atomicjack, bjornjohansen, DrewAPicture.
Fixes #33336.

Built from https://develop.svn.wordpress.org/trunk@35142


git-svn-id: http://core.svn.wordpress.org/trunk@35108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 17:33:24 +00:00
Scott Taylor 55e16aa98a KSES: have you ever heard of the `<bdo>` HTML tag? Same. http://www.w3schools.com/tags/tag_bdo.asp
Adds unit test.

Props iandunn.
Fixes #34063.

Built from https://develop.svn.wordpress.org/trunk@35141


git-svn-id: http://core.svn.wordpress.org/trunk@35106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 17:18:25 +00:00
Scott Taylor 296671abcc Taxonomy: in `wp_list_categories()`, add an arg: `separator`, to allow the overriding of `<br/>`.
Props wojtek.szkutnik.
Fixes #9025.

Built from https://develop.svn.wordpress.org/trunk@35140


git-svn-id: http://core.svn.wordpress.org/trunk@35105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 17:02:25 +00:00
Scott Taylor 45a0c26091 Taxonomy: `get_terms_to_edit()` can also return `false` or `WP_Error`. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations.
Props valendesigns.
Fixes #30472.

Built from https://develop.svn.wordpress.org/trunk@35139


git-svn-id: http://core.svn.wordpress.org/trunk@35104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 16:40:26 +00:00
Drew Jaynes dc92982950 Users: Restore changes from [35114] accidentally reverted in [35135].
See #28631.

Built from https://develop.svn.wordpress.org/trunk@35138


git-svn-id: http://core.svn.wordpress.org/trunk@35103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:45:25 +00:00
Boone Gorges b36cc4deab Create fewer fixtures in some XML-RPC tests.
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35137


git-svn-id: http://core.svn.wordpress.org/trunk@35102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:32:25 +00:00
Boone Gorges f240b3398f In `WP_UnitTestCase`, only flush rewrite rules when they're set.
See [34810]. See #33968.
Built from https://develop.svn.wordpress.org/trunk@35136


git-svn-id: http://core.svn.wordpress.org/trunk@35101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:22:24 +00:00
Drew Jaynes cdd8891631 Docs: Add a changelog entry mentioning that the `number` argument now supports -1 (all).
Also fixes the argument description.

-1 support was added in [35114].

See #28631.

Built from https://develop.svn.wordpress.org/trunk@35135


git-svn-id: http://core.svn.wordpress.org/trunk@35100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:16:24 +00:00
Scott Taylor 7c88e86bf6 Theme Editor: add a filter, `wp_theme_editor_filetypes`, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (`.less`, `.scss`) you would like.
Props MikeHansenMe, pross.
Fixes #22924.

Built from https://develop.svn.wordpress.org/trunk@35134


git-svn-id: http://core.svn.wordpress.org/trunk@35099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 14:14:24 +00:00
Scott Taylor 357b916211 Theme Installer: fix the theme "Install"/"Installed" button's vertical alignment for HiDPI displays.
Props paulwilde.
Fixes #34198.

Built from https://develop.svn.wordpress.org/trunk@35133


git-svn-id: http://core.svn.wordpress.org/trunk@35098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 13:52:27 +00:00
Sergey Biryukov e19cda5c2d Toolbar: Improve padding of toolbar submenu items on small screens.
Props tillkruess.
Fixes #28608.
Built from https://develop.svn.wordpress.org/trunk@35132


git-svn-id: http://core.svn.wordpress.org/trunk@35097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:40:25 +00:00
Sergey Biryukov be10375eb6 Accessibility: Add back-compat styles for plugins that still use `h2` as a main heading in their screens.
Props afercia.
Fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@35131


git-svn-id: http://core.svn.wordpress.org/trunk@35096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:17:24 +00:00
Sergey Biryukov 1c9ea9bb4a Accessibility: Correct the style for Popular Tags header on Edit Tags screen after [33917].
Props afercia.
See #33559. See #33658.
Built from https://develop.svn.wordpress.org/trunk@35130


git-svn-id: http://core.svn.wordpress.org/trunk@35095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:14:25 +00:00
Sergey Biryukov 7ebbe03a1f Acessibility: "Add New Category" links on Edit Post screen should not be a header.
Props afercia.
Fixes #33557.
Built from https://develop.svn.wordpress.org/trunk@35129


git-svn-id: http://core.svn.wordpress.org/trunk@35094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:00:25 +00:00
Sergey Biryukov 1c5d327676 Accessibility: bump headings one level up in post meta boxes for a better headings hierarchy.
Props afercia, joedolson, wonderboymusic.
See #33557.
Built from https://develop.svn.wordpress.org/trunk@35128


git-svn-id: http://core.svn.wordpress.org/trunk@35093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:57:24 +00:00
Sergey Biryukov 3cd956f9bb Add the CSS changes missed in [35126].
Props afercia.
See #34263.
Built from https://develop.svn.wordpress.org/trunk@35127


git-svn-id: http://core.svn.wordpress.org/trunk@35092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:51:24 +00:00
Sergey Biryukov 8688df4306 Accessibility: bump headings one level up on Credits screen for a better headings hierarchy.
Props afercia.
Fixes #34263.
Built from https://develop.svn.wordpress.org/trunk@35126


git-svn-id: http://core.svn.wordpress.org/trunk@35091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:49:26 +00:00
Scott Taylor 596431bd21 Admin Bar: fix the alignment of secondary menu item arrows.
Props juhise.
Fixes #33836.

Built from https://develop.svn.wordpress.org/trunk@35125


git-svn-id: http://core.svn.wordpress.org/trunk@35090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:54:24 +00:00
Scott Taylor 06594694e6 After [35122], update `test_wp_unique_filename()` to reflect the change.
See #16226.

Built from https://develop.svn.wordpress.org/trunk@35124


git-svn-id: http://core.svn.wordpress.org/trunk@35089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:42:25 +00:00
Boone Gorges 8de6b7aa8e Correct expected counts in `WP_User_Query` 'number' test.
The `create_many()` number should be padded by just one, to account for the
user created by the test suite. Introduced in [35114].

We also don't have to create so many fixtures to run this test.

See #28631.
Built from https://develop.svn.wordpress.org/trunk@35123


git-svn-id: http://core.svn.wordpress.org/trunk@35088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:26:23 +00:00
Scott Taylor d8e20fa273 Fotmatting: in `sanitize_file_name()`, escape `%` when uploads contain them, otherwise attachment URLs will unescape the char and break.
Adds unit tests.

Props mordauk, simonwheatley, dd32, solarissmoke.
Fixes #16226.

Built from https://develop.svn.wordpress.org/trunk@35122


git-svn-id: http://core.svn.wordpress.org/trunk@35087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:22:24 +00:00
Sergey Biryukov ae0f01904f Feeds: Remove a confusing comment from `add_feed()`, added in [3638].
It always overrides the default callback if it's set, regardless of the `in_array()` check.

See #34259.
Built from https://develop.svn.wordpress.org/trunk@35121


git-svn-id: http://core.svn.wordpress.org/trunk@35086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:14:25 +00:00
Boone Gorges cd563fd404 Use a more reliable method for generating `get_terms()` cache key.
Previously, the cache key included a serialization of `list_terms_exclusions`
callbacks, to ensure that the cache was differentiated properly for different
uses of the `list_terms_exclusions` filter. This strategy was flawed in a
couple of ways: serialization doesn't work equally well for all callable types;
the serialization required reaching into the `$wp_filter` global; serializing
the callback itself didn't properly account for the possibility that the
callback might return different values in different contexts; the cache key
didn't account for other filters that similarly affect the cached values, such
as `terms_clauses`.

We skirt all these issues by concatenating the cache key using the SQL query
string, which will reflect all filters applied earlier in `get_terms()`.

Props boonebgorges, wonderboymusic.
Fixes #21267.
Built from https://develop.svn.wordpress.org/trunk@35120


git-svn-id: http://core.svn.wordpress.org/trunk@35085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:07:24 +00:00
Sergey Biryukov bac64cc984 Docs: Describe the `$feedname` argument of `add_feed()`.
Fixes #34259.
Built from https://develop.svn.wordpress.org/trunk@35119


git-svn-id: http://core.svn.wordpress.org/trunk@35084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:01:25 +00:00
Sergey Biryukov ae9ce0ccd7 Feeds: Pass the second parameter of `"do_feed_{$feed}"` action, feed name, to callbacks added via `add_feed()`.
The `$feed` parameter was added in [35115].

Props slimndap.
See #34259.
Built from https://develop.svn.wordpress.org/trunk@35118


git-svn-id: http://core.svn.wordpress.org/trunk@35083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:59:24 +00:00
Boone Gorges 7de3499949 In `get_terms()`, don't store `WP_Term` objects in cache.
Fixes #34282.
Built from https://develop.svn.wordpress.org/trunk@35117


git-svn-id: http://core.svn.wordpress.org/trunk@35082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:58:24 +00:00
Scott Taylor fc842e33c9 Users: when passing a `WP_User` instance to `wp_update_user()`, ensure that the user password is not accidentally double-hashed. This is terrifying.
Adds unit tests.

Props tbcorr, salcode.
Fixes #28435.

Built from https://develop.svn.wordpress.org/trunk@35116


git-svn-id: http://core.svn.wordpress.org/trunk@35081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:48:24 +00:00