Scott Taylor
fcbc7b5a78
In `Custom_Image_Header->step_2()`, `$type` is set internally but never used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30136
git-svn-id: http://core.svn.wordpress.org/trunk@30136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:24:22 +00:00
Scott Taylor
02f3c92b39
Fix failing unit tests after [30096]: use `assertEqualSets()`.
...
Built from https://develop.svn.wordpress.org/trunk@30135
git-svn-id: http://core.svn.wordpress.org/trunk@30135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:44 +00:00
Boone Gorges
e9f6ee53bb
Fix database schema update introduced in [30121].
...
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30134
git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:22 +00:00
Scott Taylor
8d0e8942eb
[28785] introduced a bug, where encoded query arguments were decoded by `parse_str()` inside of `wp_parse_str()` but never re-encoded later on.
...
This encodes them, adds unit test.
Props obenland.
Fixes #29636 .
Built from https://develop.svn.wordpress.org/trunk@30133
git-svn-id: http://core.svn.wordpress.org/trunk@30133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:54:23 +00:00
Scott Taylor
c19b3d1740
Fix unit test for video shortcode after [30082].
...
Fixes #30078 .
Built from https://develop.svn.wordpress.org/trunk@30132
git-svn-id: http://core.svn.wordpress.org/trunk@30132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:49:21 +00:00
Scott Taylor
29deacc30c
Revisions modules should not rely on global settings:
...
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax
Props ericlewis, wonderboymusic.
Fixes #30219 .
Built from https://develop.svn.wordpress.org/trunk@30131
git-svn-id: http://core.svn.wordpress.org/trunk@30131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:39:24 +00:00
Scott Taylor
d1d93b7cda
Set `revision.settings` via short-circuit check for `window` property: `window._wpRevisionsSettings || {}`
...
Props ericlewis.
Fixes #30218 .
Built from https://develop.svn.wordpress.org/trunk@30130
git-svn-id: http://core.svn.wordpress.org/trunk@30130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:20:22 +00:00
Scott Taylor
a4963672d6
Add a single responsibility function for outputting Revisions JS templates: `wp_print_revision_templates()`.
...
Use it in `wp-admin/revision.php`.
Props ericlewis.
Fixes #30220 .
Built from https://develop.svn.wordpress.org/trunk@30129
git-svn-id: http://core.svn.wordpress.org/trunk@30129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:15:24 +00:00
Scott Taylor
7cbb7552da
Allow revision Backbone classes to be used on pages other than `revision.php`.
...
Props ericlewis.
Fixes #30221 .
Built from https://develop.svn.wordpress.org/trunk@30128
git-svn-id: http://core.svn.wordpress.org/trunk@30128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:08:21 +00:00
Scott Taylor
f1634f7c8f
Add some JSDoc blocks to `revisions.js`.
...
Props ericlewis.
See #30222 .
Built from https://develop.svn.wordpress.org/trunk@30127
git-svn-id: http://core.svn.wordpress.org/trunk@30127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 23:55:22 +00:00
Dominik Schilling
461507452a
Customizer: Improve `ColorControl`'s `wpColorPicker` to update UI based on setting changes.
...
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.
props westonruter.
fixes #30031 .
Built from https://develop.svn.wordpress.org/trunk@30126
git-svn-id: http://core.svn.wordpress.org/trunk@30126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:45:22 +00:00
Scott Taylor
7eefc4d1e1
JSHint after [30124].
...
Built from https://develop.svn.wordpress.org/trunk@30125
git-svn-id: http://core.svn.wordpress.org/trunk@30125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:38:21 +00:00
Scott Taylor
a6cb067481
JSHint after [30120].
...
Built from https://develop.svn.wordpress.org/trunk@30124
git-svn-id: http://core.svn.wordpress.org/trunk@30124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:35:22 +00:00
Dominik Schilling
2e76a697f6
Fix JSHint errors introduced in [30120].
...
see #30193 .
Built from https://develop.svn.wordpress.org/trunk@30123
git-svn-id: http://core.svn.wordpress.org/trunk@30123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:28:24 +00:00
Drew Jaynes
66c47f29bb
Correct references of `@uses $wpdb` in core documentation to use `@global`.
...
See #30191 , [30105].
Fixes #30217 .
Built from https://develop.svn.wordpress.org/trunk@30122
git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 17:56:22 +00:00
Boone Gorges
70631df84a
Bump db_version and add upgrade routine for schema change in [30056].
...
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30121
git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 16:03:22 +00:00
Scott Taylor
999e0fbd99
Add verbose docs to `media-views.js`.
...
Props ericlewis.
See #30193 .
Built from https://develop.svn.wordpress.org/trunk@30120
git-svn-id: http://core.svn.wordpress.org/trunk@30120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 15:20:23 +00:00
Drew Jaynes
e8f68802c6
Correct two parameter types in the `wp_save_post_revision_check_for_changes` hook documentation.
...
Props johnbillion.
Fixes #30185 .
Built from https://develop.svn.wordpress.org/trunk@30119
git-svn-id: http://core.svn.wordpress.org/trunk@30119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 23:50:22 +00:00
Boone Gorges
6745b8a870
Move `term_exists()` tests to their own file.
...
Built from https://develop.svn.wordpress.org/trunk@30118
git-svn-id: http://core.svn.wordpress.org/trunk@30118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:53:22 +00:00
Sergey Biryukov
94fa6e1615
Use correct file name in a hook comment.
...
props wedi.
fixes #30200 .
Built from https://develop.svn.wordpress.org/trunk@30117
git-svn-id: http://core.svn.wordpress.org/trunk@30117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:35:28 +00:00
Sergey Biryukov
b823b2f3c1
Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.
...
fixes #30137 .
Built from https://develop.svn.wordpress.org/trunk@30116
git-svn-id: http://core.svn.wordpress.org/trunk@30116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 11:57:22 +00:00
Boone Gorges
93ae51e801
Unserialize `get_metadata()` results when 'key' is omitted.
...
Props mattkeys, nacin.
Fixes #15030 .
Built from https://develop.svn.wordpress.org/trunk@30115
git-svn-id: http://core.svn.wordpress.org/trunk@30115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 10:25:22 +00:00
Jeremy Felt
909aa4f1e7
Improve tests for domain_exists()
...
* Split existing tests for `domain_exists()` into many smaller tests.
* Make slightly fewer, more accurate assertions.
* Remove unnecessary site creation via factory.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30114
git-svn-id: http://core.svn.wordpress.org/trunk@30114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 05:44:23 +00:00
Boone Gorges
caf4fec1f7
Streamline some `get_terms()` cache tests.
...
* Split large method into a number of smaller tests.
* Create fewer fixtures.
See #30017 .
Built from https://develop.svn.wordpress.org/trunk@30113
git-svn-id: http://core.svn.wordpress.org/trunk@30113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 04:16:22 +00:00
Boone Gorges
08ef5b6ec9
Clean up cache invalidation suspension global in unit tests.
...
This fixes a test that was introduced in [30073] which was polluting later
tests.
See #21760 .
Built from https://develop.svn.wordpress.org/trunk@30112
git-svn-id: http://core.svn.wordpress.org/trunk@30112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 04:15:23 +00:00
Drew Jaynes
39a44f62ad
Update the changelogs for the comment hook parameters added in [30092].
...
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.
Fixes #22380 .
Built from https://develop.svn.wordpress.org/trunk@30111
git-svn-id: http://core.svn.wordpress.org/trunk@30111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 03:52:22 +00:00
Drew Jaynes
8fcc2b3dc8
Update the changelog for `WP_Comment_Query::query()` to reflect two more new arguments added in [30096].
...
[30096] introduced the `type__in` and `type__not_in` arguments. See #30111 for documentation on those new arguments.
Fixes #12668 .
Built from https://develop.svn.wordpress.org/trunk@30110
git-svn-id: http://core.svn.wordpress.org/trunk@30110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 03:06:24 +00:00
Drew Jaynes
54020268f7
Update the changelog for `get_approved_comments()` to reflect that the function was refactored to leverage `WP_Comment_Query` in [30098].
...
Also updates the `$args` parameter description with a reference to see `WP_Comment_Query` for argument information.
See #12668 .
Built from https://develop.svn.wordpress.org/trunk@30109
git-svn-id: http://core.svn.wordpress.org/trunk@30109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:51:23 +00:00
Boone Gorges
af026330c4
Clean up `get_term_by()` caching.
...
* Fix cache key/group modification that was missed in [30073].
* Update unit tests to reflect new key/group format.
Props tollmanz.
Fixes #21760 .
Built from https://develop.svn.wordpress.org/trunk@30108
git-svn-id: http://core.svn.wordpress.org/trunk@30108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:50:23 +00:00
Boone Gorges
47742eae12
In `get_terms()`, do not override 'hierarchical' and 'pad_counts' when 'parent' is present.
...
The previous behavior resulted in descendant terms being improperly excluded
from the results when passing a 'parent', even when 'hierarchical' had been
set to true.
The patch also adds unit tests that demonstrate the various interactions
between the 'child_of', 'parent', and 'hierarchical' parameters of `get_terms()`.
Props landakram.
Fixes #29815 .
Built from https://develop.svn.wordpress.org/trunk@30107
git-svn-id: http://core.svn.wordpress.org/trunk@30107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:12:22 +00:00
Jeremy Felt
3dcf418545
Expand tests around wpmu_delete_blog()
...
* Test cache after a site is deleted or flagged as deleted.
* Test tables after a site is deleted or flagged as deleted.
* Test tables and cache after the main site is deleted.
* Test site count after a site is deleted or flagged as deleted.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30106
git-svn-id: http://core.svn.wordpress.org/trunk@30106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 02:00:22 +00:00
Drew Jaynes
f8657d5890
Remove redundant and erroneous `@uses` tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
Built from https://develop.svn.wordpress.org/trunk@30105
git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
Dominik Schilling
00845a6c3d
Customizer: Fix missing newly added widgets in the preview after [29905].
...
props westonruter.
fixes #29983 .
Built from https://develop.svn.wordpress.org/trunk@30104
git-svn-id: http://core.svn.wordpress.org/trunk@30104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:57:23 +00:00
Ian Stewart
27b88c350a
Twenty Fifteen: back compat checks in Twenty Fifteen are breaking the customizer, leaving them in for now, but commented out.
...
See #30137 .
Built from https://develop.svn.wordpress.org/trunk@30103
git-svn-id: http://core.svn.wordpress.org/trunk@30103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:52:22 +00:00
Dominik Schilling
3c962ee5d8
Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
...
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.
https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.
props westonruter, celloexpressions, ryankienstra.
see #28032 , #28579 , #28580 , #28650 , #28709 , #29758 .
fixes #29529 .
Built from https://develop.svn.wordpress.org/trunk@30102
git-svn-id: http://core.svn.wordpress.org/trunk@30102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:51:22 +00:00
Mark Jaquith
63cf4db8ae
Fix weird HiDPI screen rendering issue with theme install preview toolbar
...
fixes #28898
props ocean90
Built from https://develop.svn.wordpress.org/trunk@30101
git-svn-id: http://core.svn.wordpress.org/trunk@30101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:36:21 +00:00
Dominik Schilling
4df00e156d
Improve body class for page templates.
...
* Convert slash to dash too.
* Add sub-folder name as a separate body class.
* New classes are additional classes, old syntax will persists for BC.
With this `/page-templates/full-width.php` will produce `page-template`, `page-template-page-templates`, `page-template-full-width` and `page-template-page-templatesfull-width-php`.
props obenland, Caspie, donutz.
fixes #23470 .
Built from https://develop.svn.wordpress.org/trunk@30100
git-svn-id: http://core.svn.wordpress.org/trunk@30100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:20:23 +00:00
Ian Stewart
76876654ac
Twenty Fifteen: avoid errors by preventing Twenty Fifteen from being activated in old versions of WordPress
...
Props iamtakashi, fixes #30137 .
Built from https://develop.svn.wordpress.org/trunk@30099
git-svn-id: http://core.svn.wordpress.org/trunk@30099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:14:22 +00:00
Boone Gorges
3be72a13de
Use `WP_Comment_Query` to query comments in `get_approved_comments()`.
...
Props dancameron.
See #12668 .
Built from https://develop.svn.wordpress.org/trunk@30098
git-svn-id: http://core.svn.wordpress.org/trunk@30098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:58:23 +00:00
Ian Stewart
e68c17cb7b
Twenty Fifteen: leading the way with support for title-tag
...
Props obenland, fixes #30146 .
Built from https://develop.svn.wordpress.org/trunk@30097
git-svn-id: http://core.svn.wordpress.org/trunk@30097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:56:23 +00:00
Boone Gorges
56f55ea507
Better flexibility for 'type' in `WP_Comment_Query`.
...
* Add support for an array of values in 'type'.
* Introduce `type__in` parameter. This duplicates 'type' but is added for better consistency with other query classes.
* Introduce `type__not_in`.
Among other things, these changes will make it easier for plugin authors to
manage the appearance of custom comment types in various WP interfaces.
Props dancameron, mordauk.
See #12668 .
Built from https://develop.svn.wordpress.org/trunk@30096
git-svn-id: http://core.svn.wordpress.org/trunk@30096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:50:22 +00:00
John Blackbourn
ee6d4968da
Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use.
...
Fixes #20880 .
Props kovshenin, joedolson.
Built from https://develop.svn.wordpress.org/trunk@30095
git-svn-id: http://core.svn.wordpress.org/trunk@30095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:41:43 +00:00
Konstantin Kovshenin
73f6a574b7
Use a nested meta query when querying by role in `WP_User_Query`.
...
If a user query includes a meta query together with a role argument,
nest the original meta query and append the role meta query with an
AND relationship.
fixes #23849 , #27026 .
Built from https://develop.svn.wordpress.org/trunk@30094
git-svn-id: http://core.svn.wordpress.org/trunk@30094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:41:22 +00:00
Boone Gorges
beaa3f6928
Support an empty string passed as a status in `WP_Comment_Query`.
...
The changes in [30084] broke backward compatibility with interfaces that
manually passed an empty string for the value of 'status', such as on
wp-admin/edit-comments.php.
Fixes #29612 .
Built from https://develop.svn.wordpress.org/trunk@30093
git-svn-id: http://core.svn.wordpress.org/trunk@30093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:51:23 +00:00
Peter Westwood
664f19e28a
Comment Template Tags: Improve the availability of context information in comment template tag filters.
...
Fixes #22380 props momo360modena, tareq1988.
Built from https://develop.svn.wordpress.org/trunk@30092
git-svn-id: http://core.svn.wordpress.org/trunk@30092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:07:22 +00:00
John Blackbourn
a866a7192f
Introduce some actions and filters which aid plugins in revisioning post meta.
...
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
* `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
* `wp_creating_autosave` action which is fired just before an autosave is created.
See #20564 .
Props mattheu, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@30091
git-svn-id: http://core.svn.wordpress.org/trunk@30091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:02:21 +00:00
John Blackbourn
9a16b52018
Revert [28610] in order to avoid infinite redirect loops on reverse proxies which proxy from HTTPS to HTTP. This will be revisited at some point, possibly as an option via a filter.
...
Fixes #28610 .
Built from https://develop.svn.wordpress.org/trunk@30090
git-svn-id: http://core.svn.wordpress.org/trunk@30090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 18:37:25 +00:00
Mark Jaquith
6de35acf28
Increase both mystery and humanism
...
Built from https://develop.svn.wordpress.org/trunk@30089
git-svn-id: http://core.svn.wordpress.org/trunk@30089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 03:20:24 +00:00
Boone Gorges
e9adba887d
Introduce `'pre_delete_term'` hook.
...
Props cmmarslender.
Fixes #30127 .
Built from https://develop.svn.wordpress.org/trunk@30088
git-svn-id: http://core.svn.wordpress.org/trunk@30088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 02:44:22 +00:00
John Blackbourn
d70744e95c
Correct some logic to populate the `defaultValue` variable when `data.defaultValue` begins with a hash symbol.
...
Props antpb
Fixes #30125
Built from https://develop.svn.wordpress.org/trunk@30087
git-svn-id: http://core.svn.wordpress.org/trunk@30087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 02:43:22 +00:00