WordPress/wp-admin
Helen Hou-Sandí 6820130e33 Screen options: Improve the "Apply" button
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.

Built from https://develop.svn.wordpress.org/trunk@35161


git-svn-id: http://core.svn.wordpress.org/trunk@35127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 18:58:25 +00:00
..
css Screen options: Improve the "Apply" button 2015-10-14 18:58:25 +00:00
images Squish that .png a bit more. See [32994]. 2015-06-30 22:04:25 +00:00
includes Screen options: Improve the "Apply" button 2015-10-14 18:58:25 +00:00
js Accessibility: update a jQuery selector used for the Plugin Cards after [35009]. 2015-10-14 15:27:27 +00:00
maint Improve the tone of key/salts recommendation message. 2015-07-01 15:39:26 +00:00
network MS: Reflect falsy values for `upload_space_check_disabled` in UI. 2015-10-12 00:01:24 +00:00
user Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files. 2014-11-04 16:32:22 +00:00
about.php About: Remove period from placeholder. 2015-09-11 19:27:24 +00:00
admin-ajax.php Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user. 2015-09-18 20:14:24 +00:00
admin-footer.php Add `@global` annotations for `wp-admin/*`. 2015-05-28 21:41:30 +00:00
admin-functions.php First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 2013-12-24 18:57:12 +00:00
admin-header.php Correct the title used on the user dashboard. 2015-06-24 00:37:28 +00:00
admin-post.php Superglobals: Revert [34059] until further notice. 2015-09-17 12:33:26 +00:00
admin.php Use `wp_installing()` instead of `WP_INSTALLING` constant. 2015-10-05 15:06:28 +00:00
async-upload.php Superglobals: Revert [34059] until further notice. 2015-09-17 12:33:26 +00:00
comment.php Include placeholders in translator comments. 2015-09-18 18:58:24 +00:00
credits.php Accessibility: bump headings one level up on Credits screen for a better headings hierarchy. 2015-10-13 06:49:26 +00:00
custom-background.php `callback` is not a valid type in PHP, PSR-5, or phpDocumentor. `callable` should be used instead. 2015-09-25 23:58:25 +00:00
custom-header.php `callback` is not a valid type in PHP, PSR-5, or phpDocumentor. `callable` should be used instead. 2015-09-25 23:58:25 +00:00
customize.php Customize: Reduce peak memory usage by JSON-encoding settings and controls individually. 2015-09-17 19:42:26 +00:00
edit-comments.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
edit-form-advanced.php Revert [34917] until the broken test is fixed. 2015-10-08 01:04:25 +00:00
edit-form-comment.php Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility. 2015-10-14 17:44:24 +00:00
edit-link-form.php Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility. 2015-10-14 17:32:24 +00:00
edit-tag-form.php When applying the `'editable_slug'` filter, add a second param that provides more context. 2015-09-19 05:49:24 +00:00
edit-tags.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
edit.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
export.php Export: allow Media to exported separately from other types. 2015-09-19 16:47:25 +00:00
freedoms.php About: Third pass at 4.3 about page: 2015-08-13 22:11:35 +00:00
import.php Proper heading for admin screens. 2015-06-27 15:41:25 +00:00
index.php Replace some hyphens with `—`s in admin help tabs. 2015-08-19 04:53:25 +00:00
install-helper.php Add missing doc blocks to `wp-admin/includes/*`. 2015-05-29 20:17:26 +00:00
install.php Install: Replace the "Privacy" setting with the "Search Engine Visibility" setting from Reading Settings. 2015-10-01 21:35:25 +00:00
link-add.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
link-manager.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
link-parse-opml.php Add `@global` annotations for `wp-admin/*`. 2015-05-28 21:41:30 +00:00
link.php Fix syntax for single- and multi-line comments in wp-admin-directory files. 2014-07-17 09:14:16 +00:00
load-scripts.php Create a new file, `wp-admin/includes/noop.php`, which loads all of the noop functions for `load-script|styles.php` and is only loaded by those files. DRYs in the process. 2015-09-11 05:04:23 +00:00
load-styles.php Create a new file, `wp-admin/includes/noop.php`, which loads all of the noop functions for `load-script|styles.php` and is only loaded by those files. DRYs in the process. 2015-09-11 05:04:23 +00:00
media-new.php `media-new.php`, when using the browser uploader, if the result of uploading is a `WP_Error` - `wp_die()` with the error, instead of redirecting with a generic error. 2015-09-10 17:18:24 +00:00
media-upload.php Provide more helful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/media-upload.php`. 2015-09-02 16:21:21 +00:00
media.php Use a less element-specific class name for links within page titles. 2015-07-03 16:42:24 +00:00
menu-header.php Docs: Document declaration of the `$submenu_file` global in wp-admin/menu-header.php. 2015-10-01 01:48:25 +00:00
menu.php Don't show the "Add New" link on `post-new.php`. 2015-10-01 00:48:25 +00:00
moderation.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
ms-admin.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
ms-delete-site.php Trim trailing space from string in site delete confirmation 2015-07-01 16:31:25 +00:00
ms-edit.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
ms-options.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
ms-sites.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
ms-themes.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
ms-upgrade-network.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
ms-users.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
my-sites.php My Sites: Make "Create a New Site" link consistent with other "Add New" links. 2015-10-09 03:50:24 +00:00
nav-menus.php Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/nav-menus.php`. 2015-09-02 18:21:21 +00:00
network.php Network Setup: don't use `<code>` in translation strings in `wp-admin/network` files. 2015-09-18 18:18:27 +00:00
options-discussion.php Comments: Trash blacklisted comments by default. 2015-10-01 01:49:25 +00:00
options-general.php Add missing translator comments after [34294]. 2015-09-18 18:46:24 +00:00
options-head.php Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 2013-03-01 17:14:09 +00:00
options-media.php Bump H3 headings to H2 on the Media Settings screen for better accessibility. 2015-09-05 20:12:25 +00:00
options-permalink.php MS: Provide better UI when a main site's `/blog` prefix is changed. 2015-10-01 20:39:24 +00:00
options-reading.php Move ad hoc Options functions to `wp-admin/includes/options.php`: 2015-09-10 21:45:24 +00:00
options-writing.php Revert [34778], continue using `_site_option()` for the current network. 2015-10-07 17:11:25 +00:00
options.php Revert [34778], continue using `_site_option()` for the current network. 2015-10-07 17:11:25 +00:00
plugin-editor.php Replace `get_bloginfo( 'wpurl' )` with `admin_url()` in plugin editor. 2015-10-13 02:05:24 +00:00
plugin-install.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
plugins.php Replace `get_bloginfo( 'wpurl' )` with `admin_url()` for plugin activation error message. 2015-10-13 02:12:24 +00:00
post-new.php Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/post-new.php`. 2015-09-02 18:36:22 +00:00
post.php Respect the `force_delete` parameter of `get_delete_post_link()`. 2015-10-03 01:50:25 +00:00
press-this.php Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/press-this.php`. 2015-09-02 18:38:21 +00:00
profile.php Don't rely on include_path to include files. 2013-09-25 00:18:11 +00:00
revision.php Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types. 2015-09-09 03:23:23 +00:00
setup-config.php Correct the error message displayed on setup when `wp-config-sample.php` does not exist. 2015-10-13 17:36:25 +00:00
theme-editor.php Theme Editor: add a filter, `wp_theme_editor_filetypes`, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (`.less`, `.scss`) you would like. 2015-10-13 14:14:24 +00:00
theme-install.php Use `wp_star_rating()` on Add Themes screen: 2015-10-10 06:51:24 +00:00
themes.php Remove stray closing tag in `wp-admin/themes.php`. 2015-10-09 21:17:25 +00:00
tools.php Bump H3 headings to H2 on Tools screen for better accessibility. 2015-08-31 03:32:21 +00:00
update-core.php Plugins: Don't request all fields via `plugins_api( 'plugin_information' )` for plugin installs and update checks. 2015-09-26 15:50:25 +00:00
update.php Plugins: Don't request all fields via `plugins_api( 'plugin_information' )` for plugin installs and update checks. 2015-09-26 15:50:25 +00:00
upgrade-functions.php First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 2013-12-24 18:57:12 +00:00
upgrade.php Merge two database update strings for consistency. 2015-10-10 05:14:23 +00:00
upload.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
user-edit.php Revert [34778], continue using `_site_option()` for the current network. 2015-10-07 17:11:25 +00:00
user-new.php Profile: on `user-new.php`, don't allow the password fields to be hidden. When hidden, you can't add a user. 2015-09-26 06:15:26 +00:00
users.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
widgets.php Widgets: add a function, `is_registered_sidebar()` - helps us avoid touching the `$wp_registered_sidebars` global. 2015-10-13 01:33:25 +00:00