WordPress/wp-admin/includes
Helen Hou-Sandí 6820130e33 Screen options: Improve the "Apply" button
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.

Built from https://develop.svn.wordpress.org/trunk@35161


git-svn-id: http://core.svn.wordpress.org/trunk@35127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 18:58:25 +00:00
..
admin-filters.php Move media hooks out of `admin-filters.php` as sometimes editors are used on the front end. 2015-08-06 20:40:26 +00:00
admin.php Move `WP_Screen` to its own file. 2015-09-15 04:08:24 +00:00
ajax-actions.php Use `wp_star_rating()` on Add Themes screen: 2015-10-10 06:51:24 +00:00
bookmark.php Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`. 2015-09-03 08:59:24 +00:00
class-ftp-pure.php Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 2015-09-18 08:20:27 +00:00
class-ftp-sockets.php Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 2015-09-18 08:20:27 +00:00
class-ftp.php Updates: FTP: Add a missing PCRE modifer in [34281]. 2015-09-18 08:23:25 +00:00
class-pclzip.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-walker-category-checklist.php Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241]. 2015-09-22 14:33:48 +00:00
class-walker-nav-menu-checklist.php Move the admin Nav Menu Walker subclasses into their own files. Load in `nav-menu.php` to remain BC. 2015-09-15 04:02:25 +00:00
class-walker-nav-menu-edit.php Move the admin Nav Menu Walker subclasses into their own files. Load in `nav-menu.php` to remain BC. 2015-09-15 04:02:25 +00:00
class-wp-comments-list-table.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
class-wp-filesystem-base.php Add `@access` docs to `class-wp-filesystem-*` files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-direct.php Add `@access` docs to `class-wp-filesystem-*` files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-ftpext.php Updates: Try a more compatible method to detect if a file exists when using the FTP Extension. 2015-10-01 05:09:25 +00:00
class-wp-filesystem-ftpsockets.php Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for `WP_Filesystem_ftpsockets::get_contents()`. 2015-09-24 14:22:24 +00:00
class-wp-filesystem-ssh2.php Updates: SSH2 Transport: Add a connection error when the SFTP subsystem cannot be initialized. 2015-10-01 05:43:25 +00:00
class-wp-importer.php Remove unnecessary feedback message from `WP_Importer::is_user_over_quota()`. 2015-06-30 20:32:25 +00:00
class-wp-internal-pointers.php Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241]. 2015-09-22 14:35:25 +00:00
class-wp-links-list-table.php List Tables: 2015-07-14 17:47:24 +00:00
class-wp-list-table.php Docs: Fix some syntactical issues in property DocBlocks for `WP_List_Table`. 2015-10-11 03:34:26 +00:00
class-wp-media-list-table.php List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens. 2015-10-07 01:28:25 +00:00
class-wp-ms-sites-list-table.php MS: Remove registration of ID column in Sites and Users list tables. 2015-10-01 20:58:24 +00:00
class-wp-ms-themes-list-table.php MS Themes List Table: Fix inverted logic for displaying the "No items" message. 2015-10-06 17:35:23 +00:00
class-wp-ms-users-list-table.php Users: Don't pass the current `WP_Users_List_Table` or `WP_MS_Users_List_Table` instance to the `users_list_table_query_args` filter after all. 2015-10-03 21:49:24 +00:00
class-wp-plugin-install-list-table.php Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy. 2015-10-10 15:17:26 +00:00
class-wp-plugins-list-table.php Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite. 2015-10-13 22:12:25 +00:00
class-wp-post-comments-list-table.php Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223]. 2015-09-22 14:31:24 +00:00
class-wp-posts-list-table.php Posts List Table: ensure that "All" gets the "current" CSS class when applicable. 2015-10-07 00:09:24 +00:00
class-wp-press-this.php Press This: Make the regular expressions for matching images easier to read by not requiring escaping. 2015-10-01 05:16:25 +00:00
class-wp-screen.php Screen options: Improve the "Apply" button 2015-10-14 18:58:25 +00:00
class-wp-site-icon.php Don't ever use the `guid` value when retrieving URLs for media, use `wp_get_attachment_url()`. Use `get_attached_file()` for path to file. 2015-09-15 02:50:25 +00:00
class-wp-terms-list-table.php List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 2015-09-22 06:06:25 +00:00
class-wp-theme-install-list-table.php List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 2015-09-22 06:06:25 +00:00
class-wp-themes-list-table.php Revert [34778], continue using `_site_option()` for the current network. 2015-10-07 17:11:25 +00:00
class-wp-upgrader-skins.php Upgrader: Avoid using an HTML tag in a translation string, add translator comments. 2015-09-20 08:59:24 +00:00
class-wp-upgrader.php Upgrader: Introduce a new action hook `pre_auto_update`, which fires immediately prior to an auto-update for core, themes, plugins, or translations. 2015-10-13 18:58:25 +00:00
class-wp-users-list-table.php Remove obsolete code from `WP_Users_List_Table::get_sortable_columns(). 2015-10-13 02:25:25 +00:00
comment.php Allow `comment_exists()` to match based on GMT date. 2015-09-23 18:16:26 +00:00
continents-cities.php Give continents-cities their own textdomain. Props nbachiyski, Denis-de-Bernardy . fixes #9794 2009-05-14 20:05:25 +00:00
credits.php Move ad hoc functions from `wp-admin/credits.php` to `wp-admin/includes/credits.php`, which is only included by the former. 2015-09-11 04:55:26 +00:00
dashboard.php Docs: Fix some minor formatting in the `$query_args` parameter description for the `` filter doc. 2015-10-10 06:39:24 +00:00
deprecated.php Docs: Add missing method summaries for the deprecated `WP_User_Search` class, including `prepare_query()`, `query()`, `prepare_vars_for_template_usage()`, `do_paging()`, and `get_results()`. 2015-10-05 02:35:25 +00:00
edit-tag-messages.php Don't redirect to the Term list table after submitting the form on the Edit Term page. 2015-09-15 15:59:42 +00:00
export.php Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors. 2015-09-19 18:53:25 +00:00
file.php Use `wp_installing()` instead of `WP_INSTALLING` constant. 2015-10-05 15:06:28 +00:00
image-edit.php Docs: Put "it's" in its place (again). 2015-09-16 12:46:28 +00:00
image.php After [34374], ensure that `$iptc` is defined. 2015-09-22 04:49:24 +00:00
import.php `callback` is not a valid type in PHP, PSR-5, or phpDocumentor. `callable` should be used instead. 2015-09-25 23:58:25 +00:00
list-table.php List Tables: in `_WP_List_Table_Compat::get_column_info()`, also return `$primary`, which is expected since [33016]. 2015-10-07 03:12:24 +00:00
media.php Docs: Specify the default image size in the `$size` parameter description for the `image_send_to_editor` hook. 2015-10-12 17:18:24 +00:00
menu.php Docs: Wrap a couple of hook name references in inline `@see` tags in the hook docs for `custom_menu_order` and `menu_order`. 2015-10-12 03:39:26 +00:00
meta-boxes.php Taxonomy: `get_terms_to_edit()` can also return `false` or `WP_Error`. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations. 2015-10-13 16:40:26 +00:00
misc.php Use `wp_installing()` instead of `WP_INSTALLING` constant. 2015-10-05 15:06:28 +00:00
ms-admin-filters.php Cleanup `(ms-)?admin-filters.php` 2015-06-19 21:18:25 +00:00
ms-deprecated.php Docs: Standardize `@deprecated` tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 2015-08-20 22:26:24 +00:00
ms.php MS: Handle the possibility of 0 when checking a user's upload quota. 2015-10-10 23:17:25 +00:00
nav-menu.php Docs: Add a file header to wp-admin/includes/nav-menus.php. 2015-09-22 14:27:24 +00:00
network.php Revert [34778], continue using `_site_option()` for the current network. 2015-10-07 17:11:25 +00:00
noop.php Create a new file, `wp-admin/includes/noop.php`, which loads all of the noop functions for `load-script|styles.php` and is only loaded by those files. DRYs in the process. 2015-09-11 05:04:23 +00:00
options.php Move ad hoc Options functions to `wp-admin/includes/options.php`: 2015-09-10 21:45:24 +00:00
plugin-install.php Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy. 2015-10-10 15:17:26 +00:00
plugin.php Plugins: Introduce the `delete_plugin` transactional hook, which fires immediately after a plugin deletion attempt occurs. 2015-10-13 00:57:25 +00:00
post.php Docs: Adjust documentation for the `$size` parameter in the `admin_post_thumbnail_size` hook doc to clarify the required order of width and height values when an array is passed. 2015-10-12 16:22:25 +00:00
revision.php Revert [34917] until the broken test is fixed. 2015-10-08 01:04:25 +00:00
schema.php Term Meta: Prevent a "Multiple primary key defined" error during database upgrades. 2015-10-08 11:09:26 +00:00
screen.php Move `WP_Screen` to its own file. 2015-09-15 04:08:24 +00:00
taxonomy.php Docs: There are quite alot of typos in core inline comments. 2015-09-30 04:13:48 +00:00
template-functions.php Taxonomy: `get_terms_to_edit()` can also return `false` or `WP_Error`. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations. 2015-10-13 16:40:26 +00:00
template.php `wp-admin/includes/template.php` is now a loader for 3 files made via `svn cp`: 2015-09-16 15:35:23 +00:00
theme-install.php Add doc blocks to functions that are missing them. 2015-05-31 03:18:25 +00:00
theme.php Docs: Improve the hook documentation for the `themes_api` filter. 2015-09-27 23:01:24 +00:00
translation-install.php Use `wp_installing()` instead of `WP_INSTALLING` constant. 2015-10-05 15:06:28 +00:00
update-core.php Revert [34778], continue using `_site_option()` for the current network. 2015-10-07 17:11:25 +00:00
update.php Revert [34778], continue using `_site_option()` for the current network. 2015-10-07 17:11:25 +00:00
upgrade.php After [34529], if a compatible `termmeta` table is found on database upgrade, convert it to `utf8mb4` collation. 2015-10-09 02:07:25 +00:00
user.php Users: Remove redundant error message when password is only entered once. 2015-10-10 13:22:26 +00:00
widgets.php Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy. 2015-10-10 16:34:25 +00:00