honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Mark some constants in decay functions final (#50569) (#50575) 

This marks a couple of constants in the `DecayFunctionBuilder` as final.
They are written in CONSTANT_CASE and used as constants but not final
which is a little confusing and might lead to sneaky bugs.
This commit is contained in:
Nik Everett 2020-01-03 10:58:15 -05:00 committed by GitHub
parent 44827e577e
commit 1abecad21b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/src/main/java/org/elasticsearch/index/query/functionscore/DecayFunctionBuilder.java
View File

@ -65,8 +65,8 @@ public abstract class DecayFunctionBuilder<DFB extends DecayFunctionBuilder<DFB>
protected static final String DECAY = "decay"; protected static final String DECAY = "decay";
protected static final String OFFSET = "offset"; protected static final String OFFSET = "offset";
public static double DEFAULT_DECAY = 0.5; public static final double DEFAULT_DECAY = 0.5;
public static MultiValueMode DEFAULT_MULTI_VALUE_MODE = MultiValueMode.MIN; public static final MultiValueMode DEFAULT_MULTI_VALUE_MODE = MultiValueMode.MIN;
private final String fieldName; private final String fieldName;
//parsing of origin, scale, offset and decay depends on the field type, delayed to the data node that has the mapping for it //parsing of origin, scale, offset and decay depends on the field type, delayed to the data node that has the mapping for it