Plugin Manager can not download _site plugins from github
Sounds like github changes a bit download url for master zip file. From `https://github.com/username/reponame/zipball/master` to `https://github.com/username/reponame/archive/master.zip`. We need to update plugin manager to reflect that change. In the meantime, we invite users having this issue to use: ```sh bin/plugin -install reponame -url https://github.com/username/reponame/archive/master.zip ``` For example: ```sh bin/plugin -install paramedic -url https://github.com/karmi/elasticsearch-paramedic/archive/master.zip ``` Closes #3551
This commit is contained in:
parent
8668479b92
commit
352d2aaf18
|
@ -178,7 +178,7 @@ public class PluginManager {
|
|||
}
|
||||
if (!downloaded) {
|
||||
// try it as a site plugin tagged
|
||||
pluginUrl = new URL("https://codeload.github.com/" + userName + "/" + repoName + "/zip/v" + version);
|
||||
pluginUrl = new URL("https://github.com/" + userName + "/" + repoName + "/archive/v" + version + ".zip");
|
||||
System.out.println("Trying " + pluginUrl.toExternalForm() + "... (assuming site plugin)");
|
||||
try {
|
||||
downloadHelper.download(pluginUrl, pluginFile, new HttpDownloadHelper.VerboseProgress(System.out));
|
||||
|
@ -192,7 +192,7 @@ public class PluginManager {
|
|||
}
|
||||
} else {
|
||||
// assume site plugin, download master....
|
||||
URL pluginUrl = new URL("https://codeload.github.com/" + userName + "/" + repoName + "/zip/master");
|
||||
URL pluginUrl = new URL("https://github.com/" + userName + "/" + repoName + "/archive/master.zip");
|
||||
System.out.println("Trying " + pluginUrl.toExternalForm() + "... (assuming site plugin)");
|
||||
try {
|
||||
downloadHelper.download(pluginUrl, pluginFile, new HttpDownloadHelper.VerboseProgress(System.out));
|
||||
|
|
Loading…
Reference in New Issue