review comment fixes

This commit is contained in:
Zachary Tong 2015-04-27 14:32:20 -04:00
parent 31f26ec115
commit 935144a064
2 changed files with 0 additions and 5 deletions

View File

@ -63,10 +63,6 @@ public abstract class MovAvgModel {
return predictions;
}
// nocommit
// I don't like that it creates a new queue here
// The alternative to this is to just use `values` directly, but that would "consume" values
// and potentially change state elsewhere. Maybe ok?
Collection<Number> predictionBuffer = EvictingQueue.create(values.size());
predictionBuffer.addAll(values);

View File

@ -29,5 +29,4 @@ import java.io.IOException;
* average models are used by the MovAvg reducer
*/
public interface MovAvgModelBuilder extends ToXContent {
public abstract XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException;
}