honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
angular-cn/dev-infra/pullapprove/BUILD.bazel

52 lines
1.2 KiB
Python
Raw Normal View History

build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 17:37:21 -05:00
load("@npm_bazel_typescript//:index.bzl", "ts_library")
refactor(dev-infra): Add support for groups in the conditions evaluator (#38164) Conditions can refer to the groups array that is a list of the preceding groups. This commit adds support to the verification for those conditions. This commit also adds some tests to the parsing and condition matching to ensure everything works as expected. PR Close #38164
2020-07-20 14:53:26 -04:00
load("//tools:defaults.bzl", "jasmine_node_test")
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 17:37:21 -05:00
ts_library(
name = "pullapprove",
srcs = [
feat(dev-infra): standard CLI commands using yargs (#36326) Creates a standard model for CLI commands provided by ng-dev. Allows for us to have any of the tools/scripts extend to be included in the ng-dev command, or be standalone using the same yargs parser. PR Close #36326
2020-03-26 13:45:09 -04:00
"cli.ts",
feat(dev-infra): pullapprove verify should handle `files` in conditions (#36661) Currently, when verifying our pullapprove configuration, we don't respect modifications to the set of files in a condition. e.g. It's not possible to do the following: ``` contains_any_globs(files.exclude(...), [ ``` This prevents us from having codeowner groups which match a directory, but want to filter out specific sub directories. For example, `fw-core` matches all files in the core package. We want to exclude the schematics from that glob. Usually we do this by another exclude condition. This has a *significant* downside though. It means that fw-core will not be requested if a PR changes schematic code, _and_ actual fw-core code. To support these conditions, the pullapprove verification tool is refactored, so that it no longer uses Regular expressions for parsing, but rather evaluates the code through a dynamic function. This is possible since the conditions are written in simple Python that can be run in NodeJS too (with small modifications/transformations). PR Close #36661
2020-04-16 14:12:25 -04:00
"condition_evaluator.ts",
feat(dev-infra): handle excluding files via globs in pullapprove (#36162) Updates the pullapprove verification script to handle cases of excluding globs from groups. PR Close #36162
2020-03-20 09:59:35 -04:00
"group.ts",
"logging.ts",
"parse-yaml.ts",
refactor(dev-infra): Add support for groups in the conditions evaluator (#38164) Conditions can refer to the groups array that is a list of the preceding groups. This commit adds support to the verification for those conditions. This commit also adds some tests to the parsing and condition matching to ensure everything works as expected. PR Close #38164
2020-07-20 14:53:26 -04:00
"pullapprove_arrays.ts",
"utils.ts",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 17:37:21 -05:00
"verify.ts",
],
build: remove rollup packaging from dev-infra (#35647) The dev-infra package currently uses rollup for packaging. This has been done initially as a way to workaround manifest paths being used in the AMD JavaScript output. The actual solution to this problem is setting module names that match the `package.json` name. This ensures that the package can be consumed correctly in Bazel, and through NPM. This allows us to get rid of the rollup bundling, and we don't need to hard-code which dependencies should be external or included. Additionally, tools that are part of `dev-infra` can now specify their external dependencies simply in the `package.json`. To reduce version duplication, and out-of-sync versions, a new genrule has been created that syncs the versions with the top-level project `package.json`. PR Close #35647
2020-03-17 07:58:17 -04:00
module_name = "@angular/dev-infra-private/pullapprove",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 17:37:21 -05:00
visibility = ["//dev-infra:__subpackages__"],
deps = [
feat(dev-infra): create format tool in @angular/dev-infra-private (#36726) Previously we used gulp to run our formatter, currently clang-format, across our repository. This new tool within ng-dev allows us to migrate away from our gulp based solution as our gulp solution had issue with memory pressure and would cause OOM errors with too large of change sets. PR Close #36726
2020-04-20 16:00:10 -04:00
"//dev-infra/utils",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 17:37:21 -05:00
"@npm//@types/minimatch",
"@npm//@types/node",
"@npm//@types/shelljs",
"@npm//@types/yaml",
feat(dev-infra): standard CLI commands using yargs (#36326) Creates a standard model for CLI commands provided by ng-dev. Allows for us to have any of the tools/scripts extend to be included in the ng-dev command, or be standalone using the same yargs parser. PR Close #36326
2020-03-26 13:45:09 -04:00
"@npm//@types/yargs",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 17:37:21 -05:00
"@npm//minimatch",
"@npm//shelljs",
"@npm//yaml",
feat(dev-infra): standard CLI commands using yargs (#36326) Creates a standard model for CLI commands provided by ng-dev. Allows for us to have any of the tools/scripts extend to be included in the ng-dev command, or be standalone using the same yargs parser. PR Close #36326
2020-03-26 13:45:09 -04:00
"@npm//yargs",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 17:37:21 -05:00
],
)
refactor(dev-infra): Add support for groups in the conditions evaluator (#38164) Conditions can refer to the groups array that is a list of the preceding groups. This commit adds support to the verification for those conditions. This commit also adds some tests to the parsing and condition matching to ensure everything works as expected. PR Close #38164
2020-07-20 14:53:26 -04:00
ts_library(
name = "pullapprove_test_lib",
testonly = True,
srcs = glob(
["*.spec.ts"],
),
visibility = ["//visibility:private"],
deps = [
":pullapprove",
"@npm//@types/jasmine",
"@npm//@types/node",
"@npm//typescript",
],
)
jasmine_node_test(
name = "pullapprove_test",
srcs = [":pullapprove_test_lib"],
visibility = ["//visibility:private"],
)