honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
angular-cn/dev-infra/pullapprove/BUILD.bazel

52 lines
1.2 KiB
Python
Raw Normal View History

build: upgrade angular build, integration/bazel and @angular/bazel package to rule_nodejs 2.2.0 (#39182) Updates to rules_nodejs 2.2.0. This is the first major release in 7 months and includes a number of features as well as breaking changes. Release notes: https://github.com/bazelbuild/rules_nodejs/releases/tag/2.0.0 Features of note for angular/angular: * stdout/stderr/exit code capture; this could be potentially be useful * TypeScript (ts_project); a simpler tsc rule that ts_library that can be used in the repo where ts_library is too heavy weight Breaking changes of note for angular/angular: * loading custom rules from npm packages: `ts_library` is no longer loaded from `@npm_bazel_typescript//:index.bzl` (which no longer exists) but is now loaded from `@npm//@bazel/typescript:index.bzl` * with the loading changes above, `load("@npm//:install_bazel_dependencies.bzl", "install_bazel_dependencies")` is no longer needed in the WORKSPACE which also means that yarn_install does not need to run unless building/testing a target that depends on @npm. In angular/angular this is a minor improvement as almost everything depends on @npm. * @angular/bazel package is also updated in this PR to support the new load location; Angular + Bazel users that require it for ng_package (ng_module is no longer needed in OSS with Angular 10) will need to load from `@npm//@angular/bazel:index.bzl`. I investigated if it was possible to maintain backward compatability for the old load location `@npm_angular_bazel` but it is not since the package itself needs to be updated to load from `@npm//@bazel/typescript:index.bzl` instead of `@npm_bazel_typescript//:index.bzl` as it depends on ts_library internals for ng_module. * runfiles.resolve will now throw instead of returning undefined to match behavior of node require Other changes in angular/angular: * integration/bazel has been updated to use both ng_module and ts_libary with use_angular_plugin=true. The latter is the recommended way for rules_nodejs users to compile Angular 10 with Ivy. Bazel + Angular ViewEngine is supported with @angular/bazel <= 9.0.5 and Angular <= 8. There is still Angular ViewEngine example on rules_nodejs https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular_view_engine on these older versions but users that want to update to Angular 10 and are on Bazel must switch to Ivy and at that point ts_library with use_angular_plugin=true is more performant that ng_module. Angular example in rules_nodejs is configured this way as well: https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular. As an aside, we also have an example of building Angular 10 with architect() rule directly instead of using ts_library with angular plugin: https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular_bazel_architect. NB: ng_module is still required for angular/angular repository as it still builds ViewEngine & @angular/bazel also provides the ng_package rule. ng_module can be removed in the future if ViewEngine is no longer needed in angular repo. * JSModuleInfo provider added to ng_module. this is for forward compat for future rules_nodejs versions. PR Close #39182
2020-06-25 01:32:41 -07:00
load("@npm//@bazel/typescript:index.bzl", "ts_library")
refactor(dev-infra): Add support for groups in the conditions evaluator (#38164) Conditions can refer to the groups array that is a list of the preceding groups. This commit adds support to the verification for those conditions. This commit also adds some tests to the parsing and condition matching to ensure everything works as expected. PR Close #38164
2020-07-20 11:53:26 -07:00
load("//tools:defaults.bzl", "jasmine_node_test")
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 14:37:21 -08:00
ts_library(
name = "pullapprove",
srcs = [
feat(dev-infra): standard CLI commands using yargs (#36326) Creates a standard model for CLI commands provided by ng-dev. Allows for us to have any of the tools/scripts extend to be included in the ng-dev command, or be standalone using the same yargs parser. PR Close #36326
2020-03-26 10:45:09 -07:00
"cli.ts",
feat(dev-infra): pullapprove verify should handle `files` in conditions (#36661) Currently, when verifying our pullapprove configuration, we don't respect modifications to the set of files in a condition. e.g. It's not possible to do the following: ``` contains_any_globs(files.exclude(...), [ ``` This prevents us from having codeowner groups which match a directory, but want to filter out specific sub directories. For example, `fw-core` matches all files in the core package. We want to exclude the schematics from that glob. Usually we do this by another exclude condition. This has a *significant* downside though. It means that fw-core will not be requested if a PR changes schematic code, _and_ actual fw-core code. To support these conditions, the pullapprove verification tool is refactored, so that it no longer uses Regular expressions for parsing, but rather evaluates the code through a dynamic function. This is possible since the conditions are written in simple Python that can be run in NodeJS too (with small modifications/transformations). PR Close #36661
2020-04-16 20:12:25 +02:00
"condition_evaluator.ts",
feat(dev-infra): handle excluding files via globs in pullapprove (#36162) Updates the pullapprove verification script to handle cases of excluding globs from groups. PR Close #36162
2020-03-20 06:59:35 -07:00
"group.ts",
"logging.ts",
"parse-yaml.ts",
refactor(dev-infra): Add support for groups in the conditions evaluator (#38164) Conditions can refer to the groups array that is a list of the preceding groups. This commit adds support to the verification for those conditions. This commit also adds some tests to the parsing and condition matching to ensure everything works as expected. PR Close #38164
2020-07-20 11:53:26 -07:00
"pullapprove_arrays.ts",
"utils.ts",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 14:37:21 -08:00
"verify.ts",
],
build: remove rollup packaging from dev-infra (#35647) The dev-infra package currently uses rollup for packaging. This has been done initially as a way to workaround manifest paths being used in the AMD JavaScript output. The actual solution to this problem is setting module names that match the `package.json` name. This ensures that the package can be consumed correctly in Bazel, and through NPM. This allows us to get rid of the rollup bundling, and we don't need to hard-code which dependencies should be external or included. Additionally, tools that are part of `dev-infra` can now specify their external dependencies simply in the `package.json`. To reduce version duplication, and out-of-sync versions, a new genrule has been created that syncs the versions with the top-level project `package.json`. PR Close #35647
2020-03-17 12:58:17 +01:00
module_name = "@angular/dev-infra-private/pullapprove",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 14:37:21 -08:00
visibility = ["//dev-infra:__subpackages__"],
deps = [
feat(dev-infra): create format tool in @angular/dev-infra-private (#36726) Previously we used gulp to run our formatter, currently clang-format, across our repository. This new tool within ng-dev allows us to migrate away from our gulp based solution as our gulp solution had issue with memory pressure and would cause OOM errors with too large of change sets. PR Close #36726
2020-04-20 13:00:10 -07:00
"//dev-infra/utils",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 14:37:21 -08:00
"@npm//@types/minimatch",
"@npm//@types/node",
"@npm//@types/shelljs",
"@npm//@types/yaml",
feat(dev-infra): standard CLI commands using yargs (#36326) Creates a standard model for CLI commands provided by ng-dev. Allows for us to have any of the tools/scripts extend to be included in the ng-dev command, or be standalone using the same yargs parser. PR Close #36326
2020-03-26 10:45:09 -07:00
"@npm//@types/yargs",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 14:37:21 -08:00
"@npm//minimatch",
"@npm//shelljs",
"@npm//yaml",
feat(dev-infra): standard CLI commands using yargs (#36326) Creates a standard model for CLI commands provided by ng-dev. Allows for us to have any of the tools/scripts extend to be included in the ng-dev command, or be standalone using the same yargs parser. PR Close #36326
2020-03-26 10:45:09 -07:00
"@npm//yargs",
build: Add pullapprove verification tool to dev-infra-private package (#35911) Migrates pullapprove verification tool to be available in the dev-infra-private package PR Close #35911
2020-03-04 14:37:21 -08:00
],
)
refactor(dev-infra): Add support for groups in the conditions evaluator (#38164) Conditions can refer to the groups array that is a list of the preceding groups. This commit adds support to the verification for those conditions. This commit also adds some tests to the parsing and condition matching to ensure everything works as expected. PR Close #38164
2020-07-20 11:53:26 -07:00
ts_library(
name = "pullapprove_test_lib",
testonly = True,
srcs = glob(
["*.spec.ts"],
),
visibility = ["//visibility:private"],
deps = [
":pullapprove",
"@npm//@types/jasmine",
"@npm//@types/node",
"@npm//typescript",
],
)
jasmine_node_test(
name = "pullapprove_test",
srcs = [":pullapprove_test_lib"],
visibility = ["//visibility:private"],
)
Reference in New Issue Copy Permalink