honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(platform-browser): specify return type of parseEventName (#38089) 

This commit refactors the argument of the `parseEventName` function
to use an object with named properties instead of using an object indexer.

PR Close #38089
This commit is contained in:
Sonu Kapoor 2020-07-15 18:59:11 -04:00 committed by Andrew Kushnir
parent bb88c9fa3d
commit 0c2490368e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/platform-browser/src/dom/events/key_events.ts
View File

@ -111,7 +111,7 @@ export class KeyEventsPlugin extends EventManagerPlugin {
}); });
} }
static parseEventName(eventName: string): {[key: string]: string}|null { static parseEventName(eventName: string): {fullKey: string, domEventName: string}|null {
const parts: string[] = eventName.toLowerCase().split('.'); const parts: string[] = eventName.toLowerCase().split('.');
const domEventName = parts.shift(); const domEventName = parts.shift();
@ -136,7 +136,10 @@ export class KeyEventsPlugin extends EventManagerPlugin {
return null; return null;
} }
const result: {[k: string]: string} = {}; // NOTE: Please don't rewrite this as so, as it will break JSCompiler property renaming.
// The code must remain in the `result['domEventName']` form.
// return {domEventName, fullKey};
const result: {fullKey: string, domEventName: string} = {} as any;
result['domEventName'] = domEventName; result['domEventName'] = domEventName;
result['fullKey'] = fullKey; result['fullKey'] = fullKey;
return result; return result;