honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: exclude dev-app subpackage targets in material-unit-tests job (#32485) 

Ensures that the `material-unit-tests` job does not accidentally build
subpackages of the `src/dev-app` in the components repo. This is now
an issue because the components repository updated their dev-app
to use Bazel with more individual subpackages. These subpackages
are not excluded by the `--deleted_packages` flag.

For best practice, we should use the exclusion target pattern
instead of the undocumented `--deleted_packages` flag anyway.

PR Close #32485
This commit is contained in:
Paul Gschwendtner 2019-09-06 11:36:36 +02:00 committed by Matias Niemelä
parent f937f8f604
commit 7059f7af11
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/ci/run_angular_material_unit_tests.sh
View File

@ -31,6 +31,6 @@ yarn --cwd ${MATERIAL_REPO_TMP_DIR} add ${angular_dir}/dist/packages-dist-ivy-ao
# Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors. # Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors.
./scripts/circleci/setup_bazel_binary.sh ./scripts/circleci/setup_bazel_binary.sh
# Now actually run the tests. The dev-app target is excluded as it fails to compile due to # Now actually run the tests. The dev-app and all its subpackages are excluded as they fail
# limitations in Ivy's type checker (see FW-1352 and FW-1433) # to compile due to limitations in Ivy's type checker (see FW-1352 and FW-1433)
bazel test src/... --deleted_packages=//src/dev-app --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local --define=compile=aot bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local --define=compile=aot -- src/... -src/dev-app/...