honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(dev-infra): Correctly place comments in dockerfile (#41374)

Browse Source 
The doc in https://docs.docker.com/engine/reference/builder/#format says that
"Docker treats lines that begin with # as a comment, unless the line is a valid parser directive. A # marker anywhere else in a line is treated as an argument."

Fixes #41361

PR Close #41374
This commit is contained in:
Adem Simsek 2021-03-30 11:48:06 +02:00 committed by Alex Rickabaugh
parent ff9470b0a0
commit c6d9a193d6
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.devcontainer/recommended-Dockerfile
View File

@ -1,6 +1,8 @@
# Image metadata and config. # Image metadata and config.
FROM circleci/node:10-browsers # Ideally, the image version should be what we use on CI. # Ideally, the image version should be what we use on CI.
# See `executors > browsers-executor` in `.circleci/config.yml`. # See `executors > browsers-executor` in `.circleci/config.yml`.
FROM circleci/node:10-browsers
LABEL name="Angular dev environment" \ LABEL name="Angular dev environment" \
description="This image can be used to create a dev environment for building Angular." \ description="This image can be used to create a dev environment for building Angular." \
@ -16,8 +18,10 @@ USER root
# Configure `Node.js`/`npm` and install utilities. # Configure `Node.js`/`npm` and install utilities.
RUN npm config --global set user root RUN npm config --global set user root
RUN npm install --global yarn@latest # Ideally, the version should be what we use on CI.
# See `commands > overwrite_yarn` in `.circleci/config.yml`. # Ideally, the version should be what we use on CI.
# See `commands > overwrite_yarn` in `.circleci/config.yml`.
RUN npm install --global yarn@latest
# Go! (And keep going.) # Go! (And keep going.)