honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(ivy): root cause analysis for e2e tests in common (#28506) 

Adds root causes to the e2e test failures in `common`.

This PR resolves FW-1011.

PR Close #28506
This commit is contained in:
Kristiyan Kostadinov 2019-02-03 13:37:20 +01:00 committed by Matias Niemelä
parent 8f15cdbc7c
commit d4add5428b
2 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/examples/common/ngComponentOutlet/ts/e2e_test/ngComponentOutlet_spec.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {fixmeIvy} from '@angular/private/testing'; import {fixmeIvy, modifiedInIvy} from '@angular/private/testing';
import {$, ExpectedConditions, browser, by, element} from 'protractor'; import {$, ExpectedConditions, browser, by, element} from 'protractor';
import {verifyNoBrowserErrors} from '../../../../test-utils'; import {verifyNoBrowserErrors} from '../../../../test-utils';
@ -17,9 +17,7 @@ function waitForElement(selector: string) {
browser.wait(EC.presenceOf($(selector)), 20000); browser.wait(EC.presenceOf($(selector)), 20000);
} }
fixmeIvy( fixmeIvy('FW-1022: JitCompilerFactory creates incorrect compiler instance')
'unknown. Run "yarn bazel run packages/examples/common:devserver --define=compile=aot" ' +
'to debug')
.describe('ngComponentOutlet', () => { .describe('ngComponentOutlet', () => {
const URL = '/ngComponentOutlet'; const URL = '/ngComponentOutlet';
afterEach(verifyNoBrowserErrors); afterEach(verifyNoBrowserErrors);
@ -31,13 +29,14 @@ fixmeIvy(
expect(element.all(by.css('hello-world')).getText()).toEqual(['Hello World!']); expect(element.all(by.css('hello-world')).getText()).toEqual(['Hello World!']);
}); });
it('should render complete', () => { modifiedInIvy('Different behavior for projectableNodes in ViewContainerRef.createComponent')
browser.get(URL); .it('should render complete', () => {
waitForElement('ng-component-outlet-complete-example'); browser.get(URL);
expect(element.all(by.css('complete-component')).getText()).toEqual([ waitForElement('ng-component-outlet-complete-example');
'Complete: AhojSvet!' expect(element.all(by.css('complete-component')).getText()).toEqual([
]); 'Complete: AhojSvet!'
}); ]);
});
it('should render other module', () => { it('should render other module', () => {
browser.get(URL); browser.get(URL);

4
packages/examples/common/ngIf/ts/e2e_test/ngIf_spec.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {fixmeIvy} from '@angular/private/testing'; import {modifiedInIvy} from '@angular/private/testing';
import {$, ExpectedConditions, browser, by, element} from 'protractor'; import {$, ExpectedConditions, browser, by, element} from 'protractor';
import {verifyNoBrowserErrors} from '../../../../test-utils'; import {verifyNoBrowserErrors} from '../../../../test-utils';
@ -46,7 +46,7 @@ describe('ngIf', () => {
describe('ng-if-then-else', () => { describe('ng-if-then-else', () => {
let comp = 'ng-if-then-else'; let comp = 'ng-if-then-else';
fixmeIvy('unknown. Run "yarn bazel run packages/examples/common:devserver" to debug') modifiedInIvy('FW-1019: Design new API to replace static queries')
.it('should hide/show content', () => { .it('should hide/show content', () => {
browser.get(URL); browser.get(URL);
waitForElement(comp); waitForElement(comp);