ci: fix dev-infra incorrectly matching all ".bzl" files as codeowner (#32956)
The `dev-infra-framework` codeowners section is located after all the codeowner sections for the individual framework packages. This means that for certain wildcards, like `*.bzl` take precedence over the individual package sections (like of `/packages/bazel/**`). This can be observed in the following PR where `dev-infra` got requested for file changes to `@angular/bazel`. #32955. To fix this, we move the `dev-infra-framework` section before all individual framework package sections. This means that we only match files which are not matched by other patterns. Additionally a pattern for `*.BAZEL` has been added to the dev-infra section. This helps getting changes to `BUILD.bazel` files through easier as dev-infra can review those (Note: only for bazel files which are not matched by other patterns). PR Close #32956
This commit is contained in:
Paul Gschwendtner
Matias Niemelä
parent
f45c43188f
commit
d5b59009d4
|
|
@ -368,6 +368,44 @@
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
# ================================================
|
||||||
|
# Build, CI & Dev-infra Owners
|
||||||
|
# ================================================
|
||||||
|
|
||||||
|
/* @angular/dev-infra-framework
|
||||||
|
/.buildkite/** @angular/dev-infra-framework
|
||||||
|
/.circleci/** @angular/dev-infra-framework
|
||||||
|
/.devcontainer/** @angular/dev-infra-framework
|
||||||
|
/.github/** @angular/dev-infra-framework
|
||||||
|
/.vscode/** @angular/dev-infra-framework
|
||||||
|
/docs/BAZEL.md @angular/dev-infra-framework
|
||||||
|
/packages/* @angular/dev-infra-framework
|
||||||
|
/packages/examples/test-utils/** @angular/dev-infra-framework
|
||||||
|
/packages/private/** @angular/dev-infra-framework
|
||||||
|
/scripts/** @angular/dev-infra-framework
|
||||||
|
/third_party/** @angular/dev-infra-framework
|
||||||
|
/tools/build/** @angular/dev-infra-framework
|
||||||
|
/tools/cjs-jasmine/** @angular/dev-infra-framework
|
||||||
|
/tools/gulp-tasks/** @angular/dev-infra-framework
|
||||||
|
/tools/ngcontainer/** @angular/dev-infra-framework
|
||||||
|
/tools/npm/** @angular/dev-infra-framework
|
||||||
|
/tools/npm_workspace/** @angular/dev-infra-framework
|
||||||
|
/tools/public_api_guard/** @angular/dev-infra-framework
|
||||||
|
/tools/rxjs/** @angular/dev-infra-framework
|
||||||
|
/tools/size-tracking/** @angular/dev-infra-framework
|
||||||
|
/tools/source-map-test/** @angular/dev-infra-framework
|
||||||
|
/tools/symbol-extractor/** @angular/dev-infra-framework
|
||||||
|
/tools/testing/** @angular/dev-infra-framework
|
||||||
|
/tools/ts-api-guardian/** @angular/dev-infra-framework
|
||||||
|
/tools/tslint/** @angular/dev-infra-framework
|
||||||
|
/tools/validate-commit-message/** @angular/dev-infra-framework
|
||||||
|
/tools/yarn/** @angular/dev-infra-framework
|
||||||
|
/tools/* @angular/dev-infra-framework
|
||||||
|
*.BAZEL @angular/dev-infra-framework
|
||||||
|
*.bzl @angular/dev-infra-framework
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
# ================================================
|
# ================================================
|
||||||
# @angular/animations
|
# @angular/animations
|
||||||
# ================================================
|
# ================================================
|
||||||
|
|
@ -882,43 +920,6 @@ testing/** @angular/fw-test
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
# ================================================
|
|
||||||
# Build, CI & Dev-infra Owners
|
|
||||||
# ================================================
|
|
||||||
|
|
||||||
/* @angular/dev-infra-framework
|
|
||||||
/.buildkite/** @angular/dev-infra-framework
|
|
||||||
/.circleci/** @angular/dev-infra-framework
|
|
||||||
/.devcontainer/** @angular/dev-infra-framework
|
|
||||||
/.github/** @angular/dev-infra-framework
|
|
||||||
/.vscode/** @angular/dev-infra-framework
|
|
||||||
/docs/BAZEL.md @angular/dev-infra-framework
|
|
||||||
/packages/* @angular/dev-infra-framework
|
|
||||||
/packages/examples/test-utils/** @angular/dev-infra-framework
|
|
||||||
/packages/private/** @angular/dev-infra-framework
|
|
||||||
/scripts/** @angular/dev-infra-framework
|
|
||||||
/third_party/** @angular/dev-infra-framework
|
|
||||||
/tools/build/** @angular/dev-infra-framework
|
|
||||||
/tools/cjs-jasmine/** @angular/dev-infra-framework
|
|
||||||
/tools/gulp-tasks/** @angular/dev-infra-framework
|
|
||||||
/tools/ngcontainer/** @angular/dev-infra-framework
|
|
||||||
/tools/npm/** @angular/dev-infra-framework
|
|
||||||
/tools/npm_workspace/** @angular/dev-infra-framework
|
|
||||||
/tools/public_api_guard/** @angular/dev-infra-framework
|
|
||||||
/tools/rxjs/** @angular/dev-infra-framework
|
|
||||||
/tools/size-tracking/** @angular/dev-infra-framework
|
|
||||||
/tools/source-map-test/** @angular/dev-infra-framework
|
|
||||||
/tools/symbol-extractor/** @angular/dev-infra-framework
|
|
||||||
/tools/testing/** @angular/dev-infra-framework
|
|
||||||
/tools/ts-api-guardian/** @angular/dev-infra-framework
|
|
||||||
/tools/tslint/** @angular/dev-infra-framework
|
|
||||||
/tools/validate-commit-message/** @angular/dev-infra-framework
|
|
||||||
/tools/yarn/** @angular/dev-infra-framework
|
|
||||||
/tools/* @angular/dev-infra-framework
|
|
||||||
*.bzl @angular/dev-infra-framework
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
# ================================================
|
# ================================================
|
||||||
# Material CI
|
# Material CI
|
||||||
# ================================================
|
# ================================================
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue