honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: onlyInIvy tests should not be triggered for FIND_PASSING_TESTS mode (#28036) 

Previous to this change, there was a lot of noise when
trying to find tests in FIND_PASSING_TESTS mode because
tests marked "onlyInIvy" were also listed as "already
passing". Since these tests are not "fixmes" that need
to be enabled, it is not useful to have them listed.

This commit removes "onlyInIvy" tests from consideration
when running in this manual mode. The tests should still
run on CI by default (since FIND_PASSING_TESTS mode will
be false).

PR Close #28036
This commit is contained in:
Kara Erickson 2019-01-09 20:53:56 -08:00 committed by Andrew Kushnir
parent ee60c7679a
commit dffcb9cda3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/private/testing/src/ivy_test_selectors.ts
View File

@ -94,7 +94,7 @@ export function obsoleteInIvy(reason: string): JasmineMethods {
* ```
*/
export function onlyInIvy(reason: string): JasmineMethods {
return ivyEnabled ? PASSTHROUGH : IGNORE;
return ivyEnabled && !FIND_PASSING_TESTS ? PASSTHROUGH : IGNORE;
}
/**