closes#2110
The lifecycle-hooks provided by router-deprecated has already been removed in the router, the router now uses guards rather than lifecycle-hooks to achieve the same work.
* docs(toh-5): review and update/resync Dart
**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**
This is preparatory work for #2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (#2018).
By the same token it contributed to a post-RC5 resync (#2077). Other
key changes:
Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.
TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.
Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).
* docs(toh-5): edits after doing tutorial
- Some adjustments following actually doing the tutorial. In some cases code shown (e.g. this is what file foo should look like now) didn't match what the user would have. E.g., lingering @Input on the hero property.
- Fixed some lingering deprecated-router prose elements on TS side (e.g., still referring to a route by the old string names like `HeroDetail`).
- Added extra step to `app.component.ts` creation rather than having a critical-call-out later on.
- Reorder some prose for better harmony between TS and Dart prose (also improves the flow).
- Moved the `styleUrls` call-out to the point of first use.
* post-review changes
* more post-review changes
* toh-6 cache update
* chore(toh-5): improve e2e test coverage
Improved test coverage. Also updated tests to make use of async/await
(so tests are more readable).
* lint feedback
* toh-6: trim spaces from cache file to simplify diff
* toh-6: copy latest over cache before editing latest
* docs(toh-6): post-RC5 Dart resync and TS fixes
Contributes to #2077.
TS-side changes include:
- Merged three versions of `app/app.module{,1,2}.ts` into a single file
and used docregions instead.
- Misnamed files:
- `rxjs-operators.ts` -> `rxjs-extensions.ts`
- `hero-search.service.html` -> `hero-search.component.html`
- Fixed BAD FILENAME error.
Lint reports no errors and toh-6 e2e tests pass.
* docs(router): fix markdown and example mixin cleanup
- Fixed: markdown text not under `:marked` region (and so that text was
not showing up in the generated html).
- Fixed: code excerpt title `constructor` -> `isSelected`.
- Cleanup of all makeExample mixin uses.
This cleanup will help make it easier to record differences with the
deprecated router chapter (which must have app-relative makeExample
paths).
* post-review updates
Found another instance of markdown (a heading) outside of a `:marked` region.
* docs(template-syntax/dart): enhancements to example code
Enhancements to `NgStyle` section in support of its API docs.
- Add feature supporting interactive update of a paragraph’s style.
- Add full type declarations.
- Replace bogus implementation of `getStyles()`.
* dartfmt updates
* docs(quickstart): post-RC5 Dart resync
- Resync Dart QS prose with TS, post RC5.
- Added to-be-shared Jade `var` definitions to `_util-fns.jade`.
- Delete cached QS jade file.
- Eliminate the stub file `styles.1.css` in favor of a `docregion` in
the main `styles.css`.
This commit requires a `gulp add-example-boilerplate` after pulling it in.
Contributes to #2077.
* post-review edits
closes#1751
Move additional styles from `sample.css` to `hero-search.component.css`.
Edit tutorial to reflect the removal of `sample.css` and the change to `heroes.component.css`.
Edit tutorial to reflect the addition of `hero-search.component.css` file.
Edit `hero-search.component.ts` to include styles from `hero-search.component.css`.
Remove reference to `/public/docs/_examples/toh-6/ts/sample.css` from `/public/docs/_examples/toh-6/ts/index.html`.
closes#2008
Changes:
- Drop `asObservable()` since it is deprecated in RxJS 5 (see the
[migration
guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat
ors-renamed-or-removed)).
- Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At
best it is interpreted as a regex op that serves no purpose, at worst,
it gets interpreted as a space (cf. [HTML 4.01 section
17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4)
).
- Rename `searchSubject` to `searchTerms`
- Other minor tweaks to prose.
This work is in preparation for #1924.
Note: toh-6 tests pass.
Waterloo ENGL 210 J Student
Changed order of text in pipe operator to introduce pipe operator
Changed word choice/word location in pope operator
Added : before examples to keep consistent
Waterloo ENGL 210J Student
Line 44: Changed tense
Line 54: Changed wording of second sentence to not start with 'and'. Added DOM meaning (Document Object Model)
closes#1940
Note: tests are identical to those of toh-2.
Contributes to #1619.
Supersedes #1785.
Suites passed:
- public/docs/_examples/toh-4/dart
- public/docs/_examples/toh-4/ts
closes#1939
Contributes to #1619.
Note: tests are identical to those of toh-2.
Suites passed:
- public/docs/_examples/toh-3/dart
- public/docs/_examples/toh-3/ts
* chore(ng2/dart): update from beta.1x to beta.18
Update made to all `pubspec.yaml` files and to relevant prose.
Note that pipes was back a beta.15; the rest were at beta.17.
* chore(pipes/dart): update ngFor microsyntax and transform method param
Updates to pipe example source code:
- Pipe `transform()` method parameters
- `ngFor` microsyntax, from `#` to `let`
Misc fixes to problems with the tutorial examples, as detected by the new e2e tests. Now the toh-4 index.html is identical to those of the previous parts.
Fixes#1609.
Trotyl Yu
Sarun Intaralawan
Ward Bell
Patrice Chalin
Drew Hintz
Jesús Rodríguez
Karl Herrick
Patrice Chalin
Fredy Treboux
Aysegul Yonet
Brandon Roberts
Benjamin Dopplinger
Naomi Black
Peter Bacon Darwin
Matt Ezell
Ciro Nunes
wajdibr
Adam
Kathy Walrath
Adão Júnior
Torgeir Helgevold
crisbeto
Thomas Burleson
Gerard Sans
Eric Jimenez
Ignat Shining
Kyle Roberts
Fatima Remtullah
Michael
Tero Parviainen
sgmills365
amandaegraham