Andrius
1f79e624d1
build: typescript 3.7 support ( #33717 )
...
This PR updates TypeScript version to 3.7 while retaining compatibility with TS3.6.
PR Close #33717
2020-01-14 16:42:21 -08:00
atscott
538d0446b5
Revert "refactor: handle breaking changes in rules_nodejs 1.0.0 ( #34589 )" ( #34730 )
...
This reverts commit 9bb349e1c8
.
PR Close #34730
2020-01-10 14:12:15 -08:00
atscott
6e5774b9a0
Revert "build: update to rules nodejs 1.0.1 ( #34589 )" ( #34730 )
...
This reverts commit 8042433cb0
.
PR Close #34730
2020-01-10 14:12:15 -08:00
atscott
5e60215470
Revert "test: handle bootstrap templated_args in jasmine_node_test defaults.bzl ( #34589 )" ( #34730 )
...
This reverts commit da4782e67f
.
PR Close #34730
2020-01-10 14:12:15 -08:00
atscott
b788c36909
Revert "build: add a before-all-other bootstrap script that patches require ( #34589 )" ( #34730 )
...
This reverts commit c3e8439954
.
PR Close #34730
2020-01-10 14:12:14 -08:00
atscott
24679d8676
Revert "build: derive ts_library dep from jasmine_node_test boostrap label if it ends in `_es5` ( #34589 )" ( #34730 )
...
This reverts commit 79a0d007b4
.
PR Close #34730
2020-01-10 14:12:14 -08:00
Greg Magolan
79a0d007b4
build: derive ts_library dep from jasmine_node_test boostrap label if it ends in `_es5` ( #34589 )
...
PR Close #34589
2020-01-10 08:32:00 -08:00
Greg Magolan
c3e8439954
build: add a before-all-other bootstrap script that patches require ( #34589 )
...
This removes the churn in the existing bootstrap scripts.
PR Close #34589
2020-01-10 08:32:00 -08:00
Greg Magolan
da4782e67f
test: handle bootstrap templated_args in jasmine_node_test defaults.bzl ( #34589 )
...
PR Close #34589
2020-01-10 08:31:59 -08:00
Greg Magolan
8042433cb0
build: update to rules nodejs 1.0.1 ( #34589 )
...
This brings in a few minor fixes including a better way to patch require for bootstrap scripts.
PR Close #34589
2020-01-10 08:31:59 -08:00
Greg Magolan
9bb349e1c8
refactor: handle breaking changes in rules_nodejs 1.0.0 ( #34589 )
...
The major one that affects the angular repo is the removal of the bootstrap attribute in nodejs_binary, nodejs_test and jasmine_node_test in favor of using templated_args --node_options=--require=/path/to/script. The side-effect of this is that the bootstrap script does not get the require.resolve patches with explicitly loading the targets _loader.js file.
PR Close #34589
2020-01-10 08:31:59 -08:00
Paul Gschwendtner
6d3a25d897
ci: run acceptance tests on saucelabs with ivy ( #34277 )
...
Currently we only run Saucelabs on PRs using the legacy View Engine
build. Switching that build to Ivy is not trivial and there are various
options:
1. Updating the R3 switches to use POST_R3 by default. At first glance,
this doesn't look easy because the current ngtsc switch logic seems to
be unidirectional (only PRE_R3 to POST_R3).
2. Updating the legacy setup to run with Ivy. This sounds like the easiest
solution at first.. but it turns out to be way more complicated. Packages
would need to be built with ngtsc using legacy tools (i.e. first building
the compiler-cli; and then building packages) and View Engine only tests
would need to be determined and filtered out. Basically it will result in
re-auditing all test targets. This is contradictory to the fact that we have
this information in Bazel already.
3. Creating a new job that runs tests on Saucelabs with Bazel. We specify
fine-grained test targets that should run. This would be a good start
(e.g. acceptance tests) and also would mean that we do not continue maintaining
the legacy setup..
This commit implements the third option as it allows us to move forward
with the general Bazel migration. We don't want to spend too much time
on our legacy setup since it will be removed anyway in the future.
PR Close #34277
2019-12-16 07:43:41 -08:00
JiaLiPassion
539d8f09e0
fix: implement Symbol.specics of Promise ( #34162 )
...
Close #34105 , #33989
PR Close #34162
2019-12-03 10:29:04 -08:00
Greg Magolan
7f2885ec7d
build: update zone.js to use the new rollup_bundle ( #33329 )
...
PR Close #33329
2019-11-15 10:50:14 -08:00
Joey Perrott
e6045ee0b7
build: fixes for cross-platform RBE ( #33708 )
...
The earlier update to nodejs rules 0.40.0 fixes the cross-platform RBE issues with nodejs_binary. This commit adds a work-around for rules_webtesting cross-platform RBE issues.
PR Close #33708
2019-11-15 10:49:55 -08:00
Martin Probst
5332b04f35
build: TypeScript 3.6 compatibility. ( #32908 )
...
This PR updates Angular to compile with TypeScript 3.6 while retaining
compatibility with TS3.5. We achieve this by inserting several `as any`
casts for compatiblity around `ts.CompilerHost` APIs.
PR Close #32908
2019-10-03 09:09:11 -07:00
Greg Magolan
c1346462db
build: update to nodejs rules 0.37.1 ( #32151 )
...
This release includes a ts_config runfiles fix so also cleaning up the one line work-around from #31943 .
This also updates to upstream rules_webtesting browser repositories load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories") to fix a breaking change in the chromedriver distro. This bumps up the version of chromium to the version here: https://github.com/bazelbuild/rules_webtesting/blob/master/web/versioned/browsers-0.3.2.bzl
PR Close #32151
2019-09-25 11:29:12 -07:00
JiaLiPassion
a91a55a6d2
fix(zone.js): browser-legacy should not reference Zone ( #32016 )
...
PR Close #32016
2019-08-13 09:53:00 -07:00
JiaLiPassion
96cbcd6da4
feat(zone.js): support Promise.allSettled ( #31849 )
...
PR Close #31849
2019-08-05 09:54:37 -07:00
Alex Eagle
975917bafd
Revert "fix(zone.js): don't wrap uncaught promise error. ( #31443 )" ( #31918 )
...
This reverts commit 2bb9a65351
.
It breaks tests in google3 which rely on the error handling behavior.
PR Close #31918
2019-07-30 15:03:49 -07:00
JiaLiPassion
4f42eb4e77
test(zone.js): add test codes to ensure not include sourcemap ( #31892 )
...
PR Close #31892
2019-07-30 13:00:26 -07:00
JiaLiPassion
c7542a1d09
fix(zone.js): don't fire unhandledrejection if Zone handled error ( #31718 )
...
Close #31701
PR Close #31718
2019-07-24 16:10:59 -07:00
JiaLiPassion
2c402d5c99
fix(zone.js): handle MSPointer event correctly ( #31722 )
...
Close #31699
PR Close #31722
2019-07-24 14:42:49 -07:00
JiaLiPassion
35a025fbca
fix(zone.js): patch shadydom ( #31717 )
...
Close #31686
PR Close #31717
2019-07-24 14:42:14 -07:00
JiaLiPassion
716af1059c
fix(zone.js): move property patch to legacy ( #31660 )
...
Close #31659
PR Close #31660
2019-07-24 14:36:43 -07:00
JiaLiPassion
a182714703
fix(zone.js): should remove on symbol property after removeAllListeners ( #31644 )
...
Close #31643
PR Close #31644
2019-07-24 14:35:37 -07:00
JiaLiPassion
17b32b5fd4
fix(zone.js): hook should set correct current zone ( #31642 )
...
Close #31641
PR Close #31642
2019-07-24 14:34:58 -07:00
JiaLiPassion
87ce4e997b
fix(zone.js): zone-mix should import correct browser module ( #31628 )
...
Close #31626
PR Close #31628
2019-07-24 14:33:07 -07:00
JiaLiPassion
2bb9a65351
fix(zone.js): don't wrap uncaught promise error. ( #31443 )
...
Close #27840
PR Close #31443
2019-07-24 14:31:17 -07:00
JiaLiPassion
6b51ed29ef
fix(zone.js): __load_patch and __symbol__ should be in zone_extern for closure compiler ( #31350 )
...
PR Close #31350
2019-07-24 13:30:01 -07:00
Paul Gschwendtner
60f58bf051
refactor: ensure zone.js can be built with typescript strict flag ( #30993 )
...
As part of FW-1265, the `zone.js` package is made compatible
with the TypeScript `--strict` flag. Read more about the strict flag [here](https://www.typescriptlang.org/docs/handbook/compiler-options.html )
PR Close #30993
2019-07-18 14:21:26 -07:00
Greg Magolan
a4a423a083
build: fix build failures with worker mode cache and @types/events ( #31325 )
...
Errors observed only in tests on CircleCI — was not reproducible locally.
```
ERROR: /home/circleci/ng/packages/http/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/http/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/http/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts.
ERROR: /home/circleci/ng/packages/benchpress/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/benchpress/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/benchpress/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts
ERROR: C:/codefresh/volume/angular/packages/compiler/test/css_parser/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/compiler/test/css_parser:css_parser_lib failed (Exit 1):
tsc_wrapped.exe failed: error executing command
cd C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular
SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
SET RUNFILES_MANIFEST_ONLY=1
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped.exe @@bazel-out/x64_windows-fastbuild/bin/packages/compiler/test/css_parser/css_parser_lib_es5_tsconfig.json
Execution platform: @bazel_tools//platforms:host_platform
Compilation failed Error: missing input digest for C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular/external/npm/node_modules/@types/events/index.
d.ts
```
PR Close #31325
2019-07-01 14:16:43 -07:00
George Kalpakas
3851544674
style: fix code style in several files ( #31295 )
...
These files have not been formatted properly, due to issues in the
`gulp format*` tasks. See previous commits (or #31295 ) for more details.
PR Close #31295
2019-06-26 13:29:29 -07:00
Alex Rickabaugh
26a85a82ff
Revert "build: fix build failures with worker mode cache and @types/events ( #31019 )" ( #31267 )
...
This reverts commit 6ba42f1da4
.
Reason: this causes failures in g3 with i18n extraction. See #31267 .
PR Close #31267
2019-06-25 14:36:00 -07:00
Greg Magolan
6ba42f1da4
build: fix build failures with worker mode cache and @types/events ( #31019 )
...
Errors observed only in tests on CircleCI — was not reproducible locally.
```
ERROR: /home/circleci/ng/packages/http/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/http/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/http/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts.
ERROR: /home/circleci/ng/packages/benchpress/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/benchpress/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/benchpress/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts
ERROR: C:/codefresh/volume/angular/packages/compiler/test/css_parser/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/compiler/test/css_parser:css_parser_lib failed (Exit 1):
tsc_wrapped.exe failed: error executing command
cd C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular
SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
SET RUNFILES_MANIFEST_ONLY=1
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped.exe @@bazel-out/x64_windows-fastbuild/bin/packages/compiler/test/css_parser/css_parser_lib_es5_tsconfig.json
Execution platform: @bazel_tools//platforms:host_platform
Compilation failed Error: missing input digest for C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular/external/npm/node_modules/@types/events/index.
d.ts
```
PR Close #31019
2019-06-25 10:21:07 -07:00
Joey Perrott
34eaafdf40
build: correct zone.js bazel test visibilty rule ( #31175 )
...
PR Close #31175
2019-06-20 16:05:21 -07:00
Alex Eagle
bf7d046269
style: fix bazel lint in zone.js ( #31172 )
...
Update to latest buildifier to fix a false positive error
PR Close #31172
2019-06-20 12:44:06 -07:00
JiaLiPassion
5eb7426216
build: move zone.js to angular repo ( #30962 )
...
PR Close #30962
2019-06-20 11:27:39 -07:00