honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
10,304 Commits 5 Branches 1 Tag 210 MiB
Commit Graph

1585 Commits

Author SHA1 Message Date
Igor Minar acbfb9eb4d build: fix angular.json that was missing keys due to cli bugs (#23234) 
https://github.com/angular/angular-cli/issues/10225
https://github.com/angular/angular-cli/issues/10226

PR Close #23234
 2018-04-17 14:09:02 -07:00
Igor Minar d35f84a167 build(aio): update to @angular/material@6.0.0-rc.1 (#23234) 
PR Close #23234
 2018-04-17 14:09:02 -07:00
Igor Minar 87e9f333d4 build(aio): update to @angular/material@5.2.4 (#23234) 
PR Close #23234
 2018-04-17 14:09:02 -07:00
Igor Minar fc5af69fb2 build(aio): update to @angular/cli@6.0.0-rc.2 + project layout update (#23234) 
project layout was updated using:
yarn ng update @angular/cli --migrate-only --from=1.7.3

PR Close #23234
 2018-04-17 14:09:02 -07:00
Igor Minar 81ccb718b1 build(aio): upgrade to @angular/*@6.0.0-rc.3 (#23234) 
PR Close #23234
 2018-04-17 14:09:02 -07:00
Igor Minar 0c56dfadef build(aio): upgrade to @angular/*@6.0.0-rc.2 (#23234) 
PR Close #23234
 2018-04-17 14:09:02 -07:00
George Kalpakas 99f8e10809 ci(aio): fix `aio-monitoring` tests (#23390) 
Previously, we were running the e2e tests from master against
`https://angular.io` (deployed from the stable branch). Often the e2e
tests from master do not apply to the stable branch, since the app has
deviated slightly.

This commit fixes this by stop running the full e2e tests against the
deployed versions, but a smaller set of "smoke tests", which check basic
functionality that is less likely to change between versions.

PR Close #23390
 2018-04-17 13:45:38 -07:00
George Kalpakas d665d9a18c refactor(aio): rename directory (tests/deployment-config --> tests/deployment) (#23390) 
PR Close #23390
 2018-04-17 13:45:38 -07:00
George Kalpakas 8b2101be9f refactor(aio): rename spec file (#23390) 
PR Close #23390
 2018-04-17 13:45:38 -07:00
George Kalpakas 0d56cee9e1 refactor(aio): rename yarn script (deployment-config-test --> redirects-test) (#23390) 
PR Close #23390
 2018-04-17 13:45:38 -07:00
Anuj 010a4efa8c docs(aio): Fixed typo in 'comparing observables -> Observabled compared (#23407) 
to arrays' section.

PR Close #23407
 2018-04-17 13:43:45 -07:00
Eyal Cherevatzki c3280b2c2f docs(aio): change `HeroService` to `MessagesComponent` (#23397) 
Someone probably forgot to change this when coping the sentence from a previous section.

PR Close #23397
 2018-04-16 09:01:58 -07:00
Eyal Cherevatzki d11b249d36 docs(aio): change `HeroDetailsComponent` to `HeroDetailComponent` (#23397) 
For the sake of consistency, change `HeroDetailsComponent` to `HeroDetailComponent`.

PR Close #23397
 2018-04-16 09:01:58 -07:00
Vani 9c29127723 docs: document how to enable service worker using ng add command (#23348) 
PR Close #23348
 2018-04-16 08:57:13 -07:00
Tiep Phan fd1c39ce42 docs: update lifecycle hooks section in cheatsheet (#23320) 
PR Close #23320
 2018-04-15 23:44:44 -07:00
systemallica 896811df64 docs(aio): add missing word in the Component metadata section (#23384) 
PR Close #23384
 2018-04-15 23:36:55 -07:00
Brandon Roberts 490772e680 docs(aio): Update file tree to match Angular CLI V6 structure (#23367) 
PR Close #23367
 2018-04-13 14:19:16 -07:00
George Kalpakas 08325aaffc feat(service-worker): add support for configuring navigations URLs (#23339) 
The ServiceWorker will redirect navigation requests that don't match any
`asset` or `data` group to the specified index file. The rules for a
request to be classified as a navigation request are as follows:
1. Its `mode` must be `navigation`.
2. It must accept a `text/html` response.
3. Its URL must match certain criteria (see below).

By default, a navigation request can have any URL except for:
1. URLs containing `__`.
2. URLs to files (i.e. containing a file extension in the last path
   segment).

While these rules are fine in many cases, sometimes it is desirable to
configure different rules for the URLs of navigation requests (e.g.
ignore specific URLs and pass them through to the server).

This commit adds support for specifying an optional `navigationUrls`
list in `ngsw-config.json`, which contains URLs or simple globs
(currently only recognizing `!`, `*` and `**`).
Only requests whose URLs match any of the positive URLs/patterns and
none of the negative ones (i.e. URLs/patterns starting with `!`) will be
considered navigation requests (and handled accordingly by the SW).

(This is an alternative implementation to #23025.)

Fixes #20404

PR Close #23339
 2018-04-13 13:13:36 -07:00
George Kalpakas d1e716b2cb docs(service-worker): minor fixes/improvements (#23339) 
PR Close #23339
 2018-04-13 13:13:36 -07:00
Rafael 639d52fe71 refactor: ensure all 'TODO's are consistent (#23252) 
PR Close #23252
 2018-04-13 13:11:01 -07:00
George Kalpakas eac36d7e1a test(aio): fix `DocViewerComponent` tests (#23359) 
Obsolete assertions left over from #23249.

PR Close #23359
 2018-04-13 08:06:19 -07:00
George Kalpakas 0224f1aaf3 refactor(aio): remove file that should not be tracked (#23359) 
PR Close #23359
 2018-04-13 08:06:19 -07:00
Rob Wormald 74b203a55e docs(elements): add ng-add docs to elements guide (#23350) 
PR Close #23350
 2018-04-13 00:50:04 -07:00
Amit Portnoy c2a53bbf61 fix(aio): remove additional 'googlebot' reference (#23249) 
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Close #23249
 2018-04-13 00:35:29 -07:00
Suguru Inatomi 3bd682f432 docs(aio): Add link to Japanese localization (#20630) 
PR Close #20630
 2018-04-13 00:26:12 -07:00
Juan Camilo Giraldo Chaverra 221ae6998a docs(aio): fix typo on AOT compiler section 2018-04-13 00:06:26 -07:00
Michael Huang f958293205 docs(aio): update text InMemoryWebApiModule to HttpClientInMemoryWebApiModule (#23285) 
PR Close #23285
 2018-04-12 23:17:19 -07:00
Jeremy Attali 993eeababb docs: fix typo in injected variable name (#23315) 
The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.

PR Close #23315
 2018-04-12 23:16:52 -07:00
Pete Bacon Darwin aae437cb1e build(aio): implement rules to prevent short parameter names (#22759) 
PR Close #22759
 2018-04-12 00:06:49 -07:00
Pete Bacon Darwin fa11d7822c build(aio): create minLength content rule (#22759) 
This rule can be used to ensure that properties contain a minimum
number of characters.

PR Close #22759
 2018-04-12 00:06:49 -07:00
Pete Bacon Darwin 1619160c8a build(aio): implement rules to prevent headings in content (#22759) 
* No headings are allowed in `description` and `shortDescription`
* Only heading level 3 is allowed in `usageNotes`

PR Close #22759
 2018-04-12 00:06:49 -07:00
Pete Bacon Darwin 7a8c58162c build(aio): create noMarkdownHeadings content rule (#22759) 
This content rule can check what markdown headings
appear in content properties.

PR Close #22759
 2018-04-12 00:06:49 -07:00
Pete Bacon Darwin e0ae74d40e build(aio): add checkContentRules processor (#22759) 
This processor will enable us to write rules about
how the content should appear, such as:

* no headings in markdown content
* only one sentence per line
* no single character parameter names
* etc.

PR Close #22759
 2018-04-12 00:06:49 -07:00
Igor Minar 7e8cee6b61 build: fix aio size tracking, we need to use node_modules local to aio (#23328) 
This fixes an issue introduced by 4f0cae0676 which removed firebase from the root node_modules.

PR Close #23328
 2018-04-11 23:14:23 -07:00
Igor Minar ee145790d7 build(aio): fix scripts/test-production.sh file permission issue 
it needs to be executable for CI tests to run.
 2018-04-10 18:26:10 -07:00
JiaLi.Passion 30a6861fd0 build: update zone.js to 0.8.26 to fix some regression bugs (#23227) 
PR Close #23227
 2018-04-09 15:16:40 -07:00
Judy Bogart 1fac5f4eb1 docs: recommend best practice for providers (#22934) 
PR Close #22934
 2018-04-06 21:49:34 -07:00
Rob Wormald eb9968ab2a docs(elements): use Angular Elements naming in nav (#23213) 
PR Close #23213
 2018-04-05 16:32:57 -07:00
Anuj Jain b5f41f2c35 docs: fixed live example for the lifecycle hooks. (#23201) 
PR Close #23201
 2018-04-05 16:29:38 -07:00
George Kalpakas 3b607e60e9 refactor(aio): remove unused images (#23018) 
PR Close #23018
 2018-04-05 10:12:09 -07:00
George Kalpakas b874501025 docs(aio): update `live-example` docs in authors style guide (#23018) 
PR Close #23018
 2018-04-05 10:12:09 -07:00
George Kalpakas ce43e96d49 ci(aio): upload the preview before checking the bundle sizes (#23123) 
This makes the preview available even if the bundle sizes are out of
limits.

PR Close #23123
 2018-04-05 10:10:59 -07:00
George Kalpakas 79cecf9a5e fix(aio): update trusted GitHub teams (angular-core --> team) (#23181) 
PR Close #23181
 2018-04-05 10:07:13 -07:00
Pete Bacon Darwin 381da1af45 build(aio): move "optional" and "default" to end of param description (#23062) 
PR Close #23062
 2018-04-05 09:25:15 -07:00
Igor Minar 5db9ab12c0
docs: fix skipTemplateCodeGen -> skipTemplateCodegen typo in the AOT compiler guide 2018-04-04 23:12:28 -07:00
Igor Minar bf88c5c9f8 build: configure angular-cli projects to use yarn by default (#23149) 
PR Close #23149
 2018-04-04 17:47:47 -07:00
Pete Bacon Darwin 6dd8f6efe4 docs(aio): remove invalid nav item (#23175) 
The `custom-elements` guide page was renamed to `elements` in ff34d5ea7.
That commit also added a new nav item for the renamed file, so this item is
no longer valid.

PR Close #23175
 2018-04-04 14:32:14 -07:00
Pete Bacon Darwin 5b6e59cfb3 build(aio): fail the doc-gen if the nav is invalid (#23175) 
PR Close #23175
 2018-04-04 14:32:14 -07:00
JiaLi.Passion c560423b52 build: upgrade zone.js (#23108) 
PR Close #23108
 2018-04-04 08:24:02 -07:00
Vani 4506230fbb docs: update contents to recommend new way of defining providers (#23076) 
PR Close #23076
 2018-04-03 12:32:59 -07:00
Vani 5671ae6a58 docs: add tree-shakable providers doc (#23027) 
PR Close #23027
 2018-04-03 12:32:39 -07:00
Matias Niemelä 18ac228a27 docs: change examples within services to be tree-shakeable (#23070) 
PR Close #23070
 2018-04-03 10:48:52 -07:00
Igor Minar 62e6e21895 build(aio): update to rxjs@6.0.0-rc.0 (#23106) 
-rw-r--r--  1 iminar  primarygroup    2774 Mar 30 17:23 dist/announcement-bar.module.94664978458f4bcdad0e.chunk.js
-rw-r--r--  1 iminar  primarygroup    8081 Mar 30 17:23 dist/api-list.module.0080b5cc2e6a0e0cb4e0.chunk.js
-rw-r--r--  1 iminar  primarygroup    3963 Mar 30 17:23 dist/code-example.module.a71be2c11f00a30159ae.chunk.js
-rw-r--r--  1 iminar  primarygroup   29367 Mar 30 17:23 dist/code-tabs.module.91c45e5c6e7bc37a7ae3.chunk.js
-rw-r--r--  1 iminar  primarygroup   18647 Mar 30 17:23 dist/common.ba5d418531a81244d32a.chunk.js
-rw-r--r--  1 iminar  primarygroup    6719 Mar 30 17:23 dist/contributor-list.module.3f67eb8916b4b5d9553b.chunk.js
-rw-r--r--  1 iminar  primarygroup    1009 Mar 30 17:23 dist/current-location.module.5b1b839219a3afa4821c.chunk.js
-rw-r--r--  1 iminar  primarygroup   10037 Mar 30 17:23 dist/expandable-section.module.e990983253a804b8680b.chunk.js
-rw-r--r--  1 iminar  primarygroup    1642 Mar 30 17:23 dist/file-not-found-search.module.3ebb2c728ee873e1124f.chunk.js
-rw-r--r--  1 iminar  primarygroup    1971 Mar 30 17:23 dist/inline.966da76300859bd75965.bundle.js
-rw-r--r--  1 iminar  primarygroup    5905 Mar 30 17:23 dist/live-example.module.db0fa04009ecb3863ec8.chunk.js
-rw-r--r--  1 iminar  primarygroup  565539 Mar 30 17:23 dist/main.4962a0cf09dd39042cdb.bundle.js
-rw-r--r--  1 iminar  primarygroup   40272 Mar 30 17:23 dist/polyfills.60722fb8dd6546cb465e.bundle.js
-rw-r--r--  1 iminar  primarygroup   14886 Mar 30 17:23 dist/prettify.04d149a0484032073703.chunk.js
-rw-r--r--  1 iminar  primarygroup    4840 Mar 30 17:23 dist/resource-list.module.7d9223ca5f7ae5ce9d48.chunk.js
-rw-r--r--  1 iminar  primarygroup   54001 Mar 30 17:23 dist/worker-basic.min.js

PR Close #23106
 2018-04-03 10:00:23 -07:00
jenniferfell a4bf5621ed docs: add reference to ng add in tutorial and quick reference (#23130) 
PR Close #23130
 2018-04-03 07:38:47 -07:00
Judy Bogart ff34d5ea7a docs: add custom elements documentation (#22966) 
PR Close #22966
 2018-04-02 14:13:46 -07:00
Igor Minar 43d62029f0 build(aio): update to angular@6.0.0-rc.1 (#23101) 
-rw-r--r--  1 iminar  primarygroup    2774 Mar 30 15:01 dist/announcement-bar.module.94664978458f4bcdad0e.chunk.js
-rw-r--r--  1 iminar  primarygroup    8081 Mar 30 15:01 dist/api-list.module.0080b5cc2e6a0e0cb4e0.chunk.js
-rw-r--r--  1 iminar  primarygroup    3963 Mar 30 15:01 dist/code-example.module.a71be2c11f00a30159ae.chunk.js
-rw-r--r--  1 iminar  primarygroup   29367 Mar 30 15:01 dist/code-tabs.module.91c45e5c6e7bc37a7ae3.chunk.js
-rw-r--r--  1 iminar  primarygroup   18647 Mar 30 15:01 dist/common.ba5d418531a81244d32a.chunk.js
-rw-r--r--  1 iminar  primarygroup    6719 Mar 30 15:01 dist/contributor-list.module.3f67eb8916b4b5d9553b.chunk.js
-rw-r--r--  1 iminar  primarygroup    1009 Mar 30 15:01 dist/current-location.module.5b1b839219a3afa4821c.chunk.js
-rw-r--r--  1 iminar  primarygroup   10037 Mar 30 15:01 dist/expandable-section.module.e990983253a804b8680b.chunk.js
-rw-r--r--  1 iminar  primarygroup    1642 Mar 30 15:01 dist/file-not-found-search.module.3ebb2c728ee873e1124f.chunk.js
-rw-r--r--  1 iminar  primarygroup    1971 Mar 30 15:01 dist/inline.966da76300859bd75965.bundle.js
-rw-r--r--  1 iminar  primarygroup    5905 Mar 30 15:01 dist/live-example.module.db0fa04009ecb3863ec8.chunk.js
-rw-r--r--  1 iminar  primarygroup  567849 Mar 30 15:01 dist/main.b630be1eaedf8196652b.bundle.js
-rw-r--r--  1 iminar  primarygroup   40272 Mar 30 15:01 dist/polyfills.60722fb8dd6546cb465e.bundle.js
-rw-r--r--  1 iminar  primarygroup   14886 Mar 30 15:01 dist/prettify.04d149a0484032073703.chunk.js
-rw-r--r--  1 iminar  primarygroup    4840 Mar 30 15:01 dist/resource-list.module.7d9223ca5f7ae5ce9d48.chunk.js
-rw-r--r--  1 iminar  primarygroup   54001 Mar 30 15:01 dist/worker-basic.min.js

PR Close #23101
 2018-03-30 17:29:39 -07:00
Igor Minar 3df811767e build(aio): upgrade to rxjs@6.0.0-beta.4 (#23101) 
PR Close #23101
 2018-03-30 17:29:39 -07:00
Igor Minar 9c7805be2f build(aio): pin aio to typescript ~2.7.2 (#23101) 
PR Close #23101
 2018-03-30 17:29:39 -07:00
George Kalpakas 6cb1adf105 ci(aio): add monitoring for angular.io (#22483) 
This commit configures a periodic job to be run on CircleCI, performing several
checks against the actual apps deployed to production (https://angular.io) and
staging (https://next.angular.io).

Fixes #21942

PR Close #22483
 2018-03-30 15:26:50 -07:00
George Kalpakas a9e05ac82f fix(aio): fix SW routing RegExp to allow redirecting `/api/animate` URLs (#22483) 
PR Close #22483
 2018-03-30 15:26:50 -07:00
George Kalpakas 120673a3ac refactor(aio): move deployment config tests and helpers around (#22483) 
This commit prepares the ground for adding different types of tests.

PR Close #22483
 2018-03-30 15:26:50 -07:00
George Kalpakas 8c10df30d7 fix(aio): wait for the app to stabilize before registering the SW (#22483) 
This commit also waits for the app to stabilize, before starting to
check for ServiceWorker updates. This avoids setting up a long timeout,
which would prevent the app from stabilizing and thus cause issues with
Protractor.

PR Close #22483
 2018-03-30 15:26:50 -07:00
Judy Bogart de0b13d41d docs: update for hero service name change (#22920) 
PR Close #22920
 2018-03-29 09:20:04 -07:00
Judy Bogart 07d33d4e5a docs: fix operator name (#22920) 
PR Close #22920
 2018-03-29 09:20:04 -07:00
Judy Bogart 9f7bd8f618 docs: update text around changed obs examples (#22920) 
PR Close #22920
 2018-03-29 09:20:04 -07:00
Teamop 7de13b60d6 style(aio): fix typo in the scrollbar (#23064) 
PR Close #23064
 2018-03-29 08:57:41 -07:00
Alex Rickabaugh e1ea7ed019 docs: update examples for tree-shakeable providers (#22961) 
PR Close #22961
 2018-03-28 07:53:04 -07:00
Veres Lajos 0ebdb3d12f style: typo fix amendments (#22975) 
PR Close #22975
 2018-03-27 14:51:53 -04:00
Veres Lajos de90314304 style: typos fixed - https://github.com/vlajos/misspell-fixer (#22975) 
PR Close #22975
 2018-03-27 14:51:53 -04:00
Victor Berchet 4bd3a65764 fix(aio): mark the 'titlecase' pipe as pure (#22959) 
PR Close #22959
 2018-03-23 16:28:05 -04:00
Alberto Piras 16f021c319 docs(aio): fix TS warning error - filter expects a boolean function param (#22954) 
PR Close #22954
 2018-03-23 13:07:57 -04:00
Igor Minar 3a30f5d937 build(aio): remove rxjs-compat dependency from examples (#22872) 
we should not longer need it.

PR Close #22872
 2018-03-23 12:53:58 -04:00
Igor Minar 0f88fc73db build(aio): update examples to angular-in-memory-web-api@0.6.0 (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
George Kalpakas 01d2dd2a3a refactor(aio): switch to pipeable RxJS operators (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
George Kalpakas da76db9601 build(aio): upgrade `rxjs` to `6.0.0-beta.1` (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
George Kalpakas 91503e538e test(aio): minor improvements (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
George Kalpakas 53227abe7b build(aio): upgrade `rxjs` to `6.0.0-beta.0` (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
George Kalpakas 768100516f build(aio): upgrade `@angular/*` to `6.0.0-rc.0` (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
Igor Minar 328511be8e build(aio): update to typescript@2.7.2 (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
Igor Minar 56e545735c build(aio): update to @angular/core@6.0.0-beta.8 (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
Igor Minar 07e9969cb7 build(aio): update to @angular/cli@1.7.3 (#22872) 
PR Close #22872
 2018-03-23 12:53:58 -04:00
Jinhyuk Kim f461f43d72 docs: fix a typo in aot compiler guide (#22876) 
PR Close #22876
 2018-03-21 13:20:51 -07:00
Igor Minar 3cc5c2e4d0 build: update to rxjs@6.0.0-beta.0 (#22887) 
PR Close #22887
 2018-03-20 15:26:49 -07:00
Igor Minar 5f1be9b89b ci: temporarily disable two styleguide example tests (#22887) 
these tests started failing with 6.0.0-beta.0 upgrade because of a weird issue when used with rxjs v6 with rxjs-compat

PR Close #22887
 2018-03-20 15:26:49 -07:00
Igor Minar 4648597d14 build(aio): temporarily pin elements to 6.0.0-beta.8 (#22573) 
the next step will be to update all of aio to 6.0.0-rc.0

PR Close #22573
 2018-03-19 21:51:51 -07:00
Igor Minar b43f8bc7d3 feat(core): upgrade rxjs to 6.0.0-alpha.4 (#22573) 
PR Close #22573
 2018-03-19 21:51:51 -07:00
Igor Minar c445314239 ci: temporarily disable tests that depend on angular-in-memory-web-api (#22573) 
angular-in-memory-web-api is not yet compatible with rxjs v6 and rxjs v6 backwards compatibility package is not yet ready to be used.

PR Close #22573
 2018-03-19 21:51:51 -07:00
George Kalpakas e5fcf650f8 build(aio): temporarily use RxJS from root `node_modules/` when using local packages (#22573) 
PR Close #22573
 2018-03-19 21:51:51 -07:00
Igor Minar 243c86cd04 ci: improve logging when running aio/examples e2e tests (#22854) 
PR Close #22854
 2018-03-18 14:03:26 -07:00
Andrew Seguin fe21437232 feat(elements): fix payload size (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin cf3ff7d219 feat(elements): another polyfill solution (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin d72f44556d feat(elements): rebase (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 167fdf745c feat(elements): rename API to createCustomElement (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 87f60bccfd feat(elements): injector create (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 46efd4b938 feat(elements): George's comments (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 19368085aa feat(elements): provide type, not factory; remove config need (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 44f637a88b feat(elements): fix test (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 863aff1a77 feat(elements): add polyfill for elements es5 shim (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 400460cc93 feat(aio): update payload size (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Andrew Seguin 7c9b411777 feat(aio): migrate embedded comp to elements (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00