honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,259 Commits 5 Branches 1 Tag 210 MiB
Commit Graph

2173 Commits

Author SHA1 Message Date
jenniferfell 1700bd6f08 docs: fix release info navigation (#26558) 
PR Close #26558
 2018-10-19 11:30:39 -07:00
Igor Minar b89bc37170 fix(docs-infra): correct the version of @angular-devkit/build-angular (#26555) 
This dependency has not been correctly updated and I had to update it manually.

I think the issue is related to https://github.com/angular/angular-cli/issues/12624 which was fixed between CLI RCs and final.

PR Close #26555
 2018-10-19 11:30:11 -07:00
Igor Minar 39df4dbde7 feat(docs-infra): update to @angular/* v7 (#26555) 
PR Close #26555
 2018-10-19 11:30:11 -07:00
Katerina Skroumpelou 716d887e51 docs: add Katerina Skroumpelou to GDE resources (#26547) 
PR Close #26547
 2018-10-19 11:29:13 -07:00
Pete Bacon Darwin 4c0ad5238e build(docs-infra): display github links in CLI API docs (#26515) 
This commit includes the following changes:

* CLI version information is read from the CLI package from which
  we read the help files.
* CLI API pages now contain GH links
* line numbers are not shown in GH links, if the doc does not
  have a truthy `startingLine` value. This allows us to remove
  hard coded checks for `guide` pages
* content pages and CLI api docs no longer have a `startingLine`
* the hard-coded `packages` path segment has been removed from
  the templates; instead we now only use the `realProjectRelativePath`.
* the `realProjectRelativePath` has been updated accordingly for API
  and CLI API docs.

PR Close #26515
 2018-10-19 11:12:54 -07:00
Pete Bacon Darwin 9e8903ada1 build(docs-infra): show github edit link on CLI overview (#26515) 
PR Close #26515
 2018-10-19 11:12:53 -07:00
Brandon Roberts aa55d88408 docs: forms overview copy edit (#26450) 
PR Close #26450
 2018-10-19 11:08:47 -07:00
Nikhil Sharma 07fc4c2464 docs(service-worker): updated browser support for Service Worker (#26408) 
PR Close #26408
 2018-10-19 11:08:00 -07:00
Pete Bacon Darwin b9bd95b3b2 build(docs-infra): break long CLI options onto two lines (#26272) 
PR Close #26272
 2018-10-19 11:07:30 -07:00
Pete Bacon Darwin 3f89aeb80a build(docs-infra): update CLI option rendering (#26272) 
PR Close #26272
 2018-10-19 11:07:30 -07:00
Pete Bacon Darwin 6c530d3a85 build(docs-infra): render CLI arguments consistently (#26272) 
In the command syntax, arguments are rendered as
`var`s enclosed in angle brackets. So this is now repeated
in the arguments table too.

PR Close #26272
 2018-10-19 11:07:30 -07:00
Igor Minar bbf96db2f2 feat(docs-infra): add v6 to the aio version picker 2018-10-18 12:38:29 -07:00
Alan 7634c1cb31 docs: fix links to browserlist (#26531) 
PR Close #26531
 2018-10-18 12:00:38 -07:00
Rob Phoenix 95914a0fbf docs: update http to https where possible (#26509) 
PR Close #26509
 2018-10-18 11:57:57 -07:00
Rob Phoenix 9c50891d6e docs: update links to Karma homepage (#26509) 
PR Close #26509
 2018-10-18 11:57:57 -07:00
null-reference 624433c51d docs: removing errant double-quote (#26483) 
PR Close #26483
 2018-10-18 11:57:27 -07:00
lovelangy 09cc458bfc docs: type fix (#26386) 
according to the source code and the doc https://angular.io/api/forms/NgModel#inherited-from-formsngcontrol-1, the method name should be "viewToModelUpdate" instead of "viewToModel"
PR Close #26386
 2018-10-18 11:56:51 -07:00
George Kalpakas d9d226087c build(docs-infra): allow `""` as empty region in `{@example}` tags (#26514) 
PR Close #26514
 2018-10-18 09:54:17 -07:00
George Kalpakas 7bad1d356d build(docs-infra): only render code example content in one place (#26514) 
PR Close #26514
 2018-10-18 09:54:17 -07:00
George Kalpakas 0add00a743 build(docs-infra): throw error if using `title` on code snippets (#26514) 
Since #26396, the `title` property is ignored and `header` should be
used instead for specifying a code snippet's header.

This commit ensures that we don't accidentally set `title` have it be
silently ignored.

PR Close #26514
 2018-10-18 09:54:17 -07:00
Alan Agius d557f1d9de build(docs-infra): update git ref for cli command docs (#26545) 
This is to get the latest changes done in https://github.com/angular/angular-cli/pull/12634

PR Close #26545
 2018-10-18 09:54:00 -07:00
Siddharth Ajmera 665627e254 fix(aio): add relative to app level routes section (#26504) 
Added word *relative* to the **Routes at the app level** section description. This was not specified before. The routes in the *lazy-loading-ngmodules/src/app/app-routing.module.ts* also had `loadChildren` values starting with `app/...`.

The code for `app-routing.module.ts` is already fixed in [this commit](67ad9468d3)
PR Close #26504
 2018-10-17 13:11:42 -07:00
Alan Agius 65b209359a build(docs-infra): update git ref for cli command docs (#26497) 
Update for version 7 release

PR Close #26497
 2018-10-17 11:24:19 -07:00
Rob Phoenix 3a65c9ad4e docs: Update link to angular-cli repo (#26497) 
PR Close #26497
 2018-10-17 11:24:19 -07:00
Alan 77e58c6179 docs: update contributing page (#26497) 
PR Close #26497
 2018-10-17 11:24:19 -07:00
Alan 23d625172a docs: update continuous integration story (#26497) 
PR Close #26497
 2018-10-17 11:24:19 -07:00
Alan c3643615fc docs: replace `alert-is-helpful` with `alert is-helpful` (#26497) 
PR Close #26497
 2018-10-17 11:24:19 -07:00
Alan 638aaecc7d docs: add missing backticks (#26497) 
PR Close #26497
 2018-10-17 11:24:19 -07:00
Alan Agius 5a79decba4 docs: remove for example code (#26519) 
PR Close #26519
 2018-10-17 11:23:50 -07:00
Judy Bogart 225162aa6c docs: edit file structure guide (#26256) 
PR Close #26256
 2018-10-17 11:08:37 -07:00
jenniferfell beebf7fe14 docs: change links to cli wiki to link to new aio docs (#26489) 
PR Close #26489
 2018-10-17 11:06:34 -07:00
jenniferfell 0ef1f7ef0d docs: change links to cli wiki to link to new aio docs files m to z (#26492) 
PR Close #26492
 2018-10-17 11:06:07 -07:00
William Marques fc6dad40ac fix(docs-infra): rename "title" by "header" to avoid unwanted tooltips (#26396) 
Closes #26174

PR Close #26396
 2018-10-17 11:05:29 -07:00
Pete Bacon Darwin ecd473bbce fix(docs-infra): don't hide contributor links on devices that cannot hover (#26410) 
Fixes #16690

PR Close #26410
 2018-10-17 11:04:35 -07:00
Vladimir Erygin 3fa876c5e7 fix(docs-infra): fix top menu logo position (#26473) 
Fixes #26468

PR Close #26473
 2018-10-17 11:03:23 -07:00
Pete Bacon Darwin 516515d9e3 build(docs-infra): do not add extra space after links in tables (#26505) 
Closes #26487

PR Close #26505
 2018-10-17 11:02:56 -07:00
George Wilde 948f507ba0 docs(forms): change headings (#25900) 
Update heading level so it will appear in the TOC.
PR Close #25900
 2018-10-16 20:39:45 -07:00
George Wilde 81a8ee1ddb docs(forms): change headings (#25900) 
Remove "Form" sub-heading & move intro to template-driven form heading.
PR Close #25900
 2018-10-16 20:39:45 -07:00
George Wilde 5e58da14f0 docs(forms): change headings (#25900) 
Change the headings of the template-driven forms guide page.

This makes the first heading consistent with other guide pages and the menu label reducing confusion to users browsing the guide.
PR Close #25900
 2018-10-16 20:39:45 -07:00
jenniferfell 81c9720acb docs: fix links to setup and cli docs (#26463) 
PR Close #26463
 2018-10-16 14:14:19 -07:00
Vani ea2cfbbd2e docs: remove setup for local dev and anatomy of setup docs from nav (#26380) 
PR Close #26380
 2018-10-16 14:14:00 -07:00
Judy Bogart 41de0e0d98 docs: overview for cli reference section (#26043) 
PR Close #26043
 2018-10-16 14:11:26 -07:00
Vani f6a2dbf4f5 docs: updated text to match the Getting started guide (#26421) 
PR Close #26421
 2018-10-16 14:11:12 -07:00
George Kalpakas 327c614799 test(docs-infra): improve logging output in `test-pwa-score[-localhost]` (#26459) 
PR Close #26459
 2018-10-15 15:23:36 -07:00
George Kalpakas 1aa8cfbf74 build(docs-infra): upgrade lighthouse to 3.2.1 (#26459) 
PR Close #26459
 2018-10-15 15:23:36 -07:00
George Kalpakas 95d0626a1e ci(docs-infra): reduce flakyness (#26459) 
PR Close #26459
 2018-10-15 15:23:36 -07:00
Judy Bogart 5183bbffbe docs: update process for cli tool and restructure doc (#25752) 
PR Close #25752
 2018-10-15 11:22:18 -07:00
null-reference 9afc9a7464 docs: minor wording correction. "use" to "user". (#26452) 
PR Close #26452
 2018-10-15 11:19:46 -07:00
jenniferfell b2db32b715 docs: getting started updated for accuracy and style (#26093) 
PR Close #26093
 2018-10-12 14:16:02 -07:00
George Kalpakas 9e32dc7c95 build: upgrade `@types/jasminewd2` to 2.0.4 (#26139) 
This commit also removes the extra jasminewd2 typings, since the changes
have been merged in the official typings with
DefinitelyTyped/DefinitelyTyped#28957.

PR Close #26139
 2018-10-12 14:11:11 -07:00
jenniferfell a19b690338 docs: move cli commands above api in nav (#26405) 
PR Close #26405
 2018-10-12 14:09:39 -07:00
George Kalpakas bab5b68910 fix(docs-infra): prevent unnecessary SideNav scrollbar (#26416) 
Fixes #21508

PR Close #26416
 2018-10-12 14:09:09 -07:00
jenniferfell 3daeadd235 docs: visual studio removed from nav and updated to refer to getting started instead of quickstart repo (#26376) 
PR Close #26376
 2018-10-12 14:08:11 -07:00
Pete Bacon Darwin ea20ae63d0 build(docs-infra): only show name in 'inherited from' section (#26387) 
Closes #26181

PR Close #26387
 2018-10-12 09:13:02 -07:00
Pete Bacon Darwin 7777a99fe5 fix(docs-infra): highlight current CLI command in navigation menu (#26388) 
Previously CLI was being treated like the API page, where the top level item
had to be highlighted for any command page. But now the CLI commands all
have their own navigation item, which can be selected, so there is no need
to special case CLI paths any more.

Closes #26373

PR Close #26388
 2018-10-12 09:02:11 -07:00
George Kalpakas 7fbeb04b7c build(docs-infra): upgrade @angular/material to 7.0.0-rc.1 (#26394) 
PR Close #26394
 2018-10-12 08:55:15 -07:00
George Kalpakas 42ee50fc22 build(docs-infra): upgrade @angular/* to 7.0.0-rc.1 (#26394) 
PR Close #26394
 2018-10-12 08:55:15 -07:00
George Kalpakas 163b7c94a9 build(docs-infra): upgrade @angular/cli to 7.0.0-rc.2 (#26394) 
PR Close #26394
 2018-10-12 08:55:15 -07:00
jenniferfell 99736750fc docs: add angularmix to events page (#26374) 
PR Close #26374
 2018-10-11 14:16:02 -07:00
Simone Bigozzi 062fe5c2cf docs: fix transpiles link in dependency injection (#26250) 
fixed a double bracket that broke the link

PR Close #26250
 2018-10-11 14:11:45 -07:00
jenniferfell bd186c7ef9 docs: move angularjs and add performance to nav (#26375) 
PR Close #26375
 2018-10-11 14:10:41 -07:00
jenniferfell 1657c997cd docs: fix tbd link and minor edits (#26404) 
PR Close #26404
 2018-10-11 14:10:01 -07:00
George Kalpakas e0e2038718 build(docs-infra): pin git ref for cli command docs (#26391) 
The JSON files from which cli command docs for angular.io are generated
is broken on master (e.g. angular/cli-builds@e0ec86757), which cause foc
generation (and CI) to fail.

Pinning the git ref where we pull cli sources from to a version that is
known to be working (until we figure out what the best approach is)

PR Close #26391
 2018-10-11 12:57:49 -07:00
George Kalpakas 67608a907e build(docs-infra): make the git ref for cli command docs configurable (#26391) 
PR Close #26391
 2018-10-11 12:57:49 -07:00
Brandon Roberts d1b7bb52e7 docs: add note for including polyfills for StackBlitz examples (#25892) 
PR Close #25892
 2018-10-09 17:04:20 -07:00
Brandon Roberts 1312693f88 docs: add core-js polyfills for StackBlitz support (#25892) 
PR Close #25892
 2018-10-09 17:04:20 -07:00
Brandon Roberts 72ff9c880c docs: sync boilerplate configuration with Angular CLI RC2 (#25892) 
Revers Jasmine version back to ~2.99.1

PR Close #25892
 2018-10-09 17:04:20 -07:00
Brandon Roberts 3060b3e29b docs: bump Jasmine version, fix build scripts (#25892) 
PR Close #25892
 2018-10-09 17:04:20 -07:00
Brandon Roberts ee28b64d74 docs: add webpack-cli back in shared example dependencies (#25892) 
PR Close #25892
 2018-10-09 17:04:20 -07:00
Brandon Roberts 1246ba53c7 docs: cleanup universal boilerplate scripts (#25892) 
PR Close #25892
 2018-10-09 17:04:20 -07:00
Brandon Roberts c29ff722a0 docs: add testing styles back to boilerplate configuration (#25892) 
PR Close #25892
 2018-10-09 17:04:20 -07:00
Brandon Roberts 67ad9468d3 docs: fix broken lazy loading examples with Angular CLI RC upgrade (#25892) 
PR Close #25892
 2018-10-09 17:04:19 -07:00
Brandon Roberts f922808b8d docs: update to latest Angular RC, CLI RC, and Jasmine releases (#25892) 
PR Close #25892
 2018-10-09 17:04:19 -07:00
Brandon Roberts 67435d456c Revert "docs: add testing styles in index.html, remove additional configuration" (#25892) 
This reverts commit 621d82a44c9d46f69f3296b302984f5949b8dee8.

PR Close #25892
 2018-10-09 17:04:19 -07:00
Brandon Roberts fbfce79b93 docs: add testing styles in index.html, remove additional configuration (#25892) 
PR Close #25892
 2018-10-09 17:04:19 -07:00
Brandon Roberts 2a14dfa4ba docs: update shared example dependencies to Angular 7 and CLI 7 (#25892) 
PR Close #25892
 2018-10-09 17:04:19 -07:00
Wei Lun 8e71ad6027 docs: typo on function name for handleError() (#26261) 
changed function name `errorHandle()` to `handleError()`
PR Close #26261
 2018-10-09 16:54:15 -07:00
Ashish Patel 25289664ea docs: fix sentence in attribute directives guide (#26266) 
PR Close #26266
 2018-10-09 16:53:42 -07:00
George Kalpakas 9320ec0f43 build(docs-infra): upgrade Angular to 7.0.0-rc.0 and TypeScript to 3.1.1 (#26202) 
PR Close #26202
 2018-10-08 13:43:31 -07:00
George Kalpakas 5dd225cb43 build(docs-infra): upgrade webpack-cli to 3.1.2 (#26202) 
This is necessary to avoid webpack/webpack#8082, when installing
dependencies without taking the lockfile into account (e.g. with
`yarn aio-use-local` - locally or on CI).

PR Close #26202
 2018-10-08 13:43:31 -07:00
George Kalpakas 10e414f617 test(docs-infra): fix tests (#26202) 
PR Close #26202
 2018-10-08 13:43:31 -07:00
siddhant 0bdea1f69c docs: update docs to reflect the changes in RxJS 6 (#26238) 
PR Close #26238
 2018-10-08 13:43:12 -07:00
George Kalpakas decc0b840d ci(docs-infra): re-use env variable (#26138) 
PR Close #26138
 2018-10-08 12:01:02 -07:00
JiaLi.Passion ccceff5ecc docs: add fakeAsync test new feature document (#23117) 
PR Close #23117
 2018-10-05 15:43:37 -07:00
Frederik Schlemmer 6c6bc95ac0 docs: Rename 'QuickStart' into 'Getting Started' (#25762) 
Delete symlink

docs: Undo unwanted changes

docs: Rename 'QuickStart' into 'Getting Started'

Revert symlink commit
PR Close #25762
 2018-10-05 15:43:16 -07:00
George Kalpakas 3a5cb1cb11 fix(docs-infra): fix positioning of message for disabled JavaScript (#26198) 
PR Close #26198
 2018-10-05 15:39:23 -07:00
George Kalpakas ab6f055479 ci(docs-infra): show custom 404 page on preview server (for consistency) (#26199) 
PR Close #26199
 2018-10-05 15:39:02 -07:00
Atuuh 3683c6a188 docs: fix wording (#26207) 
fix wording to sound better
PR Close #26207
 2018-10-05 14:19:08 -07:00
thanhpd 4006c9b6e6 docs: fix spelling errors (#26213) 
PR Close #26213
 2018-10-05 14:18:19 -07:00
Kirankumar Sripati 245b85f72a docs: typo fixes (#26247) 
PR Close #26247
 2018-10-05 14:00:20 -07:00
Charles Lyding 3cce4afa0d build(docs-infra): update fsevents to 1.2.4 to support node 10 (#26218) 
PR Close #26218
 2018-10-05 13:45:36 -07:00
Suguru Inatomi 35936864bc docs: add Suguru Inatomi to GDE resources (#26219) 
PR Close #26219
 2018-10-04 10:10:52 -07:00
Pete Bacon Darwin a2878b0b1d fix(docs-infra): remove unnecessary margin on short descriptions (#25768) 
(This was added in 405d97431f but it is
not clear the reasoning. It looks better to remove it now.)

PR Close #25768
 2018-10-01 09:36:34 -07:00
Pete Bacon Darwin 5977b72e9c build(docs-infra): fix formatting of entry point export table (#25768) 
Now that `list-table` cells are `pre` formatterd we must be careful
of what whitespace appears in text nodes.

PR Close #25768
 2018-10-01 09:36:34 -07:00
Pete Bacon Darwin 7373da9b11 build(docs-infra): simplify property syntax rendering (#25768) 
PR Close #25768
 2018-10-01 09:36:34 -07:00
Pete Bacon Darwin 783a682a7d build(docs-infra): remove unused property table heading (#25768) 
PR Close #25768
 2018-10-01 09:36:34 -07:00
Pete Bacon Darwin d22418d417 build(docs-infra): add short description "See more" link (#25768) 
If there is additional (non-short) description then add in a
link to the short description to take the reader there.

PR Close #25768
 2018-10-01 09:36:34 -07:00
Pete Bacon Darwin 4b1fd98093 build(docs-infra): pluralize NgModule(s) heading as appropriate (#25768) 
PR Close #25768
 2018-10-01 09:36:34 -07:00
Pete Bacon Darwin 935ef13096 build(docs-infra): improve directive selector rendering (#25768) 
`:not(...)` blocks are now rendered as italic, while the
rest of the selector is bold.

PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin f4b60588fb build(docs-infra): move directive macros into memberHelpers.html (#25768) 
PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin 15dadb92ef build(docs-infra): include directives etc in class descendants lists (#25768) 
PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin ce06a75ebf build(docs-infra): display inherited members on directives (#25768) 
PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin 9889276b15 build(docs-infra): directive inputs and outputs (#25768) 
PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin d0f7eadc09 build(docs-infra): rename example template variable in directive pages (#25768) 
PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin 4b132c9848 build(docs-infra): remove class overview from directive pages (#25768) 
PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin 46729c76a0 build(docs-infra): improve directive selector rendering (#25768) 
If the documentation contains a `@selectors` tag then the content of that
is used to describe the selectors of a directive.

Otherwise the selector string is split and each selector is listed as
a list item in an unordered list.

PR Close #25768
 2018-10-01 09:36:33 -07:00
Pete Bacon Darwin f22deb2e2d build(docs-infra): improve directive API doc templates (#25768) 
Closes #22790
Closes #25530

PR Close #25768
 2018-10-01 09:36:32 -07:00
George Kalpakas 57de9fc41a build(docs-infra): upgrade @angular/cli to 6.2.3 (#26145) 
PR Close #26145
 2018-10-01 09:35:49 -07:00
George Kalpakas 31034f5146 build(docs-infra): upgrade @angular/* to 7.0.0-beta.7 (#26145) 
PR Close #26145
 2018-10-01 09:35:48 -07:00
George Kalpakas c5899f4cd4 build(docs-infra): update payload size limits to reflect current status (#26145) 
PR Close #26145
 2018-10-01 09:35:48 -07:00
Jordan Whitfield 794c3595d4 docs: fix a typo in the Universal guide (#25853) 
line 39: `highly-interactive` is the pre-qualifier of `Angular application`, which is the subject so the comma is not necessary (I think). I think this will make it easier for non-native speakers.

PR Close #25853
 2018-09-28 09:36:09 -07:00
Judy Bogart f455518d80 docs: integrate cli doc from wiki into main doc (#25776) 
PR Close #25776
 2018-09-27 15:33:47 -07:00
Ben Lesh ffc6e199bf build: RxJS updated to 6.3 (#26087) 
PR Close #26087
 2018-09-26 17:01:15 -07:00
George Kalpakas a01acec7fe fix(docs-infra): use correct parameters for paginated requests to GitHub (#25671) 
As it turns out, in GitHub API paginated requests, page numbering is
1-based. (https://developer.github.com/v3/#pagination)

Starting at page 0 (which returns the first page), results in making the
same request twice and logging incorrect numbers (since the first 100
items are listed twice).

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas 021f4344b1 fix(docs-infra): fix preview server periodic clean-up (#25671) 
Includes the following fixes:

- Fix cron entry format for clean-up script.
  Crontabs in `/etc` should not have a user field. No idea why it used
  to work before, but it started giving errors recently:
  `/bin/sh: root: not found`.

- Set required env variable in clean-up script. (Broken in cc6f36a9d.)
  This was producing the following error:
  `ERROR: Missing required environment variable 'AIO_CIRCLE_CI_TOKEN'!`

- Use the correct path for downloads to be removed. (Broken in cc6f36a9d.)

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas f113b49909 test(docs-infra): remove unnecessary test helpers (#25671) 
`supertest.Request` extends `Promise` and can be used directly without
"promisifying".

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas d8d276c245 docs(docs-infra): update preview server docs to account for recent changes (#25671) 
Mostly (but not exclusively) a follow-up to #23576.

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas e42bd012f9 ci(docs-infra): test PR previews on CI (#25671) 
The deployment of PR previews is triggered by the notification webhook
of the `aio_preview` CircleCI job (which creates and stores the build
artifacts).

This commit adds a new job (`test_aio_preview`), which waits for the
preview to be deployed (for PRs that do have a preview) and then runs
some tests against it (currently only PWA tests).

Fixes #23818

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas 6d6b0ff1ad feat(docs-infra): add API endpoint for checking if PR can have preview (#25671) 
There several reasons why PRs cannot have (public) previews:
- The PR did not affect any relevant files (e.g. non-spec files in
  `aio/` or `packages/`).
- The PR cannot be automatically verified as "trusted" (based on its
  author or labels).

Note:
The endpoint does not check whether there currently is a (public)
preview for the specified PR; only whether there can be one.

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas f378454c92 fix(docs-infra): correctly check PR files on preview server (#25671) 
According to the docs, the response of GitHub's [PR files API][1]
_"includes a maximum of 300 files"_. This means that if a PR contains
more files, it is possible that not all files are retrieved (which
could, for example, give a false negative for the "significant files
touched" check - not likely but possible).

This commit fixes it by using paginated requests to retrieve all changed
files.

[1]: https://developer.github.com/v3/pulls/#list-pull-requests-files

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas c8c8436e58 test(docs-infra): fix test for preview server's `GithubPullRequests` (#25671) 
PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas b31c8b6063 test(docs-infra): fix test for preview server's `BuildCleaner` completing prematurely (#25671) 
PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas 897261efdc test(docs-infra): fix preview server unit tests on Windows (#25671) 
Some tests where comparing actual with expected paths, without taking
into account that paths will be different on Windows.

This commit uses `path.resolve()` to convert expected paths to their
OS-specific form.

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas 35d70ff265 test(docs-infra): add support for source-maps in preview server tests (#25671) 
PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas fc0a7959a4 refactor(docs-infra): use mockable logger (#25671) 
Related discussion:
https://github.com/angular/angular/pull/23576#discussion_r187925949.

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas 182c08bee1 refactor(docs-infra): fix method name (getPrfromBranch --> getPrFromBranch) (#25671) 
PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas e2bc0ad6c2 build(docs-infra): upgrade preview server dependencies (#25671) 
PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas 73333ee3e5 build(docs-infra): replace `concurrently` with `npm-run-all` for preview server dev (#25671) 
`npm-run-all` works just as well, but is better at handling termination on Windows.

PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas c819859598 build(docs-infra): do not exit preview server `dev` script when `build` fails (#25671) 
PR Close #25671
 2018-09-26 15:26:19 -07:00
George Kalpakas 79aefa7659 build(docs-infra): avoid race condition in `aio-builds-setup/` npm scripts (#25671) 
Previously, due to multiple scripts re-building during `yarn dev`
initialization, there could be race conditions that led to errors.

This commit fixes it by ensuring `yarn build` is run once (before
the main `yarn dev` script).

PR Close #25671
 2018-09-26 15:26:19 -07:00
arjunyel e1990a5a80 docs: firefox web components info (#26118) 
PR Close #26118
 2018-09-26 15:25:44 -07:00
Pete Bacon Darwin f29b218060 feat(docs-infra): generate Angular CLI command reference (#25363) 
PR Close #25363
 2018-09-26 11:24:02 -07:00
Pete Bacon Darwin 39a67548ac build(docs-infra): add option to run only the doc-gen (#25363) 
This can save time when iterating by not
regenerating the zips and embedded examples.

PR Close #25363
 2018-09-26 11:24:02 -07:00
Brandon Roberts bc88f318f6 docs: update routing integration section based on feedback (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts a5b7008c8e docs: add section on router integration (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts 0aafbac99b docs: clean up providedIn: 'root' syntax for router examples (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts ac5aa8f46d docs: router guide review feedback changes (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts 1fb3c4ffee docs: Update router guide to use Angular CLI (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts 3c8aa0b301 docs: Refresh content on routable animations for router guide (#20023) 
PR Close #20023
 2018-09-26 10:14:49 -07:00
Brandon Roberts d19108531c docs: cleanup minor changes for forms overview (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 354d1944bb docs: remove unused properties from forms overview example (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts eaccd03ed7 docs: fix typos from review feedback (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 343df337f4 docs: update with forms overview review feedback (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 9b14483824 docs: more overview feedback changes (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts bd42caf1c7 docs: update nav descriptions based on feedback (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 7db8111973 docs: add updated reactive forms data flow image (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 74fef157e6 docs: updates from review feedback (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 9661bed3ba docs: add updated forms overview images (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 95168e4de0 docs: integrate forms diagrams into overview (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00
Brandon Roberts 13c3e241c8 docs: add final thoughts to forms overview (#25663) 
PR Close #25663
 2018-09-25 18:48:15 -07:00