Chuck Jazdzewski
68b53c07fd
fix(compiler): emit correct type-check-blocks with TemplateRef's ( #20463 )
...
The type-check block generated with `"fullTemplateTypeCheck"` was
invalid if the it contained a template ref as would be generated
using the `else` micro-syntax of `NgIf`.
Fixes : #19485
PR Close #20463
2017-11-16 16:19:54 -06:00
shioyang
368cb5ad4e
docs(aio): fix a typo to improve readability ( #20435 )
...
Remove a comma and space
PR Close #20435
2017-11-16 16:19:48 -06:00
Shavi Pathania
949836d003
docs(aio): Clearing array with [] ( #20369 ) ( #20395 )
...
Convert remaining references to directly use LoggerServices logs.
PR Close #20395
2017-11-16 16:19:35 -06:00
Shavi Pathania
697fb76960
docs(aio): Removing reference to LoggerService property ( #20369 ) ( #20395 )
...
The reference removed so that calling LoggerService clear() method
behaves as intended in SpyComponent.
PR Close #20395
2017-11-16 16:19:35 -06:00
Shavi Pathania
0fedb57cb0
docs(aio): Clearing array with [] ( #20369 ) ( #20395 )
...
Clearing array with setting length to 0 replaced with [] for being short
and marginally efficient. For reference: [] is turned into a sequence of
around 15 machine instructions on x64 (if bump pointer allocation succeeds),
whereas a.length=0 is a C++ runtime function call, which requires 10-100x as
many instructions.
Benedikt Meurer
PR Close #20395
2017-11-16 16:19:35 -06:00
Michael Giambalvo
717ac5ac4d
fix(benchpress): Allow ignoring navigationStart events in perflog metric. ( #20312 )
...
PR Close #20312
2017-11-16 16:18:38 -06:00
Miško Hevery
4064cbe945
docs: add changelog for 5.1.0-beta.1
2017-11-16 14:04:25 -08:00
Miško Hevery
a88306d671
release: cut the 5.1.0-beta.1 release
2017-11-16 14:03:03 -08:00
Miško Hevery
c702ffc471
docs: add changelog for 5.0.2
2017-11-16 13:41:55 -08:00
Chuck Jazdzewski
dcfffbf828
build: fix build failures ( #20470 )
2017-11-15 22:33:30 -08:00
ssreevani
336041aac9
docs(aio): Add instructions to fork angular/angular ( #20462 )
...
PR Close #20462
2017-11-15 18:26:27 -06:00
George Kalpakas
7e38f4fd1f
fix(aio): fix window title on Home page ( #20440 )
...
Using `display: none` on the `<h1>` causes `innerText` to not work as expected
and include the icon ligature (`link`) in the title. This caused the window
title on the angular.io Home page to appear as "Angular - link".
This commit fixes it by not generating anchors at all for headings with the
`no-anchor` class.
Fixes #20427
PR Close #20440
2017-11-15 18:25:58 -06:00
Brad Pitcher
c28b52187a
docs(aio): add missing closing backtick ( #20446 )
...
PR Close #20446
2017-11-15 18:25:49 -06:00
Alex Eagle
5ec1717c58
fix: Update test code to type-check under TS 2.5 ( #20175 )
...
PR Close #20175
2017-11-15 18:12:16 -06:00
Alex Eagle
c2a24b4241
fix(bazel): adjust mock of tsconfig for ng_module rule unit test ( #20175 )
...
Due to 7f33f01b72
PR Close #20175
2017-11-15 18:12:16 -06:00
Alex Eagle
a9f3e2bd95
build: Upgrade to TypeScript 2.5 ( #20175 )
...
- update to TypeScript 2.5
- point the 2.4 typings test at the previous typescript version, so we
don't break it accidentally
- widen the peerDeps from Angular packages that depend on TypeScript
- update to latest TypeScript 2.5 compatible Bazel rules
- move .bazelrc to tools/bazel.rc per https://docs.bazel.build/versions/master/best-practices.html#bazelrc
PR Close #20175
2017-11-15 18:12:16 -06:00
Miško Hevery
f8658cdc38
Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )"
...
This reverts commit d47b2a6f70
.
2017-11-15 17:04:22 -06:00
Jason Aden
043e408805
style(core): fix comment format for linter
2017-11-15 11:53:11 -08:00
George Kalpakas
c004d483ab
style(core): fix max line length to pass linting ( #20441 )
...
Accidentally introduced in #19920 , where other linting errors (unrelated to the
PR) prevented proper linting.
PR Close #20441
2017-11-15 11:44:52 -08:00
Jason Aden
2586846ee2
Revert "fix(core): should support event.stopImmediatePropagation"
...
This reverts commit 5e0eb5e3d94bd7077c4d6657b89bfc8d900f2bc6.
2017-11-15 11:35:21 -08:00
Matias Niemelä
d47b2a6f70
fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )
...
Closes #19100
PR Close #19753
2017-11-14 15:59:47 -08:00
Leo Globerman
1adbcda12e
docs(aio): fix wrong copy ( #20431 )
...
PR Close #20431
2017-11-14 15:58:25 -08:00
Martin Hobert
12af6d356e
docs(core): change from deprecated renderer to renderer2 ( #19920 )
...
We now show the proper class instead of the deprecated Renderer
Fixes #19806
PR Close #19920
2017-11-14 13:44:56 -08:00
Matias Niemelä
20aafff092
fix(animations): ensure final state() styles are applied within @.disabled animations ( #20267 )
...
Closes #20266
PR Close #20267
2017-11-14 11:01:11 -08:00
Mark Kennedy
a622e19df6
fix(router): 'merge' queryParamHandling strategy should be able to remove query params ( #19733 )
...
Closes #18463 , #17202
PR Close #19733
2017-11-14 11:01:04 -08:00
Fabian Wiles
1db7c0d139
ci: tighten package limits ( #20364 )
...
PR Close #20364
2017-11-14 11:00:58 -08:00
Levi Zitting
b9bd3204f2
docs(aio): fix broken link in guide/component-interaction ( #20411 )
...
add a blank line before line with markdown link
PR Close #20411
2017-11-14 10:00:46 -08:00
Brad Pitcher
bf651a504f
docs(aio): make it clear we are talking about <a> tags ( #20410 )
...
As is, it could be seen as a typo at first glance. Wrapping the "a" in carets and backticks for formatting adds some clarity.
PR Close #20410
2017-11-14 10:00:42 -08:00
Marcelo Melo
e5c4371d72
docs(aio): fix typo in filename (packages.json --> package.json) ( #20377 )
...
PR Close #20377
2017-11-14 10:00:39 -08:00
Aravind
3caae94261
docs(aio): fix not found schema ( #20347 )
...
Fixes #20338
PR Close #20347
2017-11-14 10:00:35 -08:00
Trotyl
e7a2b31472
docs(aio): fix rxjs import ( #20350 )
...
closes #20349
PR Close #20350
2017-11-14 10:00:31 -08:00
Ward Bell
c03186013c
docs: Dependency Injection guides for CLI ( #19892 )
...
PR Close #19892
2017-11-14 10:00:28 -08:00
Jesus Rodriguez
5a2531ee45
docs(aio): update template forms to CLI ( #20014 )
...
PR Close #20014
2017-11-14 10:00:23 -08:00
Jesus Rodriguez
6ca780178c
docs(aio): update reactive-forms to CLI ( #20019 )
...
PR Close #20019
2017-11-14 10:00:17 -08:00
Jesus Rodriguez
9608b0636d
docs(aio): update displaying-data for CLI ( #19574 )
...
PR Close #19574
2017-11-14 10:00:13 -08:00
Jesus Rodriguez
89187d9b6b
docs(aio): update glossary for CLI ( #20017 )
...
PR Close #20017
2017-11-14 10:00:10 -08:00
Jesus Rodriguez
335b72f301
docs(aio): update ajs-quick-reference for CLI ( #19552 )
...
PR Close #19552
2017-11-14 10:00:02 -08:00
Brad Pitcher
74071210eb
docs(aio): remove trailing underscore from provide_ ( #20356 )
...
_provide_ was already emphasized in the previous paragraph
PR Close #20356
2017-11-14 09:59:56 -08:00
Aliaksei Urbanski
fde966832b
docs(aio): fix missed grave accent ( #20379 )
...
PR Close #20379
2017-11-14 09:59:51 -08:00
Ward Bell
75d474e1d3
docs: AttributeDirectives guide for CLI ( #19771 )
...
PR Close #19771
2017-11-14 09:59:43 -08:00
Chuck Jazdzewski
24cf8b3269
fix(core): ensure init lifecycle events are called ( #20258 )
...
Throwing an exception in a lifecycle event will delay but not
prevent an Init method, such as `ngOnInit`, `ngAfterContentInit`,
or `ngAfterViewInit`, from being called. Also, calling `detectChanges()`
in a way that causes duplicate change detection (such as a
child component causing a parent to call `detectChanges()` on its
own `ChangeDetectorRef`, will no longer prevent change `ngOnInit`,
`ngAfterContentInit` and `ngAfterViewInit` from being called.
With this change lifecycle methods are still not guarenteed to be
called but the Init methods will be called if at least one change
detection pass on its view is completed.
Fixes : #17035
PR Close #20258
2017-11-10 13:47:39 -08:00
Bowen Ni
743651f5e8
refactor(animations): uses a loop instead Array.map() which creates and ( #19910 )
...
returns a new array that is discarded.
This pattern will become a compilation error in google3.
PR Close #19910
2017-11-10 13:47:02 -08:00
Torgeir Helgevold
161f88fe6f
build: update to google-closure-compiler@20171023.0.1 ( #20321 )
...
added externs
remove externs
PR Close #20321
2017-11-10 11:51:57 -08:00
Chuck Jazdzewski
c33a57666b
fix(compiler): recognize @NgModule with a redundant @Injectable ( #20320 )
...
The compiler now, again, recognizes `@NgModule()` decorators on
classes with a redundant `@Injectable()` decorator.
Fixes : #19544
PR Close #20320
2017-11-10 11:51:52 -08:00
Levi Zitting
cf618c564c
fix(aio): markdown typo in Tour of Heroes tutorial ( #20288 )
...
PR Close #20288
2017-11-10 11:51:18 -08:00
Derek
401ead07b8
docs(common): update default display value for CurrencyPipe ( #20246 )
...
PR Close #20246
2017-11-10 11:51:17 -08:00
Fabian Wiles
b55c2ba342
refactor(core): remove prolyfill from error message ( #20121 )
...
PR Close #20121
2017-11-10 11:51:15 -08:00
Trotyl Yu
d8db0f12a2
docs(changelog): remove unnecessary revert item ( #20303 )
...
PR Close #20303
2017-11-10 11:51:13 -08:00
Keen Yee Liau
eb8013e853
fix(language-service): pass compilerOptions.paths to ReflectorHost ( #20222 )
...
This commit fixes the options passed to ReflectorHost to include 'paths'
if it's specified in compiler options, so that dependency modules can
be loaded.
PR Close #20222
2017-11-10 11:51:11 -08:00
Kirils Ladovs
fb4b90a564
docs(aio): typo fix ( #20318 )
...
tutorial part 0 app component template file extention fix
PR Close #20318
2017-11-10 11:12:07 -08:00