Commit Graph

11425 Commits

Author SHA1 Message Date
George Kalpakas 6d6b0ff1ad feat(docs-infra): add API endpoint for checking if PR can have preview (#25671)
There several reasons why PRs cannot have (public) previews:
- The PR did not affect any relevant files (e.g. non-spec files in
  `aio/` or `packages/`).
- The PR cannot be automatically verified as "trusted" (based on its
  author or labels).

Note:
The endpoint does not check whether there currently is a (public)
preview for the specified PR; only whether there can be one.

PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas f378454c92 fix(docs-infra): correctly check PR files on preview server (#25671)
According to the docs, the response of GitHub's [PR files API][1]
_"includes a maximum of 300 files"_. This means that if a PR contains
more files, it is possible that not all files are retrieved (which
could, for example, give a false negative for the "significant files
touched" check - not likely but possible).

This commit fixes it by using paginated requests to retrieve all changed
files.

[1]: https://developer.github.com/v3/pulls/#list-pull-requests-files

PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas c8c8436e58 test(docs-infra): fix test for preview server's `GithubPullRequests` (#25671)
PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas b31c8b6063 test(docs-infra): fix test for preview server's `BuildCleaner` completing prematurely (#25671)
PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas 897261efdc test(docs-infra): fix preview server unit tests on Windows (#25671)
Some tests where comparing actual with expected paths, without taking
into account that paths will be different on Windows.

This commit uses `path.resolve()` to convert expected paths to their
OS-specific form.

PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas 35d70ff265 test(docs-infra): add support for source-maps in preview server tests (#25671)
PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas fc0a7959a4 refactor(docs-infra): use mockable logger (#25671)
Related discussion:
https://github.com/angular/angular/pull/23576#discussion_r187925949.

PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas 182c08bee1 refactor(docs-infra): fix method name (getPrfromBranch --> getPrFromBranch) (#25671)
PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas e2bc0ad6c2 build(docs-infra): upgrade preview server dependencies (#25671)
PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas 73333ee3e5 build(docs-infra): replace `concurrently` with `npm-run-all` for preview server dev (#25671)
`npm-run-all` works just as well, but is better at handling termination on Windows.

PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas c819859598 build(docs-infra): do not exit preview server `dev` script when `build` fails (#25671)
PR Close #25671
2018-09-26 15:26:19 -07:00
George Kalpakas 79aefa7659 build(docs-infra): avoid race condition in `aio-builds-setup/` npm scripts (#25671)
Previously, due to multiple scripts re-building during `yarn dev`
initialization, there could be race conditions that led to errors.

This commit fixes it by ensuring `yarn build` is run once (before
the main `yarn dev` script).

PR Close #25671
2018-09-26 15:26:19 -07:00
arjunyel e1990a5a80 docs: firefox web components info (#26118)
PR Close #26118
2018-09-26 15:25:44 -07:00
Kara Erickson 4cff5b2964 release: cut the v7.0.0-beta.7 release 2018-09-26 15:07:11 -07:00
Kara Erickson 459758231b docs: release notes for the v6.1.9 release 2018-09-26 13:12:20 -07:00
Pete Bacon Darwin f29b218060 feat(docs-infra): generate Angular CLI command reference (#25363)
PR Close #25363
2018-09-26 11:24:02 -07:00
Pete Bacon Darwin 39a67548ac build(docs-infra): add option to run only the doc-gen (#25363)
This can save time when iterating by not
regenerating the zips and embedded examples.

PR Close #25363
2018-09-26 11:24:02 -07:00
Brandon Roberts bc88f318f6 docs: update routing integration section based on feedback (#20023)
PR Close #20023
2018-09-26 10:14:49 -07:00
Brandon Roberts a5b7008c8e docs: add section on router integration (#20023)
PR Close #20023
2018-09-26 10:14:49 -07:00
Brandon Roberts 0aafbac99b docs: clean up providedIn: 'root' syntax for router examples (#20023)
PR Close #20023
2018-09-26 10:14:49 -07:00
Brandon Roberts ac5aa8f46d docs: router guide review feedback changes (#20023)
PR Close #20023
2018-09-26 10:14:49 -07:00
Brandon Roberts 1fb3c4ffee docs: Update router guide to use Angular CLI (#20023)
PR Close #20023
2018-09-26 10:14:49 -07:00
Brandon Roberts 3c8aa0b301 docs: Refresh content on routable animations for router guide (#20023)
PR Close #20023
2018-09-26 10:14:49 -07:00
Kara Erickson 15a2b8f622 fix(ivy): wrapper fns arent necessary anymore (#26108)
PR Close #26108
2018-09-26 00:03:16 -07:00
Brandon Roberts d19108531c docs: cleanup minor changes for forms overview (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 354d1944bb docs: remove unused properties from forms overview example (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts eaccd03ed7 docs: fix typos from review feedback (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 343df337f4 docs: update with forms overview review feedback (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 9b14483824 docs: more overview feedback changes (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts bd42caf1c7 docs: update nav descriptions based on feedback (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 7db8111973 docs: add updated reactive forms data flow image (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 74fef157e6 docs: updates from review feedback (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 9661bed3ba docs: add updated forms overview images (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 95168e4de0 docs: integrate forms diagrams into overview (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 13c3e241c8 docs: add final thoughts to forms overview (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 8d098d389a docs: incorporated forms overview review feedback (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 79a2567aa3 docs: forms overview review changes (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 5649acd03f docs: add forms overview example for snippets (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts ebd01e8e79 docs: more form overview edits (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts e08955b557 docs: incorporated forms overview feedback (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 04dfca41f4 docs(forms): add package overview for forms (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts 129f69c3bc docs: add forms overview guide (#25663)
PR Close #25663
2018-09-25 18:48:15 -07:00
Vani c7e2930f25 docs: fix issues related to tutorial. (#24445)
PR Close #24445
2018-09-25 18:45:19 -07:00
Kara Erickson 6a62ed2245 fix(ivy): objects like ElementRef should not use a special injection fn (#26064)
PR Close #26064
2018-09-25 12:51:29 -07:00
George Kalpakas 482e12c940 build: remove obsolete comment in `env.sh` (#25819)
The comment is no longer true since #25602.

PR Close #25819
2018-09-25 11:04:33 -07:00
Matias Niemelä 0c344715e5 feat(ivy): expose a series of helpful application inspection tools (#25919)
PR Close #25919
2018-09-25 09:46:12 -07:00
Max Belsky cf095d982d docs: fix a typo (#26074)
PR Close #26074
2018-09-24 13:48:24 -07:00
Pete Bacon Darwin 23ec88ef23 refactor(ivy): remove unreferenced utils file (#26076)
PR Close #26076
2018-09-24 11:39:52 -07:00
George Kalpakas 2bd767c4a6 fix(service-worker): do not blow up when caches are unwritable (#26042)
In some cases, example when the user clears the caches in DevTools but
the SW remains active on another tab and keeps references to the deleted
caches, trying to write to the cache throws errors (e.g.
`Entry was not found`).

When this happens, the SW can no longer work correctly and should enter
a degraded mode allowing requests to be served from the network.

Possibly related:
- https://github.com/GoogleChrome/workbox/issues/792
- https://bugs.chromium.org/p/chromium/issues/detail?id=639034

This commits remedies this situation, by ensuring the SW can enter the
degraded `EXISTING_CLIENTS_ONLY` mode and forward requests to the
network.

PR Close #26042
2018-09-24 09:53:39 -07:00
Frederik Schlemmer 1e02cd9961 docs: Fixes typo in FormArray (#26031)
PR Close #26031
2018-09-24 09:14:07 -07:00