15452 Commits

Author SHA1 Message Date
George Kalpakas
a23ee2b0a1 docs(router): make InitialNavigation part of the public API (#32707)
`InitialNavigation` is used in `ExtraOptions`, which is already part of
the public API. Thus, `InitialNavigation` should be too. Not publicly
exporting it from `router/index.ts` seems an omission, since the type is
already annotated with the `@publicApi` JSDoc tag.

By publicly exporting `InitialNavigation`, it will also correctly appear
in the API docs on angular.io.

PR Close #32707
2019-09-27 14:21:13 -07:00
Filipe Silva
e41cbfb585 feat(ivy): support ng-add in localize package (#32791)
PR Close #32791
2019-09-27 13:15:02 -07:00
Igor Minar
84feda1db7 build(docs-infra): do not ngcc the 'module' entry points (#32679)
CLI v8.3+ doesn't read them any more.

PR Close #32679
2019-09-27 11:34:53 -07:00
Igor Minar
ecd7554051 build(docs-infra): update to cli@9.0.0-next (#32679)
PR Close #32679
2019-09-27 11:34:53 -07:00
john li
5ae48d52e6 docs: fix typo in deployment guide (#32777)
The typo causes most of the callout to not appear on the page. The issue 
appears at the bottom of the "Lazy loading" section on the live site:
https://angular.io/guide/deployment#lazy-loading
PR Close #32777
2019-09-27 10:32:38 -07:00
Andrew Kushnir
966c2a326a fix(ivy): include ngProjectAs into attributes array (#32784)
Prior to this commit, the `ngProjectAs` attribute was only included with a special flag and in a parsed format. As a result, projected node was missing `ngProjectAs` attribute as well as other attributes added after `ngProjectAs` one. This is problematic since app code might rely on the presence of `ngProjectAs` attribute (for example in CSS). This commit fixes the problem by including `ngProjectAs` into attributes array as a regular attribute and also makes sure that the parsed version of the `ngProjectAs` attribute with a special marker is added after regular attributes (thus we set them correctly at runtime). This change also aligns View Engine and Ivy behavior.

PR Close #32784
2019-09-27 10:12:18 -07:00
Harinder Singh
278d634723 docs: correct spelling of HTMLTableCellElement in Template Syntax (#32805)
Spelling Correction in Docs

Corrected spelling; From `HTMLTableCellElment` to  `HTMLTableCellElement`.

PR Close #32805
2019-09-27 10:03:52 -07:00
Reuben Wilson
f6914159e4 docs: fix sentence phrasing (#32846)
`In this section, you'll add a "Buy" button the product details page.` -> `In this section, you'll add a "Buy" button to the product details page.`
PR Close #32846
2019-09-27 10:03:22 -07:00
Jordan Amman
2e730287fb docs: clarify sentence in lifecycle hooks doc (#32860)
PR Close #32860
2019-09-27 10:02:54 -07:00
George Kalpakas
a7d090d22e build(docs-infra): upgrade cli command docs sources to 0a36071b8 (#32878)
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).

##
Relevant changes in [commit range](c6184bf31...0a36071b8):

**Modified**
- help/generate.json

##

PR Close #32878
2019-09-27 10:01:19 -07:00
George Kalpakas
85990c3213 fix(docs-infra): correctly run on IE11 (#32871)
Since 007282d2b, [TocService][1] uses [forEach()][2] to iterate over a
`NodeList`. This breaks in IE11, which does not support
`NodeList#forEach()`.

This commit wraps the returned `NodeList` in a regular `Array` to have
access to array methods (such as `forEach()`).

Fixes #32832

[1]: https://github.com/angular/angular/blob/fbad4ff65/aio/src/app/shared/toc.service.ts#L68
[2]: https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach

PR Close #32871
2019-09-26 17:05:38 -07:00
George Kalpakas
fbad4ff65c build(docs-infra): upgrade cli command docs sources to c6184bf31 (#32864)
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).

##
Relevant changes in [commit range](493841df1...c6184bf31):

**Modified**
- help/build.json

##

PR Close #32864
2019-09-26 07:38:36 -07:00
Rustam
c07b6fece5 docs: added link to ngRuAir podcast (#32223)
PR Close #32223
2019-09-26 07:37:54 -07:00
Pascal Fivian
e9867e8ae1 docs: remove extra parenthesis from inline animations snippet (#32735)
PR Close #32735
2019-09-25 12:05:21 -07:00
Pete Bacon Darwin
0ea4875b10 fix(ngcc): make the build-marker error more clear (#32712)
The previous message was confusing as it could be
interpreted as only deleting the package mentioned.

Now we compute and display the actual node_modules
path to remove.

See https://github.com/angular/angular/issues/31354#issuecomment-532080537

PR Close #32712
2019-09-25 11:29:45 -07:00
Greg Magolan
c1346462db build: update to nodejs rules 0.37.1 (#32151)
This release includes a ts_config runfiles fix so also cleaning up the one line work-around from #31943.

This also updates to upstream rules_webtesting browser repositories load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories") to fix a breaking change in the chromedriver distro. This bumps up the version of chromium to the version here: https://github.com/bazelbuild/rules_webtesting/blob/master/web/versioned/browsers-0.3.2.bzl

PR Close #32151
2019-09-25 11:29:12 -07:00
Andrew Scott
c8be987b40 fix(ivy): ensure TestBed restores fields to the most original value (#32823)
PR Close #32823
2019-09-25 11:28:09 -07:00
Matias Niemelä
a54adcaff0 test(ivy): remove extra implementation of getDebugNode (#32843)
PR Close #32843
2019-09-25 11:27:33 -07:00
George Kalpakas
fe54af9ba6 build(docs-infra): upgrade cli command docs sources to 493841df1 (#32850)
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).

##
Relevant changes in [commit range](5d72355fc...493841df1):

**Modified**
- help/new.json

##

PR Close #32850
2019-09-25 11:27:03 -07:00
Andrew Kushnir
8da26d9de9 release: cut the v9.0.0-next.8 release 2019-09-25 10:38:09 -07:00
Andrew Kushnir
4dddee7424 docs: release notes for the v8.2.8 release 2019-09-25 10:31:19 -07:00
crisbeto
39bc6f7bea build: temporarily disable dynamic queries migration (#32837)
Disables the dynamic queries migration until we can land the relevant framework changes (#32686 and #32720).

PR Close #32837
2019-09-24 17:57:15 -07:00
Matias Niemelä
948714c17c revert: refactor(ivy): ensure StylingDebug instances provide context debug info (#32753) (#32841)
This reverts commit f8f7c1540a3b667a85887b881a456070b285cb6e.

PR Close #32841
2019-09-24 16:57:58 -07:00
Matias Niemelä
e668d7971d revert: feat(ivy): improve debugging experience for styles/classes (#32753) (#32841)
This reverts commit 32f4544f34594e16a17c24e7f3eba3dbec734900.

PR Close #32841
2019-09-24 16:57:58 -07:00
Issei Horie
3a96631387 docs: removed duplicated spaces in upgrade guide (#32813)
PR Close #32813
2019-09-24 14:01:42 -07:00
Issei Horie
c093390c22 docs: fix typo in upgrade guide (#32807)
PR Close #32807
2019-09-24 14:01:18 -07:00
Andrew Scott
32b6c2285e docs: add comment markers for internal goog.define replacement (#32795)
This is needed for closure to properly tree-shake ngDevMode and ngI18nClosureMode.

PR Close #32795
2019-09-24 13:59:46 -07:00
Matias Niemelä
86fd5719b5 fix(ivy): ensure multiple map-based bindings do not skip intermediate values (#32774)
This patch fixes a bug where the map-based cursor moves too far and
skips intermediate values when the correct combination of single-prop
bindings and map-based bindings are used together.

PR Close #32774
2019-09-24 11:58:52 -07:00
Matias Niemelä
32f4544f34 feat(ivy): improve debugging experience for styles/classes (#32753)
This patch introduces the `printTable()` and `printSources()`
methods to `DebugStylingContext` which can be used via the
`window.ng.getDebugNode` helpers when debugging an application.

PR Close #32753
2019-09-24 10:37:42 -07:00
Matias Niemelä
f8f7c1540a refactor(ivy): ensure StylingDebug instances provide context debug info (#32753)
This patch enables a styling debug instance (which is apart of the
`debugNode.styles` or `debugNode.classes` data structures) to expose
its context value so that it can be easily debugged.

PR Close #32753
2019-09-24 10:37:42 -07:00
Matias Niemelä
52552b0520 perf(ivy): remove extra SafeStyle detection code (#32775)
PR Close #32775
2019-09-23 14:33:09 -07:00
Matias Niemelä
5651fa3a95 fix(ivy): ensure window.ng.getDebugNode returns debug info for component elements (#32780)
Prior to this patch the `window.ng.getDebugNode` method would fail to
return the debug information for an element that is a host element to
a component.

PR Close #32780
2019-09-23 14:32:42 -07:00
Judy Bogart
353368cccd docs: correct default for router extra option (#32702)
PR Close #32702
2019-09-23 14:24:19 -07:00
Matias Niemelä
7a00c676ec build(ivy): make sure animation_world prodserver and devserver work as expected (#32778)
PR Close #32778
2019-09-23 14:18:22 -07:00
Kapunahele Wong
04ddcfecd8 docs: edit copy on getting started step 1 (#32773)
PR Close #32773
2019-09-19 14:20:50 -07:00
Keen Yee Liau
f3859ff2b9 test(language-service): remove MockData from MockTypescriptHost (#32752)
Remove MockData from the constructor parameters of MockTypescriptHost
since the entire Tour of Heroes (TOH) project is now loaded from disk.

Added a new method `reset()` to MockTypescriptHost that is necessary to
reset the state of the project before each spec if run to make sure
previous overrides are cleared.

PR Close #32752
2019-09-18 15:29:25 -07:00
Matias Niemelä
0450f39625 refactor(ivy): move all styling util code into utils/styling_utils.ts (#32731)
PR Close #32731
2019-09-18 15:06:39 -07:00
Matias Niemelä
5d12cb9fdf refactor(ivy): move styling/interfaces.ts to interfaces/styling.ts (#32731)
PR Close #32731
2019-09-18 15:06:39 -07:00
Matias Niemelä
ec0aa88f4e refactor(ivy): move styling/instructions.ts to instructions/styling.ts (#32731)
PR Close #32731
2019-09-18 15:06:39 -07:00
Matias Niemelä
f88f717094 refactor(ivy): remame styling_next directory to styling (#32731)
PR Close #32731
2019-09-18 15:06:39 -07:00
Matias Niemelä
0618bed83e refactor(ivy): combine styling testing files into one (#32731)
PR Close #32731
2019-09-18 15:06:38 -07:00
Keen Yee Liau
708ae4c8ef fix(language-service): Fix failing tests after merge (#32758)
https://github.com/angular/angular/pull/32653 and
https://github.com/angular/angular/pull/32592 created a conflict in test
that caused CI to turn red. This PR fixes the failing tests.

PR Close #32758
2019-09-18 14:37:36 -07:00
Kapunahele Wong
5c2e890d76 docs: edit copy on first step of getting started (#32751)
PR Close #32751
2019-09-18 13:36:59 -07:00
ayazhafiz
5ace90f04d test(language-service): add missing tests for templateUrls (#32592)
Add missing tests for duplicate, missing template diagnostics

PR Close #32592
2019-09-18 13:35:53 -07:00
Keen Yee Liau
9d8dc793da test(language-service): Create proper test project (#32653)
Language service uses a canonical "Tour of Heroes" project to test
various features, but the files are all contained in test_data.ts which
is hard to read and often contains errors that are difficult to catch
without proper IDE syntax highlighting. The directory structure is also
not clear from first glance.

This PR refactors the test project into standalone files in the proper
format.

Next up:
[ ] Update the interface of MockTypeScript to only accept scriptNames.
[ ] Remove test_data.ts

PR Close #32653
2019-09-18 13:07:01 -07:00
ayazhafiz
2846505dbd feat(language-service): expose determining the NgModule of a Directive (#32710)
This sets up the Language Service to support #32565.
This PR exposes a `getDirectiveModule` method on `TypeScriptServiceHost`
that returns the NgModule owning a Directive given the Directive's
TypeScript node or its Angular `StaticSymbol`. Both types are supported
to reduce extraneous helper methods.

PR Close #32710
2019-09-18 12:59:35 -07:00
Andrew Kushnir
ab29874f09 release: cut the v9.0.0-next.7 release 2019-09-18 10:38:54 -07:00
Andrew Kushnir
9b0861c649 docs: release notes for the v8.2.7 release 2019-09-18 10:23:31 -07:00
Jason Bedard
df1c456347 fix(bazel): ng_package(data) should support non-text files (#32721)
PR Close #32721
2019-09-17 15:58:42 -07:00
Pawel Kozlowski
05e1b3b312 perf(ivy): avoid unnecessary DOM reads in styling instructions (#32716)
Before this refactoring native node `classList` / `style` properties were
read even if not used. The reason for this was desire to avoid code duplication
between procedural and non-procedural renderers. Unfortunatelly for the case
which will be used by most users (a procedura renderer) the `classList` / `style`
properties were read twice, making the `setStyle` \ `setClass` functions the
most expensive ones (self time) in several benchmarks (large table, expanding
rows).

This refactoring adds a bit of code duplication in order to get better
runtime performance. The code duplication will be removed when we drop
checks for a procedural renderer.

PR Close #32716
2019-09-17 15:58:05 -07:00