2143 Commits

Author SHA1 Message Date
George Wilde
ddd3bf83c7 docs(forms): change documentation of the FormGroup patchValue method ()
Improve the grammar of the description to make it more readable.
PR Close 
2018-09-18 13:08:05 -07:00
Pete Bacon Darwin
9b1bb370a3 fix(ivy): ngcc should compile entry-points in the correct order ()
The compiler should process all an entry-points dependencies
before processing that entry-point.

PR Close 
2018-09-18 13:06:28 -07:00
Pete Bacon Darwin
976389836e build: update node type version ()
PR Close 
2018-09-18 13:06:28 -07:00
Pete Bacon Darwin
f76a9ad156 style(ivy): remove unused import ()
PR Close 
2018-09-18 13:06:28 -07:00
Pete Bacon Darwin
6f1100a7e9 refactor(ivy): use canonical-path in ngcc ()
It turns out that `path.posix` does not always reliably
return forward slash paths on Windows.

PR Close 
2018-09-18 13:06:28 -07:00
Greg Magolan
b99d7ed5bf build(bazel): update to rules_typescript 0.17.0 & rules_nodejs 0.13.4 ()
PR Close 
2018-09-18 13:05:38 -07:00
Kara Erickson
f47f2628e1 refactor(ivy): remove LNode.view ()
PR Close 
2018-09-18 13:04:23 -07:00
Kara Erickson
5653874683 fix(ivy): events should not mark views dirty by default ()
PR Close 
2018-09-17 13:02:39 -07:00
Alex Eagle
bdbb2f9bfa ci: update to bazel 0.17 ()
this includes support for @ character in labels, which we need for fine-grained deps

PR Close 
2018-09-17 12:51:52 -07:00
Kara Erickson
aedebaf025 refactor(ivy): remove LNode.tNode ()
PR Close 
2018-09-14 16:16:28 -07:00
Kara Erickson
47f4412650 refactor(ivy): LContainers should store views not nodes ()
PR Close 
2018-09-13 15:56:04 -07:00
Matias Niemelä
10a656fc38 refactor(ivy): ensure hello world doesn't pull in context discovery creation code ()
PR Close 
2018-09-12 13:25:12 -04:00
Daniel Wiehl
8dc2b119fb fix(router): mount correct component if router outlet was not instantiated and if using a route reuse strategy () ()
This unsets 'attachRef' on outlet context if no route is to be reused in route activation.

Closes 

PR Close 
2018-09-11 16:26:42 -07:00
vincecampanale
f2ba55f2fb docs(router): change description of parameter usage for navigation functions ()
PR Close 
2018-09-11 16:24:23 -07:00
Matt Keller
00d3666d95 fix(compiler): Fix look up of entryComponents in AOT Summaries ()
Previously, when you attempted to bootstrap a component that had a
router-outlet using ngsummaries, it would complain that the component
was not provided by any module even if it was. This commit fixes a
mistake (AFAICT) which caused the lookup of the component in the AOT
summaries to fail.

I believe this change is safe. I've run the affected tests within Google
and there were no breakages caused by this change.

PR Close 
2018-09-11 16:23:17 -07:00
cexbrayat
21009b06a1 fix(ivy): use proper sanitizer names ()
Fixes 

PR Close 
2018-09-11 16:22:38 -07:00
Greg Estren
f3b552f51f build(bazel): remove outdated "cfg = "data"" references ()
PR Close 

PR Close 
2018-09-11 08:27:39 -07:00
Misko Hevery
86a3be8610 docs(ivy): add explanation of LViewData ()
PR Close 
2018-09-11 07:10:15 -07:00
Miško Hevery
d5bd86ae5d fix(ivy): don't accidently read the inherited definition ()
Create getter methods `getXXXDef` for each definition which
uses `hasOwnProperty` to verify that we don't accidently read form the
parent class.

Fixes: 
Fixes: 

PR Close 
2018-09-11 07:09:38 -07:00
Alex Rickabaugh
a9099e8f70 fix(ivy): ensure Ivy *Ref classes derive from view engine equivalents ()
Various user code uses 'instanceof' to check whether a particular instance
is a TemplateRef, ElementRef, etc. Ivy needs to work with these checks.

PR Close 
2018-09-11 06:53:22 -07:00
Alex Rickabaugh
96d6b79ada feat(ivy): resolve references to vars in .d.ts files ()
Previously, if ngtsc encountered a VariableDeclaration without an
initializer, it would assume that the variable was undefined, and
return that result.

However, for symbols exported from external modules that resolve to
.d.ts files, variable declarations are of the form:

export declare let varName: Type;

This form also lacks an initializer, but indicates the presence of an
importable symbol which can be referenced. This commit changes the
static resolver to understand variable declarations with the 'declare'
keyword and to generate references when it encounters them.

PR Close 
2018-09-11 06:53:21 -07:00
Alex Rickabaugh
13ccdfd89d feat(ivy): support bootstrap in ngModuleDef ()
The bootstrap property of @NgModule was not previously compiled by
the compiler in AOT or JIT modes (in Ivy). This commit adds support
for bootstrap.

PR Close 
2018-09-11 06:53:21 -07:00
Alex Rickabaugh
a0c4b2d8f0 fix(ivy): add @nocollapse when writing closure-annotated code ()
Closure requires @nocollapse on Ivy definition static fields in order
to not convert them to standalone constants. However tsickle, the tool
which would ordinarily be responsible for adding @nocollapse, doesn't
properly annotate fields which are added synthetically via transforms.
So this commit adds @nocollapse by applying regular expressions against
code during the final write to disk.

PR Close 
2018-09-11 06:53:21 -07:00
Ben Lesh
7ba0cb7c93 refactor(ivy): remove superfluous Array check ()
related 

PR Close 
2018-09-10 14:00:58 -07:00
Vikram Subramanian
d83f9d432a fix(common): register locale data for all equivalent closure locales ()
This fix is for the issue below when compiling I18N Angular apps using closure.

For certain locales closure converts the input locale id to a different equivalent locale string. For example if the input locale is 'id'(for Indonesia) goog.LOCALE is set to 'in' and the closure locale data is registered only for 'in'. The Angular compiler uses the original input locale string, 'id' to set the LOCALE_ID token and there is a mismatch of locale used to register and locale used when requesting the locale data.

The fix is for the closure-locale.ts code to register the locale data for all equivalent locales names so that it doesn't matter what goog.LOCALE is actually set to.

PR Close 
2018-09-10 13:59:56 -07:00
Matias Niemelä
e3633888ed feat(ivy): support animation @triggers in templates ()
PR Close 
2018-09-10 13:59:27 -07:00
Kara Erickson
91d79939be refactor(ivy): traverse tNode tree directly ()
PR Close 
2018-09-10 09:59:17 -07:00
Miško Hevery
96eb79b1c7 build: add support for running builds outside of sandbox on Mac. ()
Add following to your `~/.bazelrc`. This will run the build faster locally
(outside of sandbox), but continue running the builds with sandboxing
on CI.

```
build --spawn_strategy=standalone --strategy=ESM5=sandboxed
```
PR Close 
2018-09-07 16:06:55 -07:00
Kara Erickson
83a1334876 refactor(ivy): migrate previousOrParentNode to use TNodes ()
PR Close 
2018-09-07 16:06:17 -07:00
Matias Niemelä
62be8c2e2f feat(ivy): allow combined context discovery for components, directives and elements ()
PR Close 
2018-09-07 14:14:56 -07:00
Matias Niemelä
d2dfd48be0 feat(ivy): patch animations into metadata ()
PR Close 
2018-09-07 13:46:06 -07:00
Alex Eagle
34ec9244a6 build: update to Node 10 ()
PR Close 
2018-09-06 14:58:30 -07:00
Pete Bacon Darwin
d96e962da3 test(ivy): mock the filesystem in ngcc main() integration tests ()
Bazel does not like the filesystem being modified.
This commit a temporary mock filesystem that can be modified as needed.

PR Close 
2018-09-05 11:35:47 -07:00
Pete Bacon Darwin
b0cb134815 feat(ivy): implement ngcc build marker ()
`ngcc` adds marker files to each folder that has been
compiled, containing the version of the ngcc used.

When compiling, it will ignore folders that contain these
marker files, as long as the version matches.

PR Close 
2018-09-05 11:35:47 -07:00
George Kalpakas
2a672a97ab fix(upgrade): trigger $destroy event on upgraded component element ()
Fixes 

PR Close 
2018-09-05 11:35:14 -07:00
George Kalpakas
71007ef9b2 refactor(upgrade): share code for destroying upgraded components between dynamic and static ()
PR Close 
2018-09-05 11:35:14 -07:00
Trotyl
010e35d995 feat(router): warn if navigation triggered outside Angular zone ()
closes , closes , closes 

PR Close 
2018-09-05 09:35:14 -07:00
Alex Rickabaugh
a417b2b419 fix(ivy): detect frozen flyweight objects in definitions and unfreeze ()
defineComponent() and friends can return a flyweight EMPTY object for
specific fields when they contain no data. InheritDefinitionFeature
was attempting to write into these flyweight objects, which have been
protected with Object.freeze().

This commit adds detection to InheritDefinitionFeature to identify the
frozen objects.

PR Close 
2018-09-05 09:27:41 -07:00
Igor Minar
51c0d9cae9 style(ivy): remove unused ivy code ()
PR Close 
2018-09-04 12:12:04 -07:00
Igor Minar
08dfbc5475 fix(ivy): reexport __POST_NGCC__ symbols as private to prevent DCE in FESM ()
While creating FESM files, rollup usually drops all unused symbols.
All *__POST_NGCC__ are unused unless ngcc rewires stuff. To prevent this DCE
we reexport them as private symbols. If ngcc is not used, these symbols will
be dropped when we optimize an application bundle.

We don't have an infrastructure to test this fix, so I just manually inspected
the bundles before and after to verify that the fix works.

PR Close 
2018-09-04 12:12:04 -07:00
Alex Rickabaugh
cc29b9cf93 fix(ivy): use globally unique names for i18n constants ()
Closure compiler requires that the i18n message constants of the form

const MSG_XYZ = goog.getMessage('...');

have names that are unique across an entire compilation, even if the
variables themselves are local to a given module. This means that in
practice these names must be unique in a codebase.

The best way to guarantee this requirement is met is to encode the
relative file name of the file into which the constant is being written
into the constant name itself. This commit implements that solution.

PR Close 
2018-09-04 12:09:29 -07:00
Brandon Roberts
abd29f5049 docs(forms): update API reference for reactive and template-driven forms modules ()
PR Close 
2018-08-31 13:37:40 -07:00
Pawel Kozlowski
6def18a95e fix(ivy): support directive outputs on ng-template ()
Compiler part of 
Fixes 

PR Close 
2018-08-31 13:37:16 -07:00
Pawel Kozlowski
34be51898d fix(ivy): support host bindings on dynamically created components ()
PR Close 
2018-08-31 13:36:53 -07:00
Pawel Kozlowski
1e3460be0b refactor(ivy): remove obsolete types ()
In the past factories could return an array with content queries
but we no longer manage queries in factory functions.

PR Close 
2018-08-31 13:36:22 -07:00
Greg Magolan
31349fde90 build(bazel): make resolveTypeReferenceDirectives override work with both ts 2.9 & ts 3.0 ()
PR Close 
2018-08-31 11:12:03 -07:00
Greg Magolan
910381ddbd build(bazel): fix bazel types reference directive resolves ()
PR Close 
2018-08-31 11:12:03 -07:00
Pete Bacon Darwin
20b9c61d4c perf(ivy): speed up ngcc ivy switch processing ()
Only parse the AST for ngcc ivy switch constants
if the marker is not found in the module text.

PR Close 
2018-08-31 09:47:50 -07:00
Pete Bacon Darwin
e964319fe9 test(ivy): test Esm5Renderer.getSwitchableDeclarations ()
Also incorporates a refactoring of the tests to make them less fragile.

PR Close 
2018-08-31 09:47:50 -07:00
Pete Bacon Darwin
26cd9f5433 feat(ivy): implement Renderer.getSwitchableDeclarations ()
This supports the "ngcc ivy switch" specified in .

PR Close 
2018-08-31 09:47:50 -07:00