Commit Graph

1724 Commits

Author SHA1 Message Date
Nikita Potapenko 48a1acab52 docs: fix typo in sample (#33984)
Fixes #33979

PR Close #33984
2019-11-26 16:37:17 -05:00
Kapunahele Wong 78c65c330f docs: add note about strictTemplates and strictNullChecks together (#34039)
PR Close #34039
2019-11-26 16:36:51 -05:00
ajitsinghkaler 5ff98fe701 docs: removed non-supported versions from LTS (#34005)
PR Close #34005
2019-11-26 16:36:23 -05:00
Kapunahele Wong d655093123 docs: add Animations import in Router doc (#33740)
Fixes #33665

PR Close #33740
2019-11-25 22:37:55 -05:00
Kapunahele Wong 1ab2ebc719 docs: edit EventEmitter name in styleguide (#33923)
Fixes #33890

PR Close #33923
2019-11-25 18:40:51 -05:00
Igor Minar ed55355363 fix(core): remove deprecated and defunct wtf* apis (#33949)
These apis have been deprecated in v8, so they should stick around till v10,
but since they are defunct we are removing them early so that they don't take up payload size.

PR Close #33949
2019-11-25 18:39:18 -05:00
Charles Lyding 56f33bc266 docs: initial Ivy i18n guide updates (#33762)
PR Close #33762
2019-11-25 14:12:18 -05:00
arturovt 51a56bc4c6 docs: fix typos and highlight booleans to keep consistency (#34013)
PR Close #34013
2019-11-25 11:38:06 -05:00
ajitsinghkaler 1217c6b7cc docs: replace class hero to interface wherever class properties not used (#34022)
Fixes #21186

PR Close #34022
2019-11-25 11:37:39 -05:00
JiaLiPassion 5129bccebf docs: add TracyLee to GDE list (#33947)
PR Close #33947
2019-11-22 18:40:03 -05:00
Joey Perrott e24453b9f8 docs: Add Joey Perrott to Angular team in contributors (#33962)
PR Close #33962
2019-11-22 17:40:03 -05:00
Kara Erickson a37bf9a516 docs: add examples for DI change in Ivy (#33643)
PR Close #33643
2019-11-22 13:04:24 -05:00
Santosh Yadav 9f211ba0f5 docs: add santosh yadav as GDE resource (#33818)
PR Close #33818
2019-11-22 12:45:52 -05:00
Girma Nigusse bb79018f92 docs(core): fix typo in Tour of Heroes App and Tutorial (#33931)
PR Close #33931
2019-11-22 12:45:03 -05:00
Alan Agius 5024e217d7 docs: update npm install dev command to `npm install --save-dev` (#33985)
See: https://docs.npmjs.com/specifying-dependencies-and-devdependencies-in-a-package-json-file

PR Close #33985
2019-11-22 12:38:17 -05:00
arturovt 2dd572b15c docs(http): fix typo (#33978)
PR Close #33978
2019-11-22 12:36:43 -05:00
Ralf D. Müller fd5f101bab docs: add CSRF to XSRF section of http guide (#32933)
link to the correct section of the HttpClientGuide:
if someone searches for CSRF (and not XSRF), she will not find the right section in the HttpClient guide

added CSRF as name of XSRF attack:
in order to make it easier to find the XSRF protection, I've added a reference to the other name "CSRF". The security guide has the same reference to XSRF/CSRF.
When I searched for this feature, I had quite some problems to find it because of this missing reference

PR Close #32933
2019-11-21 16:57:12 -05:00
Martina Kraus 2303dc4f28 docs: add martina kraus to GDE resources (#33719)
PR Close #33719
2019-11-21 16:52:32 -05:00
Alan Agius df71aa425f docs: clarify that `--prod` should be used to publish a library (#33959)
PR Close #33959
2019-11-21 10:45:18 -08:00
Dyma 11a35e5d14 docs: add learning resource (#33730)
PR Close #33730
2019-11-20 14:56:56 -08:00
Alyssa Nicoll 4ae754a222 docs: Update Alyssa on GDE list (#33538)
PR Close #33538
2019-11-20 14:52:00 -08:00
George Kalpakas 27562e92db fix(docs-infra): fix StackBlitz and zipped `http` examples (#33941)
Previously, the generated StackBlitz examples as well as the
corresponding downloadable zips for the `http` guide examples were not
correct and thus trying to run the app and/or tests would fail.

This commit fixes the examples:

- Replace `TestBed.inject()` (which was [introduced in v9][1]) with
  `TestBed.get()` (which is available in v8 used in the examples).
  (NOTE: The examples will soon be updated to v9 (as part of
  [FW-1609][2] and switched back to `TestBed.inject()` then.)

- Include `src/app/heroes/hero.ts` in the zip, because it is referenced
  by some of the other files and the compilation fails without it.

- Ensure `src/main-specs.ts` is not included in the zip that does not
  include the tests. Including the file broke the app, because there is
  logic in our zip-builder that renamed `main-*.ts` files to `main.ts`
  and thus `main-specs.ts` ended up overwriting the actual `main.ts`.

[1]: https://next.angular.io/guide/deprecations#angularcoretesting
[2]: https://angular-team.atlassian.net/browse/FW-1609

Fixes #33874
Fixes #33945

PR Close #33941
2019-11-20 14:44:31 -08:00
Judy Bogart 5c23ea71c4 docs: add version requirement for routing option (#33909)
PR Close #33909
2019-11-19 11:40:03 -08:00
Judy Bogart 341d5847d6 docs: add xrefs to update app and deprecations policy (#33767)
PR Close #33767
2019-11-18 09:13:16 -08:00
Pierre-Yves FARE 2e7a3e9ae6 docs: add html template for sizer component in template syntax guide (#33776)
fixes #33771

PR Close #33776
2019-11-18 09:12:45 -08:00
Pete Bacon Darwin 023c4ffdde docs(docs-infra): prevent auto-linking of snippet in guide (#33877)
By adding the `bash` language to the code snippet it will no
longer be auto-linked, which was causing a false positive link
to be rendered.

Fixes #33859

PR Close #33877
2019-11-18 09:11:01 -08:00
Santosh Yadav 6fadb7a3a4 docs: updated dynamic forms example (#31510)
Fixes #31446

PR Close #31510
2019-11-15 16:16:45 -08:00
dishanfernando ffe57a004c docs: Hyperlink to HTML & CSS (#33844)
Link to have a reference on the HTML & CSS for basic understanding.

PR Close #33844
2019-11-15 10:36:18 -08:00
Stefanie Fluin fe4447d568 feat(docs-infra): simplify image styles and remove figure references (#33748)
Reference #33259
Removes figures elements as AIO is not typically using captions or image groups where figures would be necessary or appropriate

PR Close #33748
2019-11-14 09:27:02 -08:00
Judy Bogart 6888cb3d7a docs: expand type-check info in update page (#33577)
PR Close #33577
2019-11-13 11:08:51 -08:00
Filipe Silva f922903b62 docs: remove migration-ngcc guide (#33727)
PR Close #33727
2019-11-12 14:03:48 -08:00
Filipe Silva 9a840e5021 docs: add postinstall opt-in (#33727)
PR Close #33727
2019-11-12 14:03:48 -08:00
Filipe Silva 31c5e67ba6 docs: expand configuration usage (#33229)
Followup to https://github.com/angular/angular-cli/pull/15819

PR Close #33229
2019-11-12 13:55:59 -08:00
ketangote fcde671ae2 docs: updated amexio resource description (#33645)
PR Close #33645
2019-11-12 09:52:48 -08:00
Judy Bogart c6ebcd1eb9 docs: fix numbering (#33736)
PR Close #33736
2019-11-11 12:46:34 -08:00
Alan Agius ca1ff3ea11 docs: update update guide to use `ng update` instead of `npm i` (#33726)
For more context see: https://github.com/angular/angular-cli/issues/16021

Closes: https://github.com/angular/angular-cli/issues/16021

PR Close #33726
2019-11-11 09:40:08 -08:00
Kara Erickson 1d429b2165 docs: add AOT mode default to version 9 upgrade doc (#33703)
PR Close #33703
2019-11-08 15:38:40 -08:00
JiaLiPassion a40103d849 docs: update jiali's info (#33698)
PR Close #33698
2019-11-08 14:41:16 -08:00
Németh Tamás b97577bd94 docs: grammar fix (#33170)
PR Close #33170
2019-11-08 14:40:58 -08:00
Németh Tamás 4385cbaa65 docs: add missing word (#33170)
PR Close #33170
2019-11-08 14:40:58 -08:00
Daniele Morosinotto 98766b1d07 docs: fix migration-renderer code snippets (#33553)
Fix code snippets for migration-renderer.md found in next.angular.io
PR Close #33553
2019-11-08 12:43:20 -08:00
Alan Agius 570936e39f docs: add ivy ssr opt-out (#33616)
PR Close #33616
2019-11-08 10:54:31 -08:00
Shibasish 43ffe7257a docs: describe your change... (#32914)
Grammatical changes
PR Close #32914
2019-11-08 10:52:17 -08:00
Kara Erickson c4fbd0bef7 docs: update ivy compatibility guide with latest changes (#33675)
This commit removes one of the expected Ivy changes because we have
decided to change the behavior to be more backwards-compatible.

It also adds a bug fix that is technically breaking to the list of
expected changes.

PR Close #33675
2019-11-08 10:51:52 -08:00
Santosh Yadav 0ca2a390d5 docs: app-name not rendering on browser (#33613)
Fixes #33612

PR Close #33613
2019-11-07 20:31:48 +00:00
Judy Bogart 2a4061a3fd docs: clarify status of sample app in stackblitz (#33574)
PR Close #33574
2019-11-06 19:39:12 +00:00
Srichandradeep Choudarapu 1bd8fdb766 docs: add missing parenthesis (#33559)
PR Close #33559
2019-11-05 21:08:59 +00:00
Eliran Eliassy 29007e406d docs(core): remove duplicate 'because' (#33569)
PR Close #33569
2019-11-05 21:07:17 +00:00
Doug Parker 25aaff2ee1 docs: Adding Doug Parker to contributors list. (#33516)
PR Close #33516
2019-11-05 00:55:17 +00:00
Geoff Bass 5bc1b6f9ac docs: remove redundant word from template syntax guide (#33534)
PR Close #33534
2019-11-05 00:54:47 +00:00
Brian Michalski e3189f97ff docs: Update link to angular + bazel example app (#33409)
http://github.com/angular/angular-bazel-example has been moved to rules_nodejs monorepo.
PR Close #33409
2019-11-04 20:07:37 +00:00
FabianGosebrink ac9d044cad docs: add GDE profile of Fabian Gosebrink (#33438)
PR Close #33438
2019-11-02 00:53:05 +00:00
Rick Katka 9e83814e61 docs: remove erroneous brack in animations guide (#33525)
Fixes #33459

PR Close #33525
2019-11-01 22:27:40 +00:00
Dave f185fabc11 docs: add GDE profile of David Muellerchen (#33455)
PR Close #33455
2019-11-01 22:23:06 +00:00
Mike Brocchi feb5f27d09 docs: Add Mike Brocchi to the list of GDEs (#33466)
PR Close #33466
2019-11-01 17:40:16 +00:00
Geoff Bass d863839ecc docs: fix selector in getting started guide (#33333)
PR Close #33333
2019-10-31 22:22:25 +00:00
TheMushr00m 66ab701606 docs: add example of a server in ruby for deployment (#33418)
PR Close #33418
2019-10-31 22:22:01 +00:00
Geoff Bass 64ac106248 docs: fix typo in Observables in Angular guide (#33509)
change `ActivateRoute` to `ActivatedRoute`
PR Close #33509
2019-10-31 22:21:00 +00:00
Kara Erickson 7355906a95 docs: add detailed example to ContentChildren change (#33499)
PR Close #33499
2019-10-31 13:54:47 -07:00
vikerman 12703d5601 docs: update to use latest 8.3.x CLI (#33518)
Change the "Updating to v9" docs to reflect that we want to use the latest 8.3.x CLI build for updating and not just 8.3.15.

PR Close #33518
2019-10-31 11:55:58 -07:00
Judy Bogart e4ebffab8d docs: fix format in ivy page (#33513)
PR Close #33513
2019-10-31 10:32:22 -07:00
Kapunahele Wong c35587ba56 docs: add template type-checking guide (#33421)
PR Close #33421
2019-10-30 13:49:18 -07:00
Judy Bogart fba72f0d4d docs: rewrite ivy page, add template typecheck doc (#33152)
PR Close #33152
2019-10-30 10:39:26 -07:00
Andrew Kushnir 5666d11633 docs: adding a note on ICU processing to Ivy compatibility guide (#33480)
PR Close #33480
2019-10-29 17:16:30 -07:00
John Ralph Umandal ba0c178dbb docs: fixed cli ng update reference link (#33320)
The automated link for ng update is currently going to the 
wrong page. Edit directs them to the correct page.
PR Close #33320
2019-10-29 14:03:52 -07:00
Igor Minar afa50838a7 docs: update instructions for v9 to reflect cli update (#33473)
PR Close #33473
2019-10-29 11:43:12 -07:00
thanhpd 27745c5d8c docs: added missing whitespaces (#33424)
PR Close #33424
2019-10-29 11:40:48 -07:00
thanhpd 2f6c97e93c docs: remove redundant whitespaces and fix minor typos (#33422)
PR Close #33422
2019-10-29 11:39:17 -07:00
Kara Erickson 3505692f75 docs: add @next to update instructions (#33410)
PR Close #33410
2019-10-25 13:01:04 -07:00
Kara Erickson 49bfc7421a docs: add ivy compatibility guide (#33390)
PR Close #33390
2019-10-25 09:34:01 -07:00
Kara Erickson 01455d70e3 docs: re-organize version 9 guide (#33390)
PR Close #33390
2019-10-25 09:34:01 -07:00
Geoff Bass 2805af900f docs: fix typo in getting started guide (#33372)
Add a missing word to make the phrase grammatically correct
PR Close #33372
2019-10-24 09:51:36 -07:00
Andrus Diaz 2f3812a1ef docs: add example of a server in golang for deployment (#33092)
PR Close #33092
2019-10-24 09:51:05 -07:00
Alex Rickabaugh f1269d98dc feat(ivy): input type coercion for template type-checking (#33243)
Often the types of an `@Input`'s field don't fully reflect the types of
assignable values. This can happen when an input has a getter/setter pair
where the getter always returns a narrow type, and the setter coerces a
wider value down to the narrow type.

For example, you could imagine an input of the form:

```typescript
@Input() get value(): string {
  return this._value;
}

set value(v: {toString(): string}) {
  this._value = v.toString();
}
```

Here, the getter always returns a `string`, but the setter accepts any value
that can be `toString()`'d, and coerces it to a string.

Unfortunately TypeScript does not actually support this syntax, and so
Angular users are forced to type their setters as narrowly as the getters,
even though at runtime the coercion works just fine.

To support these kinds of patterns (e.g. as used by Material), this commit
adds a compiler feature called "input coercion". When a binding is made to
the 'value' input of a directive like MatInput, the compiler will look for a
static field with the name ngAcceptInputType_value. If such a field is found
the type-checking expression for the input will use the static field's type
instead of the type for the @Input field,allowing for the expression of a
type conversion between the binding expression and the value being written
to the input's field.

To solve the case above, for example, MatInput might write:

```typescript
class MatInput {
  // rest of the directive...

  static ngAcceptInputType_value: {toString(): string};
}
```

FW-1475 #resolve

PR Close #33243
2019-10-24 09:49:38 -07:00
Igor Minar c79d6ec502 docs: deprecate esm5 and fesm5 code distribution in our npm packages (#33360)
See diff for more info.

PR Close #33360
2019-10-23 16:39:36 -07:00
Stefanie Fluin ba29e4d953 feat(docs-infra): implement figure styles (#33259)
PR#28396 originally addressed an update via issue #23983 to make images more visible with a white background (implementation of gray "lightbox").

This PR implements those styles defined in PR#28396.

PR Close #33259
2019-10-23 12:59:34 -07:00
ODAVING 1b607529a6 docs: fix spelling error in angular component (#32971)
change component class section of the docs

Closes #32948

PR Close #32971
2019-10-23 11:46:41 -07:00
Keen Yee Liau 2ecc4c7886 docs: Fix appHighlightColor typo (#33331)
In the example, there's no directive nor input that's named `appHighlightColor`.
It should be `appHighlight`, referring to the input binding.

PR Close #33331
2019-10-23 11:08:17 -07:00
Kara Erickson ed4d96f858 docs: add migrating to version 9 guide (#33339)
This commit adds a guide to AIO navigation for
"Migrating to Version 9" and moves the schematics
section into the guide that previously lived in
the deprecations page. It also pastes a snippet
of the deprecations page in the new guide so users
don't have to filter out deprecations they've seen
before.

Note: Ivy compatibility section is coming up in a
follow-up PR.

PR Close #33339
2019-10-23 09:11:40 -07:00
Kara Erickson 383457f898 docs: clean up deprecation guide (#33338)
PR Close #33338
2019-10-23 09:11:13 -07:00
cexbrayat c0b90c2010 docs: update localize migration doc (#33275)
The error message has been updated in #33199 to mention `ng add @angular/localize`.

This also fixes the tslint config (it needs to mention the complete side effect import).

PR Close #33275
2019-10-23 09:10:01 -07:00
Kapunahele Wong 398ff1e7e7 docs: add ModuleWithProviders deprecation (#33266)
PR Close #33266
2019-10-22 14:35:27 -07:00
Kapunahele Wong b3d6d500be docs: add ngcc postinstall migration doc (#33328)
PR Close #33328
2019-10-22 14:26:15 -07:00
Kapunahele Wong 1b8b04cf26 docs: add ModuleWithProviders migration doc (#33085)
PR Close #33085
2019-10-22 12:00:44 -07:00
TinyMan ec482dadb1 docs: clarrify use of sw behind redirect (#32915)
Closes #30684

PR Close #32915
2019-10-21 16:50:52 -04:00
David Sánchez 427a1ccd9a docs: clarify steps in Hosting on Firebase (#33089)
PR Close #33089
2019-10-21 16:07:04 -04:00
Carlos Ortiz García 717bace7ba docs(core): Document TestBed.get deprecation (#32974)
It was replaced by TestBed.inject, documenting such change.

PR Close #32974
2019-10-21 15:54:42 -04:00
Diego Juliao 160547dad6 docs: update deployers table with ngx-deploy-npm (#33269)
ngx-deploy-npm is a custom deployer to publish Angular libraries to NPM

PR Close #33269
2019-10-21 11:28:18 -04:00
Alan Agius 755a80c7ec docs: update universal docs for new ivy implementation (#33040)
PR Close #33040
2019-10-21 11:25:44 -04:00
Judy Bogart 8d44b5edac docs: edit and organize language service doc (#33202)
PR Close #33202
2019-10-18 18:19:05 -04:00
Kapunahele Wong 32b042014d docs: add field decorators to undecorated classes migration (#33069)
PR Close #33069
2019-10-18 16:31:10 -04:00
Kapunahele Wong 940fbbb014 docs: add localize migration doc (#33086)
PR Close #33086
2019-10-18 16:30:39 -04:00
crisbeto 1799f621b7 refactor(core): deprecate entryComponents (#33205)
With Ivy the `entryComponents` array isn't necessary anymore. These changes mark it as deprecated so that it can be removed in a future version.

PR Close #33205
2019-10-18 16:29:23 -04:00
ayazhafiz c44a1a78a9 docs: add ayaz hafiz as a contributor (#32975)
PR Close #32975
2019-10-18 14:43:13 -04:00
Amadou Sall 01d3599f32 docs: clarify instructions on where to create the proxy.conf.json file (#33244)
PR Close #33244
2019-10-18 14:40:57 -04:00
Olivier Combe 9e7668f16b fix(common): remove deprecated support for intl API (#29250)
BREAKING CHANGE:
In v5, we deprecated support for the intl API in order to improve the browser support. We are now removing these deprecated APIs for v9. See the original change here for more info on why: #18284.

PR Close #29250
2019-10-17 20:44:17 -04:00
crisbeto 9d54679e66 test: clean up explicit dynamic query usages (#33015)
Cleans up all the places where we explicitly set `static: false` on queries.

PR Close #33015
2019-10-17 16:10:10 -04:00
paulceli 3dc6490e72 docs: fix code-example displayed path (#33228)
PR Close #33228
2019-10-17 14:06:40 -04:00
Mayur Barge 51b9ce44ea docs: fix typo in getting started guide (#33185)
Fixes #33181

PR Close #33185
2019-10-16 10:23:01 -04:00
Filipe Silva ec6a9f2a02 docs: add postinstall script removal to Ivy guide (#32999)
PR Close #32999
2019-10-15 17:54:39 +00:00
Harinder Singh 0bdb71c122 docs: Update link (#33166)
Update multi-project workspace link

weblink on the angular.io website was not working, therefore, updated the multi-project workspace link.
PR Close #33166
2019-10-15 16:52:31 +00:00
Alexander von Weiss a86893c10f docs: use neutral domain name in i18n example (#33146)
PR Close #33146
2019-10-15 16:50:01 +00:00
Grigoriy Beziuk a9228aabac docs: a typo fixed in the upgrade guide (#33054)
PR Close #33054
2019-10-14 23:46:22 +00:00
Yulia Tsareva 5265b74138 docs: fix typo in guide (#33155)
PR Close #33155
2019-10-14 23:43:29 +00:00
Harinder Singh 127cec0214 docs: add command for creating angular workspace (#32804)
Improved documentation

Add command to create Angular workspace, it is required for executing `ng generate library <my-lib>` .

PR Close #32804
2019-10-14 16:32:46 +00:00
Benjamin Liii 4b30108734 docs: add note to build Angular locally (#31053)
I got the compiled failed error when I followed the tutorial, which should be informed in advance as there are people who might not know the dependency in the package.json if they have no former relevant experience.

PR Close #31053
2019-10-14 16:31:52 +00:00
Kapunahele Wong c88305d2eb docs: add Injectable migration docs (#32581)
PR Close #32581
2019-10-11 15:46:12 -07:00
crisbeto 0b1daa9ebd refactor(forms): remove ngForm element selector (#33058)
Removes the deprecated `ngForm` element selector and all of the code related to it.

BREAKING CHANGES:
* `<ngForm></ngForm>` can no longer be used as a selector. Use `<ng-form></ng-form>` instead.
* The `NgFromSelectorWarning` directive has been removed.
* `FormsModule.withConfig` has been removed. Use the `FormsModule` directly.

PR Close #33058
2019-10-11 15:43:56 -07:00
Adam J. Penn c8fd94ea44 style(router): removed extra semicolon (#33062)
PR Close #33062
2019-10-10 15:26:20 -07:00
Danny Skoog 6ab5f3648a refactor: utilize type narrowing (#33075)
PR Close #33075
2019-10-10 15:18:44 -07:00
Amadou Sall 1ae77da609 docs: update Stackblitz example for lazy-loading (#33070)
PR Close #33070
2019-10-10 15:17:32 -07:00
Amadou Sall 100ba0bd06 docs: align the lazy-loading guide to what's generated by the CLI (#33070)
PR Close #33070
2019-10-10 15:17:32 -07:00
Yulia Tsareva 676a95a21c docs: fix typo in guide (#32893)
PR Close #32893
2019-10-10 13:54:58 -07:00
John Ralph Umandal a3ef3e11c4 docs: changed 'function' word in to 'steps' (#32211)
changed word for better method's interpretation.

PR Close #32211
2019-10-10 13:54:23 -07:00
John Ralph Umandal 57d099ceea docs: fixed a misleading sentence (#32211)
Reading this sentence, make the reader think that the second argument strictly accepts one single animate, which is not
PR Close #32211
2019-10-10 13:54:23 -07:00
crisbeto 2265cb5938 refactor(core): remove deprecated Renderer (#33019)
Removes the `Renderer` and related symbols which have been deprecated since version 4.

BREAKING CHANGES:
* `Renderer` has been removed. Use `Renderer2` instead.
* `RenderComponentType` has been removed. Use `RendererType2` instead.
* `RootRenderer` has been removed. Use `RendererFactory2` instead.

PR Close #33019
2019-10-08 09:23:00 -07:00
Danny Skoog c507dda21a docs: correct sentence in AoT compiler guide (#33020)
PR Close #33020
2019-10-07 13:13:57 -07:00
Santosh Yadav 0ce8621196 docs: add dotnettricks to training (#32771)
PR Close #32771
2019-10-07 11:03:03 -07:00
JiaLiPassion 53d13c3fc6 refactor: rename unpatched event flag in Zone from `BLACK_LISTED_EVENTS` to `UNPATCHED_EVENTS` (#29617)
Closes #28529

PR Close #29617
2019-10-04 08:44:58 -07:00
Showtim3 052cae6427 docs: fix typo in attribute-directives.md (#32943)
Fixes #32924

PR Close #32943
2019-10-02 14:30:50 -07:00
Jakub Pawlot e7729b6863 docs: add comment about newEvent utility function (#32001)
PR Close #32001
2019-10-02 13:28:38 -07:00
Kai Röder 3de59d48b5 docs(docs-infra): use recommended type assertion (#31042)
Angular uses tslint:recommended by default. The default for no-angle-bracket-type-assertion is true
See https://github.com/palantir/tslint/blob/master/src/configs/recommended.ts#L69

PR Close #31042
2019-10-02 13:25:39 -07:00
Nikita Potapenko 3c7ac5f835 docs: add ngOnInit description (#32789)
PR Close #32789
2019-10-02 13:24:30 -07:00
Judy Bogart 70429bf350 docs: add lib build note (#32940)
PR Close #32940
2019-10-02 10:59:05 -07:00
Jordan Amman 448749cafa docs: added '>' to ng-template closing tag. (#32939)
Fixes #32931

PR Close #32939
2019-10-02 09:44:23 -07:00
Alan Agius 5d5c94d83a feat(service-worker): remove deprecated `versionedFiles` option (#32862)
BREAKING CHANGE:

Remove deprecated option `versionedFiles` from service worker asset group configuration in `ngsw-config.json`

Before
```json
"assetGroups": [
  {
    "name": "test",
    "resources": {
      "versionedFiles": [
        "/**/*.txt"
      ]
    }
  }
]
```

After
```json
"assetGroups": [
  {
    "name": "test",
    "resources": {
      "files": [
        "/**/*.txt"
      ]
    }
  }
]
```

PR Close #32862
2019-10-02 09:30:59 -07:00
Kapunahele Wong 206fb82330 docs: add dynamic queries flag migration documentation (#32582)
PR Close #32582
2019-10-01 17:19:05 -07:00
Judy Bogart 088435c5eb docs: emphasize headers for code examples (#32938)
PR Close #32938
2019-10-01 14:45:29 -07:00
Joshua Colvin 32b6548be9 docs: fix capitalization in elements docs (#32917) (#32936)
PR Close #32917

PR Close #32936
2019-10-01 14:44:49 -07:00
Gérôme Grignon b3549e6680 docs: fix typo in creating-libraries (#32930)
PR Close #32930
2019-10-01 10:59:01 -07:00
Hoel IRIS 45c893d0e1 docs(service-worker): add info about recovering from degraded Driver state (#32682)
Related to #31865

PR Close #32682
2019-09-30 14:15:35 -07:00
Judy Bogart d5071651df docs: add filename headers to code examples (#32701)
PR Close #32701
2019-09-30 10:28:20 -07:00
Judy Bogart 8985233804 docs: add prompts section to schematic guide (#32728)
PR Close #32728
2019-09-30 10:27:38 -07:00
Yulia Tsareva 877f9ad7b9 docs: add missing space between "Component" and "will" in guide (#32885)
Closes angular/angular#32873

PR Close #32885
2019-09-27 15:59:29 -07:00
john li 5ae48d52e6 docs: fix typo in deployment guide (#32777)
The typo causes most of the callout to not appear on the page. The issue 
appears at the bottom of the "Lazy loading" section on the live site:
https://angular.io/guide/deployment#lazy-loading
PR Close #32777
2019-09-27 10:32:38 -07:00
Harinder Singh 278d634723 docs: correct spelling of HTMLTableCellElement in Template Syntax (#32805)
Spelling Correction in Docs

Corrected spelling; From `HTMLTableCellElment` to  `HTMLTableCellElement`.

PR Close #32805
2019-09-27 10:03:52 -07:00
Reuben Wilson f6914159e4 docs: fix sentence phrasing (#32846)
`In this section, you'll add a "Buy" button the product details page.` -> `In this section, you'll add a "Buy" button to the product details page.`
PR Close #32846
2019-09-27 10:03:22 -07:00
Jordan Amman 2e730287fb docs: clarify sentence in lifecycle hooks doc (#32860)
PR Close #32860
2019-09-27 10:02:54 -07:00
Rustam c07b6fece5 docs: added link to ngRuAir podcast (#32223)
PR Close #32223
2019-09-26 07:37:54 -07:00
Issei Horie 3a96631387 docs: removed duplicated spaces in upgrade guide (#32813)
PR Close #32813
2019-09-24 14:01:42 -07:00
Issei Horie c093390c22 docs: fix typo in upgrade guide (#32807)
PR Close #32807
2019-09-24 14:01:18 -07:00
Kapunahele Wong 04ddcfecd8 docs: edit copy on getting started step 1 (#32773)
PR Close #32773
2019-09-19 14:20:50 -07:00
Kapunahele Wong 5c2e890d76 docs: edit copy on first step of getting started (#32751)
PR Close #32751
2019-09-18 13:36:59 -07:00
Aristeidis Bampakos cd4021ba41 docs: Typo fixes in hierarchical DI guide (#32536)
Introduce minor typo fixes in the guide for hierarchical dependency injection

PR Close #32536
2019-09-17 13:37:53 -07:00
Judy Bogart 4c061271db docs: add autoprefixer backward compatability instruction (#32109)
PR Close #32109
2019-09-16 10:48:02 -07:00
Kapunahele Wong bd679581e2 docs: add undecorated classes migration faq (#32478)
PR Close #32478
2019-09-12 12:16:14 -07:00
Kapunahele Wong 222af38462 docs: move renderer2 deprecation guide into own file (#32626)
PR Close #32626
2019-09-12 10:42:59 -07:00
Judy Bogart 5cf597249c docs: modify lazy-load module instructions for new cli flag (#32588)
PR Close #32588
2019-09-12 10:23:18 -07:00
Judy Bogart a32df388f8 docs: fix doc links to current version (#32566)
PR Close #32566
2019-09-11 19:27:00 -04:00
Judy Bogart 8a911773b8 docs: add header to code examples (#32563)
PR Close #32563
2019-09-11 19:26:19 -04:00
idzark 79b673a17f docs: add mdb angular boilerplate to docs resources (#30448)
PR Close #30448
2019-09-10 17:22:31 -04:00
Kapunahele Wong 25d90dabbe docs: port accessibility app from stackblitz to aio (#32377)
Fixes #32320

PR Close #32377
2019-09-10 13:11:48 -04:00
Tom Kwong e38351fce7 docs: fixed typo for toh-pt5.md (#32362)
PR Close #32362
2019-09-10 13:03:36 -04:00
Trevor Karjanis 5b2408f0a6 docs: fix typos in the routing and testing documentation (#32329)
PR Close #32329
2019-09-10 07:58:44 -04:00
Phaneendra 2230dfaea7 docs: describe your change... (#32552)
Properly Closed Bracket for the header
PR Close #32552
2019-09-10 06:30:05 -04:00
Carlos Ortiz García 9166baf709 refactor(core): Migrate TestBed.get to TestBed.inject (#32382)
This is cleanup/followup for PR #32200

PR Close #32382
2019-09-09 19:10:54 -04:00
Leonardo Zizzamia 66df745721 docs: add NG Rome MMXIX to Events resources (#31500)
PR Close #31500
2019-09-09 15:56:23 -04:00
Kapunahele Wong 33038f6ebe docs: edit copy and example in hierarchical injectors guide (#32501)
Fixes #32461

PR Close #32501
2019-09-06 18:28:42 -04:00
Dominik Pieper 8ae7f14252 docs: add akita to the list of data libraries (#32505)
PR Close #32505
2019-09-06 14:58:16 -04:00
Timar 4c3674f660 docs: expand abbreviation in providers guide (#32400)
The intro paragraph currently uses the DI abbreviation,
but it is clearer with DI written out and linked to the DI guide.

PR Close #32400
2019-09-05 18:59:55 -04:00
Potapy4 36d613dd67 docs: update default path for xi18n (#32480)
PR Close #32480
2019-09-05 13:34:18 -04:00
alexzuza e505fa61f3 docs: add Alexey Zuev to GDE resources (#32440)
PR Close #32440
2019-09-05 13:34:01 -04:00
John Ralph Umandal cc06153e85 docs: added note in animation keyframe offset (#32350)
Not mentioned in the docs.
Whenever offset property is used inside a keyframe's step at least once, then it must be defined to all the steps.
When read the first time, I supposed that the API automatically sets an even offset to the remaining not defined offsets, which is not

PR Close #32350
2019-09-05 13:33:26 -04:00
AMarinov 01e0f58dd6 docs: Updating the Ignite UI for Angular url (#32417)
PR Close #32417
2019-09-04 11:51:40 -07:00
Mirco Widmer cfa09b84dd docs: fix typo in structural directive example (#32459)
Fixes #32458

PR Close #32459
2019-09-04 11:36:02 -07:00
Alan e213080c0b docs: add app-shell production reference (#32471)
PR Close #32471
2019-09-04 11:34:17 -07:00
Tiep Phan 04d4fea3e8 docs: correct @ngtools/webpack url (#32407)
Fixes #32385

PR Close #32407
2019-09-03 12:00:19 -07:00
Kirk Larkin d0b3688a23 docs: removed duplicate "compilerOptions" property (#32449)
PR Close #32449
2019-09-03 11:57:32 -07:00
Santosh Yadav 9bbe67f286 docs: add clarification regarding development in older browsers in Deployment guide (#32210)
Fixes #32199

PR Close #32210
2019-08-30 13:53:11 -04:00
Issei Horie 03cbce8c66 docs: fix typo in compiler options guide (#32348)
PR Close #32348
2019-08-29 12:35:25 -07:00
Amadou Sall 0a09fb1432 docs: fix a minor typo in the HTTP guide (#32359)
"of typed" should be "of type"
PR Close #32359
2019-08-28 09:40:09 -07:00
Judy Bogart 2f6062f632 docs: fix callout header (#32325)
PR Close #32325
2019-08-28 09:06:07 -07:00
Judy Bogart e3f42818e9 docs: add detail to router event doc (#32140)
PR Close #32140
2019-08-27 16:17:06 -07:00
Judy Bogart ef2047555a docs: clean up formats in template syntax guide (#32197)
PR Close #32197
2019-08-27 16:14:24 -07:00
Jordan Nelson d953c1cee3 docs: update marketing resources.json with ExtAngular (#32126)
PR Close #32126
2019-08-27 16:12:31 -07:00
Ankit Prajapati 7c7fcd7ab8 docs: change lite-server baseDir path to output folder (#32164)
In lite-server baseDir, path should be the output folder path, So need to change `baseDir="dist"` to `baseDir="dist/project-name"`

PR Close #32164
2019-08-27 15:53:37 -07:00
Aristeidis Bampakos 55eaa5fb6d docs: Use ngOnInit to fetch data from services in the getting started guide (#32273)
Call data services inside ngOnInit interface implementation of components.

closes #32048

PR Close #32273
2019-08-27 09:08:25 -07:00
Gabor Szekely 70cf8ed05d docs: Fix typo in singleton-services.md page (#32330)
There is a typo in the first sentence of the singleton-service.md documentation page.
PR Close #32330
2019-08-27 09:07:18 -07:00
Alan c7c7f9fbe8 style: align i18n angular config (#32334)
PR Close #32334
2019-08-27 09:06:51 -07:00
Alan 1cb62346e4 docs: update i18n docs sample to cater for latest raw-loader version (#32334)
`raw-loader` version 2+ which is used in the CLI version 8 introduced a breaking change and now uses `export default` instead of `module.exports`.

See: https://github.com/webpack-contrib/raw-loader/blob/master/CHANGELOG.md#200-2019-03-18

Closes #32333

PR Close #32334
2019-08-27 09:06:51 -07:00
Judy Bogart 3a4839c97e docs: reference articles specifically (#32221)
PR Close #32221
2019-08-26 15:03:04 -07:00
Judy Bogart 82abbecddf docs: add links to web.dev sw articles (#32221)
resolves issue 32218

PR Close #32221
2019-08-26 15:03:04 -07:00
Filipe Silva 860b5d0efa docs: convert Ivy opt-in doc to opt-out (#31858)
PR Close #31858
2019-08-26 12:23:07 -07:00
Issei Horie 9bc9685911 docs: fix typo in compiler options guide (#32312)
PR Close #32312
2019-08-26 11:47:39 -07:00
Emmanuel DEMEY 25f31f2a14 docs: Update the aria-valuemax attr of the sample (#32261)
In order to be the same value as the one use here : https://stackblitz.com/edit/angular-kn5jdi?file=src%2Fapp%2Fprogress-bar.ts
PR Close #32261
2019-08-26 10:21:09 -07:00
Alan ae9960be53 docs: remove universalProject option from app shell docs (#32281)
This option has been deprecated in verson 9 as it has no effect
https://github.com/angular/angular-cli/pull/15394

PR Close #32281
2019-08-26 09:40:07 -07:00
John Ralph Umandal e188c9703c docs: fix animations reference links to api pages (#32267)
The automated links for state() and group() are currently going to the
wrong api pages. Edit directs them to the correct animations api pages.

PR Close #32267
2019-08-26 09:31:24 -07:00
Richard Lea b9fbd9bb03 docs: fix wrong HttpEventType of HttpResponse class (#32296)
PR Close #32296
2019-08-26 09:28:56 -07:00
Kapunahele Wong 9bb5f05cb9 docs: fix http example to use correct property (#32288)
Fixes #31814

PR Close #32288
2019-08-23 09:02:05 -07:00
mgechev 21bb74d16f docs: improve structure (#32227)
PR Close #32227
2019-08-22 13:29:48 -07:00
mgechev 1d1ab37546 docs: fix typo (#32227)
PR Close #32227
2019-08-22 13:29:48 -07:00
mgechev a00824c986 docs: restructure the ng deploy section (#32227)
PR Close #32227
2019-08-22 13:29:48 -07:00
mgechev d5aca7ef51 docs: address comments in the ng deploy guide (#32227)
PR Close #32227
2019-08-22 13:29:47 -07:00
mgechev 47cc92f004 docs: fix broken links to deployment packages (#32227)
PR Close #32227
2019-08-22 13:29:47 -07:00
mgechev e21e01ca22 docs: add ng deploy to the deployment guide (#32227)
PR Close #32227
2019-08-22 13:29:47 -07:00
Judy Bogart 21edc6a82e docs: update http guide (#32045)
PR Close #32045
2019-08-22 06:39:56 -07:00
Judy Bogart b85ac03136 docs(upgrade): position old setup guide as legacy until it can be removed (#32193)
PR Close #32193
2019-08-21 15:20:48 -07:00
Judy Bogart 7fed0faa44 docs: edit and organize aot doc (#32028)
PR Close #32028
2019-08-21 15:19:30 -07:00
Kara Erickson c957dfc167 docs: update collaborators page (#32229)
PR Close #32229
2019-08-21 08:26:43 -07:00
Alex Rickabaugh ec4381dd40 feat: make the Ivy compiler the default for ngc (#32219)
This commit switches the default value of the enableIvy flag to true.
Applications that run ngc will now by default receive an Ivy build!

This does not affect the way Bazel builds in the Angular repo work, since
those are still switched based on the value of the --define=compile flag.
Additionally, projects using @angular/bazel still use View Engine builds
by default.

Since most of the Angular repo tests are still written against View Engine
(particularly because we still publish VE packages to NPM), this switch
also requires lots of `enableIvy: false` flags in tsconfigs throughout the
repo.

Congrats to the team for reaching this milestone!

PR Close #32219
2019-08-20 16:41:08 -07:00
Judy Bogart e85ec23037 docs(service-worker): mention that dataGroups only cache non-mutating requests (#32142)
Fixes #28988

PR Close #32142
2019-08-19 10:11:28 -07:00
Kapunahele Wong 1c6516199e docs: clarify hierarchical injectors (#28700)
PR Close #28700
2019-08-15 12:43:51 -07:00
Judy Bogart 843881120a docs: doc browser support for service workers (#32046)
PR Close #32046
2019-08-14 11:58:20 -07:00
Jordan Nelson 7d4c9e4b67 docs: update marketing resources with Angular UI Toolkit (#31969)
PR Close #31969
2019-08-13 11:36:37 -07:00
Judy Bogart a95f860a96 docs: correct description of animation example (#32009)
PR Close #32009
2019-08-13 11:16:31 -07:00
Kapunahele Wong 3cd8a2b907 docs: update events page and fix ordering (#32106)
PR Close #32106
2019-08-13 09:57:28 -07:00
Judy Bogart 695f322dc1 docs: clarify pipe naming (#31806)
PR Close #31806
2019-08-09 10:45:49 -07:00
Syu Kato f2466cf4ee docs: fix cli builder doc (#31305)
PR Close #31305
2019-08-09 10:42:23 -07:00
Judy Bogart 17e289c39f docs: correct description of output decorator and add links to guide (#31780)
PR Close #31780
2019-08-08 12:15:29 -07:00
Judy Bogart 2913340af7 docs: update rxjs refs (#31780)
PR Close #31780
2019-08-08 12:15:29 -07:00
Judy Bogart f8c27d42ed docs: add note on compatibility mode (#31808)
PR Close #31808
2019-08-08 12:13:57 -07:00
Kapunahele Wong 17bb633031 docs: remove download for testing examples (#31949)
Examples for testing are designed specifically to run in StackBlitz and
are not regular cli projects (e.g. their `main.ts` files may load and run
tests instead of bootstrapping an app). They are not intended to be
downloaded and built/run locally using the cli.

In order to avoid confusing users, this commit removes the download links
from the guide. If desired, the projects can still be exported locally
via StackBlitz's UI.

Related to #31020 and #31937.

PR Close #31949
2019-08-08 12:13:29 -07:00
Simon Kurtz b5b33d12d6 docs: remove extraneous word from sentence in styleguide (#32038)
PR Close #32038
2019-08-08 11:43:12 -07:00
Simon Kurtz 22d3cabc10 docs: add missing Oxford comma in styleguide (#32040)
PR Close #32040
2019-08-08 11:42:36 -07:00
Daniel Waxweiler 939529ce5d docs: remove duplicate sentence in toh-pt5 (#32021)
PR Close #32021
2019-08-08 11:19:37 -07:00
Simon Kurtz 8af2cc1efe docs: use proper case in styleguide sentence (#32039)
PR Close #32039
2019-08-08 11:15:52 -07:00
Kapunahele Wong e5a89e047c docs: update node:8-browsers to 10 in testing (#32049)
Fixes #31993

PR Close #32049
2019-08-08 11:15:23 -07:00
Judy Bogart 0709ed4c2b docs: add doc for compiler options (#31829)
PR Close #31829
2019-08-05 13:01:10 -07:00
EddyP23 f542649b2b docs: fix typo in Workspace Config guide code snippet (sourceMaps --> sourceMap) (#31957)
PR Close #31957
2019-08-05 12:57:18 -07:00
George Kalpakas 2e84f4e0cd build(docs-infra): fix StackBlitz projects and ZIPs for `testing` guide examples (#31937)
- Update the `stackblitz.json` config files (used for generating
  Stackblitz projects and ZIP archives) to include the correct files
  (taking into account the current layout of the example projects).
- Update the boilerplate files for `testing` examples to match the
  current layout of the example projects.

PR Close #31937
2019-08-05 09:54:52 -07:00
George Kalpakas 8b94d6a402 build(docs-infra): remove unused StackBlitz/ZIP configurations for `setup` example (#31937)
The generated StackBlitz project and ZIP archives are no longer used
(and they are broken anyway), so removing them altogether to avoid
confusion.

Note: Still keeping the example project, because that is referenced in
the `setup` guide.

PR Close #31937
2019-08-05 09:54:52 -07:00
Alan ebb27727e4 docs: add `anyComponentStyle` budget description (#31955)
In CLI 8.2 we introduced a new budget see: https://github.com/angular/angular-cli/pull/15127

PR Close #31955
2019-08-02 09:35:38 -07:00
mgechev 046532b661 docs: add links to web.dev/angular guides (#31804)
This PR adds the following links to web.dev/angular:

1. Link to the guides in the resource section under "Online Training"
2. Links to code-splitting & preloading in the lazy-loading guide
3. Link to the accessibility guide on web.dev/angular

PR Close #31804
2019-08-01 17:45:43 -07:00
Yann Bertrand 9e9179e915 docs: update Zenika trainings URL in resources.json (#31910)
PR Close #31910
2019-08-01 10:09:49 -07:00
kristinavavrova 8e7a0d4ff9 docs: add ReactiveConf 2019 to events (#31895)
PR Close #31895
2019-07-31 11:37:44 -07:00
Ben Elliott 3479fddf68 docs: fix typo in Animation guide (#31888)
PR Close #31888
2019-07-30 12:58:52 -07:00
Ben Elliott 5bebac42f9 docs: change Angular Material Design to Material Design in animations guide (#31889)
PR Close #31889
2019-07-30 12:56:22 -07:00
katryo 14ae50b4c3 docs: fix header mistake (#31811)
The code example refers to `src/app/heroes/heroes.component.html` but its header was `src/app/hero.service.ts` which was obviously a mistake.
PR Close #31811
2019-07-26 14:01:28 -07:00
George Kalpakas a86850e3f2 refactor(docs-infra): remove obsolete `format` attribute from code examples (#31674)
The `format` attribute is an artifact of an old version of the docs
tooling (before moving it into the angular/angular repo) and no longer
does anything. People are still copy-pasting it from existing examples.

This commit removes all occurrences of the `format` attribute on code
examples.

PR Close #31674
2019-07-24 14:38:54 -07:00
George Kalpakas 1bcd58cee8 refactor(docs-infra): remove `linenums=false` since it is now the default (#31674)
PR Close #31674
2019-07-24 14:38:54 -07:00
George Kalpakas dd0be7feb7 fix(docs-infra): always default to no linenums in `<aio-code>` (#31674)
Previously, `linenums` defaulted to true if the content was more than 10
lines long and false otherwise.

Since in most cases linenums add unnecessary visual noise, this commit
changes `linenums` to always default to false (regardless of the size of
the content). It can be still be turned on by explicitly setting to true
or a number.

PR Close #31674
2019-07-24 14:38:54 -07:00
Max Ivanov 5ae9b76a9b docs: add ngxs to library section (#31792)
PR Close #31792
2019-07-23 21:14:44 -07:00
Kapunahele Wong 8f084d7214 docs: clarify toh (#28571)
PR Close #28571
2019-07-22 09:46:27 -07:00
Eneko Nieto ef75fb8ecd docs: rephrased explanation to fork before save (#31384)
PR Close #31384
2019-07-18 16:46:13 -07:00
Jane Sandberg 1b6e8411bd docs: fix typo in workspace config section (#31630)
This commit adds a missing word to the section on alternate build
configurations.

PR Close #31630
2019-07-18 14:27:17 -07:00
Jonathan Pool 9ef9bfe76b docs: change to explicit label type in getting-started form (#31213)
PR Close #31213
2019-07-18 10:32:04 -07:00
George Kalpakas 32c07ceca0 docs(core): fix typo in event-binding code example (#31611)
`item` is an object, so it is stringified to `[object Object]`. Using
its `name` property produces a more meaningful message.

PR Close #31611
2019-07-17 13:26:48 -04:00
Eric Corson d3744457ab docs: fix typo in CLI overview (#31608)
PR Close #31608
2019-07-17 13:26:31 -04:00
Kapunahele Wong fc61284dbe docs: remove prerequisite section in NgModules docs (#31169)
PR Close #31169
2019-07-17 13:26:00 -04:00
Judy Bogart 897bd18fbc docs: clarify meaning of injectable decorator (#31573)
PR Close #31573
2019-07-16 23:57:50 -04:00
Santosh Yadav f166b6d8f6 docs: add note about current working directory for cli projects (#31507)
Fixes #29878

PR Close #31507
2019-07-16 13:02:56 -04:00
Santosh Yadav 40705f3366 docs: include svg files in stackblitz and download examples (#31559)
Fixes #31537

PR Close #31559
2019-07-15 16:48:23 -04:00
Kapunahele Wong 19bc11139d docs: fix typo in static query migration guide (#31572)
PR Close #31572
2019-07-15 16:46:33 -04:00
istiti caf8c0a437 docs: add FAQ about updating libraries to static query migration guide (#31447)
PR Close #31447
2019-07-15 13:57:43 -04:00
Stephen Fluin d6c80871f5 docs: remove and update resource list (#31469)
PR Close #31469
2019-07-15 12:23:33 -04:00
Ivan Tham edc51f76c4 style(docs-infra): fix indentation in `rx-library` example (#31553)
PR Close #31553
2019-07-15 12:13:19 -04:00
Kapunahele Wong c529be9f24 docs: add microsyntax details (#31517)
PR Close #31517
2019-07-12 17:55:57 -04:00
Kapunahele Wong 7c62a8f9ca docs: remove heroes reference in i18n example (#31515)
Closes #31514

PR Close #31515
2019-07-11 15:07:55 -04:00
Snehal Baghel 7ea6073534 docs: add angular-in-depth to community curations (#31212)
PR Close #31212
2019-07-11 11:43:34 -04:00
Kapunahele Wong fe1793844d docs: fix typo in Template Syntax headers (#31474)
Fixes #31467

PR Close #31474
2019-07-11 11:40:40 -04:00