5 Commits

Author SHA1 Message Date
Joey Perrott
dffcca73e4 fix(dev-infra): clean up usages within pullapprove tooling ()
Clean up pullapprove tooling to use newly created common utils.
Additionally, use newly created logging levels rather than
verbose flagging.

PR Close 
2020-06-04 12:43:44 -07:00
Joey Perrott
d1ea1f4c7f build: update license headers to reference Google LLC ()
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close 
2020-05-26 14:26:58 -04:00
Joey Perrott
367f6fe12d feat(dev-infra): migrate pullapprove tool to use new logging system ()
Migrate the pullapprove tool in ng-dev to use new logging system rather
than directly calling console.* to create a better experience
for users.

PR Close 
2020-05-21 17:40:35 -04:00
Paul Gschwendtner
f0c570bd41 feat(dev-infra): pullapprove verify should handle files in conditions ()
Currently, when verifying our pullapprove configuration, we don't
respect modifications to the set of files in a condition.

e.g. It's not possible to do the following:

```
contains_any_globs(files.exclude(...), [
```

This prevents us from having codeowner groups which match a directory,
but want to filter out specific sub directories. For example, `fw-core`
matches all files in the core package. We want to exclude the schematics
from that glob. Usually we do this by another exclude condition.

This has a *significant* downside though. It means that fw-core will not
be requested if a PR changes schematic code, _and_ actual fw-core code.

To support these conditions, the pullapprove verification tool is
refactored, so that it no longer uses Regular expressions for parsing,
but rather evaluates the code through a dynamic function. This is
possible since the conditions are written in simple Python that can
be run in NodeJS too (with small modifications/transformations).

PR Close 
2020-04-23 12:17:10 -07:00
Joey Perrott
83e4a76afa feat(dev-infra): handle excluding files via globs in pullapprove ()
Updates the pullapprove verification script to handle
cases of excluding globs from groups.

PR Close 
2020-03-27 11:12:48 -07:00