Peter Bacon Darwin
fc86352adf
build(aio): use http push for navigation.json
2017-10-20 09:41:02 -07:00
Peter Bacon Darwin
441e01c568
fix(aio): simplify GaService to avoid e2e test failures
...
The GaService and the E2E specs were unnecessarily complicated and had
arbitrary async timeouts to ensure that the interplay between the GA
library code and the rest of the app worked correctly. This resulted
in potential flaky tests if the timeouts were not adequate; this was
experienced when Travis upgraded to Chrome 62.
The new approach is to block loading of the Analytics library altogether
if there is a `__e2e__` flag set in the `SessionStorage` of the browser.
It doesn't appear to be enough just to set the flag directly on the
window. I think this is because the window gets cleaned when navigation
occurs (but I am not certain).
The downside of this is that we had to add a small piece of extra logic
to the GA snippet in index.html; and we also had to switch from using
`<script async ...>` to a programmatic approach to loading the GA library
which prevents the browser from eagerly fetching the library. This may
be mitigated by adding it to the HTTP/2 push configuration of the Firebase
hosting.
Re-enables the test that was disabled in https://github.com/angular/angular/pull/19784
Closes #19785
2017-10-20 09:40:52 -07:00
Filipe Silva
14380ff086
build: add warning about changing ngtools_api2
2017-10-20 09:39:30 -07:00
Filipe Silva
820bb7bd8c
revert: ci: use chrome stable ( #18307 )
...
This reverts commit 8bcb268140
.
2017-10-20 09:38:59 -07:00
Tobias Bosch
230b98d4dd
docs: add changelog for 5.0.0-rc.3
2017-10-18 17:23:09 -07:00
Tobias Bosch
065ea926c0
release: cut the 5.0.0-rc.3 release
2017-10-18 17:23:09 -07:00
Tobias Bosch
9b9820858e
docs: add changelog for 4.4.6
2017-10-18 17:23:09 -07:00
Tobias Bosch
b922743f6e
build: narrow TS version to >=2.4.2 and <2.5 ( #19787 )
...
As this is the only version range that we tested against in G3.
We will support newer versions of TypeScript soon
after the Angular 5 release.
Closes #19750
PR Close #19787
2017-10-18 11:20:23 -07:00
Alex Rickabaugh
04ab9f1917
fix(common): attempt to JSON.parse errors for JSON responses ( #19773 )
...
PR Close #19773
2017-10-18 11:18:58 -07:00
Chuck Jazdzewski
25cbc98979
fix(compiler-cli): do not add references to files outside of `rootDir` ( #19770 )
...
References to resources (such as .css files) that are generated into
the `outDir` directory outside of `rootDir` would cause a spurious
compiler error about not being able to find a files that ends in
'.ngstyle.ts'.
Also fixed a minor issue in compiler error reporting
Fixes : #19765 , #19767
PR Close #19770
2017-10-18 11:18:50 -07:00
cole-beckwith-sp
3861ba2929
docs(changelog): fix typo ( #19766 )
...
PR Close #19766
2017-10-18 11:18:42 -07:00
Alex Rickabaugh
3bcf0cf472
fix(service-worker): PushEvent.data has to be decoded ( #19764 )
...
PushEvent.data is not the data object itself, but an instance representing
the data in wire format, with methods to synchronously decode it to JSON,
ArrayBuffer, etc. NGSW assumes all push data is in JSON format.
PR Close #19764
2017-10-18 11:18:34 -07:00
Alex Rickabaugh
396c2417d9
fix(service-worker): freshness strategy should clone response for cache ( #19764 )
...
When Cache.put() is called with a Response, it consumes the response. If
the Response is used for any other purpose (such as satisfying the
original FetchEvent) it must be cloned first.
A bug exists in the mocks used for SW tests, where this condition is not
validated. The bodies of MockResponses can be utilized repeatedly without
erroring in the same way that a real browser would. This bug is fixed by
this commit, which causes tests for the freshness strategy of data caching
to start failing.
The cause of this failure is a second bug in the data caching code, where
the Response is not cloned prior to being passed to Cache.put(). This is
also fixed.
PR Close #19764
2017-10-18 11:18:34 -07:00
Shai Reznik
fcfb1544e8
docs(aio): changed confusing term ( #19762 )
...
Controller should be decorator I believe
PR Close #19762
2017-10-18 11:18:26 -07:00
Alex Eagle
56774dfb79
fix(compiler-cli): diagnostics file paths relative to cwd, not tsconfig ( #19748 )
...
PR Close #19748
2017-10-18 11:18:17 -07:00
Matias Niemelä
c0cc6eeca1
test(animations): ensure :enter callbacks fire on container insertion ( #19674 )
...
PR Close #19674
2017-10-18 11:18:08 -07:00
vsavkin
6f2939da62
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-18 11:17:55 -07:00
Jason Aden
7d1abd9adb
build: update to rxjs@5.5.0 ( #19345 )
...
PR Close #19345
2017-10-18 11:17:43 -07:00
Tobias Bosch
81173b0d29
fix(aio): make tests less flaky ( #19784 )
...
PR Close #19784
2017-10-18 10:19:24 -07:00
Tobias Bosch
b0c7ea8181
Revert "fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )"
...
This reverts commit c569b75249
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:58:41 -07:00
Tobias Bosch
30ecb6e88a
Revert "test(animations): ensure :enter callbacks fire on container insertion ( #19674 )"
...
This reverts commit 41f57affb6
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:57:56 -07:00
Tobias Bosch
8d735da5d8
Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )"
...
This reverts commit 5a9ed2de27
.
As it broke an internal test.
2017-10-18 09:56:59 -07:00
Matias Niemelä
5a9ed2de27
fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )
...
Closes #19100
PR Close #19753
2017-10-17 20:57:57 -07:00
Matias Niemelä
41f57affb6
test(animations): ensure :enter callbacks fire on container insertion ( #19674 )
...
PR Close #19674
2017-10-17 20:57:48 -07:00
vsavkin
c569b75249
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-17 20:57:30 -07:00
Tobias Bosch
01e4aa5427
build: remove required BrowserStack run as it fails with “Access denied” ( #19769 )
...
See #19768
PR Close #19769
2017-10-17 15:51:40 -07:00
Tobias Bosch
ad130d62d8
fix(compiler): add first bazel test for `ng_module` ( #19703 )
...
We were missing quite a bit of test coverage,
this is the start of recreating it.
PR Close #19703
2017-10-17 15:18:31 -07:00
Vohmyanin Sergey Vasilevich
621f87b2bd
fix(service-worker): use posix path resolution for generation of ngsw.json ( #19527 )
...
PR Close #19527
2017-10-17 15:18:17 -07:00
Tobias Bosch
64b36190de
build: don’t make BrowserStack required as it fails with “Access denied”
...
See #19768
2017-10-17 14:56:10 -07:00
Matias Niemelä
507290d30d
build: fix broken path for animations in .pullapprove ( #19453 )
...
PR Close #19453
2017-10-17 10:45:10 -07:00
Trotyl
15a8429b96
fix(service-worker): add missing annotation for SwPush ( #19721 )
...
PR Close #19721
2017-10-17 10:38:45 -07:00
Jules Kremer
9723a362b6
docs(aio): update 2018 events ( #19706 )
...
update ac 2017 dates
PR Close #19706
2017-10-17 10:38:37 -07:00
Peter Bacon Darwin
d75a9fabdc
ci: validate commit messages correctly when not on master ( #19685 )
...
PR Close #19685
2017-10-17 10:38:29 -07:00
Kapunahele Wong
9b264c5c78
docs(aio): change in-mem-web-api version for examples ( #19668 )
...
PR Close #19668
2017-10-17 10:38:15 -07:00
Chuck Jazdzewski
60bdcd6f5f
fix(compiler): generate correct imports for type check blocks ( #19582 )
...
Fixes : #19485
PR Close #19582
2017-10-17 10:37:55 -07:00
Matias Niemelä
d035175cdb
fix(animations): ensure inner :leave animations do not remove node when skipped ( #19532 ) ( #19693 )
...
PR Close #19693
2017-10-16 11:13:58 -07:00
Matias Niemelä
f42d317d2f
fix(animations): ensure animateChild() works with all inner leave animations ( #19006 ) ( #19532 ) ( #19693 )
...
PR Close #19693
2017-10-16 11:13:58 -07:00
Vikram Subramanian
405ccc7195
fix(bazel): fix the output directory for extractor to be genfiles/ instead of bin/ ( #19716 )
...
PR Close #19716
2017-10-13 17:31:10 -07:00
Vikram Subramanian
836c889baa
fix(compiler): prepare for future Bazel semantics of += ( #19717 )
...
This is a local mod that was already applied in G3.
PR Close #19717
2017-10-13 16:29:46 -07:00
George Kalpakas
43f9d917d9
build(aio): fix overwriting with local Angular packages that depend on other local ones ( #19655 )
...
PR Close #19655
2017-10-13 09:27:51 -07:00
George Kalpakas
62c7b7842b
test(aio): fix testing of `NgPackagesInstaller` ( #19655 )
...
PR Close #19655
2017-10-13 09:27:51 -07:00
Peter Bacon Darwin
97969a85cd
ci(aio): raise payload limit to accommodate the new search feature ( #19682 )
...
PR Close #19682
2017-10-13 09:18:42 -07:00
Peter Bacon Darwin
91fcfcb042
feat(aio): add search to 404 page ( #19682 )
...
The 404 page will now run a search based on the given URL to offer
suggestions for the page that the user really wanted.
PR Close #19682
2017-10-13 09:18:42 -07:00
Peter Bacon Darwin
88c46feb20
refactor(aio): move SearchResultsComponent into shared module ( #19682 )
...
This will allow it to be used by an embedded component.
PR Close #19682
2017-10-13 09:18:42 -07:00
Peter Bacon Darwin
c3f07b329f
feat(aio): allow SearchService to have multiple clients ( #19682 )
...
PR Close #19682
2017-10-13 09:18:41 -07:00
Peter Bacon Darwin
6121083ba5
test(aio): tidy up e2e tests that used invalid URLs ( #19682 )
...
PR Close #19682
2017-10-13 09:18:41 -07:00
Peter Bacon Darwin
717c68089d
build(aio): remove unused imports and local variables ( #19682 )
...
PR Close #19682
2017-10-13 09:18:41 -07:00
Peter Bacon Darwin
09b4244baf
fix(aio): upgrade rxjs dependency to work with TS 2.4 ( #19682 )
...
PR Close #19682
2017-10-13 09:18:41 -07:00
Olivier Combe
2e45267705
ci: add service-worker to pullapprove ( #19642 )
...
PR Close #19642
2017-10-13 09:15:59 -07:00
Casey Schroeder
e81d1fc361
docs(animations): add missing bracket to fadeAnimation
...
Closes #18899
2017-10-13 09:12:36 -07:00