224d78765f
Summary of changes: - created .github/CODEOWNERS with docs and config similar to the one in .pullapprove.yml - updated docs - updated .github/angular-robot.yml to not expect pullapprove status - removed .pullapprove.yml The primary motivations behind this change are: - CODEOWNERS didn't exist when we introduced pullapprove - CODEOWNERS is a functionality tightly integrated with github which results in better DX - pullapprove v2 has been very unstable recently causing productivity loss - pullapprove v2 has been deprecated in favor of v3, which requires and migration PR Close #27690
1.0 KiB
1.0 KiB
Pushing changes into the Angular tree
Please see Using git with Angular repositories for details about how we maintain a linear commit history, and the rules for committing.
As a contributor, just read the instructions in CONTRIBUTING.md and send a pull request. Someone with committer access will do the rest.
Change approvals
Change approvals in our monorepo are managed via GitHub CODEOWNERS and are configured via the .github/CODEOWNERS file.
Merging
Once a change has all the approvals either the last approver or the PR author (if PR author has the project collaborator status) should mark the PR with PR: merge as well as PR target: * labels.
This signals to the caretaker that the PR should be merged. See merge instructions.
Who is the Caretaker?
See this explanation.