f0c570bd41
Currently, when verifying our pullapprove configuration, we don't respect modifications to the set of files in a condition. e.g. It's not possible to do the following: ``` contains_any_globs(files.exclude(...), [ ``` This prevents us from having codeowner groups which match a directory, but want to filter out specific sub directories. For example, `fw-core` matches all files in the core package. We want to exclude the schematics from that glob. Usually we do this by another exclude condition. This has a *significant* downside though. It means that fw-core will not be requested if a PR changes schematic code, _and_ actual fw-core code. To support these conditions, the pullapprove verification tool is refactored, so that it no longer uses Regular expressions for parsing, but rather evaluates the code through a dynamic function. This is possible since the conditions are written in simple Python that can be run in NodeJS too (with small modifications/transformations). PR Close #36661
23 lines
706 B
TypeScript
23 lines
706 B
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
import * as yargs from 'yargs';
|
|
import {verify} from './verify';
|
|
|
|
/** Build the parser for the pullapprove commands. */
|
|
export function buildPullapproveParser(localYargs: yargs.Argv) {
|
|
return localYargs.help()
|
|
.strict()
|
|
.option('verbose', {alias: ['v'], description: 'Enable verbose logging'})
|
|
.demandCommand()
|
|
.command('verify', 'Verify the pullapprove config', {}, ({verbose}) => verify(verbose));
|
|
}
|
|
|
|
if (require.main === module) {
|
|
buildPullapproveParser(yargs).parse();
|
|
}
|