angular-cn/dev-infra
Paul Gschwendtner 67f65a9d25 refactor(dev-infra): improve type-safety of git client utility (#42468)
Currently the `GitClient` accepts a generic parameter for determining
whether the `githubToken` should be set or not. This worked fine so far
in terms of distinguishing between an authenticated and
non-authenticated git client instance, but if we intend to conditionally
show methods only for authenticated instances, the generic parameter
is not suitable.

This commit splits up the `GitClient` into two classes. One for
the base logic without any authorization, and a second class that
extends the base logic with authentication logic. i.e. the
`AuthenticatedGitClient`. This allows us to have specific methods only
for the authenticated instance. e.g.

  * `hasOauthScopes` has been moved to only exist for authenticated
    instances.
  * the GraphQL functionality within `gitClient.github` is not
    accessible for non-authenticated instances. GraphQL API requires
    authentication as per Github.

The initial motiviation for this was that we want to throw if
`hasOAuthScopes` is called without the Octokit instance having
a token configured. This should help avoiding issues as within
3b434ed94d
that prevented the caretaker process momentarily.

Additionally, the Git client has moved from `index.ts` to
`git-client.ts` for better discoverability in the codebase.

PR Close #42468
2021-06-03 14:34:33 -07:00
..
bazel refactor(dev-infra): move shared browser bazel setup into dedicated bazel folder (#42268) 2021-06-03 10:37:41 -07:00
benchmark refactor(dev-infra): move shared browser bazel setup into dedicated bazel folder (#42268) 2021-06-03 10:37:41 -07:00
caretaker refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
commit-message refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
format refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
misc feat(dev-infra): add `ng-dev build-and-link` command (#42319) 2021-05-25 22:11:03 +00:00
ngbot refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
pr refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
pullapprove refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
release refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
ts-circular-dependencies fix(dev-infra): exclude node_modules from circular dependency checks (#41407) 2021-04-02 15:47:33 -07:00
utils refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
BUILD.bazel feat(dev-infra): add `ng-dev build-and-link` command (#42319) 2021-05-25 22:11:03 +00:00
build-worker.js refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
cli.ts feat(dev-infra): add `ng-dev build-and-link` command (#42319) 2021-05-25 22:11:03 +00:00
commit-message-filter.js refactor(dev-infra): create ng-dev executable locally in the repo (#39089) 2020-10-22 13:36:14 -07:00
index.bzl fix(dev-infra): allow build-worker to be used in forked process (#40012) 2020-12-08 12:06:51 -08:00
ng-dev.js refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
tmpl-package.json feat(dev-infra): create the prettier formatter for ng-dev format tooling (#41824) 2021-04-27 12:23:05 -07:00
tsconfig.json build: add tsconfig with strict flag to dev-infra package (#38656) 2020-09-28 16:11:39 -04:00