History

George Kalpakas 93f07aee6c test(ngcc): use DelegatingReflectionHost for testing NgccReflectionHosts (#36284 )

In #36089, `DelegatingReflectionHost` was introduced. Under the hood, it
delegates another `NgccReflectionHost` in order to reflect over the
program's source files, while using a different TypeScript
`ReflectionHost` to reflect over `.d.ts` files (which is how external
dependencies are represented in the program).

Previously, the `NgccReflectionHost`s were used directly in tests. This
does not exercise them in the way they are exercised in the actual
program, because (when used directly) they will also reflect on `.d.ts`
files too (instead of delegating to the TypeScript `ReflectionHost`).
This could hide bugs that would happen on the actual program.

This commit fixes this by using the `DelegatingReflectionHost` in the
various `NgccReflectionHost` tests.

NOTE:
This change will cause some of the existing tests to start failing.
These failures demonstrate pre-existing bugs in ngcc, that were hidden
due to the tests' being inconsistent with how the `ReflectionHost`s are
used in the actual program. They will be fixed in the next commit.

PR Close #36284

2020-04-03 11:08:46 -07:00

src

refactor(ngcc): move logic for identifying known declarations to method (#36284 )

2020-04-03 11:08:46 -07:00

test

test(ngcc): use DelegatingReflectionHost for testing NgccReflectionHosts (#36284 )

2020-04-03 11:08:46 -07:00

BUILD.bazel

fix(ngcc): use path-mappings from tsconfig in dependency resolution (#36180 )

2020-03-24 10:16:12 -07:00

index.ts

refactor(ngcc): expose logging level on the logger (#35861 )

2020-03-05 18:17:15 -05:00

main-ivy-ngcc.ts

fix(ngcc): rename the executable from ivy-ngcc to ngcc (#33140 )

2019-10-14 16:29:14 +00:00

main-ngcc.ts

fix(ngcc): use path-mappings from tsconfig in dependency resolution (#36180 )

2020-03-24 10:16:12 -07:00

README.md

refactor(ivy): move ngcc into a higher level folder (#29092 )

2019-03-20 14:45:54 -04:00

README.md

Angular Compatibility Compiler (ngcc)

This compiler will convert node_modules compiled with ngc, into node_modules which appear to have been compiled with ngtsc.

This conversion will allow such "legacy" packages to be used by the Ivy rendering engine.

Building

The project is built using Bazel:

yarn bazel build //packages/compiler-cli/ngcc

Unit Testing

The unit tests are built and run using Bazel:

yarn bazel test //packages/compiler-cli/ngcc/test

Integration Testing

There are tests that check the behavior of the overall executable:

yarn bazel test //packages/compiler-cli/ngcc/test:integration