94893accdb
An @NgModule with invalid provider declarations produces errors under normal circumstances. However, within the TestBed two small issues with provider overrides interfered with the correct production of these errors: 1. a 'null' provider object caused a premature crash when the TestBed attempted to check for a 'provide' property on it with hasOwnProperty(). 2. the array of providers would have an empty override array appended to it for each input provider, which would pollute the error messages produced down the line. This commit fixes both of these issues, by 1) checking for null and 2) filtering out the empty override arrays. Testing strategy: future commits change the way the TestBed compiles modules, causing tests to become sensitive to this bug if not fixed. PR Close #28033 |
||
|---|---|---|
| .. | ||
| animations | ||
| bazel | ||
| benchpress | ||
| common | ||
| compiler | ||
| compiler-cli | ||
| core | ||
| docs | ||
| elements | ||
| examples | ||
| forms | ||
| http | ||
| language-service | ||
| platform-browser | ||
| platform-browser-dynamic | ||
| platform-server | ||
| platform-webworker | ||
| platform-webworker-dynamic | ||
| private/testing | ||
| router | ||
| service-worker | ||
| upgrade | ||
| BUILD.bazel | ||
| README.md | ||
| empty.ts | ||
| es6-subset.d.ts | ||
| goog.d.ts | ||
| license-banner.txt | ||
| rollup.config.js | ||
| system.d.ts | ||
| tsconfig-build.json | ||
| tsconfig-test.json | ||
| tsconfig.json | ||
| types.d.ts | ||
README.md
Angular
The sources for this package are in the main Angular repo. Please file issues and pull requests against that repo.
License: MIT