angular-cn/dev-infra
Paul Gschwendtner b1fa1bf0d5 fix(dev-infra): `ng_rollup_bundle` rule should error if import cannot be resolved (#42760)
Rollup just prints a warning if an import cannot be resolved and ends up
being treated as an external dependency. This in combination with the
`silent = True` attribute for `rollup_bundle` means that bundles might
end up being extremely small without people noticing that it misses
actual imports.

To improve this situation, the warning is replaced by an error if
an import cannot be resolved.

This unveiles an issue with the `ng_rollup_bundle` macro from
dev-infra where imports in View Engine were not resolved but ended
up being treated as external. This did not prevent benchmarks using
this macro from working because the ConcatJS devserver had builtin
resolution for workspace manifest paths. Though given the new check
for no unresolved imports, this will now cause errors within Rollup, and
we need to fix the resolution. We can fix the issue by temporarily
enabling workspace linking. This does not have any performance
downsides.

To enable workspace linking (which we might need more often in the
future given the linker taking over patched module resolution), we
had to rename the `angular` dependency to a more specific one so
that the Angular linker could link into `node_modules/angular`.

PR Close #42760
2021-07-09 14:50:14 -07:00
..
bazel fix(dev-infra): api-golden tool does not specify a tsconfig and breaks for consumers (#42737) 2021-07-02 10:08:03 -07:00
benchmark fix(dev-infra): `ng_rollup_bundle` rule should error if import cannot be resolved (#42760) 2021-07-09 14:50:14 -07:00
caretaker refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
commit-message refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
format refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
misc feat(dev-infra): add `ng-dev build-and-link` command (#42319) 2021-05-25 22:11:03 +00:00
ngbot refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
pr fix(dev-infra): use API pagination for retrieving project branches (#42666) 2021-06-29 10:33:54 -07:00
pullapprove feat(dev-infra): update pullapprove verification to ensure all groups have reviewers (#42614) 2021-06-22 16:27:36 +00:00
release fix(dev-infra): convert commit SHAs and PR numbers to links when generating changelog (#42732) 2021-07-02 09:23:45 -07:00
ts-circular-dependencies fix(dev-infra): exclude node_modules from circular dependency checks (#41407) 2021-04-02 15:47:33 -07:00
utils fix(dev-infra): use API pagination for retrieving project branches (#42666) 2021-06-29 10:33:54 -07:00
BUILD.bazel fix(dev-infra): missing `pkg_npm` substitution for top-level targets being accessed (#42754) 2021-07-02 17:15:18 -07:00
build-worker.js refactor(dev-infra): update octokit to latest version v18 (#42666) 2021-06-29 10:33:54 -07:00
cli.ts feat(dev-infra): add `ng-dev build-and-link` command (#42319) 2021-05-25 22:11:03 +00:00
commit-message-filter.js refactor(dev-infra): create ng-dev executable locally in the repo (#39089) 2020-10-22 13:36:14 -07:00
index.bzl fix(dev-infra): allow build-worker to be used in forked process (#40012) 2020-12-08 12:06:51 -08:00
ng-dev.js fix(dev-infra): convert commit SHAs and PR numbers to links when generating changelog (#42732) 2021-07-02 09:23:45 -07:00
tmpl-package.json feat(dev-infra): introduce shared tool for validating API signature (#42688) 2021-06-30 11:43:48 -07:00
tsconfig.json feat(dev-infra): introduce shared tool for validating API signature (#42688) 2021-06-30 11:43:48 -07:00