angular-cn/packages/router/test
Alison Gale f6667f8281 fix(router): adjust UrlTree redirect to replace URL if in eager update (#32988)
Resubmit #31168 now that google3 tests can pass. This requires http://cl/272696717 to be patched.
Original description from jasonaden:

Without this change when using UrlTree redirects in urlUpdateStrategy="eager", the URL would get
updated to the target location, then redirected. This resulted in having an additional entry in the
history and thus the back button would be broken (going back would land on the URL causing a new
redirect).

Additionally, there was a bug where the redirect, even without urlUpdateStrategy="eager", could
create a history with too many entries. This was due to kicking off a new navigation within the
navigation cancelling logic. With this PR the new navigation is pushed to the next tick with a
setTimeout, allowing the page being redirected from to be cancelled before starting a new
navigation.

Related to #27148

fix(router): adjust UrlTree redirect to replace URL if in eager update

Fix lint errors

PR Close #32988
2019-10-18 14:42:21 -04:00
..
aot_ngsummary_test build: rules_nodejs 0.26.0 & use @npm instead of @ngdeps now that downstream angular build uses angular bundles (#28871) 2019-02-28 12:06:36 -08:00
operators refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
utils build: add bazel test rules for remainder of packages (#21053) 2017-12-22 13:10:51 -08:00
BUILD.bazel build: rules_nodejs 0.26.0 & use @npm instead of @ngdeps now that downstream angular build uses angular bundles (#28871) 2019-02-28 12:06:36 -08:00
apply_redirects.spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
bootstrap.spec.ts refactor(core): move Meta methods that only have one version from DomAdapter (#32408) 2019-09-03 11:59:39 -07:00
config.spec.ts fix(router): fix lazy loading of aux routes (#23459) 2018-06-13 11:20:20 -07:00
create_router_state.spec.ts build: upgrade jasmine (and related typings) to latest version (#19904) 2018-07-06 13:48:02 -07:00
create_url_tree.spec.ts Revert "fix(router): change processing url tree children condition (#26243)" (#27516) 2018-12-06 09:17:20 -08:00
helpers.ts feat(router): allow guards to return UrlTree as well as boolean (#26521) 2018-10-31 19:51:50 -04:00
integration.spec.ts fix(router): adjust UrlTree redirect to replace URL if in eager update (#32988) 2019-10-18 14:42:21 -04:00
recognize.spec.ts Revert "fix(router): process empty path segment when preceding a named outlet (#26243)" (#27516) 2018-12-06 09:17:20 -08:00
regression_integration.spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
router.spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
router_preloader.spec.ts fix(ivy): align NgModuleRef implementation between Ivy and ViewEngine (#27482) 2018-12-06 13:35:08 -08:00
router_scroller.spec.ts fix(router): default scroll position restoration to disabled (#25586) 2018-08-21 10:48:14 -07:00
router_state.spec.ts build(bazel): fix router test failure (#29375) 2019-03-19 23:39:37 -04:00
shared.spec.ts style: typos fixed - https://github.com/vlajos/misspell-fixer (#22975) 2018-03-27 14:51:53 -04:00
spy_ng_module_factory_loader.spec.ts test(ivy): run router tests with ivy on CI (#27195) 2018-11-21 09:19:40 -08:00
url_serializer.spec.ts fix(router): correct the segment parsing so it won't break on ampersand (#23684) 2018-05-10 07:53:53 -07:00
url_tree.spec.ts style: typos fixed - https://github.com/vlajos/misspell-fixer (#22975) 2018-03-27 14:51:53 -04:00