honeymoose
/
hapi-fhir
mirror of https://github.com/hapifhir/hapi-fhir.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary FIXMEs.

This commit is contained in:
Diederik Muylwyk 2021-03-04 19:19:34 -05:00
parent e3ba4bd1b6
commit 96a2151542
4 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/SearchParamWithInlineReferencesExtractor.java
View File

@ -214,7 +214,6 @@ public class SearchParamWithInlineReferencesExtractor {
}
// FIXME: DM 2021-03-04 - This is where inline match URLs are handled.
/**
* Handle references within the resource that are match URLs, for example references like "Patient?identifier=foo". These match URLs are resolved and replaced with the ID of the
* matching resource.

1
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java
View File

@ -2124,7 +2124,6 @@ public abstract class BaseTermReadSvcImpl implements ITermReadSvc {
private boolean isPlaceholder(MetadataResource theResource) {
// FIXME: DM 2021-03-04 - We should probably check if this extension exists and the value is true.
// FIXME: DM 2021-03-04 - Don't like that getExtensionUrl returns null instead of empty collection.
return theResource.getMeta().getExtensionByUrl(HapiExtensions.EXT_RESOURCE_META_PLACEHOLDER) != null;
}

1
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoCreatePlaceholdersR4Test.java
View File

@ -287,7 +287,6 @@ public class FhirResourceDaoCreatePlaceholdersR4Test extends BaseJpaR4Test {
assertEquals(0, patient.getIdentifier().size());
}
// FIXME: DM 2021-03-04 - This test fails; placeholder identifier isn't populated by default.
@Test
public void testCreatePlaceholderWithMatchUrl_IdentifierCopiedByDefault_WithUpdateToTarget() {
myDaoConfig.setAutoCreatePlaceholderReferenceTargets(true);

3
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/packages/NpmR4Test.java
View File

@ -357,9 +357,6 @@ public class NpmR4Test extends BaseJpaR4Test {
}
}
// FIXME: DM 2021-03-04 - This test is meant to validate that placeholder ValueSets are not created.
// FIXME: DM 2021-03-04 - This test or a new test should probably validate that placeholder ConceptMaps are also not created.
// FIXME: DM 2021-03-04 - This test does not validate that placeholder resources are created with a EXT_RESOURCE_META_PLACEHOLDER extension.
// Reproduces https://github.com/hapifhir/hapi-fhir/issues/2332
@Test
public void testInstallR4Package_AutoCreatePlaceholder() throws Exception {