Commit Graph

3404 Commits

Author SHA1 Message Date
jamesagnew 4f1f09abb1 Merge branch 'master' of github.com:hapifhir/hapi-fhir 2021-06-04 20:40:51 -04:00
jamesagnew 3e4522be86 Add logging 2021-06-04 20:40:40 -04:00
Kevin Dougan SmileCDR 0143e83156
Added another try-with-resources local variable based on a lgtm.com report. (#2711) 2021-06-04 15:17:27 -04:00
jamesagnew 899caa1913 Update transaction service visibility 2021-06-04 14:18:19 -04:00
James Agnew 62be623cf5
Add support for ICD-10-CM (#2702)
* Add support for ICD-10-CM

* Have this working

* Fix LGTM issues

* Test fix
2021-06-03 19:55:16 -04:00
Ken Stevens 94d6b15db9
_filter searchparam should not appear in cap stmt if disabled (#2706)
* issue reproduced and fixed

* changelog

* cleanup
2021-06-03 18:45:49 -04:00
Ken Stevens c498522c78
search by source reported incorrect size (#2705)
* issue reproduced in test and fixed

* changelog
2021-06-03 18:19:43 -04:00
juan.marchionatto 473de64ddc Fix DockerRequiredCondition check.
Add @RequiresDocker annotation to two tests.
2021-06-03 14:14:47 -04:00
jamesagnew 9401ecaf95 Merge branch 'master' of github.com:hapifhir/hapi-fhir 2021-06-02 16:47:12 -04:00
jamesagnew a0366befc4 Forward port fix 2021-06-02 16:47:02 -04:00
James Agnew 1d2b47c9fb
Update endpoint validation interceptors (#2698) 2021-06-02 05:39:01 -04:00
James Agnew fe763dd2d6
Upgrade deps (#2695)
* Upgrade deps

* Fix build error

* Branch tweak

* Build fix

* Build fix

* Undo bump

* Test fixes
2021-06-01 12:03:29 -04:00
rbhman dfde993f2d
Allow lower case error message to also trigger retry (#2693)
* Allow lower case error message to also trigger retry

* similar data integrity exception on different table

Co-authored-by: Hedman, Bruno <bruno.hedman@rmp.uhn.ca>
2021-06-01 10:50:06 -04:00
James Agnew 05ac88bc21
Add initiate bulk export pointcut (#2692)
* Add initiate bulk export pointcut

* Add changelog

* Test fixes
2021-05-31 16:05:09 -04:00
James Agnew a2950324ef
Avoid SQL based transaction dupe check (#2688)
* Avoid SQL based transaction dupe check

* Add changelog

* Test fixes

* Test fixes
2021-05-30 20:26:36 -04:00
James Agnew 8d377fbf76
Add bulk import instrumentation (#2685)
* Add batch job instrumentation

* Add bulk import instrumentation

* Fix build
2021-05-30 11:47:51 -04:00
Patrick Werner f34dd7ecd8
Merge pull request #2683 from me-d4l/feature/ignore-package-id-case
Make package ID handling case-insensitive (#2682)
2021-05-29 17:12:43 +02:00
James Agnew 24b3f0f30d
Enable mass ingestion mode (#2681)
* Work on fixes

* Work on counts

* Enable mass ingestion mode

* Add changelog

* Test fix

* Test fix

* Test fixes

* Fixes

* Test fix

* Test fix
2021-05-27 18:43:51 -04:00
morten.ernebjerg 69d3e3f3ca
Add further test for non-matching IDs 2021-05-27 15:18:45 +02:00
morten.ernebjerg cbfca6a560
Make package ID handling case-insensitive 2021-05-27 14:57:07 +02:00
James Agnew c8c596aff4
Fix date search on period with no end (#2676)
* Add test

* Working test

* Update test

* Account for date fixes

* Add changelog

* Add setting

* Test fixes

* Test fix
2021-05-26 21:03:53 -04:00
James Agnew 7a83c76e65
Add validation suppression mode (#2675)
* Add validation suppression mode

* Add changelog

* Compile fix
2021-05-26 17:41:48 -04:00
Ken Stevens af44b9c7a0
Ks 20210526 accurate total (#2677)
* begin with failing test

* fixed

* changelog
2021-05-26 12:20:49 -04:00
Kevin Dougan SmileCDR 6167fb2415
2669 - Cache-Control no-store returns excessive resources (#2671)
* First attempt at a Unit Test.

* Removed sample test data.

* Added failing Unit Test - now to find out why.

* Added a _count param to more exactly match the provided customer scenario.

* Added a possible fix for this sceanrio.

* Work on this

* Have a working fix, not yet fully tested

* Test fix

Co-authored-by: jamesagnew <jamesagnew@gmail.com>
2021-05-25 08:49:25 -04:00
James Agnew 2c722e64c2
Add support for including qualified star syntax (#2672)
* Add support for including qualified star syntax

* Add changelog

* Add docs

* Build fix
2021-05-23 16:50:37 -04:00
jamesagnew ff2698d4d1 Merge branch 'rel_5_4' 2021-05-19 09:22:11 -04:00
James Agnew 2badae2097
Avoid contained resource in conditional create (#2665)
* Work on unexpected contained resources

* Avoid contained on conditional create

* Add changelog
2021-05-19 07:49:59 -04:00
jamesagnew b463b072c8 Test fixes 2021-05-18 21:32:13 -04:00
jamesagnew de56f440cb Version bump 2021-05-18 17:14:14 -04:00
jamesagnew e02bfca610 Add logging 2021-05-18 12:33:02 -04:00
Tadgh 9d039e095b Fix copy paste error. shame. 2021-05-18 11:12:59 -04:00
Tadgh 5b6f76e2dc Address review comments 2021-05-18 11:05:56 -04:00
Tadgh 143474225e Add test. Add fix 2021-05-18 09:58:58 -04:00
jamesagnew c725d1453f Add logs 2021-05-18 09:22:29 -04:00
jamesagnew 926bf393d3 Merge branch 'rel_5_4' 2021-05-17 09:10:58 -04:00
James Agnew 40ecafcd31
Don't unescape plus in match URLs (#2658)
* Don't unescape plus in match URLs

* Perf improvements

* Add changelog

* Test fix

* Work on tests

* Fixes

* Test fix
2021-05-16 21:51:23 -04:00
Tadgh 57bb11797e fix 2021-05-13 15:46:26 -04:00
Tadgh 15ea4fb555 Tidy test 2021-05-13 10:47:26 -04:00
Tadgh 3428d71023 Add toggle. Add test. Add changelog. add docs 2021-05-13 10:29:07 -04:00
Ken Stevens 316e7e0d6d
Ks 20210512 value set expansion id (#2654)
* tested and fixed

* changelog
2021-05-12 21:38:29 -04:00
James Agnew b64346ba1e
Add shcheduled task enablement config (#2652)
* Add shcheduled task enablement config

* Add changelog

* Test fix

* Cleanup
2021-05-12 14:38:30 -04:00
Tadgh d6252526c3 Move member variable 2021-05-11 10:53:10 -04:00
jamesagnew 31ef476efe Test fix 2021-05-11 10:12:27 -04:00
jamesagnew e9ff2fd3ae Test fix 2021-05-11 09:26:23 -04:00
jamesagnew 5c4fcac530 Merge branch 'rel_5_4' 2021-05-11 08:40:09 -04:00
James Agnew 3015438a0c
Avoid query cache poisoning (#2647)
* Avoid query cache poisoning

* Test fixes

* Add changelog
2021-05-11 08:39:38 -04:00
James Agnew 43631d4937
Account for NOPs in Auto-Versioned References (#2643)
* Account for NOPs in auto-versioned references

* Add docs

* Add tests
2021-05-08 18:09:50 -04:00
jamesagnew 0cebbf4fa8 Merge branch 'master' of github.com:hapifhir/hapi-fhir 2021-05-07 17:44:27 -04:00
jamesagnew 2068372998 Version bump 2021-05-07 17:43:54 -04:00
James Agnew 5a9f499fbf
Resolve weakness in history operation (#2642)
* Address DOS issue in History operation

* Work on history caching

* Add docs

* Add changelog

* Resolve test failures

* Test fixes

* Test fix

* Test fixes
2021-05-07 12:04:59 -04:00
Tadgh cf864c2078 Merge remote-tracking branch 'origin/master' into issue-2634-increase-src-path-length 2021-05-06 09:10:48 -04:00
James Agnew 1424d48912
Avoid NPE in concept mapping (#2637) 2021-05-06 05:25:38 -04:00
Ken Stevens a4856bba17
fix iBundleProvider.getResources(from,to) throwing a NPE (#2632)
* fix iBundleProvider.getResources(from,to) throwing a NPE

* change log

* review feedback

* rename test to IT that has concurrency failures
2021-05-05 21:50:51 -04:00
Tadgh 4031968357
Calls with zero request details and non-partitionable resource automatically go to default now. This updates the test to pass in servletrequest details, simulating a user request (#2636) 2021-05-05 16:57:12 -04:00
Tadgh bf37d1db74 Fix test 2021-05-05 15:36:20 -04:00
Tadgh e15825b336 Increase length, add test 2021-05-05 15:29:02 -04:00
Tadgh 0fb0419a67 If null, return default partition during create 2021-05-04 16:22:01 -04:00
Tadgh fcc662da79 Fix not sending request details 2021-05-04 16:18:34 -04:00
KevinIsAProgrammer 75c74a22db
Merge pull request #2619 from hapifhir/2590_preserve_the_ID_value_of_the_resources_in_the_package_loader
2590 preserve the id value of the resources in the package loader
2021-05-03 15:39:14 -04:00
Kevin Hartmann 320e8379b3 Now convert pure numeric ids to "npm-<id>". 2021-05-03 12:55:17 -04:00
James Agnew 172ea770b8
Fix transaction references (#2627) 2021-05-03 12:25:51 -04:00
jamesagnew 8be50641e5 License header 2021-05-03 08:45:54 -04:00
Hanan Awwad 871914bd3b
Concept properties are not being saved while using the operation apply-codesystem-delta-add (#2577)
* fix issue #2280

* revert the indentation back.

* revert-back untouched changes.

* saving concept properties using the operation apply-codesystem-delta-add

* fix test cases; add check for null properties

* fix test; expected file descriptors
2021-05-03 08:02:20 -04:00
Jari Maijenburg 6dc12603bb
Fixed GraphQL token parameter matching bug (#2623) 2021-05-02 17:18:51 -04:00
James Agnew 0cea403800
Fix vulnerability warning on maven plugin (#2621)
* Fix vulnerability warning on maven plugin

* Compile fixes

* Fix bootstrap dep

* Test fix

* Fix tests

* FIx deps
2021-05-02 12:14:32 -04:00
James Agnew 970a9884f0
Avoid tag definition constraint (#2620)
* Avoid tag definition constraint failure

* Version bumps

* Add changelog

* Avoid guava issue

* Test fix

* Test fix

* Bump pom
2021-05-01 17:16:15 -04:00
Tuomo Ala-Vannesluoma fbca9f8060
Offset query fixes (#2579)
* Fix new searchbuilder limit similar to legacy searchbuilder

* Fix returning includes when using offset query

* Add unit tests for offset query with include

* Only use count param if offset is given (sometimes we want to search synchronously more if DAO is used directly)

* Throw if offset is tried to use with everything operations

* Do not offer offset paging for everything operations and fix tests to assert that
2021-04-30 19:01:27 -04:00
Kevin Hartmann e8ac24b4df Test now passes. 2021-04-30 15:17:22 -04:00
Kevin Hartmann b3afe41de8 Added test to make sure we have loaded the expected package id. 2021-04-30 15:14:19 -04:00
Tadgh 983d811af6
Merge pull request #2587 from hapifhir/issue-2585-enhance-placeholder-targets-logic
Issue 2585 enhance placeholder targets logic
2021-04-30 12:55:27 -04:00
Tadgh ac7c684437 Refactor to support all new tests 2021-04-29 17:01:19 -04:00
Tadgh 78271a2931 Create tests for all possiblye use cases 2021-04-29 15:25:11 -04:00
Kevin Dougan SmileCDR 646faa10e1
2540 - Upgraded the fhir_core_version from 5.3.0 to 5.3.10 (#2545)
* 2540 - Upgraded the fhir_core_version from 5.3.0 to 5.3.9.

* 2540 - Updated the Unit Test messages due to the upgraded dependencies.

* 2540 - Fixed some additional Unit Test message checks.

* 2540 - Updated the POM to refer to fhir_core_version 5.3.10-SNAPSHOT so a FULL Pipeline Build can run to verify that everything is fixed now.

* 2540 - Added some DEBUG Sysout logging to try and determine why the Pipeline Builds fail for a specific Unit Test when it passes locally...

* 2540 - Added some more logging to try and determine why the Pipeline Builds fail for a specific Unit Test when it passes locally...

* 2540 - Updated a Unit Test to account for a newly returned search param.

* 2540 - Updated a Unit Test to account for a newly returned search param and removed some debug output.
2021-04-29 15:00:37 -04:00
Tadgh 3ff2ad37ff Start with failing test 2021-04-29 14:08:50 -04:00
James Agnew 95d7ba6fa8
Streamline Search SQLs (#2576)
* Streamline SQL queries

* SQL query tidying

* Add changelog

* Test fixes

* Tests passing

* Ongoing work

* Test fixes

* Test fixes

* Build fix

* Cleanup

* Fixes
2021-04-28 10:29:09 -04:00
Tadgh 9ecb390dae Move tests to proper class. Fix issue with version referencing 2021-04-26 13:40:11 -04:00
Tadgh b200c10ced Merge remote-tracking branch 'origin/master' into issue-2534-new-tx-pointcut 2021-04-26 09:48:30 -04:00
James Agnew 2ba1005762
OpenAPI Support (#2560)
* Start work on OpenAPI

* Fixes

* Work on OpenAPI

* Cleanup

* Cleanup

* More swagger work

* Build fix

* More work

* More work

* Add documentation

* Docs fixes

* Add changelog

* License updates

* Add API

* Cleanup

* Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/docs/server_plain/openapi.md

Co-authored-by: patrick-vachon-smilecdr <81274188+patrick-vachon-smilecdr@users.noreply.github.com>

* Work on scripts

* Add docs

* Compile fix

* Work on fixes

* Fix tests

* Test fix

* Test fix

* Build fix

* Tests

* Build fix

* Work on pipeline

* Version bump

* Test fix

* Version bump

* Test fix attempts

* Test fix

* Test fix

* Remove accidentally committed files

* Fixes

* Tets fixes

* Test fix

* Test fix

* Test fix

* Test fixes

* Test fixes

* Test fixes

* License header updates

* test fix

* Test fixes

* Test fix

* Test fixes

* Test fix

* Checkstyle bump

Co-authored-by: patrick-vachon-smilecdr <81274188+patrick-vachon-smilecdr@users.noreply.github.com>
2021-04-25 15:40:50 -04:00
Tadgh a5f81988fc Merge branch 'improve-bundle-builder' into issue-2534-new-tx-pointcut 2021-04-21 16:53:49 -04:00
Tadgh b7166735f9 Merge remote-tracking branch 'origin/master' into issue-2534-new-tx-pointcut 2021-04-21 12:13:54 -04:00
Tadgh ad8921ac4e Add docs, enum, remove prints 2021-04-21 10:39:23 -04:00
Tadgh e997d49d42 Additional Tests 2021-04-20 18:25:45 -04:00
Tadgh 3dee0c8ab6 Working in-place bundle sort 2021-04-20 17:48:55 -04:00
Nick Goupinets 4e266462ec Bumped up version due to breaking changes 2021-04-20 16:17:27 -04:00
Tadgh ff2690b74e Add tests for transaction sorting 2021-04-20 14:12:25 -04:00
Tadgh 1670ed7202 Begin topological sort implementation 2021-04-19 20:01:02 -04:00
Tadgh 2ed4b01eb8 Remove notnull 2021-04-19 10:31:16 -04:00
Tadgh 014fa05271 Fix a present annotation 2021-04-19 09:17:35 -04:00
Tadgh 89e56ecb98 Remove jetbrains annotation 2021-04-19 09:14:12 -04:00
Tadgh c54862e772 Coding around at the speed of sound occasionally causes compilation failures 2021-04-18 18:03:37 -04:00
Tadgh 77e2768a14 Address code review comments. Create new static builder for all partitions SRD 2021-04-18 17:36:55 -04:00
Tadgh 3075a9b5e6 Still minor refactoring 2021-04-16 16:53:23 -04:00
Tadgh f91a4f9576 wip tidy implementaion 2021-04-16 14:18:01 -04:00
Tadgh fad32aa636 Partition management for expired jobs 2021-04-16 11:55:12 -04:00
Tadgh 8035d51e48 Refactor, comment 2021-04-16 11:31:43 -04:00
Tadgh efe5b7b140 Fix package cache usage 2021-04-16 11:24:42 -04:00
Tadgh 7cabcbd772 Fix partition selection for system request details 2021-04-16 11:12:40 -04:00
James Agnew ca2088f3ad
Add framework for Bulk Import (#2538)
* Start work on bul;k import

* Work on bulk import

* Have batch working

* Working

* Working

* More work

* More work on bulk export

* Address fixmes

* License header updates

* Test fixes

* License header updates

* Test fix

* Test fix

* Version bumps

* Work on config

* Test cleanup

* One more version bump

* Version bump

* CLeanup

* A few additions

* Test fixes

* Test fix

* Test fix

* Migration fix

* Test fix

* Test fix
2021-04-14 17:41:32 -04:00
Ken Stevens 550602b2f1
added numeric matcher (#2547)
* added numeric matcher

* changelog

* performance optimization

* fix test
2021-04-14 13:15:30 -04:00
IanMMarshall 4cd0409bae
Merge pull request #2546 from hapifhir/2535_ignore_logical_structuredefinition_during_package_install
2535 ignore logical structuredefinition during package install
2021-04-14 10:54:37 -04:00
Kevin Dougan SmileCDR b45ddcc3da
2543 - Fix issue where versionned references are not being returned properly. (#2544)
* 2543 - Fix issue where versionned references are not being returned properly.

* 2543 - Added changelog entries for this fix plus a previous fix for 2533.
2021-04-14 08:45:49 -04:00
ianmarshall 5a3f2e3edf Change package loader to not generate snapshot for logical StructureDefinition resources. 2021-04-13 22:22:06 -04:00
Tadgh fcbfb11506 Merge remote-tracking branch 'origin/master' into issue-2534-new-tx-pointcut 2021-04-13 15:55:01 -04:00
Tadgh 3732698e01 Update a few more pointcuts 2021-04-13 13:50:53 -04:00
Tadgh de3d6cd36a Update pointcut invocations 2021-04-13 13:49:50 -04:00
Tadgh d695e35e59 Update test 2021-04-13 09:31:45 -04:00
Tadgh f61d52d199 Should have realized that transactiondetails is an object reference, so we can't change it effectively 2021-04-13 09:26:05 -04:00
Kevin Dougan SmileCDR 129df5dc14
2533 - Fix Issue with Reference Resources Not Being Returned In Search Queries (#2539)
* 2533 - Initial commit to show how I might fix this Bug but not ready for merge at this time as it causes some other Unit Test failures in FhirResourceDaoR4VersionedReferenceTest.

* Fix up test

* 2533 - Cleaned up Unit Test to make it ready to merge.

Co-authored-by: jamesagnew <jamesagnew@gmail.com>
2021-04-13 05:28:39 -04:00
jamesagnew 3637dfc60f License headers 2021-04-12 09:57:08 -04:00
Tadgh 8099b6634a wip 2021-04-09 18:21:15 -04:00
Tadgh ac8e012892 wip 2021-04-09 13:07:15 -04:00
Tadgh 99e10de5fb
Merge pull request #2487 from hapifhir/mdm-expansion-interceptor
MDM Expansion Interceptor (poc)
2021-04-09 11:23:04 -04:00
Tadgh 8f30f7b0f2 Vague skeleton of pointcut 2021-04-09 11:08:47 -04:00
James Agnew edfe1ae8e6
Add lastupdated to capabilitystatement (#2530)
* Add lastupdated to capabilitystatement

* Test fix

* Test fix
2021-04-08 13:23:21 -04:00
James Agnew f70648484a
Avoid a deadlock uploading terminology in postgres (#2529)
* Fix #2493

* Try to fix intermittent test failure
2021-04-08 12:28:42 -04:00
James Agnew 462d9bc6c4
Fix compartment defs for R5 (#2528)
* Fix compartment defs for R5

* Add changelog

* Test fix
2021-04-08 05:59:05 -04:00
James Agnew a6cbf7eebd
Add support for hierarchycal valueset expansion (#2525)
* Add support for hierarchycal valueset expansion

* Add changelog

* Add tests

* Cleanup

* Test fix

* Test fixes
2021-04-06 17:36:54 -04:00
James Agnew fcffb04c7b
Allow unknown code systems during validation (#2523)
* Allow unknown code systems during validation

* Add changelog

* Test fix
2021-04-05 20:59:59 -04:00
James Agnew b617c7690d
Search Parameter Infrastructure Cleanup (#2522)
* Search param service cleanup

* Work on collapsing search param

* Search param cleanup

* Work on build

* Test fix

* Test fixes

* Ongoing work

* Test fix

* Compile fix

* Test fixes

* Test fix

* Test fix

* License header updates

* Remove fixme

* Cleanup

* Cleanup
2021-04-05 17:40:10 -04:00
James Agnew 0bf746f23b
Add support for revincludes to CapabilityStatement generator (#2521)
* Add support for revincludes to CapabilotyStatement generator

* Add changelog

* Fixes

* Test fix

* Test fixes

* Test fix

* Test fix

* More fixes to CS cache

* Test fix

* Test fix

* Test fix
2021-04-05 08:29:04 -04:00
Tadgh 961c996ea9 Remove foolish local bind 2021-04-01 17:32:14 -04:00
Tadgh 696982ce1e Fix bean name. Update docs 2021-03-31 13:45:40 -04:00
Tadgh 74be6761b1 Merge remote-tracking branch 'origin/master' into mdm-expansion-interceptor 2021-03-31 09:47:57 -04:00
Tadgh 8b69d161bd Update docs 2021-03-30 17:12:55 -04:00
Tadgh 419a5829ea This shockingly works 2021-03-30 12:39:37 -04:00
jamesagnew 4eb9508e28 One more fix to interceptor 2021-03-30 11:47:03 -04:00
jamesagnew 8759cdae00 Additional cleanup 2021-03-30 08:20:14 -04:00
jamesagnew 4feda13d7f License header update 2021-03-30 06:02:32 -04:00
James Agnew 049097e5b4
Improve CapabilityStatement Generation (#2511)
* Start work

* Work on testing

* Version bump

* Test fix

* Compile fix

* Test Fixes

* Test fix

* Test fix

* Compile fix

* Tst fix

* Test fix

* Test fix

* Test fix
2021-03-30 05:48:03 -04:00
Tadgh a15ded7140 Interceptor now correctly intercepts at the right point 2021-03-29 21:12:03 -04:00
Tadgh ab143e34cb Merge remote-tracking branch 'origin/master' into mdm-expansion-interceptor 2021-03-29 19:27:37 -04:00
Tadgh 838ac890d3 wip 2021-03-29 19:19:37 -04:00
Tadgh 5f42743f48 wip 2021-03-29 19:16:26 -04:00
Diederik Muylwyk e3be7cc6fb Fix build 2021-03-29 18:39:51 -04:00
Diederik Muylwyk b720c32c1d Version bump 2021-03-29 18:23:16 -04:00
Tadgh 432579c591 Fix test error 2021-03-29 15:00:20 -04:00
Tadgh 19810db65d Test refactor. address review comments 2021-03-29 14:55:41 -04:00
Tadgh c46617fefa Use dynamic projection 2021-03-29 11:38:52 -04:00
Tadgh 002d3fcf3c Migrate constant 2021-03-29 11:07:23 -04:00
Tadgh e9e20988c9 Partial moving of presearch regsitered pointcut 2021-03-29 10:49:58 -04:00
Tadgh 9f13225aa5 WIP interceptor using reference param modifier 2021-03-26 17:57:38 -04:00
Tadgh e8f49f2fba More docs 2021-03-26 16:01:29 -04:00
Tadgh a3fbd3e1a1 Hotter docs 2021-03-26 16:00:06 -04:00
Tadgh bee33f763a Refactors, tidying. Improving docs 2021-03-26 15:54:27 -04:00
Tadgh f7eee5985e Add some logging to figure out CI failure 2021-03-26 11:58:52 -04:00
Tadgh a1a3e65106 remove dead whitespace 2021-03-26 10:20:41 -04:00
Tadgh cc1861e876 Update test. 2021-03-25 15:48:03 -04:00
Tadgh 4d3b021f12 Add annotating processor and composite processor 2021-03-25 13:53:41 -04:00
Tadgh 315dc3fcb7 start with failing test 2021-03-24 12:50:29 -04:00
Tadgh 6f669f9ccd wip 2021-03-23 19:29:22 -04:00