honeymoose/playwright-java
1
0
Fork 0
mirror of https://github.com/microsoft/playwright-java.git synced 2025-09-08 21:01:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: ensure file is closed after reading (#95)

Browse Source
This commit is contained in:
Yury Semikhatsky 2020-12-07 18:17:42 -08:00 committed by GitHub
parent d7a107b896
commit 8d7bbe38d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
playwright/src/test/java/com/microsoft/playwright/TestHar.java
View File

@ -27,6 +27,7 @@ import org.junit.jupiter.api.Test;
import java.io.FileNotFoundException; import java.io.FileNotFoundException;
import java.io.FileReader; import java.io.FileReader;
import java.io.IOException; import java.io.IOException;
import java.io.Reader;
import java.nio.file.Files; import java.nio.file.Files;
import java.nio.file.Path; import java.nio.file.Path;
@ -127,8 +128,10 @@ public class TestHar extends TestBase {
Deferred<Void> loadEvent = page.waitForLoadState(Page.LoadState.DOMCONTENTLOADED); Deferred<Void> loadEvent = page.waitForLoadState(Page.LoadState.DOMCONTENTLOADED);
loadEvent.get(); loadEvent.get();
context.close(); context.close();
JsonObject log = new Gson().fromJson(new FileReader(harPath.toFile()), JsonObject.class).getAsJsonObject("log"); JsonObject log;
try (Reader reader = new FileReader(harPath.toFile())) {
log = new Gson().fromJson(reader, JsonObject.class).getAsJsonObject("log");
}
assertEquals(1, log.getAsJsonArray("pages").size()); assertEquals(1, log.getAsJsonArray("pages").size());
JsonObject pageEntry = log.getAsJsonArray("pages").get(0).getAsJsonObject(); JsonObject pageEntry = log.getAsJsonArray("pages").get(0).getAsJsonObject();
assertEquals("page_0", pageEntry.get("id").getAsString()); assertEquals("page_0", pageEntry.get("id").getAsString());