honeymoose
/
sp-dev-fx-webparts
mirror of https://github.com/pnp/sp-dev-fx-webparts.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
sp-dev-fx-webparts/.github/CONTRIBUTING.md

6.4 KiB
Raw Blame History

Contribution Guidance

If you'd like to contribute to this repository, please read the following guidelines. Contributors are more than welcome to share your learnings with others from centralized location.

Code of Conduct

This project has adopted the Microsoft Open Source Code of Conduct. For more information, see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Question or Problem?

Please do not open GitHub issues for general support questions as the GitHub list should be used for feature requests and bug reports. This way we can more easily track actual issues or bugs from the code and keep the general discussion separate from the actual code.

If you have questions about how to use SharePoint Framework or any of the provided samples, please use the following locations.

Typos, Issues, Bugs and contributions

Whenever you are submitting any changes to the SharePoint repositories, please follow these recommendations.

  • Always fork repository to your own account for applying modifications
  • Do not combine multiple changes to one pull request, please submit for example any samples and documentation updates using seperate PRs
  • If you are submitting multiple samples, please create specific PR for each of them
  • If you are submitting typo or documentation fix, you can combine modifications to single PR where suitable

Submitting changes as pull requests

Here's a high level process for submitting new samples or updates to existing ones.

  1. Sign the Contributor License Agreement (see below)
  2. Fork the main repository to your GitHub account
  3. Create a new branch for your fork for the contribution based on dev branch
  4. Include your changes to your branch
  5. Commit your changes using descriptive commit message - These are used to track changes on the repositories for monthly communications, see September 2016 as an example
  6. Create a pull request in your own fork and target 'dev' branch
  7. Fill up the provided PR template with the requested details

note. Delete the feature specific branch only AFTER your pull request has been processed.

Sample naming and structure guidelines

When you are submitting a new sample, it has to follow up below guidelines

  • You will need to have a README file for your contribution, which is based on provided template under the Samples folder. Please copy this template and update accordingly. README has to be named as README.md with capital letters.
    • You will need to have a picture of the web part in practice in the README file ("pics or it didn't happen"). Preview image must be located in /assets/ folder in the root your you solution.
  • README template contains specific tracking image as a final entry in the page with img tag by default to https://telemetry.sharepointpnp.com/sp-dev-fx-webparts/samples/readme-template. This is transparent image, which is used to track popularity of individual samples in GitHub.
  • If you find already similar kind of sample from the existing samples, we would appreciate you to rather extend existing one, than submitting a new similar sample
    • If you for example use Office Graph with React, please rather add new web part to already existing solution, rather than introducing completely new solution
    • When you update existing samples, please update also README accordingly with information on provided changes and with your author details
  • When you are submitting new sample solution, please name the sample solution folder accordingly
    • Folder should start by identifying JS library used - like "react-", "angular-", "knockout-"
    • If you are not using any specific JS library, please use "js-" as the prefix for your sample
    • Do not use words "sample", "webpart" or "wb" in the folder or sample name - these are samples for client-side web parts repository
    • If your solution is demonstrating multiple technologies, please use functional terms as the name for the solution folder
  • Do not use period/dot in the folder name of the provided sample

Step-by-step on submitting a pull request to this repository

Please see following wiki post from the GitHub repository wiki for exact steps on submitting new pull requests.

  • How to submit a PR to SharePoint repository? - Step-by-step with commands and pictures coming soon

Meging your existing github projects with this repository

If the sample you wish to contrubute is tored in your own Github repository, you can use the following steps to merge it with the Psp-dev-fx-webparts repository: - Fork the sp-dev-fx-webparts repository om hithub - create a local git rpository md sp-dev-fx-webparts cd sp-dev-fx-webparts git init - pull your forked copy of sp-dev-fx-webparts into your local repository git remote add origin https://github.com/yourgitaccount/sp-dev-fx-webparts.git git pull origin dev - pull your other project from github into the samples folder of your local copy of sp-dev-fx-webparts
git subtree add --prefix=samples/projectname https://github.com/yourgitaccount/projectname.git master - push the changes up to your forked repository git push orgin dev

Signing the CLA

Before we can accept your pull requests you will be asked to sign electronically Contributor License Agreement (CLA), which is prerequisite for any contributions to PnP repository. This will be one time process, so for any future contributions you will not be asked to re-sign anything. After the CLA has been signed, our PnP core team members will have a look on your submission for final verification of the submission. Please do not delete your development branch until the submission has been closed.

You can find Microsoft CLA from the following address - https://cla.microsoft.com.

Thank you for your contribution.

Sharing is caring.