iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci(docs-infra): disable flaky tests (#37673) 

I could not figure out the root cause of the flakes, so disabling the
flaky tests for now. See
https://github.com/angular/angular/pull/37637#issuecomment-647608149 for
more info.

Fixes #37629

PR Close #37673
This commit is contained in:
George Kalpakas 2020-06-22 19:16:33 +03:00 committed by Misko Hevery
parent 5229809adb
commit 38dfbc775f
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
aio/src/app/layout/doc-viewer/doc-viewer.component.spec.ts
View File

@ -401,7 +401,10 @@ describe('DocViewerComponent', () => {
expect(loadElementsSpy.calls.argsFor(1)).toEqual([docViewer.nextViewContainer]); expect(loadElementsSpy.calls.argsFor(1)).toEqual([docViewer.nextViewContainer]);
}); });
it('should unsubscribe from the previous "embed" observable when unsubscribed from', () => { // This test sometimes incorrectly fails on CI.
// Reported in https://github.com/angular/angular/issues/37629.
// Investigated in https://github.com/angular/angular/pull/37637.
xit('should unsubscribe from the previous "embed" observable when unsubscribed from', () => {
const obs = new ObservableWithSubscriptionSpies(); const obs = new ObservableWithSubscriptionSpies();
loadElementsSpy.and.returnValue(obs); loadElementsSpy.and.returnValue(obs);
@ -436,7 +439,10 @@ describe('DocViewerComponent', () => {
expect(swapViewsSpy).toHaveBeenCalledWith(addTitleAndTocSpy); expect(swapViewsSpy).toHaveBeenCalledWith(addTitleAndTocSpy);
}); });
it('should unsubscribe from the previous "swap" observable when unsubscribed from', () => { // This test sometimes incorrectly fails on CI.
// Reported in https://github.com/angular/angular/issues/37629.
// Investigated in https://github.com/angular/angular/pull/37637.
xit('should unsubscribe from the previous "swap" observable when unsubscribed from', () => {
const obs = new ObservableWithSubscriptionSpies(); const obs = new ObservableWithSubscriptionSpies();
swapViewsSpy.and.returnValue(obs); swapViewsSpy.and.returnValue(obs);