fix: disable injectable-pipe migration (#30180)

Disables the injectable pipe migration until we can decide whether this is the right solution for Ivy. Rolling it out properly will involve a more detailed plan and more changes like updating the styleguide, scaffolding schematics etc.

Context for the new `test-migrations.json`: since we use the `migrations.json` both for the real migrations and for tests, it doesn't allow us to disable a schematic, but continue running its tests. This change adds the test-specific file so that we can continue running the `injectable-pipe` tests, even though the schematic itself is disabled.

PR Close #30180

packages/core/schematics/BUILD.bazel

@@ -3,6 +3,7 @@ load("//tools:defaults.bzl", "npm_package")
 exports_files([
     "tsconfig.json",
     "migrations.json",
+    "test-migrations.json",
 ])
 
 npm_package(

packages/core/schematics/migrations.json

@@ -14,11 +14,6 @@
       "version": "8-beta",
       "description": "Warns developers if values are assigned to template variables",
       "factory": "./migrations/template-var-assignment/index"
-    },
-    "migration-v8-injectable-pipe": {
-      "version": "8-beta",
-      "description": "Migrates all Pipe classes so that they have an Injectable annotation",
-      "factory": "./migrations/injectable-pipe/index"
     }
   }
 }

packages/core/schematics/test-migrations.json

@@ -0,0 +1,20 @@
+{
+  "schematics": {
+    "migration-move-document": {
+      "description": "Migrates DOCUMENT Injection token from platform-browser imports to common import",
+      "factory": "./migrations/move-document/index"
+    },
+    "migration-static-queries": {
+      "description": "Migrates ViewChild and ContentChild to explicit query timing",
+      "factory": "./migrations/static-queries/index"
+    },
+    "migration-template-local-variables": {
+      "description": "Warns developers if values are assigned to template variables",
+      "factory": "./migrations/template-var-assignment/index"
+    },
+    "migration-injectable-pipe": {
+      "description": "Migrates all Pipe classes so that they have an Injectable annotation",
+      "factory": "./migrations/injectable-pipe/index"
+    }
+  }
+}

packages/core/schematics/test/BUILD.bazel

@@ -5,7 +5,7 @@ ts_library(
     testonly = True,
     srcs = glob(["**/*.ts"]),
     data = [
-        "//packages/core/schematics:migrations.json",
+        "//packages/core/schematics:test-migrations.json",
     ],
     deps = [
         "//packages/core/schematics/migrations/injectable-pipe",

packages/core/schematics/test/injectable_pipe_migration_spec.ts

@@ -20,7 +20,7 @@ describe('injectable pipe migration', () => {
   let previousWorkingDir: string;
 
   beforeEach(() => {
-    runner = new SchematicTestRunner('test', require.resolve('../migrations.json'));
+    runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json'));
     host = new TempScopedNodeJsSyncHost();
     tree = new UnitTestTree(new HostTree(host));
 
@@ -123,5 +123,5 @@ describe('injectable pipe migration', () => {
     host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents));
   }
 
-  function runMigration() { runner.runSchematic('migration-v8-injectable-pipe', {}, tree); }
+  function runMigration() { runner.runSchematic('migration-injectable-pipe', {}, tree); }
 });

packages/core/schematics/test/move_document_migration_spec.ts

@@ -20,7 +20,7 @@ describe('move-document migration', () => {
   let previousWorkingDir: string;
 
   beforeEach(() => {
-    runner = new SchematicTestRunner('test', require.resolve('../migrations.json'));
+    runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json'));
     host = new TempScopedNodeJsSyncHost();
     tree = new UnitTestTree(new HostTree(host));
 
@@ -151,5 +151,5 @@ describe('move-document migration', () => {
     host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents));
   }
 
-  function runMigration() { runner.runSchematic('migration-v8-move-document', {}, tree); }
+  function runMigration() { runner.runSchematic('migration-move-document', {}, tree); }
 });

packages/core/schematics/test/static_queries_migration_template_spec.ts

@@ -21,7 +21,7 @@ describe('static-queries migration with template strategy', () => {
   let warnOutput: string[];
 
   beforeEach(() => {
-    runner = new SchematicTestRunner('test', require.resolve('../migrations.json'));
+    runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json'));
     host = new TempScopedNodeJsSyncHost();
     tree = new UnitTestTree(new HostTree(host));
 
@@ -97,7 +97,7 @@ describe('static-queries migration with template strategy', () => {
   }
 
   async function runMigration() {
-    await runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise();
+    await runner.runSchematicAsync('migration-static-queries', {}, tree).toPromise();
   }
 
   describe('ViewChild', () => {

packages/core/schematics/test/static_queries_migration_usage_spec.ts

@@ -26,7 +26,7 @@ describe('static-queries migration with usage strategy', () => {
   afterAll(() => process.env['NG_STATIC_QUERY_USAGE_STRATEGY'] = '');
 
   beforeEach(() => {
-    runner = new SchematicTestRunner('test', require.resolve('../migrations.json'));
+    runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json'));
     host = new TempScopedNodeJsSyncHost();
     tree = new UnitTestTree(new HostTree(host));
 
@@ -145,7 +145,7 @@ describe('static-queries migration with usage strategy', () => {
   }
 
   async function runMigration() {
-    await runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise();
+    await runner.runSchematicAsync('migration-static-queries', {}, tree).toPromise();
   }
 
   function createQueryTests(queryType: 'ViewChild' | 'ContentChild') {

packages/core/schematics/test/template_var_assignment_migration_spec.ts

@@ -21,7 +21,7 @@ describe('template variable assignment migration', () => {
   let warnOutput: string[];
 
   beforeEach(() => {
-    runner = new SchematicTestRunner('test', require.resolve('../migrations.json'));
+    runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json'));
     host = new TempScopedNodeJsSyncHost();
     tree = new UnitTestTree(new HostTree(host));
 
@@ -58,9 +58,7 @@ describe('template variable assignment migration', () => {
     host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents));
   }
 
-  function runMigration() {
+  function runMigration() { runner.runSchematic('migration-template-local-variables', {}, tree); }
-    runner.runSchematic('migration-v8-template-local-variables', {}, tree);
-  }
 
   it('should warn for two-way data binding variable assignment', () => {
     writeFile('/index.ts', `