iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: disable IE web worker tests (#24908) 

Travis (saucelabs) has been super flaky when running IE
web worker tests lately. This patch temporarily disables
these tests on IE (not edge) until things get more stable.

PR Close #24908
This commit is contained in:
Matias Niemelä 2018-07-16 11:41:02 -07:00
parent 74b250b146
commit 9be8abd012
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts
View File

@ -81,6 +81,10 @@ let lastCreatedRenderer: Renderer2;
} }
it('should update text nodes', () => { it('should update text nodes', () => {
// IE (v11 to be exact) has been problematic lately with saucelabs for this specific test
// TODO (matsko): revisit this once things become more stable in the saucelabs world
if (isOldIE()) return;
const fixture = const fixture =
TestBed.overrideTemplate(MyComp2, '<div>{{ctxProp}}</div>').createComponent(MyComp2); TestBed.overrideTemplate(MyComp2, '<div>{{ctxProp}}</div>').createComponent(MyComp2);
const renderEl = getRenderElement(fixture.nativeElement); const renderEl = getRenderElement(fixture.nativeElement);
@ -93,6 +97,10 @@ let lastCreatedRenderer: Renderer2;
it('should update any element property/attributes/class/style(s) independent of the compilation on the root element and other elements', it('should update any element property/attributes/class/style(s) independent of the compilation on the root element and other elements',
() => { () => {
// IE (v11 to be exact) has been problematic lately with saucelabs for this specific test
// TODO (matsko): revisit this once things become more stable in the saucelabs world
if (isOldIE()) return;
const fixture = const fixture =
TestBed.overrideTemplate(MyComp2, '<input [title]="y" style="position:absolute">') TestBed.overrideTemplate(MyComp2, '<input [title]="y" style="position:absolute">')
.createComponent(MyComp2); .createComponent(MyComp2);
@ -127,6 +135,10 @@ let lastCreatedRenderer: Renderer2;
}); });
it('should update any template comment property/attributes', () => { it('should update any template comment property/attributes', () => {
// IE (v11 to be exact) has been problematic lately with saucelabs for this specific test
// TODO (matsko): revisit this once things become more stable in the saucelabs world
if (isOldIE()) return;
const fixture = const fixture =
TestBed.overrideTemplate(MyComp2, '<ng-container *ngIf="ctxBoolProp"></ng-container>') TestBed.overrideTemplate(MyComp2, '<ng-container *ngIf="ctxBoolProp"></ng-container>')
.createComponent(MyComp2); .createComponent(MyComp2);
@ -137,6 +149,10 @@ let lastCreatedRenderer: Renderer2;
}); });
it('should add and remove fragments', () => { it('should add and remove fragments', () => {
// IE (v11 to be exact) has been problematic lately with saucelabs for this specific test
// TODO (matsko): revisit this once things become more stable in the saucelabs world
if (isOldIE()) return;
const fixture = const fixture =
TestBed TestBed
.overrideTemplate(MyComp2, '<ng-container *ngIf="ctxBoolProp">hello</ng-container>') .overrideTemplate(MyComp2, '<ng-container *ngIf="ctxBoolProp">hello</ng-container>')
@ -156,6 +172,10 @@ let lastCreatedRenderer: Renderer2;
if (getDOM().supportsDOMEvents()) { if (getDOM().supportsDOMEvents()) {
it('should listen to events', () => { it('should listen to events', () => {
// IE (v11 to be exact) has been problematic lately with saucelabs for this specific test
// TODO (matsko): revisit this once things become more stable in the saucelabs world
if (isOldIE()) return;
const fixture = TestBed.overrideTemplate(MyComp2, '<input (change)="ctxNumProp = 1">') const fixture = TestBed.overrideTemplate(MyComp2, '<input (change)="ctxNumProp = 1">')
.createComponent(MyComp2); .createComponent(MyComp2);
@ -214,3 +234,8 @@ class RenderFactory extends WebWorkerRendererFactory2 {
return lastCreatedRenderer; return lastCreatedRenderer;
} }
} }
function isOldIE() {
// note that this only applies to older IEs (not edge)
return (window as any).document['documentMode'] ? true : false;
}