iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(core): re-enable IE 10/11 test on SauceLabs (#35962) 

I was not able to reproduce IE 10/11 failrue of the disabled
tests on SauceLabs any more. I did some cleanup of the test
in question but I doubt it was the root cause of the problem.

PR Close #35962
This commit is contained in:
Pawel Kozlowski 2020-03-09 15:34:01 +01:00 committed by Misko Hevery
parent 58f4254fba
commit a323b9b1a3
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/core/test/BUILD.bazel
View File

@ -87,15 +87,6 @@ jasmine_node_test(
karma_web_test_suite( karma_web_test_suite(
name = "test_web", name = "test_web",
tags = [
# FIXME: fix on saucelabs
# IE 11.0.0 (Windows 8.1.0.0) ivy NgModule providers should throw when the aliased provider does not exist FAILED
# Error: Expected function to throw an exception with message 'R3InjectorError(SomeModule)[car -> SportsCar]:
# NullInjectorError: No provider for Car!', but it threw an exception with message 'R3InjectorError(SomeModule)[car -> Car]:
# NullInjectorError: No provider for Car!'.
# at <Jasmine>
"fixme-saucelabs-ivy",
],
deps = [ deps = [
":test_lib", ":test_lib",
], ],

2
packages/core/test/linker/ng_module_integration_spec.ts
View File

@ -794,7 +794,7 @@ function declareTests(config?: {useJit: boolean}) {
const injector = createInjector([{provide: 'car', useExisting: SportsCar}]); const injector = createInjector([{provide: 'car', useExisting: SportsCar}]);
let errorMsg = `NullInjectorError: No provider for ${stringify(SportsCar)}!`; let errorMsg = `NullInjectorError: No provider for ${stringify(SportsCar)}!`;
if (ivyEnabled) { if (ivyEnabled) {
errorMsg = `R3InjectorError(SomeModule)[car -> SportsCar]: \n ` + errorMsg; errorMsg = `R3InjectorError(SomeModule)[car -> ${stringify(SportsCar)}]: \n ` + errorMsg;
} }
expect(() => injector.get('car')).toThrowError(errorMsg); expect(() => injector.get('car')).toThrowError(errorMsg);
}); });