iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(docs-infra): reduce ambiguity in `deploy-to-firebase.js` test descriptions (#39853) 

Previously, test descriptions used `latest` to refer to the most
recent/highest version. This was ambiguous, because `latest` can also
refer to the stable version of a package (e.g. see `@latest` npm tag).

This commit replaces `latest` with `highest` (or `highest for major`) to
reduce ambiguity.

Discussed in:
https://github.com/angular/angular/pull/39853#discussion_r531730317

PR Close #39853
This commit is contained in:
George Kalpakas 2020-11-30 13:59:13 +02:00 committed by Misko Hevery
parent cf1f5a1e37
commit eba185edc8
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
aio/scripts/deploy-to-firebase.spec.js
View File

@ -231,7 +231,7 @@ describe('deploy-to-firebase:', () => {
]);
});
it('archive - skip deploy - major same as stable, minor less than stable', () => {
it('archive - skip deploy - major same as stable, minor lower than stable', () => {
expect(getDeploymentsInfoFor({
CI_REPO_OWNER: 'angular',
CI_REPO_NAME: 'angular',
@ -249,7 +249,7 @@ describe('deploy-to-firebase:', () => {
]);
});
it('archive - skip deploy - major lower than stable, minor not latest', () => {
it('archive - skip deploy - major lower than stable, minor not highest for major', () => {
expect(getDeploymentsInfoFor({
CI_REPO_OWNER: 'angular',
CI_REPO_NAME: 'angular',
@ -287,7 +287,7 @@ describe('deploy-to-firebase:', () => {
]);
});
it('rc - deploy success - major same as stable, minor higher', () => {
it('rc - deploy success - major same as stable, minor highest for major', () => {
// Create a stable branch name that has the same major and lower minor than
// `mostRecentMinorBranch`.
// NOTE: Since `mostRecentMinorBranch` can have a minor version of `0`, we may end up with `-1`
@ -332,7 +332,7 @@ describe('deploy-to-firebase:', () => {
]);
});
it('rc - skip deploy - major same as stable, minor not latest', () => {
it('rc - skip deploy - major same as stable, minor not highest for major', () => {
expect(getDeploymentsInfoFor({
CI_REPO_OWNER: 'angular',
CI_REPO_NAME: 'angular',
@ -350,7 +350,7 @@ describe('deploy-to-firebase:', () => {
]);
});
it('rc - skip deploy - major higher than stable, minor not latest', () => {
it('rc - skip deploy - major higher than stable, minor not highest for major', () => {
expect(getDeploymentsInfoFor({
CI_REPO_OWNER: 'angular',
CI_REPO_NAME: 'angular',
@ -368,7 +368,7 @@ describe('deploy-to-firebase:', () => {
]);
});
it('rc - skip deploy - major higher than stable but lower than most recent, minor latest', () => {
it('rc - skip deploy - major higher than stable but not highest, minor highest for major', () => {
expect(getDeploymentsInfoFor({
CI_REPO_OWNER: 'angular',
CI_REPO_NAME: 'angular',