iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(bazel): add terser as an optional peer dependency (#33891) 

`ng_package` rule has an implicitly optional depedency on terser a48573efe8/packages/bazel/src/ng_package/ng_package.bzl (L36)

When using this rule without terser being available we get the below error;
```
ERROR: /home/circleci/ng/modules/express-engine/BUILD.bazel:22:1: every rule of type ng_package implicitly depends upon the target '@npm//terser/bin:terser', but this target could not be found because of: no such package '@npm//terser/bin': BUILD file not found in directory 'terser/bin' of external repository @npm. Add a BUILD file to a directory to mark it as a package.
ERROR: Analysis of target '//modules/express-engine:npm_package' failed; build aborted: no such package '@npm//terser/bin': BUILD file not found in directory 'terser/bin' of external repository @npm. Add a BUILD file to a directory to mark it as a package.
```

PR Close #33891
This commit is contained in:
Alan Agius 2019-11-18 10:06:12 +01:00 committed by Alex Rickabaugh
parent a6247aafa1
commit ffa3936b4c
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/bazel/package.json
View File

@ -33,12 +33,18 @@
"peerDependencies": { "peerDependencies": {
"@angular/compiler-cli": "0.0.0-PLACEHOLDER", "@angular/compiler-cli": "0.0.0-PLACEHOLDER",
"@bazel/typescript": "0.*", "@bazel/typescript": "0.*",
"terser": "^4.3.1",
"typescript": ">=3.6 <3.7", "typescript": ">=3.6 <3.7",
"rollup": ">=1.20.0", "rollup": ">=1.20.0",
"rollup-plugin-commonjs": ">=9.0.0", "rollup-plugin-commonjs": ">=9.0.0",
"rollup-plugin-node-resolve": ">=4.2.0", "rollup-plugin-node-resolve": ">=4.2.0",
"rollup-plugin-sourcemaps": ">=0.4.0" "rollup-plugin-sourcemaps": ">=0.4.0"
}, },
"peerDependenciesMeta": {
"terser": {
"optional": true
}
},
"repository": { "repository": {
"type": "git", "type": "git",
"url": "https://github.com/angular/angular.git" "url": "https://github.com/angular/angular.git"