Moved all heroes functionality into milestone 2
Crisis Center initial functionality is milestone 3
Admin feature module as milestone 4 including route guard examples
Updated milestone 5 to lazy load admin feature module
Added examples for CanLoad, CanActivateChildren guard, component-less routes
Added section on explanation of ActivatedRoute
Added section on animating route components
Added section on relative navigation
* Removed 03-05, 04-12, 04-15.
Removed style for whitespace in imports.
Removed + sign prefix for routing folders. Updated all code.
Removed style that said to use lazy loading. There was no value in the style other than use it :)
* renamed componet router to router
Each page is designed to have a single banner; adjust the cheatsheet to
follow this convention. Also eliminate the article nested within the
`l-conent` div.
Propagated changes/cleanup to JS and Dart.
The page `docs/ts/latest/guide/cheatsheet.html` is a mirror of
`docs/ts/latest/cheatsheet.html`. Use Jade instead of Harp to create
the mirror so that jade2ng can generate the corresponding file.
Make equivalent TS code changes to Dart sample.
This sync’s Dart with all #2177 changes pertinent to Dart.
E2E tests pass now for Dart, Suites passed:
- public/docs/_examples/lifecycle-hooks/ts
Footer logo was overflowing at ~960px wide viewport. Added `background-size: contain` (shorthand), and `max-width: 100%` to contain wrapper, and background image within grid.
* template-syntax - removed word redundancies, consistent bolding rather than italics
* Some (not all) changes from PR.
* remaining changes from pull request
* since RC5 the webpack prod build is defect
Issue #10618 recommends 'mangle: { keep_fnames: true, screw_ie8: true } for the webpack UglifyJs plugin
* remove screw_ie8 option
removed the screw_ie8: true option because it is not necessary
* docs(toh-6/dart): refactoring of 'add, edit, delete heroes'
Refactoring of "add, edit, delete heroes" section of toh-6 from one big
bottom-up step into small independent feature slices, where the user
achieves a "milesone" (i.e., can run the full app) after each feature
section. The section rewrite is shorter and offers a better UX.
Other simplifications:
- Error handling is consistent: in the hero service we log to the
console, everwhere else we just let errors bubble up.
- Hero service methods renamed based on function (create, update)
rather then lower-level implementation (post, put).
- @Output properties have been eliminated (since they weren't
explained).
E2E tests now pass on both the TS and Dart sides.
* docs(toh-6/ts): refactoring of 'add, edit, delete heroes'
Refactoring of "add, edit, delete heroes" section of toh-6 from one big
bottom-up step into small independent feature slices, where the user
achieves a "milesone" (i.e., can run the full app) after each feature
section. The section rewrite is shorter and offers a better UX.
Other simplifications:
- Error handling is consistent: in the hero service we log to the
console, everwhere else we just let errors bubble up.
- Hero service methods renamed based on function (create, update)
rather then lower-level implementation (post, put).
- @Output properties have been eliminated (since they weren't
explained).
E2E tests now pass on both the TS and Dart sides.
Post-Dart-review updates included.
* docs(toh-6): ward tweaks
* example(dart/toh-4,5): getHeroesSlowly() to return getHeroes()
Have `getHeroesSlowly()` delay and then return the value of
`getHeroes()`. This makes it easier for user’s performing the tutorial
to keep this slower method as they evolve toh-5 into toh-6.
* example(ts/toh-4,5): getHeroesSlowly() to return getHeroes()
Have `getHeroesSlowly()` delay and then return the value of
`getHeroes()`. This makes it easier for user’s performing the tutorial
to keep this slower method as they evolve toh-5 into toh-6.
* docs(server-communication): Fix typo in example
Clearly we're transforming the response, not the request.
* docs(server-communication): Fix typo in example
Clearly we're transforming the response, not the request.
* lifecycle-hooks: copy latest to cache
* docs(lifecycle-hooks): post-RC5 Dart resync
- TS prose: removed mention of `routerOnActivate` which no longer
exists in the new router.
- TS improvements to the sample code have also been propagated to the
Dart sample.
Contributes to #2077.
E2E tests pass now.
* post-review updates
* glossary: replace cached by latest before edits
* docs(glossary): general cleanup and fix links
This commit addresses issues with the glossary for all languages (JS, TS, Dart).
Fixes#1123, #1838, #2036.
This was originally started as post-RC5 Dart resync, but since mixing Harp partials with Jade mixins can be problematic, this commit does a general cleanup of the 3 x 2 = 6 glossary files (found in `{ts,js,dart}/latest/{.,guide}`).
This commit builds upon #2098 (which created the first `ts/_cache` copy of the glossary), but doesn't really depend on it.
* post-review updates
* post-review updates
closes#2110
The lifecycle-hooks provided by router-deprecated has already been removed in the router, the router now uses guards rather than lifecycle-hooks to achieve the same work.
* docs(toh-5): review and update/resync Dart
**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**
This is preparatory work for #2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (#2018).
By the same token it contributed to a post-RC5 resync (#2077). Other
key changes:
Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.
TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.
Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).
* docs(toh-5): edits after doing tutorial
- Some adjustments following actually doing the tutorial. In some cases code shown (e.g. this is what file foo should look like now) didn't match what the user would have. E.g., lingering @Input on the hero property.
- Fixed some lingering deprecated-router prose elements on TS side (e.g., still referring to a route by the old string names like `HeroDetail`).
- Added extra step to `app.component.ts` creation rather than having a critical-call-out later on.
- Reorder some prose for better harmony between TS and Dart prose (also improves the flow).
- Moved the `styleUrls` call-out to the point of first use.
* post-review changes
* more post-review changes
* toh-6 cache update
* chore(toh-5): improve e2e test coverage
Improved test coverage. Also updated tests to make use of async/await
(so tests are more readable).
* lint feedback
* toh-6: trim spaces from cache file to simplify diff
* toh-6: copy latest over cache before editing latest
* docs(toh-6): post-RC5 Dart resync and TS fixes
Contributes to #2077.
TS-side changes include:
- Merged three versions of `app/app.module{,1,2}.ts` into a single file
and used docregions instead.
- Misnamed files:
- `rxjs-operators.ts` -> `rxjs-extensions.ts`
- `hero-search.service.html` -> `hero-search.component.html`
- Fixed BAD FILENAME error.
Lint reports no errors and toh-6 e2e tests pass.
* docs(router): fix markdown and example mixin cleanup
- Fixed: markdown text not under `:marked` region (and so that text was
not showing up in the generated html).
- Fixed: code excerpt title `constructor` -> `isSelected`.
- Cleanup of all makeExample mixin uses.
This cleanup will help make it easier to record differences with the
deprecated router chapter (which must have app-relative makeExample
paths).
* post-review updates
Found another instance of markdown (a heading) outside of a `:marked` region.
* docs(template-syntax/dart): enhancements to example code
Enhancements to `NgStyle` section in support of its API docs.
- Add feature supporting interactive update of a paragraph’s style.
- Add full type declarations.
- Replace bogus implementation of `getStyles()`.
* dartfmt updates
* docs(quickstart): post-RC5 Dart resync
- Resync Dart QS prose with TS, post RC5.
- Added to-be-shared Jade `var` definitions to `_util-fns.jade`.
- Delete cached QS jade file.
- Eliminate the stub file `styles.1.css` in favor of a `docregion` in
the main `styles.css`.
This commit requires a `gulp add-example-boilerplate` after pulling it in.
Contributes to #2077.
* post-review edits
closes#1751
Move additional styles from `sample.css` to `hero-search.component.css`.
Edit tutorial to reflect the removal of `sample.css` and the change to `heroes.component.css`.
Edit tutorial to reflect the addition of `hero-search.component.css` file.
Edit `hero-search.component.ts` to include styles from `hero-search.component.css`.
Remove reference to `/public/docs/_examples/toh-6/ts/sample.css` from `/public/docs/_examples/toh-6/ts/index.html`.
closes#2008
Changes:
- Drop `asObservable()` since it is deprecated in RxJS 5 (see the
[migration
guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat
ors-renamed-or-removed)).
- Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At
best it is interpreted as a regex op that serves no purpose, at worst,
it gets interpreted as a space (cf. [HTML 4.01 section
17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4)
).
- Rename `searchSubject` to `searchTerms`
- Other minor tweaks to prose.
This work is in preparation for #1924.
Note: toh-6 tests pass.
Alex Wolfe
Naomi Black
Jesús Rodríguez
Georgios Kalpakas
Brandon Roberts
Kapunahele Wong
Filipe Silva
Torgeir Helgevold
Ward Bell
Benjamin Dopplinger
Deborah Kurata
John Papa
Jonathan Persson
Shai Reznik
jmcgoldrick
Katiuska Gamero
Peter Bacon Darwin
Marc Laval
Patrice Chalin
Lars Gyrup Brink Nielsen
Kathy Walrath
Peter Fryer-Davis
Aristeidis Bampakos
Wesley Cho
Patrice Delorme
Martin-Wegner
Rob Wormald
Suguru Inatomi
Drew Hintz
Trotyl Yu
Gian Marco Gherardi
Ferdinand Malcher
Cassio Landim
Daniel Kuczewski
Martin
Sarun Intaralawan
Patrice Chalin
Drew Hintz
Karl Herrick
Fredy Treboux
Aysegul Yonet
Matt Ezell
Ciro Nunes
wajdibr
Adam
Adão Júnior
crisbeto
Thomas Burleson
Gerard Sans
Eric Jimenez
Ignat Shining
Kyle Roberts
Fatima Remtullah