iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
angular-docs-cn/docs/COMMITTER.md
Joey Perrott 296dc0622f ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) 
We are migrating to PullApprove for our PR review management in an attempt
to allow for more granular and equitable code review assignments across the
team.  Currently this migration is equivalent in the review assignments
it will create. Once stable, our expectation is that we will be able to
take advantage of PullApproves additional features for things like staged
reviews.

PR Close #34814
2020-01-28 09:19:34 -08:00

1.0 KiB
Raw Blame History

Pushing changes into the Angular tree

Please see Using git with Angular repositories for details about how we maintain a linear commit history and the rules for committing.

As a contributor, see the instructions in CONTRIBUTING.md.

Change approvals

Change approvals in our monorepo are managed via PullApprove and are configured via the .pullapprove file.

Merging

Once a change has all of the required approvals, either the last approver or the PR author (if PR author has the project collaborator status) should mark the PR with the PR action: merge label and the correct target label. This signals to the caretaker that the PR should be merged. See merge instructions.

Who is the Caretaker?

See this explanation.