296dc0622f
We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814
21 lines
1.0 KiB
Markdown
21 lines
1.0 KiB
Markdown
# Pushing changes into the Angular tree
|
|
|
|
Please see [Using git with Angular repositories](https://docs.google.com/document/d/1h8nijFSaa1jG_UE8v4WP7glh5qOUXnYtAtJh_gwOQHI/edit)
|
|
for details about how we maintain a linear commit history and the rules for committing.
|
|
|
|
As a contributor, see the instructions in [CONTRIBUTING.md](../CONTRIBUTING.md).
|
|
|
|
# Change approvals
|
|
|
|
Change approvals in our monorepo are managed via [PullApprove](https://https://docs.pullapprove.com/) and are configured via the [`.pullapprove`](../.pullapprove) file.
|
|
|
|
# Merging
|
|
|
|
Once a change has all of the required approvals, either the last approver or the PR author (if PR author has the project collaborator status)
|
|
should mark the PR with the `PR action: merge` label and the correct [target label](https://github.com/angular/angular/blob/master/docs/TRIAGE_AND_LABELS.md#pr-target).
|
|
This signals to the caretaker that the PR should be merged. See [merge instructions](CARETAKER.md).
|
|
|
|
# Who is the Caretaker?
|
|
|
|
See [this explanation](https://twitter.com/IgorMinar/status/799365744806854656).
|