Previously, `BuildCreator#changePrVisibility()` would throw an error if the PR's visibility was already up-to-date or if the PR directory did not exist (e.g. was removed). This method was only used from inside `BuildCreator#create()`, which had already checked for the existence of the directories. This commit renames `changePrVisibility()` to `updatePrVisibility()` and makes it more "forgiving" (i.e. it will only throw if both public and non-public directories exist). This allows it to be used on events that may or may not have caused the PR's visibility to change (e.g. a GitHub webhook triggered whenever a PR's labels change).
1.6 KiB
Overview - HTTP Status Codes
This is a list of all the possible HTTP status codes returned by the nginx anf upload servers, along with a bried explanation of what they mean:
http://*.ngbuilds.io/*
- 307 (Temporary Redirect): All non-HTTPS requests. 308 (Permanent Redirect) would be more appropriate, but is not supported by all agents (e.g. cURL).
https://pr<pr>-<sha>.ngbuilds.io/*
-
200 (OK): File was found or URL was rewritten to
/index.html
(i.e. all paths that have no.
in final segment). -
403 (Forbidden): Trying to access a sub-directory.
-
404 (Not Found): File not found.
https://ngbuilds.io/create-build/<pr>/<sha>
-
201 (Created): Build deployed successfully and is publicly available.
-
202 (Accepted): Build not automatically verifiable. Stored for later deployment (after re-verification).
-
400 (Bad Request): No payload.
-
401 (Unauthorized): No
AUTHORIZATION
header. -
403 (Forbidden): Unable to verify build (e.g. invalid JWT token, or unable to talk to 3rd-party APIs, etc).
-
405 (Method Not Allowed): Request method other than POST.
-
409 (Conflict): Request to overwrite existing directory (e.g. deploy existing build or change PR visibility when the destination directory does already exist).
-
413 (Payload Too Large): Payload larger than size specified in
AIO_UPLOAD_MAX_SIZE
.
https://*.ngbuilds.io/*
-
404 (Not Found): Request not matched by the above rules.
-
500 (Internal Server Error): Error while processing a request matched by the above rules.