Commit Graph

9250 Commits

Author SHA1 Message Date
Matthew Hooker 9e8d845c03
create instance reservation 2018-01-25 14:33:41 -08:00
Matthew Hooker 543caf3ec5
WIP OCI Classic builder 2018-01-25 14:33:41 -08:00
Matthew Hooker 48e12b6bee
only set role name if it's set. 2018-01-25 10:39:21 -08:00
Matthew Hooker 00a55e209a
Merge pull request #5817 from brianterry/role_in_amazon_import
Added role in amazon-import
2018-01-25 10:39:04 -08:00
Brian Terry 380147200c Added role in amazon-import 2018-01-25 10:56:30 -05:00
Matthew Hooker 7f4112ba22
Merge pull request #5810 from hashicorp/multistep-context
Add context to build steps
2018-01-24 17:28:02 -08:00
Matthew Hooker 5e444ff7ab
update multistep documentation 2018-01-24 17:27:08 -08:00
Matthew Hooker 3e2895afec
comments 2018-01-24 17:09:18 -08:00
Matthew Hooker eafda52411
use amazon steps from master 2018-01-24 17:09:18 -08:00
Matthew Hooker aa667577a5
update context library 2018-01-24 17:09:18 -08:00
Matthew Hooker 2afd81741c
use correct context 2018-01-24 17:09:18 -08:00
Matthew Hooker ce4f30c5ae
fix tests 2018-01-24 17:09:17 -08:00
Matthew Hooker 8cd403425e
test fixes WIP 2018-01-24 17:09:17 -08:00
Matthew Hooker 5d48d658b4
Wire context through misc steps
Some steps actually need to pass the context around, so let's create
a ctx variable and pass it.
2018-01-24 17:09:17 -08:00
Matthew Hooker 7a189a83a1
fix imports
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker a831d522be
change run signatures
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.

`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker a0c625ea44
Revert "working with opt-in"
This reverts commit 4068ffdaf541354e75507add7ca0b193993fcd52.
2018-01-24 17:09:16 -08:00
Matthew Hooker e98f201602
working with opt-in 2018-01-24 17:09:16 -08:00
Matthew Hooker 62e3d1362f
pass context through step.run again 2018-01-24 17:09:16 -08:00
Matthew Hooker 030b5fd4f0
WIP add context to state bag 2018-01-24 17:09:16 -08:00
Matthew Hooker 07a5af66f8
remove ctx arg from step.run 2018-01-24 17:09:15 -08:00
Matthew Hooker 366dc3da0a
move multistep imports to helper.
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
Matthew Hooker 89d43256bb
pass context into step.run 2018-01-24 17:09:15 -08:00
Matthew Hooker 807e88245b
trying to add context to state bag 2018-01-24 17:09:15 -08:00
Matthew Hooker 4c5a7e08b5
remove multistep vendor dep 2018-01-24 17:09:15 -08:00
Matthew Hooker ccbd8b8abf
update plugin documentation 2018-01-24 16:59:32 -08:00
Matthew Hooker 247119e1c3
make examples copy/pastable 2018-01-23 14:34:40 -08:00
Matthew Hooker 61c17c1d2a
Merge pull request #5800 from jessestuart/jesse/cleanup_contributing_docs
[docs] Fix typos + cleanup CONTRIBUTING.md docs.
2018-01-23 14:34:12 -08:00
Matthew Hooker 83bfeb200d
Merge pull request #5799 from jessestuart/jesse/remove_redundant_vagrantfile_block
[vagrant] Remove redundant configuration block in Vagrantfile.
2018-01-23 13:12:53 -08:00
Matthew Hooker 4bccbbba1f
Merge pull request #5790 from GennadySpb/trusted_certs_dir
Support 'trusted_certs_dir' chef-client configuration option
2018-01-23 13:11:27 -08:00
James Nugent 5967732442
Merge pull request #5795 from stack72/bump-triton-go-deps
builder/triton: bump triton-go dependencies
2018-01-23 14:40:03 +00:00
Matthew Hooker ebe995c0ff
run goimports 2018-01-22 17:21:10 -08:00
Matthew Hooker 5ef0c2280f
Merge pull request #5802 from arizvisa/GH-5789
Some chances to log errors were missed inside step_create_floppy.go for floppy_files
2018-01-19 15:49:03 -08:00
Ali Rizvi-Santiago 0e0b467da7 Forgot to check some errors during the adding of files to the floppy disk. This gives users some better information in case packer is unable to add a file...like if there's not enough disk space available. 2018-01-19 13:34:01 -06:00
Ali Rizvi-Santiago 97fc9c02a5 Grr...missed the case that actually mattered on linux. 2018-01-18 23:58:24 -06:00
Ali Rizvi-Santiago f9572cb244 Fixed a bug on linux related to forgetting to check the platform for the forward-slash prefix. 2018-01-18 23:48:20 -06:00
Ali Rizvi-Santiago 41f4dc3f3d umm...gofmt -w on common/config{,_test}.go from linux instead of windows(?) 2018-01-18 23:33:44 -06:00
Ali Rizvi-Santiago 7cd5d576d9 Updated common/config.go's FileExistsLocally implementation to use the LocalDownloader interface for determining the real file path. 2018-01-18 23:18:55 -06:00
Ali Rizvi-Santiago 8a102a42a0 gofmt -w on common/config{,_test}.go 2018-01-18 23:09:53 -06:00
Ali Rizvi-Santiago 15079a99dc Fixed common/config_test.go tests for DownloadableURL to avoid writing to disk on the windows platform. Also added tests for relative paths/uris.
common/config_test.go:
    Replaced instances of os.Mkdir and os.Create with tests that use
        the existing "common/test-fixtures" mechanism.
    Removed the runtime.GOOS test for the "FileExistsLocally" test,
        as the functionality should work regardless of the platform.
    Added some more comprehensive tests for the relative uri/pathing.
    Replaced the Windows Object Manager name test as the Object
        Manager's naming scheme is different from a UNC path.
    Modified the FilePaths tests to support the policy of windows absolute
        paths being prefixed with the `/` introduced with PR #5761.
2018-01-18 23:08:22 -06:00
Ali Rizvi-Santiago 95f60f6153 Modified common/config.go to accommodate some of the new DownloadableURL policies made by the PR #5761 merge.
common/config.go:
    Added the ability for DownloadableURL to promote UNC paths to the SMB uri.
    Modified DownloadableURL to include the "./" prefix when a relative path is passed to it.
    Fix-up the DownloadableURL argument if on windows and incorrectly prefixed with "/".
2018-01-18 22:43:08 -06:00
Jesse Stuart a83a22200a
[docs] More typo fixes + cleanup. 2018-01-18 04:58:04 -05:00
Jesse Stuart 5db947d9e8
[vagrant] Remove redundant configuration block. 2018-01-18 04:34:14 -05:00
Jesse Stuart 93e565ca3c
[docs] Fix typo in CONTRIBUTING.md 2018-01-18 04:22:23 -05:00
stack72 20f9ef3445 builder/triton: bump triton-go dependencies
This introduces a new triton-go errors package so we can error handle our code in a better way
2018-01-17 16:55:00 +02:00
Ali Rizvi-Santiago 50e9cd2ca7 Initial fixes of common/config.go after rebase before refactoring of test-cases so that they don't require root to run. 2018-01-16 13:46:27 -06:00
Ali Rizvi-Santiago c17f827e1d Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols. 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago 3cf448f6ec Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path. 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago 46a5ca30e5 Removed call to filepath.Rel(...) in builder/vmware/iso/step_create_vmx.go 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago 4a1fb0d262 Grrr...gofmt -w common/*.go 2018-01-16 13:37:31 -06:00