ef32147a4a
Fix GCP HCL image_encryption_key fields and use the same casing in JSON and HCL2
...
this closes #9997
2020-10-27 15:46:45 +01:00
c4866504e1
respect the destroy flag in content library config ( #10165 )
...
* respect the destroy flag in content library config
* Make vsphere-clone respect delete_vm state tag; use a common delete func to prevent future drift
2020-10-27 09:07:08 -04:00
bab29060fe
regen hcl after master merge
2020-10-26 15:48:10 +01:00
f5e037e8b4
Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp
2020-10-26 15:47:29 +01:00
73370570f4
Fix Proxmox builder unhandled buildvar type ( #10154 )
...
* Fix Proxmox builder unhandled buildvar type #10139
Co-authored-by: Calle Pettersson <carlpett@users.noreply.github.com>
Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>
2020-10-26 15:11:09 +01:00
25f4e24772
Merge pull request #10150 from nshalman/nshalman/tag-snapshots
...
amazon/ebssurrogate: apply snapshot tags right when taking snapshot
2020-10-23 15:57:18 -07:00
7646ecf8c6
fix tests
2020-10-23 15:35:37 -07:00
4862b2c0f0
Merge pull request #10163 from hashicorp/fix-azure_arm-manageddisk-deletion-regression
...
builder/azure_arm: Fix build failures due to the deletion of attached managed disks
2020-10-23 15:19:30 -07:00
fc619dc977
Merge pull request #9626 from featheredtoast/add-proxmox-vm-clone
...
builder/proxmox FEATURE: split Proxmox into proxmox-iso and proxmox-clone
2020-10-23 13:36:45 -07:00
56c7a9cda5
rebase
2020-10-23 11:47:20 -07:00
15467aa868
Update builder/vsphere/common/step_shutdown.go
...
Co-authored-by: Sylvia Moss <sylviamoss.m@gmail.com>
2020-10-23 11:41:03 -07:00
185f3d9d48
vsphere clone config not yet using warnings, leaving code commented out
2020-10-23 11:41:03 -07:00
c8ad66f419
update to docs as suggested
2020-10-23 11:41:03 -07:00
c86a48fbc9
syntax change
2020-10-23 11:41:03 -07:00
f86f7c4464
Another instance using `Prepare()` needed an update
2020-10-23 11:41:03 -07:00
09edada93d
moved the warning into Prepare() and updated the invocation
2020-10-23 11:41:03 -07:00
572de129d7
update documentation
2020-10-23 11:41:03 -07:00
1048cdbcc4
check for no communicator and provide messaging to user
2020-10-23 11:41:03 -07:00
2ecf5cc9aa
Communicator is not needed unless shutdown_command is populated
2020-10-23 11:41:03 -07:00
6b39b1eed6
StepShutdown should still occur if Comm.Type is none
2020-10-23 11:41:03 -07:00
65ff092fd4
hashicorp/packer#9924
2020-10-23 11:41:03 -07:00
19bd997f11
add directory existence check
2020-10-23 11:06:25 -07:00
a1d69bfe91
Fix liniting issues
2020-10-23 13:52:05 -04:00
afd33679f5
builder/azure_arm: Fix build failures due to the deletion of attached managed disks
...
Previously (prior to v1.6.2) the Azure ARM builder had two delete functions
one that would run before any of the StepDelete* types, and one on deployment template
cleanup. The refactored coded re-introduces the logic from the previously removed
step in v1.6.1 as the main delete logic for the whole deployment
template. Ensuring that all deployed items are deleted before trying to
remove any managed disks.
This change moves all the deletion logic into the
step_deployment_template#Cleanup function to ensure that dependent steps
are only called once the created deployment items (i.e
StepDelateAdditionalDisks) have been deleted.
Test results before change
```
compute.DisksClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="OperationNotAllowed" Message="Disk pkrdd02e9rzzu5k-1 is attached to VM /subscriptions/1f90521a-24f6-4758-ac3d-88d869fb0bf5/resourceGroups/packer-acceptance-test/providers/Microsoft.Compute/virtualMachines/pkrvm02e9rzzu5k."
--- FAIL: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk (454.00s)
FAIL
FAIL github.com/hashicorp/packer/builder/azure/arm 454.008s
```
Test results after change
```
--- PASS: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk (563.56s)
```
Closes #10070
2020-10-23 13:44:27 -04:00
8f67f939f9
Merge pull request #10158 from Direnol/yandex-add-support-iam-auth
...
Added support for IAM credential in the token field and YC_TOKEN env
2020-10-23 09:39:46 -07:00
75befba67e
add more doc
2020-10-23 18:01:52 +03:00
60595ad522
remove extra log
2020-10-23 14:09:05 +03:00
72fe3bbc26
Update builder/yandex/access_config.go
...
Co-authored-by: GennadySpb <lipenkov@gmail.com>
2020-10-23 14:05:39 +03:00
ae7fc84557
Added support for IAM credential in the token field and YC_TOKEN env
2020-10-23 11:47:28 +03:00
7fac596b37
don't try to delete a cd file if the upload of the cd itself failed
2020-10-22 16:53:40 -07:00
3be53e10af
Merge pull request #10128 from nayyara-samuel/add-state-timeout-linode
...
Add documented `state_timeout` parameters to Linode builder
2020-10-22 15:13:59 -07:00
c4001734d0
Merge pull request #10143 from hashicorp/do_9951
...
builder/vsphere: skip iso download if hashed file is already present on remote datastore
2020-10-22 15:06:04 -07:00
00037d8e69
Merge pull request #10145 from hashicorp/fix_10135
...
commhostport isn't present if communicator is null; protect casting i…
2020-10-22 14:24:23 -07:00
70cb4097e1
review comments, add plugin type for a few missing builders
2020-10-21 16:17:32 -07:00
c0ce8a9414
rework fixer deprecation code so we know what plugins they relate to
2020-10-21 15:28:59 -07:00
f1f834b8fe
commhostport isn't present if communicator is null; protect casting in a check
2020-10-21 14:30:23 -07:00
83a672f2c9
amazon/ebssurrogate: apply snapshot tags right when taking snapshot
2020-10-21 16:17:37 -04:00
796c40f89b
builder/vsphere: skip iso download if hashed file is already present in remote packer_cache
2020-10-21 11:33:43 -07:00
a2ba700ac0
Remove deprecated object ids from configs
2020-10-21 13:56:22 -04:00
522d122858
regen all code
2020-10-21 12:04:10 +02:00
4aea2efd0f
HCL2: fully name SSHTemporaryKeyPair fields so that they don't conflict and can be generated
2020-10-21 11:53:07 +02:00
1621ab59d8
tests/azure/arm: Update test image name ( #10133 )
...
I've run into a few cases where running the full test suite for the ARM
builder would fail because of conflicting image names. This is a
workaround for now the bigger fix is to have the acceptance clean up any
created images.
Results before change
```
the managed image named testBuilderAccManagedDiskWindows-1603151855 already exists in the resource group packer-acceptance-test, use the -force option to automatically delete it.
--- FAIL: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group (0.66s)
```
Results after change
```
PASS
ok github.com/hashicorp/packer/builder/azure/arm 2431.115s
```
2020-10-21 11:12:50 +02:00
799c548c40
Merge pull request #10116 from OblateSpheroid/GH8915
...
Feat (builder/oracle-oci): Allow filtering on base image
2020-10-20 14:41:09 -07:00
d1e0214bec
avoid panic debugging ssh key
2020-10-20 16:59:46 +02:00
f51b231c17
Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp
2020-10-20 16:39:01 +02:00
536421efaf
debug mode: don't dump the ssh key if its from a file
2020-10-20 12:00:49 +02:00
2f26e6d823
tests (builder/oracle-oci): test base image filter in config
2020-10-19 23:30:46 -04:00
32ebabfcf5
Add documented `state_timeout` parameters to Linode builder
2020-10-19 22:07:22 -04:00
b8e6e2c081
Merge pull request #10085 from 10000coins/f-aws-tenancy
...
builder/amazon: Support for source instance tenancy
2020-10-19 12:49:07 -07:00
ef1b401a22
Merge pull request #10102 from mattr-/update-amazon-builder-for-io2
...
builder/amazon: Add io2 as a supported volume type
2020-10-16 16:32:57 -07:00
ecc8c6a44a
Replace `create_image` with `skip_create_image`, as requested
...
Closes #9965
2020-10-16 15:42:30 -07:00
476eefa26b
Add 'create_image' option to googlecompute
...
When building a CI/CD deployment, during the PR process it's nice to be
able to run the builder, but not create the image the build produces.
Closes #9965
2020-10-16 15:42:17 -07:00
456214eb51
Merge pull request #10056 from marinsalinas/new_client
...
New official Outscale SDK migration.
2020-10-16 15:28:54 -07:00
608307cd1e
Re-allow spot + tenancy. Validate tenancy is set to a usable value
2020-10-16 21:43:22 +00:00
d5d1a8708e
Add tests for Tenancy vs Spot Price
2020-10-16 21:43:22 +00:00
6967e02103
Add support for source instance tenancy to amazon builders
2020-10-16 21:43:22 +00:00
0c34d6ca12
feat (builder/oracle-oci): add regex search on base image name
2020-10-15 15:28:38 -04:00
27128dc62f
feat (builder/oracle-oci): allow filtering on base image
2020-10-15 11:02:16 -04:00
54032d6c11
gen code and docs
2020-10-15 16:51:23 +02:00
f4f731b83c
Refactor google compute's temporary ssh keygen genertion to use the sshkey package
2020-10-15 16:51:11 +02:00
15f97421e2
builder/amazon: Add io2 as a supported volume type
...
io2 volumes are new as of 2020-08-24. This adds support for specifying
them in a packer template and having the iops value specified take
effect.
2020-10-14 09:01:17 -05:00
c7ba5c9a14
Fix line ending issues for test files ( #10096 )
2020-10-14 11:03:43 +02:00
22a49a2f2e
chore: fix test
2020-10-13 16:19:15 -05:00
472b008a94
chore: fix test
2020-10-13 15:16:01 -05:00
4810a3d86f
Merge pull request #10077 from hashicorp/document_3348
...
builder/qemu: docs: users must re-apply packer defaults for drive and device arguments
2020-10-13 11:41:28 -07:00
2578bbbb50
chore: fix test
2020-10-13 12:54:25 -05:00
09f57537bf
chore: fix lint issues on osc builder
2020-10-13 11:02:13 -05:00
56807553fc
chore: fix lint issues on osc builder
2020-10-13 10:45:32 -05:00
0f12414126
Merge branch 'master' into add-proxmox-vm-clone
2020-10-12 10:48:15 -07:00
01ed398756
fix up alicloud docs to make it clearer that disk_size and other disk device options are not top level fields. ( #10080 )
2020-10-12 10:28:25 +02:00
2861ad9074
clean up imports
2020-10-11 11:47:02 -07:00
709a173060
fix docs linking issue
2020-10-09 14:01:21 -07:00
b05fd9303e
document that users must re-apply packer defualts for drive and device arguments
2020-10-09 10:39:27 -07:00
774a168957
Merge pull request #10064 from hashicorp/refactor_step_run
...
builder/qemu: (tech-debt) Major refactor of step_run.
2020-10-08 11:54:34 -07:00
3e35630d8d
remove slashes to prevent windows test fails
2020-10-08 11:36:36 -07:00
62a401ef28
Fix 10060 ( #10065 )
...
* fix overeager validation
* fix validation of openstack source images
2020-10-08 10:54:41 +02:00
93531b3ec5
[proxmox] Adds proxmox fixer and fixer test
...
Add fixer for proxmox to proxmox-iso. Updated gofmt.
2020-10-08 00:04:43 -07:00
a140c13943
[proxmox] add proxmox builder alias
...
Adds an alias for `proxmox` that points to proxmox-iso builder for
backwards compatibility
2020-10-07 23:43:12 -07:00
d6aa172edc
remove typo'd option from docs
2020-10-07 16:14:13 -07:00
8e632866b1
typo
2020-10-07 15:22:08 -07:00
b54b778572
major refactor of the step_run. Splits step into two major parts:
...
- generating defaults
- overriding defaults with user args
The default generation has been shuffled around some, in order to
make sure that any changes to a specific arg happen in one place
to make it easier to reason about those args. Related args have
been moved close to one another.
The deviceArgs and driveArgs were overly complex after several
layers of copy/paste modifications. Careful pruning reduced the
layers of logic and repeated code, to help make it easier to reason
about.
2020-10-07 15:09:45 -07:00
d4d78feed2
feat(scaleway): get image by label if not an UUID ( #10061 )
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-10-07 16:04:00 +02:00
a478bf6f37
fix: update scaleway website documentation ( #10058 )
2020-10-07 12:02:08 +02:00
809f38be3a
[azure-chroot] Updating parameter `exlude_from_latest` to `exclude_from_latest` ( #10034 )
2020-10-07 11:08:33 +02:00
cd3bdc9e38
REFACTOR: do not pass comm ref through statebag
2020-10-06 22:45:19 -07:00
fdda18e392
Use Trilean for boolean value, and allow for missing values for defaults
2020-10-06 17:24:45 -07:00
977022fb35
Go format
2020-10-06 16:53:29 -07:00
a26e3e6887
[Proxmox] FIX: tests, add required iso_file to basic iso config tests
2020-10-06 16:04:18 -07:00
61c6085651
final fix to make service account impersonation work with iap tunnels ( #10054 )
2020-10-06 15:34:06 -04:00
7ee9a4b638
Merge pull request #9968 from upodroid/google-impersonation
...
GCP: add service account impersonation
2020-10-06 11:32:03 -07:00
f6d362d392
skip Ctx
2020-10-06 11:54:04 +02:00
25d7e7ce17
fix tests
2020-10-06 11:48:24 +02:00
5b3ff89cb0
proxmox: move iso.storageConfig to common.storageConfig
2020-10-06 11:42:49 +02:00
1260e123aa
proxmox.Config: remove mapstructure:",squash" tag
2020-10-06 11:14:09 +02:00
b2be255057
Merge remote-tracking branch 'origin/master' into pr/featheredtoast/9626-1
2020-10-06 11:11:04 +02:00
deb08409f1
Merge pull request #10040 from OblateSpheroid/GH6844
...
Feat (oracle/oci): allow specifying image compartment
2020-10-05 15:02:23 -07:00
721cbac645
Merge pull request #9996 from hashicorp/fix_9995
...
Make shell-local post-processor return copy of previous artifact
2020-10-05 13:00:51 -07:00
c892f0582b
GH#6844: allow image compartment to be specified
2020-10-02 22:30:52 -04:00
157b5cdc28
Merge pull request #10017 from kostasns/oci_boot_volume
...
Allow to specify boot volume size in OCI builder
2020-10-02 11:04:05 -07:00
b1c74f9df0
Merge branch 'master' of github.com:hashicorp/packer into google-impersonation
2020-10-01 23:19:15 +01:00
Adrien Delorme
Megan Marsh
blz-ea
netapp-jgriffit
James Griffith
Wilken Rivera
Roman Mingazeev
Nahum Shalman
js-g
Nayyara Samuel
Bryan Hundven
Evan Pipho
Matt Rogers
Marin Salinas
Jeff Wong
Patrik
abarbare
Ricardo Rosales
upodroid